Miguel A. Garcia | 2 Sep 2011 11:37
Picon
Favicon

SDP comments to draft-ietf-avtext-client-to-mixer-audio-level-04.txt

Hi:

I've read Sections 4 and 7 of 
draft-ietf-avtext-client-to-mixer-audio-level-04.txt, and I don't have 
comments from the SDP point of view.

/Miguel

--

-- 
Miguel A. Garcia
+34-91-339-3608
Ericsson Spain
Miguel A. Garcia | 2 Sep 2011 11:39
Picon
Favicon

SDP comments to draft-ietf-avtext-mixer-to-client-audio-level-04.txt

Hi,

These are some comments to Sections 5 and 7 of 
draft-ietf-avtext-mixer-to-client-audio-level-04.txt

- In Figures 4 and 5, all the SDP examples are missing the "s=" line (it 
can have a single white space, but I think it must be there). According 
to RFC 3264:

    The SDP "s=" line conveys the subject of the session, which is
    reasonably defined for multicast, but ill defined for unicast.  For
    unicast sessions, it is RECOMMENDED that it consist of a single space
    character (0x20) or a dash (-).

- On the SDP answer in Figures 4 and 5, the port of the audio stream is 
set to "52543". Since this stream is used together with RTCP, the RTP 
stream should be set to an even port number, in order to allow the RTCP 
stream to be received in the consecutive (odd) port number. According to 
RFC 4566:

       For RTP, the default is that only the even-numbered ports are used
       for data with the corresponding one-higher odd ports used for the
       RTCP belonging to the RTP session, and the <number of ports>
       denoting the number of RTP sessions.

       If non-contiguous ports are used or if they don't follow the
       parity rule of even RTP ports and odd RTCP ports, the "a=rtcp:"
       attribute MUST be used.

/Miguel
(Continue reading)

Emil Ivov | 5 Sep 2011 16:31
Gravatar

Re: SDP comments to draft-ietf-avtext-mixer-to-client-audio-level-04.txt

Hey Miguel,

На 02.09.11 12:39, Miguel A. Garcia написа:
> Hi,
> 
> These are some comments to Sections 5 and 7 of 
> draft-ietf-avtext-mixer-to-client-audio-level-04.txt

Thanks for picking those up! They are now all fixed within in version 05.

http://tools.ietf.org/html/draft-ietf-avtext-mixer-to-client-audio-level-05

Cheers,
Emil

> - In Figures 4 and 5, all the SDP examples are missing the "s=" line (it 
> can have a single white space, but I think it must be there). According 
> to RFC 3264:
> 
>     The SDP "s=" line conveys the subject of the session, which is
>     reasonably defined for multicast, but ill defined for unicast.  For
>     unicast sessions, it is RECOMMENDED that it consist of a single space
>     character (0x20) or a dash (-).
> 
> 
> - On the SDP answer in Figures 4 and 5, the port of the audio stream is 
> set to "52543". Since this stream is used together with RTCP, the RTP 
> stream should be set to an even port number, in order to allow the RTCP 
> stream to be received in the consecutive (odd) port number. According to 
> RFC 4566:
(Continue reading)

Miguel A. Garcia | 13 Sep 2011 10:54
Picon
Favicon

SDP Comments to draft-ietf-siprec-protocol-00

Hi,

here are some comments to the SDP in draft-ietf-siprec-protocol-00

- Section 5.3. I found a few "must" and "should" in lowercase. I wonder 
whether these should be written normatively (uppercase) or is there a 
reason for not doing it, in which case, I would recommend to go around 
the lowercase terms to avoid confusion.

- Section 5.3, third paragraph: the text is written around the format 
(a=sendonly), but I will instead put the focus on the semantics. For 
example, I would write:

    Since the SRC does not expect to receive media from the SRS, the SRC 
will typically set each media stream of the SDP offer to only send media, 
by qualifying them with the a=sendonly attribute. Conversely, as the SRS 
only receives RTP streams from SRCs, the SDP answer will normally set 
each media stream to only receive media, by setting them with the 
a=recvonly attribute, according to the procedures of RFC 3264 [RFC3264].

- Section 5.3, fourth paragraph. As a matter of personal taste, I prefer 
that actions are attributed to either the SRC or the SRS, but not to the 
"SDP" (which is not an entity). For example, the sentence "the SDP must 
provide a label..." should be restated in terms of the "the SRC MUST 
include a label *attribute* (a=label) in each media stream of the SDP"...

Also, in this fourth paragraph in Section 5.3, avoid the future tense, 
unless you really want to describe an action that will take a later time: 
"... will be used ..."

(Continue reading)

Christer Holmberg | 14 Sep 2011 12:40
Picon
Favicon

Draft submission: draft-holmberg-mmusic-sdp-multiplex-negotiation

 
Hi,
 
I've submitted a new draft, draft-holmberg-mmusic-sdp-multiplex-negotiation, which defines a mechanism and grouping framework extension in order to negotiate multiplexing of media associated with multiple m= lines.
 
Comments are welcome :)
 
Regards,
 
Christer
 
_______________________________________________
mmusic mailing list
mmusic <at> ietf.org
https://www.ietf.org/mailman/listinfo/mmusic
Harald Alvestrand | 14 Sep 2011 20:43
Picon

Re: Draft submission: draft-holmberg-mmusic-sdp-multiplex-negotiation

On 09/14/11 12:40, Christer Holmberg wrote:
 
Hi,
 
I've submitted a new draft, draft-holmberg-mmusic-sdp-multiplex-negotiation, which defines a mechanism and grouping framework extension in order to negotiate multiplexing of media associated with multiple m= lines.
This is an alternative to draft-alvestrand-one-rtp-01; we've discussed this.

We're very interested in having feedback on the differences between the two - in the end, there should be only one!
 
Comments are welcome :)
 
Regards,
 
Christer
 
_______________________________________________ mmusic mailing list mmusic <at> ietf.org https://www.ietf.org/mailman/listinfo/mmusic

_______________________________________________
mmusic mailing list
mmusic <at> ietf.org
https://www.ietf.org/mailman/listinfo/mmusic
Charles Eckel (eckelcu | 14 Sep 2011 21:44
Picon
Favicon

Re: [siprec] SDP Comments to draft-ietf-siprec-protocol-00

Hi Miguel,

Thank you for all your comments. Please see snippet regarding a
clarification on one of your comments.

> - Section 6.2.1. The syntax is not correct. You should start by
extending
> the "attribute" production in SDP, for example:
> 
>        attribute          /= record-attr
>        ; attribute defined in RFC 4566
>        record-attr        = "record:" indication
>        indication         = "on" / "off" / "paused"
> 
> - Section 6.2.2. For discussion... Do you really need two attributes,
> "record" and "recordpref"? I believe both could be integrated into a
> single attribute. For example, you could have the a=record attribute
with
> the two values, one for the current status, and one of the current
> preference.

Are you recommending:

record-attr        = "record:" indication pref [not sure if this is
legit syntax]
indication         = "started" / "stopped" / "paused" / "noindication"
pref                = "start" / "stop" / "pause" / "nopreference"

or 

record-attr        = "record:" value
value              = "started" / "stopped" / "paused"/ "start" / "stop"
/ "pause"

Thanks,
Charles
Bert Greevenbosch | 15 Sep 2011 07:36
Favicon

Re: Draft submission: draft-holmberg-mmusic-sdp-multiplex-negotiation

Hi Christer and Harald,

 

I have reviewed both drafts draft-alvestrand-one-rtp-01 and draft-holmberg-mmusic-sdp-multiplex-negotiation-00.

 

The drafts share the main idea: using the RFC 5888 grouping mechanism to signal that media is multiplexed on the same port (-alvestrand-: TOGETHER; -holmberg-: MULTIPLEX). The following differences caught my attention:

 

1.       In -alvestrand- port numbers associated with sections of the same TOGETHER group are different in the offer, and then adjusted by the answerer depending on whether it accepts or not. In -holmberg- the port numbers are already the same in the offer.

·         The different port numbers in the offer have an effect on legacy device behaviour: in the -alvestrand- case, the legacy device can accept the port numbers as offered, whereas in the -holmberg- case the legacy device response is not specified (as RFC 4566 does not give a clear indication what to do in case of equal port numbers for different media streams).

2.       In -alvestrand- the interpretation of the "b=" (bandwidth) line is well-defined for multiplexed ports.

·         This is omitted in -holmberg-, but could be specified in a similar manner.

3.       In -alvestrand-, there is the concept of "parameter combining".

·         The draft says: "The general approach when combining the sections is to treat the parameters as if they were all contained in the same section."

·         This seems complicated in general, as there are many SDP attributes that only apply to certain media types or codecs.

·         For example, the "fmtp" attribute contains codec specific parameters, that only apply to the associated codec. For different codecs, a sanity check may resolve this problem (as one codec is likely to not understand the parameters from another codec), but especially in case of multiplexing streams from the same codec this sanity check will not resolve the issue.

·         Maybe "parameter" only points to specific RTP parameters, whereas other parameters/attributes can still be specific for different sections? In that case, it might be better to be more specific, i.e. define and use a term "RTP parameter".

4.       In -alvestrand-, the interpretation of the SDP highly depends on the first media section associated with the TOGETHER group.

·         "If the responder understands the semantics of the TOGETHER extension, the parameters of the first section MUST be used to establish the RTP session, and the parameters for the other sections MUST be ignored".

·         The draft correctly states, that this means that refusing the first "m=" section in a TOGETHER group prohibits establishing the call, whereas other "m=" sections in the same group can be refused.

·         This only holds for specific port and ICE parameters; for other parameters see 4.

·         As this is not specified in -holmberg-, there is a need to consider how to handle possible inconsistencies between "m=" sections associated with one MULTIPLEX group there.

5.       In -holmberg-, there are two criteria to determine the multiplexing of multiple "m=" sections:

·         (1) The sections use the same port.

·         (2) The sections are in the same "MULTIPLEX" group.

·         It is specified, when the answer does not contain  the "MULTIPLEX" group, then multiplexing cannot take place.

·         It is not specified, what to do when the "MULTIPLEX" group is included in the answer but the port numbers of the grouped sections are different.

 

What is your opinion on these points?

 

Best regards,

Bert

 

 

From: mmusic-bounces <at> ietf.org [mailto:mmusic-bounces <at> ietf.org] On Behalf Of Harald Alvestrand
Sent: 15 September 2011 02:44
To: Christer Holmberg
Cc: MMUSIC WG
Subject: Re: [MMUSIC] Draft submission: draft-holmberg-mmusic-sdp-multiplex-negotiation

 

On 09/14/11 12:40, Christer Holmberg wrote:

 

Hi,

 

I've submitted a new draft, draft-holmberg-mmusic-sdp-multiplex-negotiation, which defines a mechanism and grouping framework extension in order to negotiate multiplexing of media associated with multiple m= lines.

This is an alternative to draft-alvestrand-one-rtp-01; we've discussed this.

We're very interested in having feedback on the differences between the two - in the end, there should be only one!

 

Comments are welcome :)

 

Regards,

 

Christer

 

 

 

_______________________________________________

mmusic mailing list

mmusic <at> ietf.org

https://www.ietf.org/mailman/listinfo/mmusic

 

_______________________________________________
mmusic mailing list
mmusic <at> ietf.org
https://www.ietf.org/mailman/listinfo/mmusic
Miguel A. Garcia | 15 Sep 2011 08:34
Picon
Favicon

Re: [siprec] SDP Comments to draft-ietf-siprec-protocol-00

Hi Charles:

Both options work for me. Perhaps the first one, being explicit, is more 
future proof.

/Miguel

On 14/09/2011 21:44, Charles Eckel (eckelcu) wrote:
> Hi Miguel,
>
> Thank you for all your comments. Please see snippet regarding a
> clarification on one of your comments.
>
>> - Section 6.2.1. The syntax is not correct. You should start by
> extending
>> the "attribute" production in SDP, for example:
>>
>>         attribute          /= record-attr
>>         ; attribute defined in RFC 4566
>>         record-attr        = "record:" indication
>>         indication         = "on" / "off" / "paused"
>>
>> - Section 6.2.2. For discussion... Do you really need two attributes,
>> "record" and "recordpref"? I believe both could be integrated into a
>> single attribute. For example, you could have the a=record attribute
> with
>> the two values, one for the current status, and one of the current
>> preference.
>
> Are you recommending:
>
> record-attr        = "record:" indication pref [not sure if this is
> legit syntax]
> indication         = "started" / "stopped" / "paused" / "noindication"
> pref                = "start" / "stop" / "pause" / "nopreference"
>
> or
>
> record-attr        = "record:" value
> value              = "started" / "stopped" / "paused"/ "start" / "stop"
> / "pause"
>
> Thanks,
> Charles

--

-- 
Miguel A. Garcia
+34-91-339-3608
Ericsson Spain
Christer Holmberg | 15 Sep 2011 09:00
Picon
Favicon

Re: Draft submission: draft-holmberg-mmusic-sdp-multiplex-negotiation

Hi Bert,

Comments inline.

>I have reviewed both drafts draft-alvestrand-one-rtp-01 and draft-holmberg-mmusic-sdp-multiplex-negotiation-00.
>
>The drafts share the main idea: using the RFC 5888 grouping mechanism to signal that media 
>is multiplexed on the same port (-alvestrand-: TOGETHER; -holmberg-: MULTIPLEX).

Correct. 

(In order to avoid confusion, I used a different name for the grouping :)

>The following differences caught my attention:
>
>	 1.       In -alvestrand- port numbers associated with sections of the same TOGETHER group 
>	are different in the offer, and then adjusted by the answerer depending on whether it accepts 
>	or not. In -holmberg- the port numbers are already the same in the offer.

Correct.

>	The different port numbers in the offer have an effect on legacy device behaviour: in the 
>	-alvestrand- case, the legacy device can accept the port numbers as offered, whereas in the -
>	holmberg- case the legacy device response is not specified (as RFC 4566 does not give a clear 
>	indication what to do in case of equal port numbers for different media streams).

My personal experience is that products will accept the offer in a normal way, and reply with different 
ports, because they aren't really affected by the fact that the remote end uses the same port.

>	2.       	In -alvestrand- the interpretation of the "b=" (bandwidth) line is well-defined for 
>		   	multiplexed ports.
>
>	*         	This is omitted in -holmberg-, but could be specified in a similar manner.

Correct.

>	3.       	In -alvestrand-, there is the concept of "parameter combining".
>
>	*         	The draft says: "The general approach when combining the sections is to treat the 
>			parameters as if they were all contained in the same section."
>
>	*         	This seems complicated in general, as there are many SDP attributes that only apply to 
>			certain media types or codecs.
>
>	*         	For example, the "fmtp" attribute contains codec specific parameters, that only apply to 
>			the associated codec. For different codecs, a sanity check may resolve this problem 
>			(as one codec is likely to not understand the parameters from another codec), but especially 
>			in case of multiplexing streams from the same codec this sanity check will not resolve the issue.
>
>	*         	Maybe "parameter" only points to specific RTP parameters, whereas other parameters/attributes can 
>			still be specific for different sections? In that case, it might be better to be more specific, 
>			i.e. define and use a term "RTP parameter".
>
>	4.       	In -alvestrand-, the interpretation of the SDP highly depends on the first media section associated 
>			with the TOGETHER group.
>
>	*         	"If the responder understands the semantics of the TOGETHER extension, the parameters of the first 
>			section MUST be used to establish the RTP session, and the parameters for the other sections MUST 
>			be ignored".
>
>	*         	The draft correctly states, that this means that refusing the first "m=" section in a TOGETHER group
> 			prohibits establishing the call, whereas other "m=" sections in the same group can be refused.
>
>
>	*         	This only holds for specific port and ICE parameters; for other parameters see 4.
>
>	*         	As this is not specified in -holmberg-, there is a need to consider how to handle possible 
>			inconsistencies between "m=" sections associated with one MULTIPLEX group there.
>
>	5.       	In -holmberg-, there are two criteria to determine the multiplexing of multiple "m=" sections:
>
>	*         	(1) The sections use the same port.
>
>	*         	(2) The sections are in the same "MULTIPLEX" group.
>
>	*         	It is specified, when the answer does not contain the "MULTIPLEX" group, then multiplexing 
>			cannot take place.
>
>	*         	It is not specified, what to do when the "MULTIPLEX" group is included in the answer but the 
>			port numbers of the grouped sections are different.

The draft shall say that it is not allowed - neither in the offer or in the answer.

Thanks for your comments!

Regards,

Christer

	 

	 

	From: mmusic-bounces <at> ietf.org [mailto:mmusic-bounces <at> ietf.org] On Behalf Of Harald Alvestrand
	Sent: 15 September 2011 02:44
	To: Christer Holmberg
	Cc: MMUSIC WG
	Subject: Re: [MMUSIC] Draft submission: draft-holmberg-mmusic-sdp-multiplex-negotiation

	 

	On 09/14/11 12:40, Christer Holmberg wrote: 

	 

	Hi,

	 

	I've submitted a new draft, draft-holmberg-mmusic-sdp-multiplex-negotiation, which defines a
mechanism and grouping framework extension in order to negotiate multiplexing of media associated with
multiple m= lines.

	This is an alternative to draft-alvestrand-one-rtp-01; we've discussed this.
	
	We're very interested in having feedback on the differences between the two - in the end, there should be
only one!
	
	

	 

	Comments are welcome :)

	 

	Regards,

	 

	Christer

	 

	 
	 
	_______________________________________________
	mmusic mailing list
	mmusic <at> ietf.org
	https://www.ietf.org/mailman/listinfo/mmusic

	 

Gmane