1 Jul 2006 03:01
Gen ART review of draft-nystrom-eap-potp-05.txt
<Black_David <at> emc.com>
2006-07-01 01:01:39 GMT
2006-07-01 01:01:39 GMT
Magnus, I am the assigned Gen-ART reviewer for draft-nystrom-eap-potp-05.txt For background on Gen-ART, please see the FAQ at <http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html>. Please resolve these comments along with any other Last Call comments you may receive. This draft is on the right track but has open issues, described in the review. The draft is generally well written, and reasonably clear. Everything I found is minor, but a couple of the concerns rise to the level of open issues that deserve attention. ---------- Issues ---------- (A) Page 31: the definition of "msg_hash" in running text is dense, informal and mixes the algorithm for computing the hash input with a description of the design rationale for the algorithm. The result may be error-prone for an implementer. This should be separated to explicitly specify the algorithm step by step, and then explain why the algorithm is the way it is. At a high level, the algorithm has two basic steps: 1) Concatenate specified messages excluding retransmissions. 2) Remove a list of fields and TLVs from the concatenation, shortening it. The explanation of the algorithm should explain why step 2) is a(Continue reading)
RSS Feed