headers
Ralph Versteegen | 1 Jan 2011 07:23
Picon

Re: SVN: teeemcee/4063 Remove the nativehbits array and all the code for saving/loading it in S

On 31 December 2010 23:06, James Paige <Bob <at> hamsterrepublic.com> wrote:
> On Thu, Dec 30, 2010 at 04:18:38PM -0800, subversion <at> HamsterRepublic.com wrote:
>> teeemcee
>> 2010-12-30 16:18:38 -0800 (Thu, 30 Dec 2010)
>> 640
>> Remove the nativehbits array and all the code for saving/loading it in SAV/RSAV. Only the elemental
bitsets were actually used (for no reason), and none of it was modifiable, so saving it in save files was
more of a bug than a feature!
>
> All this cleanup you are doing lately is fantastic. Kudos!
>
>> However, I left rename_in_status in RSAV (which now corresponds to gam.hero(i).rename_in_status)
because I can see some point in someday allowing it to be modified in-game (if you disagree, go ahead and
remove it), and if I remove it from RSAV, that'll be a nuisance in future. (Hint: adding such a feature is
trivial because all the code is already written... I just don't care enough for it to add it)
>
> I have no objection to it being there.

I have just realised (actually, experienced first-hand) that removing
these bits means older versions of Game will give loaded heroes blank
elemental bits. The rsav version number should be incremeneted.
Unfortunately...

 IF GetChildNodeInt(node, "ver") > 0 THEN
  'FIXME: this should be a user-visible pop-up warning
  rsav_warn "new save file on old game player. Some data might get lost"
 END IF

Noooooo! How many times do we have run into exactly the same lack of
warning messages before we learn our lesson?
(Continue reading)

Permalink | Reply | 1 comment |
headers
subversion | 1 Jan 2011 07:57
Favicon

SVN: teeemcee/4064 Added scrollmenu (usemenu variant); updated Status menu for % elemental

teeemcee
2010-12-31 22:57:42 -0800 (Fri, 31 Dec 2010)
136
Added scrollmenu (usemenu variant); updated Status menu for % elemental resistances (new messages,
which use a new style of substitions)
---
U   wip/common.bas
U   wip/common.bi
U   wip/customsubs.bas
U   wip/menustuf.bas
A   wip/ohrhelp/globalstring_elemental_resist.txt
Permalink | Reply | 0 comments |
headers
subversion | 1 Jan 2011 08:05
Favicon

SVN: teeemcee/4065 Remove weak/strong/absorb bits from battle. Wrote awful_compatible_equip

teeemcee
2010-12-31 23:05:25 -0800 (Fri, 31 Dec 2010)
309
Remove weak/strong/absorb bits from battle. Wrote awful_compatible_equip_elemental_merging which
generalises the old scheme using interpolation (and fuzzy logic).
Also added fuzzythreshold and LoadItemElementals

I've always hated coming up with names for things; sorry I've been pretty poor with that lately.
---
U   wip/battle_udts.bi
U   wip/bmod.bas
U   wip/bmod.bi
U   wip/bmodsubs.bas
U   wip/loading.bas
U   wip/loading.bi
U   wip/menustuf.bas
U   wip/udts.bi
U   wip/util.bas
U   wip/util.bi
Permalink | Reply | 2 comments |
headers
subversion | 1 Jan 2011 08:05
Favicon

SVN: teeemcee/4066 Increment rsav version to 1, add warning message for unknown versions, a

teeemcee
2010-12-31 23:05:49 -0800 (Fri, 31 Dec 2010)
104
Increment rsav version to 1, add warning message for unknown versions, add CURRENT_RSAV_VERSION constant
---
U   wip/const.bi
U   wip/savegame.bas
Permalink | Reply | 0 comments |
headers
subversion | 1 Jan 2011 20:07
Favicon

SVN: teeemcee/4067 Rewrote get/setfixbits, and added extendfile

teeemcee
2011-01-01 11:07:55 -0800 (Sat, 01 Jan 2011)
317
Rewrote get/setfixbits, and added extendfile

get/setfixbits was not only limited to just 16 bits, but it used setpicstuf+load/storeset functions
which I am shocked to find anybody this century still using (and I think you meant to pass 4 bytes instead of 2
as the record size: file corruption just waiting to happen)
---
U   wip/common.bas
U   wip/common.bi
U   wip/util.bas
U   wip/util.bi
Permalink | Reply | 2 comments |
headers
subversion | 1 Jan 2011 20:08
Favicon

SVN: teeemcee/4068 You can time the upgrade process by changing time_rpg_upgrade to true or

teeemcee
2011-01-01 11:08:14 -0800 (Sat, 01 Jan 2011)
175
You can time the upgrade process by changing time_rpg_upgrade to true or passing --time-upgrade.
Added common_setoption for parsing misc shared Game/Custom commandline options
---
U   wip/common.bas
U   wip/common.bi
U   wip/compat.bas
Permalink | Reply | 0 comments |
headers
subversion | 1 Jan 2011 20:08
Favicon

SVN: teeemcee/4069 Fix bug in HashTable (negative hashes would crash hash_find)

teeemcee
2011-01-01 11:08:28 -0800 (Sat, 01 Jan 2011)
112
Fix bug in HashTable (negative hashes would crash hash_find)
Relatedly, added more sanity checking to frame_load
---
U   wip/allmodex.bas
U   wip/util.bas
U   wip/util.bi
Permalink | Reply | 0 comments |
headers
subversion | 1 Jan 2011 20:08
Favicon

SVN: teeemcee/4070 Yikes! Fix hero data corruption bug in game upgrading (hero handle point

teeemcee
2011-01-01 11:08:41 -0800 (Sat, 01 Jan 2011)
472
Yikes! Fix hero data corruption bug in game upgrading (hero handle points fixbit) that's been there over
three years.

It was very hard to notice though. TEST.RPG has been affected by this. If you go to the 2nd spell list of heroes
1 and up, and create spells in the 2nd- and 3rd- to last slots, you'll notice that the 3-rd last one defaults
to "Learned at Level 23", and the 2nd last one has an invalid level learnt that causes it to display
whatever's in the slot above.
---
U   wip/common.bas
Permalink | Reply | 0 comments |
headers
subversion | 1 Jan 2011 20:08
Favicon

SVN: teeemcee/4071 Fix blatantly obvious out-of-bounds crash (introduced r4025) in equip me

teeemcee
2011-01-01 11:08:53 -0800 (Sat, 01 Jan 2011)
260
Fix blatantly obvious out-of-bounds crash (introduced r4025) in equip menu when there were no
alternative equipable items for a slot (just the unequip option).
(Of course it would normally only crash with -exx, which is probably the reason no one mentioned it)
---
U   wip/menustuf.bas
Permalink | Reply | 0 comments |
headers
subversion | 1 Jan 2011 20:09
Favicon

SVN: teeemcee/4072 Updated DT0 and HeroDef for percentage based elementals.

teeemcee
2011-01-01 11:09:07 -0800 (Sat, 01 Jan 2011)
367
Updated DT0 and HeroDef for percentage based elementals.
-DT0 is binsize-sized now
-Changed return value from percent_grabber
-Added SINGLE overloads for percent_grabber & percent_format, and changed their handling of sig. fig.s
-Changed Yorgo's resists in test.rpg. Note that interference from the default weapon prevents values
higher than 200% on the Status screen
---
U   wip/bmod.bas
U   wip/bmodsubs.bas
U   wip/common.bas
U   wip/common.bi
U   wip/const.bi
U   wip/customsubs.bas
U   wip/customsubs.bi
U   wip/loading.bas
U   wip/menustuf.bas
A   wip/ohrhelp/hero_elementals.txt
U   wip/subs.bas
U   wip/testgame/test.rpg
U   wip/udts.bi
Permalink | Reply | 4 comments |

Gmane