1 Aug 2006 12:36
Re: [Freeciv-Dev] (PR#19049) Problematic/buggy strings.
Hi, Jason,
(Freeciv-i18n: cc'd for thine information and entertainment, as well as
keeping the list awake. ;))
Episode x in our series of "let's see how long mails we can generate" -
sorry 'bout that.
On Mon, 2006-07-31 at 10:57 -0700, Jason Dorje Short wrote:
> > #: client/text.c:176 client/gui-sdl/mapview.c:626
> > msgid " with "
> >
> > This string needs a translator comment at the least, but it is also
> > buggy: sentences of any sort should not be split up like this, they
> > should be produced with e.g. "%s with %s" (and translator-commented) so
> > that we can move the with to be somewhere else as well if needed.
>
> It is a problem. Building sentences using code is quite problematic.
> But the alternative is a switch statement with a potentially infinite
> number of cases.
The text.c code looks like this:
impr_type_iterate(i) {
if (is_improvement_visible(i) && city_got_building(pcity, i)) {
/* TRANS: previous lines gave other information about the city. */
if (has_improvements) {
astr_add(&str, ", ");
} else {
astr_add(&str, _(" with "));
}
(Continue reading)
RSS Feed