Testing

1..2...3

Beep
Beep
Beep

I guess this is the first post to the scummc-general mailing list.  
Lets hope its not the last.

Now, where were we?

Re: Testing

On 11/25/06, Stuart J Urquhart <jamesu <at> gmail.com> wrote:
> 1..2...3
>
> Beep
> Beep
> Beep
>
> I guess this is the first post to the scummc-general mailing list.
> Lets hope its not the last.
>
> Now, where were we?

Hello!

Well, now that the ice has been broken, let me point out the patch
I've submitted (adds an operator to implement the isObjectOfClass()
function in a more sensible way):

https://gna.org/patch/?633

I skipped over the notification options, and I noticed the gna docs
say the patch tracker is deprecated, so please let me know if there's
a better way to submit patches.

Jesse

Re: Testing

On Sat, 25 Nov 2006 02:08:47 -0800
"Jesse McGrew" <jmcgrew <at> gmail.com> wrote:

> On 11/25/06, Stuart J Urquhart <jamesu <at> gmail.com> wrote:
> > 1..2...3
> >
> > Beep
> > Beep
> > Beep
> >
> > I guess this is the first post to the scummc-general mailing list.
> > Lets hope its not the last.
> >
> > Now, where were we?
> 
> Hello!
> 
> Well, now that the ice has been broken, let me point out the patch
> I've submitted (adds an operator to implement the isObjectOfClass()
> function in a more sensible way):
> 
> https://gna.org/patch/?633

Look intersting. Sadly i don't have much time for review today :(

> I skipped over the notification options, and I noticed the gna docs
> say the patch tracker is deprecated, so please let me know if there's
> a better way to submit patches.

I dunno yet. The tracker look cool, but not that great to comment on patch.

Conversation Scripts

Hey again,

I was asking Alban the other day how conversations were handled in  
SCUMM. Sadly though, he hadn't investigated this area very much, so  
naturally i decided to do a little digging myself.

Firstly, i got a bit confused since the function names in SCUMMVM  
often have different names compared to SCUMMC. Add to that the fact  
that a lot of the opcodes have sub parameters which are exposed as  
separate functions in SCUMMC, which led me off track a bit.

A crucial element of conversations seems to be the saveRestoreVerbs  
op-code, which is exposed as three functions in SCUMMC:

saveVerbs(saveID, start, end)
    Sets saveid for each verb from start -> end, where saveid == 0
restoreVerbs(saveID, start, end)
    Sets saveid to 0 for each verb from start -> end, where saveid ==  
saveID. Any verbs where saveid is already 0 are killed.
deleteVerbs(saveID, start, end)
    Kills verbs from start -> end where saveid == saveID.

(Note that in all cases, start and end are indexes in the verb list)

This function is called a few times before and after conversations. I  
haven't seen it being called during conversations, so i can only  
assume that all the conversation items must be plonked on all at once.

How does this work in a conversation? well its rather simple.

Re: "is" operator

On Sat, 25 Nov 2006 02:08:47 -0800
"Jesse McGrew" <jmcgrew <at> gmail.com> wrote:

> Hello!
> 
> Well, now that the ice has been broken, let me point out the patch
> I've submitted (adds an operator to implement the isObjectOfClass()
> function in a more sensible way):

Everything alright with patch so it's commited. Keep them comming ;)
We should also update the docs on the wiki.

Which make me think that having the doc separated (ie. not part of the
svn repos) is probably not that good in the long run.
Using something like docbook and post-commit hooks we could use svn and
still have an always up-to-date html version on the web page.

	Albeu

[PATCH] spelling fixes

Here's a patch to correct many of the strings in the compiler and
tools. Mostly these are spelling/punctuation/grammar, but I also fixed
the file extension in scc's usage message.

Affected files:
boxedit.c, char.c, cost_lexer.c, cost_parse.y, costview.c, decode.c,
imgremap.c, midi.c, rd.c, read.c, scc_char.c, scc_code.c, scc_cost.c,
scc_img.c, scc_ld.c, scc_lex.c, scc_lexer.c, scc_ns.c, scc_param.c,
scc_parse.y, scc_roobj.c, scc_smf.c, scc_util.c, scvm.c, scvm_res.c,
scvm_thread.c, write.c, zpnn2bmp.c

Jesse

------ patch begins ------

Index: scc_img.c
===================================================================
--- scc_img.c	(revision 222)
+++ scc_img.c	(working copy)
 <at>  <at>  -195,7 +195,7  <at>  <at> 

   fmt = scc_fd_r32le(fd);
   if(fmt != 0 && fmt != 1) {
-    printf("BMP file %s use an unsupported compression format:
0x%x.\n",fd->filename,fmt);
+    printf("BMP file %s uses an unsupported compression format:
0x%x.\n",fd->filename,fmt);
     return NULL;
   }

Re: Conversation Scripts

On Sat, 25 Nov 2006 15:35:15 +0000
Stuart J Urquhart <jamesu <at> gmail.com> wrote:

> Firstly, i got a bit confused since the function names in SCUMMVM  
> often have different names compared to SCUMMC. Add to that the fact  
> that a lot of the opcodes have sub parameters which are exposed as  
> separate functions in SCUMMC, which led me off track a bit.

Yep i renamed some functions to get more consistency in the ScummC
API, this is IMHO more important than using the same names as ScummVM.
Regarding these sub parameter, they are not really parameters but
functions with 16 bit opcodes. ScummVM implement them with switch()
but it can be done in other ways, in scvm i just used 2 opcode tables.

> A crucial element of conversations seems to be the saveRestoreVerbs  
> op-code, which is exposed as three functions in SCUMMC:
> 
> saveVerbs(saveID, start, end)
>     Sets saveid for each verb from start -> end, where saveid == 0
> restoreVerbs(saveID, start, end)
>     Sets saveid to 0 for each verb from start -> end, where saveid ==  
> saveID. Any verbs where saveid is already 0 are killed.
> deleteVerbs(saveID, start, end)
>     Kills verbs from start -> end where saveid == saveID.
> 
> (Note that in all cases, start and end are indexes in the verb list)

Hmm, are you sure of the argument order ? From the ScummVM code
(script_v6.cpp:o6_saveRestoreVerbs) it seems the saveID come last
and not first.

Re: [PATCH] spelling fixes

On 11/27/06, Alban Bedel <albeu <at> free.fr> wrote:
> On Mon, 27 Nov 2006 12:12:26 -0800
> "Jesse McGrew" <jmcgrew <at> gmail.com> wrote:
>
> > Here's a patch to correct many of the strings in the compiler and
> > tools. Mostly these are spelling/punctuation/grammar, but I also fixed
> > the file extension in scc's usage message.
>
> Look good, but sadly the patch have been munged by the mailing system.
> Could you repost it as attachement ? I forgot to mention that in the
> other mail, my bad :/

All right, here it is.

Jesse

_______________________________________________
ScummC-general mailing list
ScummC-general <at> gna.org
https://mail.gna.org/listinfo/scummc-general

Re: [PATCH] spelling fixes

On 11/27/06, Jesse McGrew <jmcgrew <at> gmail.com> wrote:
> On 11/27/06, Alban Bedel <albeu <at> free.fr> wrote:
> > On Mon, 27 Nov 2006 12:12:26 -0800
> > "Jesse McGrew" <jmcgrew <at> gmail.com> wrote:
> >
> > > Here's a patch to correct many of the strings in the compiler and
> > > tools. Mostly these are spelling/punctuation/grammar, but I also fixed
> > > the file extension in scc's usage message.
> >
> > Look good, but sadly the patch have been munged by the mailing system.
> > Could you repost it as attachement ? I forgot to mention that in the
> > other mail, my bad :/
>
> All right, here it is.

Now that I'm looking at it again, here are a few more corrections I
missed in read.c:

line 1143 should read "Warning: we already have an EXCD\n"
line 1152 should read "Warning: we already have an ENCD\n"
line 1161 should read "Warning: we already have an NLSC\n"

Jesse

Re: Conversation Scripts

On 27 Nov 2006, at 20:22, Alban Bedel wrote:

>
>
>> A crucial element of conversations seems to be the saveRestoreVerbs
>> op-code, which is exposed as three functions in SCUMMC:
>>
>> saveVerbs(saveID, start, end)
>>     Sets saveid for each verb from start -> end, where saveid == 0
>> restoreVerbs(saveID, start, end)
>>     Sets saveid to 0 for each verb from start -> end, where saveid ==
>> saveID. Any verbs where saveid is already 0 are killed.
>> deleteVerbs(saveID, start, end)
>>     Kills verbs from start -> end where saveid == saveID.
>>
>> (Note that in all cases, start and end are indexes in the verb list)
>
> Hmm, are you sure of the argument order ? From the ScummVM code
> (script_v6.cpp:o6_saveRestoreVerbs) it seems the saveID come last
> and not first.

Yes. The args get popped in the order:
    c b a
I would assume scummc pushes the args in the order:
    a b c

a being the start, b being the end, and c being the id, which would  
make sense. Plus of course it works :)