headers
Katsumi Yamaoka | 1 Oct 2010 09:34
X-Face
Favicon
Gravatar

[emacs-w3m:11380] Re: nnshimbun-request-scan fetches unsubscribed server groups

In [emacs-w3m : No.11379] Matt Lundin wrote:
> It works as expected (i.e., activates only subscribed groups at
> startup) if I replace nnshimbun-request-group with
> nnshimbun-request-scan in nnshimbun-retrieve-groups.

> --- nnshimbun.el	2010-09-30 07:38:47.825664151 -0400
> +++ nnshimbun-fix.el	2010-09-30 08:21:01.153141306 -0400
>  <at>  <at>  -531,7 +531,7  <at>  <at> 
>  (deffoo nnshimbun-retrieve-groups (groups &optional server)
>    (when (nnshimbun-possibly-change-group nil server)
>      (dolist (group groups)
> -      (nnshimbun-request-group group server))
> +      (nnshimbun-request-scan group server))
>      t))

Hmm, for me -group works but -scan doesn't.  Anyway I need to
learn more how the most recent Gnus works...
Permalink | Reply | 3 comments |
headers
Matt Lundin | 1 Oct 2010 14:35

[emacs-w3m:11381] Re: nnshimbun-request-scan fetches unsubscribed server groups

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> In [emacs-w3m : No.11379] Matt Lundin wrote:
>> It works as expected (i.e., activates only subscribed groups at
>> startup) if I replace nnshimbun-request-group with
>> nnshimbun-request-scan in nnshimbun-retrieve-groups.
>
>> --- nnshimbun.el	2010-09-30 07:38:47.825664151 -0400
>> +++ nnshimbun-fix.el	2010-09-30 08:21:01.153141306 -0400
>>  <at>  <at>  -531,7 +531,7  <at>  <at> 
>>  (deffoo nnshimbun-retrieve-groups (groups &optional server)
>>    (when (nnshimbun-possibly-change-group nil server)
>>      (dolist (group groups)
>> -      (nnshimbun-request-group group server))
>> +      (nnshimbun-request-scan group server))
>>      t))
>
> Hmm, for me -group works but -scan doesn't.  Anyway I need to
> learn more how the most recent Gnus works...

You are right. With nnshimbun-request-scan, the groups are updated but
not displayed at startup (i.e., no data about the groups is provided to
Gnus).

On the other hand, with nnshimbun-request-group, the groups are
displayed but not updated.

I believe that nnshimbun-request-group only updates the nov database
(and article count) if the group is ephemeral and an .overview file does
not already exist (lines 510-513). Thus, both at startup and when
(Continue reading)

Permalink | Reply | 2 comments |
headers
Matt Lundin | 1 Oct 2010 15:57

[emacs-w3m:11382] Re: nnshimbun-request-scan fetches unsubscribed server groups

Matt Lundin <mdl <at> imapmail.org> writes:

> Katsumi Yamaoka <yamaoka <at> jpl.org> writes:
>
>> Hmm, for me -group works but -scan doesn't.  Anyway I need to
>> learn more how the most recent Gnus works...
>
> You are right. With nnshimbun-request-scan, the groups are updated but
> not displayed at startup (i.e., no data about the groups is provided to
> Gnus).
>
> On the other hand, with nnshimbun-request-group, the groups are
> displayed but not updated.
>
> I believe that nnshimbun-request-group only updates the nov database
> (and article count) if the group is ephemeral and an .overview file does
> not already exist (lines 510-513). Thus, both at startup and when
> calling gnus-group-get-new-news, preexisting nnshimbun groups are not
> updated.
>
> Would it be possible to have nnshimbun-retrieve-groups call
> nnshimbun-request-scan *and* nnshimbun-request-group in succession?

On further review, I find that this does not work either, as it returns
data to Gnus on only one group per server. E.g., only one group in
rss-blogs is displayed, even though I have subscribed to multiple
groups. (This is also the case if nnshimbun-retrieve-groups only calls
nnshimbun-request-group.)

Per the gnus documentation, an nnchoke-retrieve-groups function needs to
(Continue reading)

Permalink | Reply | 1 comment |
headers
Thierry Volpiatto | 2 Oct 2010 08:00
Picon
Gravatar

[emacs-w3m:11383] Re: nnshimbun fail with last version of gnus

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> wrote:
>> nnshimbun doesn't work since last changes in gnus.
>
>> Debugger entered--Lisp error: (wrong-number-of-arguments #[(group &optional server dont-check)
>
> Update it from CVS.
> Cf. http://news.gmane.org/group/gmane.emacs.gnus.general/thread=71153
>
>
Thanks.

--

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
Permalink | Reply | 0 comments |
headers
Katsumi Yamaoka | 6 Oct 2010 07:30
X-Face
Favicon
Gravatar

[emacs-w3m:11384] Re: nnshimbun-request-scan fetches unsubscribed server groups

In [emacs-w3m : No.11382] Matt Lundin wrote:
> Matt Lundin <mdl <at> imapmail.org> writes:
>> Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>>> Hmm, for me -group works but -scan doesn't.  Anyway I need to
>>> learn more how the most recent Gnus works...

>> You are right. With nnshimbun-request-scan, the groups are updated but
>> not displayed at startup (i.e., no data about the groups is provided to
>> Gnus).

Oh, I see at last!  You meant groups newly subscribed to, not
Gnus' startup.  I verified that groups appear with zero unread
articles at startup.

[...]
> On further review, I find that this does not work either, as it returns
> data to Gnus on only one group per server. E.g., only one group in
> rss-blogs is displayed, even though I have subscribed to multiple
> groups. (This is also the case if nnshimbun-retrieve-groups only calls
> nnshimbun-request-group.)

> Per the gnus documentation, an nnchoke-retrieve-groups function needs to
> provide data on all the groups in the server.[1] With the following
> patch, all subscribed nnshimbun groups are both updated and displayed at
> startup:

I've applied your patch.  Thank you very much!
(Continue reading)

Permalink | Reply | 0 comments |
headers
Masatake YAMATO | 7 Oct 2010 12:18
Picon
Favicon

[emacs-w3m:11385] Re: bridging between emacs's bookmark.el and emacs-w3m

今日bzrからとってきたソースコードでビルドしたemacsで試してみましたが、期待通り
動作しました。

大和

> 山岡さん、有沢さん
> 
> コメントとパッチをありがとうございます。
> bookmark-make-record-defaultの引数の宣言を見る限り24でも動きそうですね。
> 私も手元には23しか置いていないので、24で動いたらまた報告致します。他に24で
> ためされた方がいたら、是非ここの報告をお願いします。
> 
> 有沢さんに頂いたパッチを
> 
> 	http://github.com/masatake/bookmark-w3m-el/raw/master/bookmark-w3m.el
> 
> に反映させました。
> 
> 大和
> 
>
Permalink | Reply | 7 comments |
headers
Katsumi Yamaoka | 8 Oct 2010 06:53
X-Face
Favicon
Gravatar

[emacs-w3m:11386] Re: bridging between emacs's bookmark.el and emacs-w3m

In [emacs-w3m : No.11385] 大和さん wrote:
> 今日bzrからとってきたソースコードでビルドしたemacsで試してみましたが、
> 期待通り動作しました。

どうもありがとうございます。少しモディファイして emacs-w3m に組
み込みました。ユーザーは何もしなくても Emacs 23 以上で有効です。

主な変更内容:
・w3m-load.el に bookmark-w3m-bookmark-jump の autoload を追加。
・bookmark-w3m.el が作った bookmark を、emacs-w3m が load されて
　いないときでも使えるようにするためには (require 'w3m-load) が
  必要であることをコメントに追加。
・コンパイル警告を黙らせrるためのおまじないを追加。

こんなかんじでいかがでしょう?
--

-- 
山岡
Permalink | Reply | 6 comments |
headers
Masatake YAMATO | 8 Oct 2010 08:02
Picon
Favicon

[emacs-w3m:11387] Re: bridging between emacs's bookmark.el and emacs-w3m

> In [emacs-w3m : No.11385] 大和さん wrote:
>> 今日bzrからとってきたソースコードでビルドしたemacsで試してみましたが、
>> 期待通り動作しました。
> 
> どうもありがとうございます。少しモディファイして emacs-w3m に組
> み込みました。ユーザーは何もしなくても Emacs 23 以上で有効です。
> 
> 主な変更内容:
> ・w3m-load.el に bookmark-w3m-bookmark-jump の autoload を追加。
> ・bookmark-w3m.el が作った bookmark を、emacs-w3m が load されて
> 　いないときでも使えるようにするためには (require 'w3m-load) が
>   必要であることをコメントに追加。
> ・コンパイル警告を黙らせrるためのおまじないを追加。
>
> こんなかんじでいかがでしょう?

お手数をおかけしました。ありがとうございます。

ということで私の個人のツリーでの作業を停止します。
http://github.com/masatake/bookmark-w3m-el/blob/master/README

大和
Permalink | Reply | 5 comments |
headers
Katsumi Yamaoka | 14 Oct 2010 00:57
X-Face
Favicon
Gravatar

[emacs-w3m:11388] Re: Omitting optional argument of `w3m-tab-previous-buffer' causes an error

IRIE-san wrote:
> I found that a function `w3m-tab-previous-buffer' causes an error
> "Wrong type argument: number-or-marker-p, nil" if it is called with
> no arguments non-interactively like "(w3m-tab-previous-buffer)".

> Currently the code is as follows:

> (defun w3m-tab-previous-buffer (&optional n event)
>   "Turn N pages of emacs-w3m buffers behind."
>   (interactive (list (prefix-numeric-value current-prefix-arg)
> 		     last-command-event))
>   (w3m-tab-next-buffer (- n) event))

> Here, "(- n)" cannot be calculated if N is omitted. To avoid the error,
> it should be modified as:

> (defun w3m-tab-previous-buffer (&optional n event)
>   "Turn N pages of emacs-w3m buffers behind."
>   (interactive (list (prefix-numeric-value current-prefix-arg)
> 		     last-command-event))
>   (w3m-tab-next-buffer (- (or n 1)) event))

Yeah, that's exactly a bug.  Thank you for finding it out.
Fixed in the emacs-w3m CVS trunk.

Regards,
Permalink | Reply | 0 comments |
headers
IRIE Shinsuke | 14 Oct 2010 00:39
Picon
Favicon

[emacs-w3m:11389] Omitting optional argument of `w3m-tab-previous-buffer' causes an error

Hi,

I found that a function `w3m-tab-previous-buffer' causes an error
"Wrong type argument: number-or-marker-p, nil" if it is called with
no arguments non-interactively like "(w3m-tab-previous-buffer)".

Currently the code is as follows:

(defun w3m-tab-previous-buffer (&optional n event)
  "Turn N pages of emacs-w3m buffers behind."
  (interactive (list (prefix-numeric-value current-prefix-arg)
		     last-command-event))
  (w3m-tab-next-buffer (- n) event))

Here, "(- n)" cannot be calculated if N is omitted. To avoid the error,
it should be modified as:

(defun w3m-tab-previous-buffer (&optional n event)
  "Turn N pages of emacs-w3m buffers behind."
  (interactive (list (prefix-numeric-value current-prefix-arg)
		     last-command-event))
  (w3m-tab-next-buffer (- (or n 1)) event))

Thanks.

IRIE Shinsuke
Permalink | Reply | 1 comment |

Gmane