Re: myrkwid bug with backspace/delete

Am 31.03.2011 17:36, schrieb Barry Warsaw:
> Hi Andreas,
>
> myrkwid branch still has a minor problem.
>
> -----snip snip-----
> class Foo:
>      def foo(self):
>          pass
> -----snip snip-----
>
> Put point at the end of the 'pass' line.
>
> Hit return.  Indentation is correct.  However backspace/delete never moves.
>
> Cheers,
> -Barry
>
>
>

Hi Barry,

checked in fixes.
Also cured a mistake of 745208'-fix, where python- and emacs-lisp logic 
has been came across...

Cheers

Andreas

Re: myrkwid bug with backspace/delete

On Apr 01, 2011, at 12:31 PM, Andreas Röhler wrote:

>checked in fixes.  Also cured a mistake of 745208'-fix, where python- and
>emacs-lisp logic has been came across...

Thanks Andreas!  Things are looking better, but still not quite perfect. ;)

-----snip snip-----
def foo():
    a = bar(one=1,
            two=2,
            three=3)
-----snip snip-----

Put point at the closing parenthesis and hit return.  You get lined up under
the 't' in 'three' whereas you should be lined up under the 'a'.

Cheers,
-Barry

_______________________________________________
Python-mode mailing list
Python-mode <at> python.org
http://mail.python.org/mailman/listinfo/python-mode

Re: myrkwid bug with backspace/delete

Am 01.04.2011 21:58, schrieb Barry Warsaw:
> On Apr 01, 2011, at 12:31 PM, Andreas Röhler wrote:
>
>> checked in fixes.  Also cured a mistake of 745208'-fix, where python- and
>> emacs-lisp logic has been came across...
>
> Thanks Andreas!  Things are looking better, but still not quite perfect. ;)
>
> -----snip snip-----
> def foo():
>      a = bar(one=1,
>              two=2,
>              three=3)
> -----snip snip-----
>
> Put point at the closing parenthesis and hit return.  You get lined up under
> the 't' in 'three' whereas you should be lined up under the 'a'.

Hi Berry,

it's lined below `t' indicating the multiline character.

I'm afraid we are here in a sphere, were people will ask for different 
styles.

Unless I miss something.

What about storing that as a bug report and coming back at a later time?

BTW after merge would adress the execute/shell/unicode errors.

Re: myrkwid bug with backspace/delete

On Apr 01, 2011, at 10:45 PM, Andreas Röhler wrote:

>Am 01.04.2011 21:58, schrieb Barry Warsaw:
>> On Apr 01, 2011, at 12:31 PM, Andreas Röhler wrote:
>>
>>> checked in fixes.  Also cured a mistake of 745208'-fix, where python- and
>>> emacs-lisp logic has been came across...
>>
>> Thanks Andreas!  Things are looking better, but still not quite perfect. ;)
>>
>> -----snip snip-----
>> def foo():
>>      a = bar(one=1,
>>              two=2,
>>              three=3)
>> -----snip snip-----
>>
>> Put point at the closing parenthesis and hit return.  You get lined up under
>> the 't' in 'three' whereas you should be lined up under the 'a'.
>
>Hi Berry,
>
>it's lined below `t' indicating the multiline character.

Right.  But after the closing of the bar() function call, the next line can't
possibly occur under the 't' because you'll get an IndentationError:

-----snip snip-----
def foo():
    a = bar(one=1,

Re: myrkwid bug with backspace/delete

Am 01.04.2011 22:49, schrieb Barry Warsaw:
> On Apr 01, 2011, at 10:45 PM, Andreas Röhler wrote:
> 
>>Am 01.04.2011 21:58, schrieb Barry Warsaw:
>>> On Apr 01, 2011, at 12:31 PM, Andreas Röhler wrote:
>>>
>>>> checked in fixes.  Also cured a mistake of 745208'-fix, where python- and
>>>> emacs-lisp logic has been came across...
>>>
>>> Thanks Andreas!  Things are looking better, but still not quite perfect. ;)
>>>
>>> -----snip snip-----
>>> def foo():
>>>      a = bar(one=1,
>>>              two=2,
>>>              three=3)
>>> -----snip snip-----
>>>
>>> Put point at the closing parenthesis and hit return.  You get lined up under
>>> the 't' in 'three' whereas you should be lined up under the 'a'.
>>
>>Hi Berry,
>>
>>it's lined below `t' indicating the multiline character.
> 
> Right.  But after the closing of the bar() function call, the next line can't
> possibly occur under the 't' because you'll get an IndentationError:

Yep.  I don't think anybody would want to be under the 't' in this case.

Re: myrkwid bug with backspace/delete

Am 01.04.2011 22:49, schrieb Barry Warsaw:
> On Apr 01, 2011, at 10:45 PM, Andreas Röhler wrote:
>
>> Am 01.04.2011 21:58, schrieb Barry Warsaw:
>>> On Apr 01, 2011, at 12:31 PM, Andreas Röhler wrote:
>>>
>>>> checked in fixes.  Also cured a mistake of 745208'-fix, where python- and
>>>> emacs-lisp logic has been came across...
>>>
>>> Thanks Andreas!  Things are looking better, but still not quite perfect. ;)
>>>
>>> -----snip snip-----
>>> def foo():
>>>       a = bar(one=1,
>>>               two=2,
>>>               three=3)
>>> -----snip snip-----
>>>
>>> Put point at the closing parenthesis and hit return.  You get lined up under
>>> the 't' in 'three' whereas you should be lined up under the 'a'.
>>
>> Hi Berry,
>>
>> it's lined below `t' indicating the multiline character.
>
> Right.  But after the closing of the bar() function call, the next line can't
> possibly occur under the 't' because you'll get an IndentationError:
>
> -----snip snip-----
> def foo():

Re: myrkwid bug with backspace/delete

Am 01.04.2011 23:23, schrieb Georg Brandl:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 01.04.2011 22:49, schrieb Barry Warsaw:
>> On Apr 01, 2011, at 10:45 PM, Andreas Röhler wrote:
>>
>>> Am 01.04.2011 21:58, schrieb Barry Warsaw:
>>>> On Apr 01, 2011, at 12:31 PM, Andreas Röhler wrote:
>>>>
>>>>> checked in fixes.  Also cured a mistake of 745208'-fix, where python- and
>>>>> emacs-lisp logic has been came across...
>>>>
>>>> Thanks Andreas!  Things are looking better, but still not quite perfect. ;)
>>>>
>>>> -----snip snip-----
>>>> def foo():
>>>>       a = bar(one=1,
>>>>               two=2,
>>>>               three=3)
>>>> -----snip snip-----
>>>>
>>>> Put point at the closing parenthesis and hit return.  You get lined up under
>>>> the 't' in 'three' whereas you should be lined up under the 'a'.
>>>
>>> Hi Berry,
>>>
>>> it's lined below `t' indicating the multiline character.
>>
>> Right.  But Letafter the closing of the bar() function call, the next line can't

Re: myrkwid bug with backspace/delete

[ ... ]

py-compute-indentation fixed, tests added

Cheers

Andreas

Re: python.el cleanup

> ;; That isn't covered by an FSF copyright assignment (?),

IIUC this is still the case (and historically it's the main reason why
it's not been included in Emacs).

> ;; unlike this ;; code, and seems not to be well-maintained for Emacs
> (though I've ;; submitted fixes).

Indeed, it is better to keep such comments elsewhere than in source code.

        Stefan

Re: python.el cleanup

On Apr 03, 2011, at 08:55 PM, Andreas Röhler wrote:

>;; That isn't covered by an FSF copyright assignment (?), unlike this
>;; code, and seems not to be well-maintained for Emacs (though I've
>;; submitted fixes).

I've said before, but it's worth repeating.  While I still believe that at
some point I did sign a copyright assignment for my contributions to
python-mode.el, I also have absolutely no problem signing one again if for
whatever (unimportant) reason, the FSF does not have one on file from me.

Please, if necessary, just send me the paperwork.  I'm certain the FSF has my
contact information on file.

-Barry

_______________________________________________
Python-mode mailing list
Python-mode <at> python.org
http://mail.python.org/mailman/listinfo/python-mode