jon6685 | 2 Jan 2006 14:42
Picon

Bug report and fix

Could someone tell me where I can pass on a bug fix. I've tried
emailing James Clark directly, but have not had any response.

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

Lennart Borgman | 2 Jan 2006 15:25
Picon
Picon
Favicon

Re: Bug report and fix

jon6685 wrote:

>Could someone tell me where I can pass on a bug fix. I've tried
>emailing James Clark directly, but have not had any response.
>  
>
I do not know how to reach him, but maybe you can put the fix on 
http://www.emacswiki.org/  - ?

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

Norman Walsh | 2 Jan 2006 20:14
Favicon

Re: Bug report and fix

/ Lennart Borgman <lennart.borgman.073 <at> student.lu.se> was heard to say:
| jon6685 wrote:
|
|>Could someone tell me where I can pass on a bug fix. I've tried
|>emailing James Clark directly, but have not had any response.
|>  
|>
| I do not know how to reach him, but maybe you can put the fix on 
| http://www.emacswiki.org/  - ?

Please post it here, too :-)

                                        Be seeing you,
                                          norm

--

-- 
Norman Walsh <normyahoo <at> nwalsh.com> | Never despair; but if you do,
http://nwalsh.com/                  | work on in despair.--Edmund Burke
jonhurst737 | 3 Jan 2006 08:59
Picon

Re: Bug report and fix

The bug is in nxml-backward-single-paragraph, which has ramifications
for paragraph filling since nxml-do-fill-paragraph uses this function
when defining the fill region.

 The test case is:

<?xml version="1.0" encoding="utf-8"?>
<test>
  <sub>some &lt; more</sub>
  <sub>some &lt; more</sub>
  <sub>no more &lt;</sub>
</test>

Placing the cursor in the content of either the first or third sub
element and executing nxml-backward-paragraph results in the correct
behavior, but doing the same with the second sub element jumps back to
the same position as the first.

The bug is in line 10 of the nxml-backward-single-paragraph defun.
This should be changed from:

(search-backward "<" nxml-prolog-end t) 

to:

(re-search-backward "[<&]" nxml-prolog-end t)

Regards

Jon
(Continue reading)

Dave Pawson | 3 Jan 2006 09:46
Picon
Gravatar

Re: Re: Bug report and fix

On 03/01/06, jonhurst737 <untrusted <at> hursts.eclipse.co.uk> wrote:

>
> The bug is in line 10 of the nxml-backward-single-paragraph defun.
> This should be changed from:
>
> (search-backward "<" nxml-prolog-end t)
>
> to:
>
> (re-search-backward "[<&]" nxml-prolog-end t)

Thanks John.
Not line 10 of the defun in my listing though?
The modified line is marked ;;DP below.
  Works OK after the mod you supplied though.

Can you confirm this is the one?
Iine 2053 in nxml-mode.el

(defun nxml-backward-single-paragraph ()
  "Move backward over a single paragraph.
Return nil at start of buffer, t otherwise."
  (let* ((token-end (nxml-token-before))
	 (offset (- token-end (point)))
	 (last-tag-pos xmltok-start)
	 pos had-data last-data-pos)
    (goto-char token-end)
    (unless (setq pos (nxml-paragraph-start-pos nil offset))
      (setq had-data (nxml-token-contains-data-p nil offset))
(Continue reading)

Florent Georges | 3 Jan 2006 12:00
Picon
Favicon

Re: Re: Bug report and fix

Dave Pawson wrote:

> Not line 10 of the defun in my listing though?

  You're right.  But it's the line 10 after the docstring.  Coincidence
?-)

  Best wishes to all,

--drkm

	

	
		
___________________________________________________________________________ 
Nouveau : téléphonez moins cher avec Yahoo! Messenger ! Découvez les tarifs exceptionnels pour
appeler la France et l'international.
Téléchargez sur http://fr.messenger.yahoo.com

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

<*> Your use of Yahoo! Groups is subject to:
(Continue reading)

Dave Pawson | 3 Jan 2006 12:08
Picon
Gravatar

Re: Re: Bug report and fix

On 03/01/06, Florent Georges <darkman_spam <at> yahoo.fr> wrote:
> Dave Pawson wrote:
>
> > Not line 10 of the defun in my listing though?
>
>   You're right.  But it's the line 10 after the docstring.  Coincidence
> ?-)

OK Florent :-)
So long as we are talking about the same change, line 10 it is!

regards
--
Dave Pawson
XSLT XSL-FO FAQ.
http://www.dpawson.co.uk

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/

(Continue reading)

LENNART BORGMAN | 3 Jan 2006 13:41
Picon
Picon
Favicon

Re: Re: Bug report and fix


----- Original Message -----
From: Dave Pawson <dave.pawson <at> gmail.com>
Date: Tuesday, January 3, 2006 12:08 pm
Subject: Re: [emacs-nxml-mode] Re: Bug report and fix

> On 03/01/06, Florent Georges <darkman_spam <at> yahoo.fr> wrote:
> > Dave Pawson wrote:
> >
> > > Not line 10 of the defun in my listing though?
> >
> >   You're right.  But it's the line 10 after the docstring.  
> Coincidence> ?-)
> 
> OK Florent :-)
> So long as we are talking about the same change, line 10 it is!
> 

What about a nice "diff -c"?

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

<*> Your use of Yahoo! Groups is subject to:
(Continue reading)

Florent Georges | 3 Jan 2006 14:18
Picon
Favicon

Re: Re: Bug report and fix

LENNART BORGMAN wrote:

> > OK Florent :-)
> > So long as we are talking about the same change, line
> > 10 it is!

> What about a nice "diff -c"?

  Or even "diff -u" for accurate legibility.

--drkm

	

	
		
___________________________________________________________________________ 
Nouveau : téléphonez moins cher avec Yahoo! Messenger ! Découvez les tarifs exceptionnels pour
appeler la France et l'international.
Téléchargez sur http://fr.messenger.yahoo.com

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

(Continue reading)

jonhurst737 | 3 Jan 2006 15:39
Picon

Re: Bug report and fix

--- In emacs-nxml-mode <at> yahoogroups.com, Dave Pawson <dave.pawson <at> g...>
wrote:
> Can you confirm this is the one?
> Iine 2053 in nxml-mode.el

That's the one.

Jon

 
Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/emacs-nxml-mode/

<*> To unsubscribe from this group, send an email to:
    emacs-nxml-mode-unsubscribe <at> yahoogroups.com

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/


Gmane