headers
NAKAMURA Toshikazu | 3 May 2007 04:57
Favicon

Re: a couple of problems (mp3info and tags)

NAKAMURA Toshikazu <nr-tkz <at> nifty.com> writes:
> 
> 1. mp3info (win32) accepts the filename only after all the other
>    arguments. I noticed a similar problem was reported in the mailing
>    list and a patch was applied to emms-tag-editor.el but
>    emms-info-mp3info.el also needs a change.
> 
> 2. When I change the filename while editing a mp3 tag and submit the
>    change, emms-tag-editor.el causes an error when it calls
>    emms-cache-set-function. The order of arguments passed to
>    emms-cache-set-function is wrong.

These problems have been fixed in the latest development snapshot.
Thanks.

> 3. When I delete some info items reducing them to null strings and
>    submit these changes, emms-tag-editor.el fails to set changed
>    values to the tag. In order to make these changes effective, it
>    seems different parts of emms-info-mp3info.el and
>    emms-tag-editor.el need to be rewritten.

However, the last one still seems to need a fix. When I submit changes
including null strings, emms fails to set these null strings to the
tag. Please look at the attached patch to see if it is OK.

Regards,
--

-- 
NAKAMURA Toshikazu <nr-tkz <at> nifty.com>
Attachment (emms-tag-editor.el.patch): application/octet-stream, 551 bytes
(Continue reading)

Permalink | Reply | 4 comments |
headers
Ye Wenbin | 3 May 2007 06:50
Picon

Re: a couple of problems (mp3info and tags)

I have send the patch to emms-patch mailing list at Apr 8. I don't know why
it wasn't applied.

> However, the last one still seems to need a fix. When I submit changes
> including null strings, emms fails to set these null strings to the
> tag. Please look at the attached patch to see if it is OK.
>
> Regards,

--

-- 
使用 Opera 革命性的电子邮件客户程序: http://www.opera.com/mail/
Permalink | Reply | 3 comments |
headers
Jorgen Schaefer | 3 May 2007 11:52

Re: a couple of problems (mp3info and tags)

"Ye Wenbin" <wenbinye <at> gmail.com> writes:

> I have send the patch to emms-patch mailing list at Apr 8. I don't know why
> it wasn't applied.

If there is any patch that is missing, I didn't receive it - could
you resend it?

Regards,
        -- Jorgen

--

-- 
((email . "forcer <at> forcix.cx") (www . "http://www.forcix.cx/")
 (gpg   . "1024D/028AF63C")   (irc . "nick forcer on IRCnet"))
Permalink | Reply | 1 comment |
headers
NAKAMURA Toshikazu | 3 May 2007 12:34
Favicon

Re: a couple of problems (mp3info and tags)

"Ye Wenbin" <wenbinye <at> gmail.com> writes:
> 
> I have send the patch to emms-patch mailing list at Apr 8. I don't know why
> it wasn't applied.
> 
> > However, the last one still seems to need a fix. When I submit changes
> > including null strings, emms fails to set these null strings to the
> > tag. Please look at the attached patch to see if it is OK.

The patch I posted before is for the bugs 1 & 2 in the original
message. It has been applied and these bugs are fixed. For another bug
I mentioned in the same message, I did nothing then, because it seemed
a little complicated. The new patch I posted today is for the last
one. I suppose part of emms-tag-editor.el has been modified but it
still does not work as expected.

So, could you please look at the new patch and apply it if you think
it is OK?

Regards,
--

-- 
NAKAMURA Toshikazu
Permalink | Reply | 0 comments |
headers
Ye Wenbin | 3 May 2007 13:44
Picon

Re: a couple of problems (mp3info and tags)

Sorry, I made a mistake. I didn't notice he point out another bug of my  
code.

> If there is any patch that is missing, I didn't receive it - could
> you resend it?
>
> Regards,
>         -- Jorgen
>
Permalink | Reply | 0 comments |
headers
raindrop | 11 May 2007 14:53
Picon
Favicon

emms-lyrics-display bug?

I just get the emms 05-11-07 package. with  (setq emms-lyrics-display-on-modeline nil) (setq emms-lyrics-display-on-minibuffer t), emms lyrics does not show anything.
maybe the last line of function emms-lyrics-display should be (message lyric) ???

使用下一代的 MSN Messenger。 立即尝试！ 
<div>
<div>I just get the emms 05-11-07 package. with&nbsp; (setq emms-lyrics-display-on-modeline nil) (setq emms-lyrics-display-on-minibuffer t), emms lyrics does not show anything.<br>maybe the last line of function emms-lyrics-display should be (message lyric) ???<br>
</div>
<br>&#20351;&#29992;&#19979;&#19968;&#20195;&#30340; MSN Messenger&#12290; <a href="http://imagine-msn.com/messenger/launch80/default.aspx?locale=zh-cn&amp;source=wlmailtagline" target="_new">&#31435;&#21363;&#23581;&#35797;&#65281;</a>
</div>
Permalink | Reply | 1 comment |
headers
William Xu | 13 May 2007 15:03
Picon
Gravatar

Re: emms-lyrics-display bug?

raindrop <didi_sor <at> hotmail.com> writes:

   I just get the emms 05-11-07 package. with  (setq emms-lyrics-display-on-modeline nil) (setq
   emms-lyrics-display-on-minibuffer t), emms lyrics does not show
   anything.

Do you actually have the lyric files for the playing song? For example,
place `foo.lrc' for `foo.mp3' under the same directory.

        William
Permalink | Reply | 0 comments |
headers
raindrop | 14 May 2007 10:31
Picon
Favicon

RE: emms-lyrics-display bug?

  Of course i did.  if I (setq emms-lyrics-display-on-modeline t) (setq emms-lyrics-display-on-minibuffer t), emms will display lyrics on modeline AND minibuffer. I think the value of `emms-lyrics-mode-line-string' is not valid until emms-lyrics-display-on-modeline is t.
> Do you actually have the lyric files for the playing song? For example,
> place `foo.lrc' for `foo.mp3' under the same directory.
>
>
> William

探索 Windows Vista 的世界 了解更多信息！ 
<div>
&nbsp; Of course i did.&nbsp; if I (setq emms-lyrics-display-on-modeline t) (setq emms-lyrics-display-on-minibuffer t), emms will display lyrics on modeline AND minibuffer. I think the value of `emms-lyrics-mode-line-string' is not valid until emms-lyrics-display-on-modeline is t.<br>&gt; Do you actually have the lyric files for the playing song? For example,<br>&gt; place `foo.lrc' for `foo.mp3' under the same directory.<br>&gt; <br>&gt; <br>&gt;         William<br><br>&#25506;&#32034; Windows Vista &#30340;&#19990;&#30028; <a href="http://search.live.com/results.aspx?q=windows+vista&amp;mkt=zh-cn&amp;FORM=LIVSOP" target="_new">&#20102;&#35299;&#26356;&#22810;&#20449;&#24687;&#65281;</a>
</div>
Permalink | Reply | 501 comments |
headers
William Xu | 14 May 2007 11:05
Picon
Gravatar

Re: emms-lyrics-display bug?

raindrop <didi_sor <at> hotmail.com> writes:

     Of course i did.  if I (setq emms-lyrics-display-on-modeline t) (setq
emms-lyrics-display-on-minibuffer t),
   emms will display lyrics on modeline AND minibuffer. I think the value of
`emms-lyrics-mode-line-string' is
   not valid until emms-lyrics-display-on-modeline is t.

Ah, it's a bug. emms-lyrics-display-on-minibuffer shouldn't depend on
emms-lyrics-display-on-modeline. 

I've just sent a patch fixing that, namely, 

,----
| Mon May 14 16:57:22 CST 2007  William Xu <william.xwl <at> gmail.com>
|   * emms-lyrics.el: (emms-lyrics-display): Fix "displaying only on minibuf"
|   bug, it works now.
`----

You may try the patch now.

Thanks for reporting.

        William
Permalink | Reply | 501 comments |
headers
Ye Wenbin | 21 May 2007 09:11
Picon

Re: Tag Editor

This command is useful when you want replace some text only in certain tag.
for example, replace a to b only in tag `info-title', not in other tags.

Sorry, I'm not good at English, so I don't know how to write a proper  
description for
the commands.

On Sun, 22 Apr 2007 20:15:09 +0800, Daniel Dehennin  
<nebuchadnezzar <at> asgardr.info> wrote:

> Hello,
>
> I try to use the tag editor and figure some difficulties with the
> emms-tag-editor-replace-in-tag.
>
> Is it possible to describe the functionning of this feature please ?
>
> Regards.

--

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Permalink | Reply | 3 comments |

Gmane