Daniel Dehennin | 23 Jul 01:01 2016

[PATCH] Make cons cell usable when replacing a tag

The following changes since commit bec63d3ea62dafc4158c35abdf7e9180419a3f78:

  * Makefile: add .info suffix. (2016-07-09 12:33:04 -0400)

are available in the git repository at:

  git://git.baby-gnu.net/emms.git tags/feature/make-cons-cell-usable-in-emms-tag-editor-replace-in-tag

for you to fetch changes up to a7654a328e17a42cb555a80f681fc21818fd5786:

  Make cons cell usable when replacing a tag (2016-07-22 23:43:09 +0200)

----------------------------------------------------------------
Rebased on latest master:

As reported on the mailing list[1][2], it's not possible to use a cons
cell like '\,(downcase \1)' in emms-tag-editor-replace-in-tag.

After looking at how query-replace-regexp handle this case, I patch
'emms-tag-editor-replace-in-tag'.

I also fix a bug when using a catch all regexp like  '\(.*\)', the
generator will first try to match on the current line, to replace
multiple occurrences in the same string.

But '(re-search-forward "\\(.*\\)" (line-end-position) t)' will match
the end-of-line, making the replacement looping on the same line.

Footnotes:
[1]  http://lists.gnu.org/archive/html/emms-help/2005-07/msg00010.html
(Continue reading)

Daniel Dehennin | 23 Jul 01:00 2016

[PATCH] Avoids FLAC tags duplication with old values.

The following changes since commit bec63d3ea62dafc4158c35abdf7e9180419a3f78:

  * Makefile: add .info suffix. (2016-07-09 12:33:04 -0400)

are available in the git repository at:

  git://git.baby-gnu.net/emms.git tags/hotfix/duplicated-flac-tags

for you to fetch changes up to d392fcd18b79b50daa03b9849c18424fc77cc7ff:

  emms-tag-editor-tag-flac do not replace tags (2016-07-22 23:43:02 +0200)

----------------------------------------------------------------
Avoids FLAC tags duplication with old values.

----------------------------------------------------------------
Daniel Dehennin (1):
      emms-tag-editor-tag-flac do not replace tags

 lisp/emms-tag-editor.el | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/lisp/emms-tag-editor.el b/lisp/emms-tag-editor.el
index 6ed23f2..c1d4b9d 100644
--- a/lisp/emms-tag-editor.el
+++ b/lisp/emms-tag-editor.el
 <at>  <at>  -143,19 +143,25  <at>  <at>  See also `emms-tag-editor-tag-file' and `emms-tag-editor-tag-ogg'.")
   "Commit changes to an FLAC file according to TRACK."
   (require 'emms-info-metaflac)
   (with-temp-buffer
(Continue reading)

Daniel Dehennin | 23 Jul 00:03 2016

Pull request waiting for merge

Hello,

I made 2 pull requests[1] on GitHub for patch posted here
but I have no news about thoses patches and pull requests.

Do they looks good for merging or should I modify something?

Regards.

Footnotes: 
[1]  https://github.com/emacsmirror/emms/pulls

--

-- 
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6  2AAD CC1E 9E5B 7A6F E2DF
Hello,

I made 2 pull requests[1] on GitHub for patch posted here
but I have no news about thoses patches and pull requests.

Do they looks good for merging or should I modify something?

Regards.

Footnotes: 
[1]  https://github.com/emacsmirror/emms/pulls

(Continue reading)

Alex Vong | 9 Jul 10:15 2016
Picon

Info file installed does not have the .info suffice

Hi,

I noticed in the makefile, the following line:
  install -m 0644 $(DOCDIR)emms.info $(INFODIR)/emms
would install the info file without the .info suffice.

It causes problems, because the package manager I am using (GNU Guix)
geneate a dir file for emacs by finding all the info file based on the
file suffice.

I would suggest to change the above line to:
  install -m 0644 $(DOCDIR)emms.info $(INFODIR)/emms.info
which would fix the issue. What do you think?

Thanks,
Alex

Yoni Rabkin | 24 Jun 21:08 2016
Picon

Emacswiki page


If anyone wants to volunteer to review the Emms Emacswiki page, please
do so. It would be useful to provide concrete solutions to questions
being asked, refer people to the manual as well as update out-of-date
information.

--

-- 
   "Cut your own wood and it will warm you twice"

Alejandro Erickson | 23 Jun 00:35 2016
Picon
Gravatar

[PATCH] Remove apparent defunct streams

I also removed Digitally Imported streams and, I believe, Sky.fm
streams, because they require premium subscriptions to be used outside
of their websites and apps.  I think people who use streams a lot do not
depend on this list very much, but it is nice to have a few streams for
the person first trying out `emms-streams`.
---
 lisp/emms-streams.el | 118 ++++++++++++++++++---------------------------------
 1 file changed, 41 insertions(+), 77 deletions(-)

diff --git a/lisp/emms-streams.el b/lisp/emms-streams.el
index 0feee49..c581ba1 100644
--- a/lisp/emms-streams.el
+++ b/lisp/emms-streams.el
 <at>  <at>  -107,83 +107,47  <at>  <at>  needed info.")
 ;; lastfm it's a lastfm station
 (defvar emms-stream-default-list
  '(("SomaFM: Beatblender"
-    "http://www.somafm.com/beatblender.pls" 1 streamlist)
-   ("SomaFM: Secret Agent"
-    "http://www.somafm.com/secretagent.pls" 1 streamlist)
-   ("SomaFM: Groove Salad"
-    "http://www.somafm.com/groovesalad.pls" 1 streamlist)
-   ("SomaFM: Drone Zone"
-    "http://www.somafm.com/dronezone.pls" 1 streamlist)
-   ("SomaFM: Tag's Trance"
-    "http://www.somafm.com/tagstrance.pls" 1 streamlist)
-   ("SomaFM: Indie Pop Rocks"
-    "http://www.somafm.com/indiepop.pls" 1 streamlist)
-   ("SomaFM: Doomed"
-    "http://www.somafm.com/doomed.pls" 1 streamlist)
(Continue reading)

Alejandro Erickson | 23 Jun 00:34 2016
Picon
Gravatar

[PATCH] Clean up trashing functions and comment bugs

(emms-browser-move-files-to-trash) mimics the behaviour
of (emms-browser-delete-files), using (delete-file path t) in order to
ultimately call (move-file-to-trash FILENAME). This allows users to keep
the `delete' functionality of `delete-file` and
`delete-directory` (which can be set to send to trash instead), and also
gives some confidence in the music removal and organisation features of
emms (that they won't accidentally permanently delete music).

Note bug in same function and emms-browser-delete-files, that os
x (darwin) files .DS_Store prevent deletion of empty directories. I
don't know enough elisp to fix this.

Note bug in commented function `de-kill-covers-and-parent`, that it
decides whether or not an album has been deleted based on how many
tracks were deleted.  This is obviously going to give both false
positives and false negatives.  It should instead check whether there
are non-image files (or .DS_Store) in the directories in question.
---
 lisp/emms-browser.el | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/lisp/emms-browser.el b/lisp/emms-browser.el
index 23b1495..5efaa1d 100644
--- a/lisp/emms-browser.el
+++ b/lisp/emms-browser.el
 <at>  <at>  -263,6 +263,10  <at>  <at> 
 ;; The following code will delete covers at the same time, and remove
 ;; parent directories if they're now empty.

+;; Note that deleting more than one song from an album can result in
(Continue reading)

Alejandro Erickson | 23 Jun 00:34 2016
Picon
Gravatar

[PATCH] Play/pause dwim, tries to pause/play music

(emms-play-pause-dwim) first tries (emms-pause).  If an error is
encountered it tries to play the first item in the current playlist.
Failing that it plays something random from the emms browser.  If it
fails again, it emits a message.
---
 lisp/emms.el | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/lisp/emms.el b/lisp/emms.el
index 2d282bb..5a037ed 100644
--- a/lisp/emms.el
+++ b/lisp/emms.el
 <at>  <at>  -434,6 +434,43  <at>  <at>  If player hasn't started, then start it now."
       (emms-player-pause)
     (emms-start)))

+(defun emms-play-pause-dwim ()
+  "Try to (un)pause, or play from playlist, or play a random track from the music library."
+  (interactive)
+  (let ((res nil))
+    (ignore-errors
+      (emms-pause)
+      (setq res t)
+      )
+    (unless res
+      (let ((res nil))
+        (ignore-errors
+          (emms-playlist-mode-go)
+          (goto-line 1) 
+          (emms-playlist-mode-play-smart)
(Continue reading)

Alejandro Erickson | 23 Jun 00:34 2016
Picon
Gravatar

[PATCH 1/2] Bind seek-more keys

Bind keys for seek-more forward/backward.  It might make more sense to
bind </> instead of ,/., but those were taken for seek 10 seconds.
---
 lisp/emms-playlist-mode.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/emms-playlist-mode.el b/lisp/emms-playlist-mode.el
index e8972c0..b4d3faa 100644
--- a/lisp/emms-playlist-mode.el
+++ b/lisp/emms-playlist-mode.el
 <at>  <at>  -137,7 +137,9  <at>  <at>  This is true for every invocation of `emms-playlist-mode-go'."
     (define-key map (kbd "p") 'emms-previous)
     (define-key map (kbd "SPC") 'scroll-up)
     (define-key map (kbd ">") 'emms-seek-forward)
+    (define-key map (kbd ".") 'emms-seek-minute-forward)
     (define-key map (kbd "<") 'emms-seek-backward)
+    (define-key map (kbd ",") 'emms-seek-minute-backward)
     (define-key map (kbd "P") 'emms-pause)
     (define-key map (kbd "s") 'emms-stop)
     (define-key map (kbd "f") 'emms-show)
--

-- 
2.8.3

Иван Трусков | 20 Jun 15:52 2016
Picon

Transferring playlists

Hello!
Is it possible to transfer playlists (pls) between computers if (for some reason) tracks have different positions in directory structure? (things happen during file transfer)...
<div><div dir="ltr">Hello!<div>Is it possible to transfer playlists (pls) between computers if (for some reason) tracks have different positions in directory structure? (things happen during file transfer)...</div>
</div></div>
Alejandro Erickson | 19 Jun 21:32 2016
Picon
Gravatar

help submitting my patches

Hi,
I wrote some extra functions for EMMS as I prepared an EMMS plugin for Spacemacs, and I realised I should probably offer the changes to EMMS first.  I don't understand how to do that though (this being my first emacs-related contribution).  I've read https://www.emacswiki.org/emacs/EMMSDevelopment

I cloned https://github.com/emacsmirror/emms at https://github.com/alejandroerickson/emms and made my changes, with one or so commits per feature.  Your doc doesn't mention github pull requests (naïve question perhaps, but why?), and when I tried the format-patch command I got an the following error:

 % git format-patch -M emacsmirror                                                                                                                                                       ~/emms (master) alejandro
fatal: ambiguous argument 'emacsmirror': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

The changes include:
- seek one minute functions (many people have long, 1hr+ tracks)
- remove defunct streams (about half of them don't work, including DI radio that requires premium account to stream outside their app)
- a delete function that explicitly moves to trash, rather than depending on whether emacs is configured to delete by trashing or not
- play/pause dwim, that tries really hard to play music, even if the playlist is empty

There will probably be more changes as I discover and use more features of emms, but I'd like to submit a patch in the interim.

Additional question: is there testing code for emms?

Note: emms-patches rejected my email.

Alejandro

--
Dr. Alejandro Erickson
Postdoctoral Research Associate in Computer Science, Durham University, UK

<div><div dir="ltr">Hi,<div>I wrote some extra functions for EMMS as I prepared an EMMS plugin for Spacemacs, and I realised I should probably offer the changes to EMMS first.&nbsp; I don't understand how to do that though (this being my first emacs-related contribution).&nbsp; I've read&nbsp;<a href="https://www.emacswiki.org/emacs/EMMSDevelopment" target="_blank">https://www.emacswiki.org/emacs/EMMSDevelopment</a>
</div>
<div><br></div>
<div>I cloned&nbsp;<a href="https://github.com/emacsmirror/emms" target="_blank">https://github.com/emacsmirror/emms</a>&nbsp;at&nbsp;<a href="https://github.com/alejandroerickson/emms" target="_blank">https://github.com/alejandroerickson/emms</a>&nbsp;and made my changes, with one or so commits per feature.&nbsp; Your doc doesn't mention github pull requests (na&iuml;ve question perhaps, but why?), and when I tried the format-patch command I got an the following error:</div>
<div><br></div>
<div>
<div>&nbsp;% git format-patch -M emacsmirror &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ~/emms (master) alejandro</div>
<div>fatal: ambiguous argument 'emacsmirror': unknown revision or path not in the working tree.</div>
<div>Use '--' to separate paths from revisions, like this:</div>
</div>
<div><br></div>
<div>The changes include:</div>
<div>- seek one minute functions (many people have long, 1hr+ tracks)</div>
<div>- remove defunct streams (about half of them don't work, including DI radio that requires premium account to stream outside their app)</div>
<div>- a delete function that explicitly moves to trash, rather than depending on whether emacs is configured to delete by trashing or not</div>
<div>- play/pause dwim, that tries really hard to play music, even if the playlist is empty</div>
<div><br></div>
<div>There will probably be more changes as I discover and use more features of emms, but I'd like to submit a patch in the interim.</div>
<div>
<br><span>Additional question: is there testing code for emms?</span><div class=""></div>
</div>
<div><span><br></span></div>
<div><span>Note: emms-patches rejected my email.</span></div>
<div><span><br></span></div>
<div><span>Alejandro</span></div>
<div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">
<div>
<span>Dr. Alejandro Erickson</span><br>
</div>
<div>Postdoctoral Research Associate in&nbsp;<span>Computer Science,&nbsp;</span><span>Durham University, UK</span>
</div>
<div>
<a href="http://alejandroerickson.com" target="_blank">http://alejandroerickson.com</a><br>
</div>
<div><br></div>
</div></div>
</div></div>

Gmane