Re: el-get is broken *again*
Dave Abrahams <dave@...
2011-06-07 12:12:58 GMT
At Tue, 07 Jun 2011 10:55:25 +0200,
Julien Danjou wrote:
> It's very nice of you to work on what you are currently working on,
> and the problem is not that you broke it. It's that you merged patches
> that are huge, not reviewed and not (totally) tested.
> So, please, please, stop doing that. Make atomic, small, understandable,
> and reviewable commits. Ask for testing and/or review, and merge your
> work step by step with small patches. That way we can fix things all
> together by targeting small patches rather than hundreds of lines
First of all, I'm sorry the code broke for you. That said,
* These patches (and the one you say caused breakage in particular)
were sitting in a pull request for quite some time waiting for
* They implement what Dimitri said should go in immediately after the
* I've been testing them in my own installation for a few weeks
* I actually got someone to review them and made changes, which he
then reviewed again, based on his comments (in particular, they were
not atomic enough).
* I don't know how to implement the features they provide in smaller
commits that make any sense.
* I'll admit I feel a little self-righteous about this part: I'm the
only one who's even bothered to *try* to implement a single test for
el-get, and as far as I can tell the functionality still matches the
documentation. If it doesn't, please tell me in precisely what way.
Better yet: demonstrate how it fails and write a little test case.
Obviously there's something in your usage pattern that doesn't match
mine, but how am I supposed to avoid "breaking" code if I don't have
any sense of what that is?
> Now we have to wait for you to fix it, because clearly it's not an
> option to me to spend hours digging and understanding what you did and
> what you wanted to do.
Or you can roll back and discard everything I committed, I suppose. I
would really prefer that you didn't, though.
> FYI, my config just calls (el-get 'wait) with some `el-get-sources' set,
> and it seems el-get does not load anything anymore (even autoload I
That is surely a breakdown in the work I did to preserve backward
compatability with the old way of using el-get-sources.
el-get-standard-packages now contains the list of the packages you
expect to always be installed. My guess is that you are setting
el-get-sources after loading el-get. Is that right?
To unsubscribe, send mail to el-get-devel-unsubscribe@...