Nuevo Crucero a Brasil

EmacsWiki page

I just established http://www.emacswiki.org/emacs/el-get, but it's
beyond minimal.  Dimitri, it'd be great if you could write something
there.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

--

-- 
To unsubscribe, send mail to el-get-devel-unsubscribe@...

el-get is broken *again*

Hi,

This morning I git pull'ed el-get, and it just broke my Emacs *again*.

I bisected, and the culprit is:

commit ab191c8bc35ab3bbcec437069dc64b6dea3875e4
Author: Dave Abrahams <dave@...>
Date:   Thu May 26 10:37:28 2011 -0400

    Dependency resolution and dynamic package state tracking

Obviously, this commit is huge and not the last one, so I can't revert
it easily.

Dave, this is at least the second time you totally break el-get. I'm ok
that people break things, but only if we can understand why, and if can
at least be reverted/understood/fixed easily.

It's very nice of you to work on what you are currently working on,
and the problem is not that you broke it. It's that you merged patches
that are huge, not reviewed and not (totally) tested.

So, please, please, stop doing that. Make atomic, small, understandable,
and reviewable commits. Ask for testing and/or review, and merge your
work step by step with small patches. That way we can fix things all
together by targeting small patches rather than hundreds of lines
changed.

Now we have to wait for you to fix it, because clearly it's not an
option to me to spend hours digging and understanding what you did and
what you wanted to do. 

FYI, my config just calls (el-get 'wait) with some `el-get-sources' set,
and it seems el-get does not load anything anymore (even autoload I
guess).

--

-- 
Julien Danjou
❱ http://julien.danjou.info

Re: el-get is broken *again*

At Tue, 07 Jun 2011 10:55:25 +0200,
Julien Danjou wrote:
> 
> It's very nice of you to work on what you are currently working on,
> and the problem is not that you broke it. It's that you merged patches
> that are huge, not reviewed and not (totally) tested.
>
> So, please, please, stop doing that. Make atomic, small, understandable,
> and reviewable commits. Ask for testing and/or review, and merge your
> work step by step with small patches. That way we can fix things all
> together by targeting small patches rather than hundreds of lines
> changed.

First of all, I'm sorry the code broke for you.  That said,

* These patches (and the one you say caused breakage in particular)
  were sitting in a pull request for quite some time waiting for
  review

* They implement what Dimitri said should go in immediately after the
  release

* I've been testing them in my own installation for a few weeks

* I actually got someone to review them and made changes, which he
  then reviewed again, based on his comments (in particular, they were
  not atomic enough).

* I don't know how to implement the features they provide in smaller
  commits that make any sense.

* I'll admit I feel a little self-righteous about this part: I'm the
  only one who's even bothered to *try* to implement a single test for
  el-get, and as far as I can tell the functionality still matches the
  documentation.  If it doesn't, please tell me in precisely what way.
  Better yet: demonstrate how it fails and write a little test case.

  Obviously there's something in your usage pattern that doesn't match
  mine, but how am I supposed to avoid "breaking" code if I don't have
  any sense of what that is?

> Now we have to wait for you to fix it, because clearly it's not an
> option to me to spend hours digging and understanding what you did and
> what you wanted to do. 

Or you can roll back and discard everything I committed, I suppose.  I
would really prefer that you didn't, though.

> FYI, my config just calls (el-get 'wait) with some `el-get-sources' set,
> and it seems el-get does not load anything anymore (even autoload I
> guess).

That is surely a breakdown in the work I did to preserve backward
compatability with the old way of using el-get-sources.
el-get-standard-packages now contains the list of the packages you
expect to always be installed.  My guess is that you are setting
el-get-sources after loading el-get.  Is that right?

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

--

-- 
To unsubscribe, send mail to el-get-devel-unsubscribe@...

Re: el-get is broken *again*

On Tue, Jun 07 2011, Dave Abrahams wrote:
> That is surely a breakdown in the work I did to preserve backward
> compatability with the old way of using el-get-sources.
> el-get-standard-packages now contains the list of the packages you
> expect to always be installed.  My guess is that you are setting
> el-get-sources after loading el-get.  Is that right?

Yes, that's right.

--

-- 
Julien Danjou
❱ http://julien.danjou.info

Re: el-get is broken *again*

At Tue, 07 Jun 2011 15:00:31 +0200,
Julien Danjou wrote:
> 
> On Tue, Jun 07 2011, Dave Abrahams wrote:
> > That is surely a breakdown in the work I did to preserve backward
> > compatability with the old way of using el-get-sources.
> > el-get-standard-packages now contains the list of the packages you
> > expect to always be installed.  My guess is that you are setting
> > el-get-sources after loading el-get.  Is that right?
> 
> Yes, that's right.

Could you try setting el-get-sources before loading el-get and see if
that makes everything work for you?

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

--

-- 
To unsubscribe, send mail to el-get-devel-unsubscribe@...

Re: el-get is broken *again*

On Tue, Jun 07 2011, Dave Abrahams wrote:

> Could you try setting el-get-sources before loading el-get and see if
> that makes everything work for you?

Yes, that fixes the problem.
(OTOH I'm not sure that's a good solution but you might have a fix :)

--

-- 
Julien Danjou
❱ http://julien.danjou.info

Re: el-get is broken *again*

At Tue, 07 Jun 2011 09:18:18 -0400,
Dave Abrahams wrote:
> 
> At Tue, 07 Jun 2011 15:00:31 +0200,
> Julien Danjou wrote:
> > 
> > On Tue, Jun 07 2011, Dave Abrahams wrote:
> > > That is surely a breakdown in the work I did to preserve backward
> > > compatability with the old way of using el-get-sources.
> > > el-get-standard-packages now contains the list of the packages you
> > > expect to always be installed.  My guess is that you are setting
> > > el-get-sources after loading el-get.  Is that right?
> > 
> > Yes, that's right.
> 
> Could you try setting el-get-sources before loading el-get and see if
> that makes everything work for you?

I just pushed some changes designed to solve this problem, but they
really have not been tested enough, so I'd appreciate it if you'd try
them out.  I am going to try to write some simple tests for these
next.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

--

-- 
To unsubscribe, send mail to el-get-devel-unsubscribe@...

Re: el-get is broken *again*

On Tue, Jun 07 2011, Dave Abrahams wrote:

> I just pushed some changes designed to solve this problem, but they
> really have not been tested enough, so I'd appreciate it if you'd try
> them out.  I am going to try to write some simple tests for these
> next.

I pulled that.

Now, it does not work at all, with el-get-sources set after or before
(require 'el-get).

--

-- 
Julien Danjou
❱ http://julien.danjou.info

Re: el-get is broken *again*

At Tue, 07 Jun 2011 16:37:46 +0200,
Julien Danjou wrote:
> 
> On Tue, Jun 07 2011, Dave Abrahams wrote:
> 
> > I just pushed some changes designed to solve this problem, but they
> > really have not been tested enough, so I'd appreciate it if you'd try
> > them out.  I am going to try to write some simple tests for these
> > next.
> 
> I pulled that.
> 
> Now, it does not work at all, with el-get-sources set after or before
> (require 'el-get).

Bah, please roll back one step and use the workaround of pre-setting
el-get-sources for the time being; I'll get it fixed.

Sorry for the inconvenience.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

--

-- 
To unsubscribe, send mail to el-get-devel-unsubscribe@...