[commit] rev 388: dvc-bookmarks: Further fix removing partners.

Thanks for cleaning up my mess, Thierry.  This patch fixes the case when
you have more than one partner and you want to remove the second or
subsequent one and that one has a nick.

Committed revision 388 to http://bazaar.launchpad.net/~toby-mi6/dvc/toby_allsopp

dvc-bookmarks: Further fix removing partners.

  * lisp/dvc-bookmarks.el (dvc-bookmarks-remove-partner): Use the actual
    partner object rather than creating a new one designed to look like the
    old one.  Require the input partner to match an existing partner.
    Default to the partner at point.

Re: [commit] rev 388: dvc-bookmarks: Further fix removing partners.

Toby Allsopp <toby <at> mi6.gen.nz> writes:

> Thanks for cleaning up my mess, Thierry.  This patch fixes the case when
> you have more than one partner and you want to remove the second or
> subsequent one and that one has a nick.
>
> Committed revision 388 to http://bazaar.launchpad.net/~toby-mi6/dvc/toby_allsopp
>
> dvc-bookmarks: Further fix removing partners.
>   
>   * lisp/dvc-bookmarks.el (dvc-bookmarks-remove-partner): Use the actual
>     partner object rather than creating a new one designed to look like the
>     old one.  Require the input partner to match an existing partner.
>     Default to the partner at point.

Very nice, pulled!
Thank you.
--

-- 
A + Thierry
Pub key: http://pgp.mit.edu

[commit] rev 388: Merged from Toby Allsopp: Some more fixes for dvc-bookmarks-remove-partner

Committed revision 388 to http://bzr.xsteve.at/dvc/

Merged from Toby Allsopp: Some more fixes for dvc-bookmarks-remove-partner
    ------------------------------------------------------------
    revno: 387.1.1
    committer: Toby Allsopp <toby <at> mi6.gen.nz>
    branch nick: fix-bookmarks
    timestamp: Tue 2008-04-01 21:05:32 +1300
    message:
      dvc-bookmarks: Further fix removing partners.

      * lisp/dvc-bookmarks.el (dvc-bookmarks-remove-partner): Use the actual
        partner object rather than creating a new one designed to look like the
        old one.  Require the input partner to match an existing partner.
        Default to the partner at point.

Re: [commit] rev 383: dvc-bookmarks: Add a function to edit a bookmark.

   >    dvc-bookmarks: Add a function to edit a bookmark.
   >
   > What's a bookmark in the DVC.el meaning ?

   That's a pretty poor explanation, sorry.  In the absence of good
   documentation the source is your best bet for figuring out what it does.

That's ok and is enough for me to start using it :)

Thank you.

	Xavier
--

-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

Unit tests ?

Hi,

Has someone already thought to add unit tests to check for
regressions and such into DVC.el ?

I think we should have such tests.

Regards

	Xavier
--

-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

[commit] rev 390: dvc-bookmarks: Update display when adding/removing partners/nicknames.

Committed revision 390 to http://bazaar.launchpad.net/~toby-mi6/dvc/toby_allsopp

dvc-bookmarks: Update display when adding/removing partners/nicknames.

  * lisp/dvc-bookmarks.el (dvc-bookmarks-invalidate-current-bookmark): New function.
    (dvc-bookmarks-add-partner, dvc-bookmarks-remove-partner) 
    (dvc-bookmarks-add-nickname): Call it.

[commit] rev 391: dvc-bookmarks: Clean up nickname adding code.

Committed revision 391 to http://bazaar.launchpad.net/~toby-mi6/dvc/toby_allsopp

dvc-bookmarks: Clean up nickname adding code.

  * lisp/dvc-bookmarks.el (dvc-bookmark-partners-by-url): New function.
    (dvc-bookmarks-remove-partner): Call it.
    (dvc-bookmarks-add-nickname): Simplify by using
    dvc-bookmark-partners-by-url and dvc-bookmarks-partner-nickname.
    Report an error in case dvc-bookmarks-partner-at-point is buggy.

dvc-bookmarks

Hello, dvc-bookmarks-pull and dvc-bookmarks-missing don't support path
like "~/some_path" when pulling or "missing" from a partner.
I modify these two functions:

,----
| (defun dvc-bookmarks-missing ()
|   (interactive)
|   (let ((local-tree (dvc-bookmarks-current-value 'local-tree)))
|     (if local-tree
|         (let* ((default-directory local-tree)
| 	      (abs-partner (if (file-directory-p (dvc-bookmarks-partner-at-point))
| 			       (expand-file-name (dvc-bookmarks-partner-at-point))
| 			     (dvc-bookmarks-partner-at-point)))
|               (partner (or abs-partner (dvc-bookmarks-marked-value 'local-tree))))
|           (message "Running dvc missing for %s, against %s"
|                    (dvc-bookmark-name (dvc-bookmarks-current-bookmark))
|                    partner)
|           (dvc-missing partner))
|       (message "No local-tree defined for this bookmark entry."))))
`----

,----
| (defun dvc-bookmarks-pull ()
|   "Pull from partner at point or default into current bookmark."
|   (interactive)
|   (let ((local-tree (dvc-bookmarks-current-value 'local-tree)))
|     (if local-tree
|         (let ((default-directory local-tree)
|               (partner (if (file-directory-p (dvc-bookmarks-partner-at-point))
| 			   (expand-file-name (dvc-bookmarks-partner-at-point))

[PATCH] dvc-log-close : respect vc-delete-logbuf-window

<<LOG-START>>
(dvc-log-close): do not delete log buffer if vc-delete-logbuf-window is nil
<<LOG-END>>

[VERSION] dvc-dev-bzr

Bazaar (bzr) 1.0.0

Emacs  : GNU Emacs 23.0.60.10 (x86_64-unknown-linux-gnu, GTK+ Version 2.8.20)
 of 2008-03-31 on nyc-qws-005
-- 
Sam Steingold (http://sds.podval.org/) on Fedora Core release 5 (Bordeaux)
http://iris.org.il http://palestinefacts.org http://honestreporting.com
http://openvotingconsortium.org http://jihadwatch.org http://mideasttruth.com
If you know that you know nothing, you know too much.

=== modified file 'lisp/dvc-log.el'
--- lisp/dvc-log.el	2008-01-25 08:42:13 +0000
+++ lisp/dvc-log.el	2008-04-02 16:08:10 +0000
@@ -151,7 +151,9 @@

 (defun dvc-log-close (buffer)
   "Close the log buffer, and delete the file."
-  (kill-buffer buffer)
+  (if vc-delete-logbuf-window
+      (kill-buffer buffer)
+      (bury-buffer buffer))
   (delete-file (dvc-log-edit-file-name)))

Re: dvc-bookmarks

Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

> Hello, dvc-bookmarks-pull and dvc-bookmarks-missing don't support path
> like "~/some_path" when pulling or "missing" from a partner.
> I modify these two functions:
>
> ,----
> | (defun dvc-bookmarks-missing ()
> |   (interactive)
> |   (let ((local-tree (dvc-bookmarks-current-value 'local-tree)))
> |     (if local-tree
> |         (let* ((default-directory local-tree)
> | 	      (abs-partner (if (file-directory-p (dvc-bookmarks-partner-at-point))
> | 			       (expand-file-name (dvc-bookmarks-partner-at-point))
> | 			     (dvc-bookmarks-partner-at-point)))
> |               (partner (or abs-partner (dvc-bookmarks-marked-value 'local-tree))))
> |           (message "Running dvc missing for %s, against %s"
> |                    (dvc-bookmark-name (dvc-bookmarks-current-bookmark))
> |                    partner)
> |           (dvc-missing partner))
> |       (message "No local-tree defined for this bookmark entry."))))
> `----
>
> ,----
> | (defun dvc-bookmarks-pull ()
> |   "Pull from partner at point or default into current bookmark."
> |   (interactive)
> |   (let ((local-tree (dvc-bookmarks-current-value 'local-tree)))
> |     (if local-tree
> |         (let ((default-directory local-tree)