Re: DVC-API and requiring 'sh'

Matthieu Moy <Matthieu.Moy <at> imag.fr> writes:

> Stephen Leake <stephen_leake <at> stephe-leake.org> writes:
>
>> The part about porting to Windows without 'sh' not being "hard" is not
>> true; 'sh' is required to separate stdout from stderr, since Emacs
>> call-process merges them.
>>
>> Creating a version of DVC that does not require 'sh' requires fixing
>> call-process first. That is not only "hard" (call-process is the
>> hairiest C code I've ever seen), it is probably impossible, since it
>> would break every other use of call-process. We might be able to
>> implement a new function call-process-separate-stdout-stderr, but
>> there's no way it would become part of standard Emacs.
>
> Well, I don't know Windows enough, but I'd be really surprised if
> there were no way to split stdout and stderr on windows other than
> using cygwin/mingw.
>
> I'm not talking about changing Emacs, just finding a native way to do
> what we do with "sh".

Ah. Good point.

I'm so used to using "sh" for things, I forgot there is a Windows OS
shell language :).

How about this:

  In practice, that is not a problem for Unix users, but requires

Re: [commit] rev 294: dvc-log-edit-done: Snarf the current prefix argument

Michael Olson <mwolson <at> gnu.org> writes:

> Stephen Leake <stephen_leake <at> stephe-leake.org> writes:
>
>> Michael Olson <mwolson <at> member.fsf.org> writes:
>>
>>> Committed revision 294 to http://mwolson.org/bzr/dvc/
>>>
>>> dvc-log-edit-done: Snarf the current prefix argument
>>>   
>>>   This allows C-u C-c C-c in a log edit buffer to actually work for
>>>   xgit.
>>
>> What does C-u mean in this context?
>>
>> Please describe it in the doc string for dvc-log-edit-done, so other
>> back-ends can implement it.
>
> It means whatever backends want it to mean.  It's just a "slot".  In the
> case of xgit, it means "reverse the value of xgit-use-index for this
> commit".  I already explained the xgit-specific part in an earlier log
> message for the changes that modified xgit.

Hmm. I'm not sure back-end implementation-dependent arguments are a
good thing in the DVC front-end. But this one seems fairly benign.

At least let's document it in dvc-unified. How about:

(define-dvc-unified-command dvc-log-edit-done (&optional arg)
  "Commit and close the log buffer. Optional ARG is back-end specific."

reverse order of buffers in ediff?

In pcvs, when you request an ediff display of a file against its base
version, the base is in the top window, the workspace in the bottom.

In DVC, the base is in the bottom.

I find this confusing, and I think it will confuse new users.

I guess tla followed the DVC convention?

I'd like to change it to be the same as pcvs. Perhaps it needs to be a
user option?

--

-- 
-- Stephe

Re: [commit] rev 294: dvc-log-edit-done: Snarf the current prefix argument

Stephen Leake <stephen_leake <at> stephe-leake.org> writes:

> Hmm. I'm not sure back-end implementation-dependent arguments are a
> good thing in the DVC front-end. But this one seems fairly benign.
>
> At least let's document it in dvc-unified. How about:
>
> (define-dvc-unified-command dvc-log-edit-done (&optional arg)
>   "Commit and close the log buffer. Optional ARG is back-end specific."

If you want to send in a patch for this, that's fine by me.  Just use
two spaces after the period.

--

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
            Sysadmin -- Hobbies: Lisp, GP2X, HCoop    | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

_______________________________________________
Dvc-dev mailing list
Dvc-dev <at> gna.org
https://mail.gna.org/listinfo/dvc-dev

Re: reverse order of buffers in ediff?

>>>>> "stephen" == Stephen Leake <stephen_leake <at> stephe-leake.org> writes:

    stephen> In pcvs, when you request an ediff display of a file against its base
    stephen> version, the base is in the top window, the workspace in the bottom.

    stephen> In DVC, the base is in the bottom.

    stephen> I find this confusing, and I think it will confuse new users.

    stephen> I guess tla followed the DVC convention?

    stephen> I'd like to change it to be the same as
    stephen> pcvs. Perhaps it needs to be a user option?

Oh please do so ! I *always* use '~' to switch the buffers when
using ediff from dvc... and never find the time to dig to
implement this.

      Vincent

rev 274: xmtn-dvc-missing don't check number of heads

Committed revision 274 to http://stephe-leake.org/dvc

  * lisp/xmtn-revlist.el (xmtn-dvc-missing): don't check number of heads;
    output is useful with 1 or more heads.

--

-- 
-- Stephe

rev 276: misc cleanup, one more 'let dvc-temp-current-active-dvc'

Committed revision 276 to http://stephe-leake.org/dvc

  * docs/DVC-API (dvc-revision-get-file-in-buffer): better discussion of
    requiring'sh'

  * lisp/dvc-core.el (dvc-revision-get-file-in-buffer): set
    dvc-temp-current-active-dvc for find-file-hook.

  * lisp/dvc-unified.el (dvc-log-edit-done): improve doc string.

--

-- 
-- Stephe

[commit] rev 126: dvc-missing: Symbol's function definition is void: dvc-remove-optional-args

Committed revision 126 to http://www.asgardr.info/~nebu/archives/dvc.dev/

dvc-missing: Symbol's function definition is void: dvc-remove-optional-args

  * lisp/dvc-unified.el (dvc-remove-optional-args): autoload the function.

--

-- 
Daniel Dehennin
Récupérer ma clef GPG:
gpg --keyserver pgp.mit.edu --recv-keys 0x6A2540D1

_______________________________________________
Dvc-dev mailing list
Dvc-dev <at> gna.org
https://mail.gna.org/listinfo/dvc-dev

xdarcs-missing, -pull vs dvc-back-end-wrappers

Stefan Reichör <stefan <at> xsteve.at> writes:

> Committed revision 277 to http://bzr.xsteve.at/dvc/
>
> xdarcs: Implemented xdarcs-missing

and later:

> Committed revision 278 to http://bzr.xsteve.at/dvc/
>
> xdarcs: Added a simple implementation for xdarcs-pull: Just pull all
> changes via "darcs pull -all"

These added the following to xdarcs-dvc.el:

;;;###autoload
(defalias 'xdarcs-dvc-missing 'xdarcs-missing)

;;;###autoload
(defalias 'xdarcs-dvc-pull 'xdarcs-pull)

This raises the issue of exactly what functions belong in
dvc-back-end-wrappers, and whether to use aliases for back-end
functions. See the thread at
https://mail.gna.org/public/dvc-dev/2007-10/msg00050.html 

That thread did not arrive at a clear policy.

The intent is to make it easy for users to handle the case of a
workspace that is controlled by more than one back-end. For example, I

Re: reverse order of buffers in ediff?

Stephen Leake <stephen_leake <at> stephe-leake.org> writes:

> In pcvs, when you request an ediff display of a file against its base
> version, the base is in the top window, the workspace in the bottom.
>
> In DVC, the base is in the bottom.
>
> I find this confusing, and I think it will confuse new users.
>
> I guess tla followed the DVC convention?
>
> I'd like to change it to be the same as pcvs. Perhaps it needs to be a
> user option?

I found the required change. In dvc-diff.el, function dvc-diff-ediff
does:

            (dvc-file-ediff-revisions on-modified-file
                                      dvc-diff-modified
                                      dvc-diff-base)

But dvc-file-ediff-revisions is defined as:

(defun dvc-file-ediff-revisions (file &optional base modified)

Another function, dvc-file-ediff, puts the base revision on top.

So it would seem the current behavior is a mistake, and dvc-diff-ediff
should be changed to do: