Re: [DVC] Re: trying dvc

I'll take a look.

> > I tried both xtla-1.2.tar.gz and dvc-snapshot.tar.gz.  In each
> > case I ran into the same issue.  I could not add a new branch
> > within the archive browser window.  The diagnostic complained of
> > failing to identify the nature of the branch/archive/repository.
> 
> The archive browser is a tla/baz-only feature for now.
> 
> I invite you do continue the discussion on dvc-dev ML (which I'm
> Cc-ing).

Masatake

[DVC] [PATCH] Autoconf 2.59d compatibility issue

Hi,

I needed to set "datarootdir" in "texinfo/Makefile.in" (see the enclosed
patch) to build and install with my version of autoconf (2.59d); it
won't be set otherwise, thus resulting in an attempt to install info
files to "/info/" instead of "/usr/share/info/".

I do not know if this is a proper bug fix, I just followed the first
search hit about the problem I was able to spot:

  http://www.ginac.de/pipermail/cln-list/2006-April/000187.html

<<LOG-START>>
Set "datarootdir" in order to build with autoconf 2.59d.
<<LOG-END>>

[VERSION] stefan@.../dvc--dev--0--patch-231

Emacs  : GNU Emacs 22.0.50.1 (i486-pc-linux-gnu, GTK+ Version 2.8.17)
 of 2006-05-24 on pacem, modified by Debian
--

-- 
Ciao, Davide

_______________________________________________
Dvc-dev mailing list
Dvc-dev@...
https://mail.gna.org/listinfo/dvc-dev

[DVC] ewoc

Hi,

dvc has problems here with "ewoc.el" version as shipped with Emacs (GNU
Emacs 22.0.50.1 (i486-pc-linux-gnu, GTK+ Version 2.8.17) of 2006-05-24
on pacem, modified by Debian).  For instance, what should be separate
lines in the bookmark buffer, as well as in others, display as a single
long line with items separated by some space.  Other errors show up as
well when trying to view missing patches (I can try to be more specific
if asked).

The problem disappears if I (load-file
"/usr/share/emacs/site-lisp/dvc/lisp/contrib/ewoc.el"); maybe dvc should
cater for the apparently slightly reworked ewoc API.

--

-- 
Thanks, Davide

Re: [DVC] ewoc

"Davide G. M. Salvetti" <salve@...> writes:

> The problem disappears if I (load-file
> "/usr/share/emacs/site-lisp/dvc/lisp/contrib/ewoc.el"); maybe dvc should
> cater for the apparently slightly reworked ewoc API.

Yes, we've already been told that. I'll probably hit the problem soon
too .

But the development of DVC is not very active right now (by lack of
time for me), so you'll have to wait for some time, or fix it
yourself :-\. I'll try to do that within a few weeks.

--

-- 
Matthieu

Re: [DVC] ewoc

>>>>>  MM == Matthieu Moy [2006-6-2]

MM> But the development of DVC is not very active right now (by lack of
MM> time for me), so you'll have to wait for some time, or fix it
MM> yourself :-\. I'll try to do that within a few weeks.

Ok, meanwhile, here is my try: salve@.../dvc--main--0,
available at
http://people.debian.org/~salve/arch/salve-8fiUuRrzOP3HJpy3KAqqPA <at> public.gmane.org:

  - patch-1: Already discussed, I need it to set datarootdir.

  - patch-2, patch-4: In Debian, we have a policy to use a special
    function to add to load-path; I refactored the relevant Debian file
    to use it.

  - patch-3: This is the one catering for the new ewoc-create interface:
    I just wrapped a function around the pretty printer argument for
    each ewoc-create instance, which inserts a trailing newline if
    needed (i.e., for a "new" ewoc).  Maybe it's not the best way to do
    it, dispose of it at your will (it seems to work for me).

It should be backward compatible with old ewoc library.

I found a couple more of little problems with dvc, which at this moment
I have no time to dwell any further:

  - in the `*baz-revisions*' buffer, hitting `RET' on any entry results in
--8<---------------cut here---------------start------------->8---
tla--revlog-any: Wrong type argument: sequencep, rev-list

[DVC] [PATCH] Maybe I need some input?

Hi devs,

I think I need some help.  I'm trying to fix dvc, which gives me some
trouble, but at this moment I have a very limited beginner's
understanding of its internals (I hope you can help me to improve).

The current problem I tryed to fix: I pressed `y' from the
`*baz-missing*' buffer to sync one of my trees and dvc yelled at me that
nil failed arrayp.  I edebugged `tla-revision-sync-tree' and found that
--8<---------------cut here---------------start------------->8---
(tla--revision-revision (car (cddr elem)))
--8<---------------cut here---------------end--------------->8---
failed.  Ok, since `s' worked, I studied `tla-revision-star-merge' and
found that in a very similar situation it calls
--8<---------------cut here---------------start------------->8---
(tla--revision-revision (dvc-revlist-entry-patch-struct (nth 1 elem)))
--8<---------------cut here---------------end--------------->8---
instead.  Then I patched `tla-revision-sync-tree' mimicking
`tla-revision-star-merge' and `y' worked (this is the enclosed patch).

Out of curiosity, I poked around to see if there were other occurrences
of this `(tla--revision-revision (car (cddr elem)))' thingy (or other
similar in spirit forms) and found out that there are many, e.g., in
`tla-revision-get-revision', `tla-revision-cache-revision',
`tla-revision-add-to-library', `tla-revision-scroll-or-show-changeset',
`tla-revision-delta', `tla-revision-bookmarks-add',
`tla-revision-replay'.

Now, of course, I wonder if:
  1. my fix to `tla-revision-sync-tree' is right;

[DVC] [PATCH] Maybe I need some input?

Hi devs,

I think I need some help.  I'm trying to fix dvc, which gives me some
trouble, but at this moment I have a very limited beginner's
understanding of its internals (I hope you can help me to improve).

The current problem I tryed to fix: I pressed `y' from the
`*baz-missing*' buffer to sync one of my trees and dvc yelled at me that
nil failed arrayp.  I edebugged `tla-revision-sync-tree' and found that
--8<---------------cut here---------------start------------->8---
(tla--revision-revision (car (cddr elem)))
--8<---------------cut here---------------end--------------->8---
failed.  Ok, since `s' worked, I studied `tla-revision-star-merge' and
found that in a very similar situation it calls
--8<---------------cut here---------------start------------->8---
(tla--revision-revision (dvc-revlist-entry-patch-struct (nth 1 elem)))
--8<---------------cut here---------------end--------------->8---
instead.  Then I patched `tla-revision-sync-tree' mimicking
`tla-revision-star-merge' and `y' worked (this is the enclosed patch).

Out of curiosity, I poked around to see if there were other occurrences
of this `(tla--revision-revision (car (cddr elem)))' thingy (or other
similar in spirit forms) and found out that there are many, e.g., in
`tla-revision-get-revision', `tla-revision-cache-revision',
`tla-revision-add-to-library', `tla-revision-scroll-or-show-changeset',
`tla-revision-delta', `tla-revision-bookmarks-add',
`tla-revision-replay'.

Now, of course, I wonder if:
  1. my fix to `tla-revision-sync-tree' is right;

Re: [DVC] ewoc

Hi Davide!

Thanks for helping!

>>>>>>  MM == Matthieu Moy [2006-6-2]
>
> MM> But the development of DVC is not very active right now (by lack of
> MM> time for me), so you'll have to wait for some time, or fix it
> MM> yourself :-\. I'll try to do that within a few weeks.
>
> Ok, meanwhile, here is my try: salve@.../dvc--main--0,
> available at
> http://people.debian.org/~salve/arch/salve-8fiUuRrzOP3HJpy3KAqqPA <at> public.gmane.org:
>
>   - patch-1: Already discussed, I need it to set datarootdir.
>
>   - patch-2, patch-4: In Debian, we have a policy to use a special
>     function to add to load-path; I refactored the relevant Debian file
>     to use it.
>
>   - patch-3: This is the one catering for the new ewoc-create interface:
>     I just wrapped a function around the pretty printer argument for
>     each ewoc-create instance, which inserts a trailing newline if
>     needed (i.e., for a "new" ewoc).  Maybe it's not the best way to do
>     it, dispose of it at your will (it seems to work for me).

I registered your archive. But I can't access your archive:
baz missing salve\@debian.org--2005/dvc--main--0
webdav error (directory_files):
/~salve/arch/salve@.../dvc/dvc--main/dvc--main--0/

Re: [DVC] ewoc

Stefan Reichör <stefan@...> writes:

> I registered your archive. But I can't access your archive:
> baz missing salve\@debian.org--2005/dvc--main--0
> webdav error (directory_files):
/~salve/arch/salve@.../dvc/dvc--main/dvc--main--0/
(404 Not Found)

$ baz register-archive
http://people.debian.org/~salve/arch/salve-8fiUuRrzOP3HJpy3KAqqPA <at> public.gmane.org                                          
Registering Archive: salve@...
$ baz missing salve@.../dvc--main--0                                                                            
salve@.../dvc--main--0--base-0
salve@.../dvc--main--0--patch-1
salve@.../dvc--main--0--patch-2
salve@.../dvc--main--0--patch-3
salve@.../dvc--main--0--patch-4
salve@.../dvc--main--0--patch-5
salve@.../dvc--main--0--patch-6
salve@.../dvc--main--0--patch-7

> This is probable a problem with DVC's new revision data structures.
> Matthieu do you have a clue on this one?

Yes, probably the migration to the new revision data-structure was not
as complete as I thought.

I should get time to fix this by the end of this week (hopefully).

Thanks for the report anyway.

Re: [DVC] ewoc

Matthieu Moy <Matthieu.Moy@...> writes:

> Stefan Reichör <stefan@...> writes:
>
>> I registered your archive. But I can't access your archive:
>> baz missing salve\@debian.org--2005/dvc--main--0
>> webdav error (directory_files):
/~salve/arch/salve@.../dvc/dvc--main/dvc--main--0/
(404 Not Found)
>
> $ baz register-archive
> http://people.debian.org/~salve/arch/salve-8fiUuRrzOP3HJpy3KAqqPA <at> public.gmane.org                                          
> Registering Archive: salve@...
> $ baz missing salve@.../dvc--main--0                                                                            
> salve@.../dvc--main--0--base-0
> salve@.../dvc--main--0--patch-1
> salve@.../dvc--main--0--patch-2
> salve@.../dvc--main--0--patch-3
> salve@.../dvc--main--0--patch-4
> salve@.../dvc--main--0--patch-5
> salve@.../dvc--main--0--patch-6
> salve@.../dvc--main--0--patch-7

It works for me also now.

Davide, I would like to merge your improvements.
Since dvc will be included in GNU Emacs, you need to sign Emacs papers.
Are you willing to do that?
Masatake will give you the needed instructions, if you have not
already signed the papers.