headers
Luc Teirlinck | 1 Jan 2004 04:17
Picon

completion-regexp-list and case-fold-search

The case sensitivity of regex matching in the use of
`completion-regexp-list' by the basic completion functions is
determined by `case-fold-search' and _not_ by
`completion-ignore-case'.  Whether something is a valid completion for
the minibuffer completion functions has nothing to do with whether the
user prefers _interactive regexp searches_ to be case-sensitive or
not.  Hence, `case-fold-search' should be bound around all calls to
`{try,test}-completion' and `all-completions'.  If `partial-completion-mode'
is enabled, that is the case:  `case-fold-search' is bound to the
value of `completion-ignore-case' around all calls.  That seems to
make sense and is correct for the one single use of
`completion-regexp-list' in the Emacs source code (`customize-mode').
With `partial-completion-mode' set to nil (the default) this is not the
case however.  This is a bug.

Two solutions:

1.  Make all the basic minibuffer completion functions bind
    `case-fold-search' to the value of `completion-ignore-case' around
    all calls to `{try,test}-completion' and `all-completions', as
    `partial-completion-mode' already does.

2.  More radically, make `{try,test}-completion' and `all-completions'
    _themselves_ bind `case-fold-search' to the value of
    `completion-ignore-case', thereby effectively making the
    case-sensitivity of `completion-regexp-list' entirely determined
    by `completion-ignore-case'.

I have implemented (1) in my private Emacs and it seems to work
perfectly.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Eli Zaretskii | 1 Jan 2004 06:49
Picon

Re: CVS directories in completion-ignored-extensions

> Date: Tue, 30 Dec 2003 20:34:07 -0500
> From: Miles Bader <miles <at> gnu.org>
> 
> So sure, without a better mechanism, there will be some annoying side-effects
> in completion, but let's program for the common case, and _keep_ CVS in
> completion-ignored-extensions.

How about if we change "CVS/" to "/CVS/" and modify the code to match
the whole name if the member of the list begins with a slash?

The only problem with that approach, AFAICT, is when a user wants to
ignore files under the root directory.  If that sounds like a serious
problem, we could have something like "//foo/" to DTRT in such cases.

What do you-all think?
Permalink | Reply | 21 comments |
headers
Eli Zaretskii | 1 Jan 2004 06:52
Picon

Re: Defcustom write-file-functions and write-contents-functions?

> From: Simon Josefsson <jas <at> extundo.com>
> Date: Wed, 31 Dec 2003 20:56:21 +0100
> 
> You convinced me, thanks for the feedback.  How about this patch,
> instead?
> 
> 2003-12-31  Simon Josefsson  <jas <at> extundo.com>
> 
> 	* files.el (before-save-hook): Add.

This addition should be followed by 2 documentation changes: (1) to
the ELisp manual, and (2) to etc/NEWS.

TIA
Permalink | Reply | 2 comments |
headers
Eli Zaretskii | 1 Jan 2004 07:24
Picon

Re: sqrt with negative arg.

> Date: Wed, 31 Dec 2003 15:36:31 -0600 (CST)
> From: Luc Teirlinck <teirllm <at> dms.auburn.edu>
> 
> A few hours ago, the documentation of sqrt in numbers.texi was
> changed from saying that it returns a NaN to saying that it signals a
> domain-error.  It definitely returns a NaN on my machine.

Really?  What system is that?  Can you debug Fsqrt and see why it
happens?

The way it's supposed to work on most modern systems is that the call
to `sqrt' in the underlying C code causes errno to be set, and Fsqrt
is supposed to check for that and signal an appropriate error.  See
the macro IN_FLOAT defined on floatfns.c.

(The last time a similar problem was reported and discussed here, we
found it was due to a bug in a particular version of glibc that was
fixed in later versions.)
Permalink | Reply | 0 comments |
headers
Luc Teirlinck | 1 Jan 2004 17:42
Picon

Re: sqrt with negative arg.

Richard Stallman wrote:

       A few hours ago, the documentation of sqrt in numbers.texi was
       changed from saying that it returns a NaN to saying that it signals a
       domain-error.  It definitely returns a NaN on my machine.

   I think that is a bug--why does it not signal an error?

As Eli pointed out, it is probably due to my glibc version.  So I will
definitely _not_ install the change to numbers.texi which I proposed.

Sincerely,

Luc.
Permalink | Reply | 0 comments |
headers
Richard Stallman | 1 Jan 2004 17:30
Picon
Picon

Re: sqrt with negative arg.

    A few hours ago, the documentation of sqrt in numbers.texi was
    changed from saying that it returns a NaN to saying that it signals a
    domain-error.  It definitely returns a NaN on my machine.

I think that is a bug--why does it not signal an error?
Permalink | Reply | 1 comment |
headers
Eli Zaretskii | 1 Jan 2004 15:45
Picon

Re: Defcustom write-file-functions and write-contents-functions?

> From: Simon Josefsson <jas <at> extundo.com>
> Date: Thu, 01 Jan 2004 13:22:17 +0100
> >
> > This addition should be followed by 2 documentation changes: (1) to
> > the ELisp manual, and (2) to etc/NEWS.
> 
> Yes, although I waited with that until people said it was a good idea
> to install it.  Maybe that time is now?  If so:

Thanks!
Permalink | Reply | 0 comments |
headers
Kim F. Storm | 1 Jan 2004 22:27
Picon

Re: CVS directories in completion-ignored-extensions

Eli Zaretskii <eliz <at> elta.co.il> writes:

> > Date: Tue, 30 Dec 2003 20:34:07 -0500
> > From: Miles Bader <miles <at> gnu.org>
> > 
> > So sure, without a better mechanism, there will be some annoying side-effects
> > in completion, but let's program for the common case, and _keep_ CVS in
> > completion-ignored-extensions.
> 
> How about if we change "CVS/" to "/CVS/" and modify the code to match
> the whole name if the member of the list begins with a slash?

That's a good idea!

> 
> The only problem with that approach, AFAICT, is when a user wants to
> ignore files under the root directory.  If that sounds like a serious
> problem, we could have something like "//foo/" to DTRT in such cases.

IIUC, the completion-ignored-extensions doesn't have any notion of
things being relative to a certain directory, so why is the root
directory a problem?

> 
> What do you-all think?

I like it, but I think /CVS/ is sufficient.

--

-- 
Kim F. Storm <storm <at> cua.dk> http://www.cua.dk
(Continue reading)

Permalink | Reply | 0 comments |
headers
Simon Josefsson | 1 Jan 2004 13:22

Re: Defcustom write-file-functions and write-contents-functions?

Eli Zaretskii <eliz <at> elta.co.il> writes:

>> From: Simon Josefsson <jas <at> extundo.com>
>> Date: Wed, 31 Dec 2003 20:56:21 +0100
>> 
>> You convinced me, thanks for the feedback.  How about this patch,
>> instead?
>> 
>> 2003-12-31  Simon Josefsson  <jas <at> extundo.com>
>> 
>> 	* files.el (before-save-hook): Add.
>
> This addition should be followed by 2 documentation changes: (1) to
> the ELisp manual, and (2) to etc/NEWS.

Yes, although I waited with that until people said it was a good idea
to install it.  Maybe that time is now?  If so:

Index: etc/NEWS
===================================================================
RCS file: /cvsroot/emacs/emacs/etc/NEWS,v
retrieving revision 1.882
diff -u -p -r1.882 NEWS
--- etc/NEWS	30 Dec 2003 23:39:57 -0000	1.882
+++ etc/NEWS	1 Jan 2004 12:21:03 -0000
 <at>  <at>  -1,5 +1,5  <at>  <at> 
 GNU Emacs NEWS -- history of user-visible changes.  2003-05-21
-Copyright (C) 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
+Copyright (C) 1999, 2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
 See the end for copying conditions.
(Continue reading)

Permalink | Reply | 1 comment |
headers
Richard Stallman | 1 Jan 2004 22:10
Picon
Picon

Re: `make' written in elisp

    Yes. There is no change needed for the packages i tested until now
    (except placing an additional file called elMakefile into the install
    directory). And if a package would require to change its directory
    structure/whatever, that is clearly a fault of elMake then and needs to
    be fixed.

Then it might be a good idea.  Can you show me an example of an
elMakefile?
Permalink | Reply | 1 comment |

Gmane