Re: Patch to improve scrolling in Yi

Did these patches ever go through? I too found the scrolling behavior
in Yi uncomfortable, I am used to scrolling only a little bit at a
time like Vim. This is not a performance issue in Vim, its just as
fast.

Making it an option to turn on or off would be nice.

On Sat, Sep 18, 2010 at 9:26 AM, Jeremy Wall <jwall@...> wrote:
> yep but I think since I use gmail that postfix may need some
> additional configuration I'm researching it now.
>
> On Sat, Sep 18, 2010 at 11:11 AM, Jeff Wheeler <wheele11@...> wrote:
>> On Sat, Sep 18, 2010 at 10:18 AM, Jeremy Wall <jwall@...> wrote:
>>
>>> I just resent the two patches to the list. I verified I have the
>>> sendmail command so I'm not sure why It's not showing up.
>>
>> It should show up within half an hour or so if you have sendmail working.
>>
>> Did you setup the "from" address to be the same as the address you're
>> sending from now, within darcs?
>>
>> --
>> Jeff Wheeler
>>
>> Undergraduate, Electrical Engineering
>> University of Illinois at Urbana-Champaign
>>
>> --
>> Yi development mailing list

Re: Patch to improve scrolling in Yi

I haven't had time to add the code to configure this yet which I
believe is a prereq to getting them accepted. 

On Mon, Oct 4, 2010 at 4:34 PM, Tony Miller <mcfiredrill@...> wrote:
> Did these patches ever go through? I too found the scrolling behavior
> in Yi uncomfortable, I am used to scrolling only a little bit at a
> time like Vim. This is not a performance issue in Vim, its just as
> fast.
>
> Making it an option to turn on or off would be nice.
>
> On Sat, Sep 18, 2010 at 9:26 AM, Jeremy Wall <jwall@...> wrote:
>> yep but I think since I use gmail that postfix may need some
>> additional configuration I'm researching it now.
>>
>> On Sat, Sep 18, 2010 at 11:11 AM, Jeff Wheeler <wheele11@...> wrote:
>>> On Sat, Sep 18, 2010 at 10:18 AM, Jeremy Wall <jwall@...> wrote:
>>>
>>>> I just resent the two patches to the list. I verified I have the
>>>> sendmail command so I'm not sure why It's not showing up.
>>>
>>> It should show up within half an hour or so if you have sendmail working.
>>>
>>> Did you setup the "from" address to be the same as the address you're
>>> sending from now, within darcs?
>>>
>>> --
>>> Jeff Wheeler
>>>
>>> Undergraduate, Electrical Engineering

Re: Patch to improve scrolling in Yi

I think the more significant blocker was that nobody knew the /right/
way to implement this, without mixing the layers (UI, scrolling
behavior) too much.

-Jeff

On Mon, Oct 4, 2010 at 5:17 PM, Jeremy Wall <jwall@...> wrote:
> I haven't had time to add the code to configure this yet which I
> believe is a prereq to getting them accepted. 
>
> On Mon, Oct 4, 2010 at 4:34 PM, Tony Miller <mcfiredrill@...> wrote:
>> Did these patches ever go through? I too found the scrolling behavior
>> in Yi uncomfortable, I am used to scrolling only a little bit at a
>> time like Vim. This is not a performance issue in Vim, its just as
>> fast.
>>
>> Making it an option to turn on or off would be nice.
>>
>> On Sat, Sep 18, 2010 at 9:26 AM, Jeremy Wall <jwall@...> wrote:
>>> yep but I think since I use gmail that postfix may need some
>>> additional configuration I'm researching it now.
>>>
>>> On Sat, Sep 18, 2010 at 11:11 AM, Jeff Wheeler <wheele11@...> wrote:
>>>> On Sat, Sep 18, 2010 at 10:18 AM, Jeremy Wall <jwall@...> wrote:
>>>>
>>>>> I just resent the two patches to the list. I verified I have the
>>>>> sendmail command so I'm not sure why It's not showing up.
>>>>
>>>> It should show up within half an hour or so if you have sendmail working.
>>>>

Re: Patch to improve scrolling in Yi

On Tue, Oct 5, 2010 at 12:20 AM, Jeff Wheeler <wheele11@...> wrote:
> I think the more significant blocker was that nobody knew the /right/
> way to implement this, without mixing the layers (UI, scrolling
> behavior) too much.

I would be ok to push the patch if it was accompanied with (inline)
documentation
of the issues and what exactly is happening. There was a good case made that
the current behaviour is inconsistent anyway.

Cheers,
JP.

--

-- 
Yi development mailing list
yi-devel@...
http://groups.google.com/group/yi-devel

Re: Patch to improve scrolling in Yi

Ok I'll try to add some documentation sometime this week. It's been
end of quarter at work and I've been too busy with stuff to get back
to the patch.

On Mon, Oct 4, 2010 at 5:27 PM, Jean-Philippe Bernardy
<bernardy@...> wrote:
> On Tue, Oct 5, 2010 at 12:20 AM, Jeff Wheeler <wheele11@...> wrote:
>> I think the more significant blocker was that nobody knew the /right/
>> way to implement this, without mixing the layers (UI, scrolling
>> behavior) too much.
>
> I would be ok to push the patch if it was accompanied with (inline)
> documentation
> of the issues and what exactly is happening. There was a good case made that
> the current behaviour is inconsistent anyway.
>
> Cheers,
> JP.
>
> --
> Yi development mailing list
> yi-devel@...
> http://groups.google.com/group/yi-devel
>

--

-- 
Yi development mailing list
yi-devel@...
http://groups.google.com/group/yi-devel

darcs patch: fix scrolling so it no longer snaps to t... (and 2 more)

3 patches for repository http://code.haskell.org/yi:

Thu Sep 16 00:17:42 CDT 2010  jwall@...
  * fix scrolling so it no longer snaps to the middle.

  scrolling off the top or bottom of the screen now just moves the viewport
  the minimum # of lines necessary to keep the point in sight. This is a
  much less disruptive scrolling experience.

Fri Sep 17 23:20:58 CDT 2010  jwall@...
  * Scrolling - Store actual buffer lines displayed in a window.

  In order for scrolling to work we have to differentiate between the height
  of the window in display lines and the number of actual buffer lines
  displayed in a window. This patch stores that information in a window.

Wed Oct  6 15:51:36 CDT 2010  jwall@...
  * add documentation and clean up

  Document the rational for this change as well as clean up
  some of the comments and todos.

--

-- 
Yi development mailing list
yi-devel@...
http://groups.google.com/group/yi-devel

Re: darcs patch: fix scrolling so it no longer snaps to t... (and 2 more)

I'm fine applying this. Any complaints?

-Jeff

On Wed, Oct 6, 2010 at 3:52 PM,  <jwall@...> wrote:
> 3 patches for repository http://code.haskell.org/yi:
>
> Thu Sep 16 00:17:42 CDT 2010  jwall@...
>  * fix scrolling so it no longer snaps to the middle.
>
>  scrolling off the top or bottom of the screen now just moves the viewport
>  the minimum # of lines necessary to keep the point in sight. This is a
>  much less disruptive scrolling experience.
>
> Fri Sep 17 23:20:58 CDT 2010  jwall@...
>  * Scrolling - Store actual buffer lines displayed in a window.
>
>  In order for scrolling to work we have to differentiate between the height
>  of the window in display lines and the number of actual buffer lines
>  displayed in a window. This patch stores that information in a window.
>
> Wed Oct  6 15:51:36 CDT 2010  jwall@...
>  * add documentation and clean up
>
>  Document the rational for this change as well as clean up
>  some of the comments and todos.
>
> --
> Yi development mailing list
> yi-devel@...

Re: darcs patch: fix scrolling so it no longer snaps to t... (and 2 more)

If it's fine by you it's fine by me :)
-- JP

On Thu, Oct 7, 2010 at 6:44 AM, Jeff Wheeler <wheele11@...> wrote:
> I'm fine applying this. Any complaints?
>
> -Jeff
>
> On Wed, Oct 6, 2010 at 3:52 PM,  <jwall@...> wrote:
>> 3 patches for repository http://code.haskell.org/yi:
>>
>> Thu Sep 16 00:17:42 CDT 2010  jwall@...
>>  * fix scrolling so it no longer snaps to the middle.
>>
>>  scrolling off the top or bottom of the screen now just moves the viewport
>>  the minimum # of lines necessary to keep the point in sight. This is a
>>  much less disruptive scrolling experience.
>>
>> Fri Sep 17 23:20:58 CDT 2010  jwall@...
>>  * Scrolling - Store actual buffer lines displayed in a window.
>>
>>  In order for scrolling to work we have to differentiate between the height
>>  of the window in display lines and the number of actual buffer lines
>>  displayed in a window. This patch stores that information in a window.
>>
>> Wed Oct  6 15:51:36 CDT 2010  jwall@...
>>  * add documentation and clean up
>>
>>  Document the rational for this change as well as clean up
>>  some of the comments and todos.

patch applied (yi): fix scrolling so it no longer snaps to the middle.

Thu Sep 16 01:17:42 EDT 2010  jwall@...
  * fix scrolling so it no longer snaps to the middle.
  Ignore-this: e80f848c675274b889129e20d4e9a5b6

  scrolling off the top or bottom of the screen now just moves the viewport
  the minimum # of lines necessary to keep the point in sight. This is a
  much less disruptive scrolling experience.

    M ./src/Yi/Buffer/HighLevel.hs -4 +18

--

-- 
Yi development mailing list
yi-devel@...
http://groups.google.com/group/yi-devel

patch applied (yi): Scrolling - Store actual buffer lines displayed in a window.

Sat Sep 18 00:20:58 EDT 2010  jwall@...
  * Scrolling - Store actual buffer lines displayed in a window.
  Ignore-this: 832bc90350c820a84a56aab985a46f35

  In order for scrolling to work we have to differentiate between the height
  of the window in display lines and the number of actual buffer lines
  displayed in a window. This patch stores that information in a window.

    M ./src/Yi/Buffer/HighLevel.hs -4 +5
    M ./src/Yi/Editor.hs -1 +5
    M ./src/Yi/UI/Vty.hs -12 +21
    M ./src/Yi/Window.hs -4 +5

--

-- 
Yi development mailing list
yi-devel@...
http://groups.google.com/group/yi-devel