1 Nov 11:36
Re: HTML exporter background color mismatch
Neil Hodgson <nyamatongwe <at> gmail.com>
2009-11-01 10:36:16 GMT
2009-11-01 10:36:16 GMT
Jingcheng Zhang:
> 467c467,471
> < fprintf(fp, "\tbackground: %s;\n", sd.back.c_str());
> ---
>> if (sd.specified & StyleDefinition::sdBack) {
>> fprintf(fp, "\tbackground: %s;\n", sd.back.c_str());
>> } else {
>> fprintf(fp, "\tbackground: %s;\n", bgColour.c_str());
>> }
The else branch doesn't appear necessary to me as bgColour is
already the default background colour. Even simpler would be moving
the check for specified into the overall guard:
+++ Exporters.cxx 1 Nov 2009 10:34:10 -0000
@@ -462,7 +462,7 @@
} else if (istyle == STYLE_DEFAULT) {
fprintf(fp, "\tcolor: #000000;\n");
}
- if (sd.back.length()) {
+ if ((sd.specified & StyleDefinition::sdBack) && sd.back.length()) {
if (istyle != STYLE_DEFAULT && bgColour != sd.back) {
fprintf(fp, "\tbackground: %s;\n", sd.back.c_str());
fprintf(fp, "\ttext-decoration: inherit;\n");
Neil
--~--~---------~--~----~------------~-------~--~----~
(Continue reading)
RSS Feed