26 Jun 17:27 2016

### Custom Insets on a Menu


The attached patch almost works. (Details like the icon are not yet
there.) There are some big problems, however, which seem to derive from
the fact that the whole menu and toolbar setup is not really designed to
be modified on the fly.

The problem here seems to trace to how FuncRequest objects are handled
by our Action class. Namely, when an Action is created, it retains a
const & to a FuncRequest. So one can't pass a temporary. This means that
I have to create a kind of cache for these objects. The idea was to keep
them around as long as we need them. But it turns out that we need them
rather a long time. If you look at the FIXME in the patch, you will see
what I mean. Clearing the menu is supposed to delete any actions it owns:

Removes all the menu's actions. Actions owned by the menu and not shown
in any other widget are deleted.

In fact, however, they seem still to be around, and if we clear the
cache we eventually segfault. If we don't clear the cache, we are
effectively leaking memory.

I can make this work by changing the Action class so it makes a copy of
the FuncRequest. But I worry that this is just hiding the real problem,
and that all these Action objects we're creating are leaking, or at
least being retained for no good reason.

Help wanted!

Richard


26 Jun 13:55 2016

### Master compile error

Master does not build for me with autotools and gcc 6.1.1:

In file included from ./../support/unicode.h:18:0,
from docstream.cpp:15:
./../support/unique_ptr.h:24:28: error: ‘std::make_unique’ has not been
declared
namespace lyx { using std::make_unique; }

Regards
Jürgen


26 Jun 02:21 2016

### workaround to 'git reset --hard' not working because of .gitattributes

Just in case anyone else has this issue:

I keep having the following situation come up:

$git status On branch master Your branch is up-to-date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: 3rdparty/hunspell/1.3.3/src/hunspell/hunspell.dsp modified: development/Win32/packaging/installer/information/WinLangCode.htm modified: development/Win32/vld/src/crtmfcpatch.h modified: development/Win32/vld/src/resource.h modified: development/Win32/vld/src/vld.h no changes added to commit (use "git add" and/or "git commit -a")$

I think this is due to the recent fixes in .gitattributes. In any case,
git reset --hard does not fix anything. But the following does work for
me:

git rm .gitattributes
git reset --hard

source:
http://stackoverflow.com/questions/11383094/unstaged-changes-left-after-git-reset-hard


25 Jun 21:56 2016

I recently stumbled upon

using std::shared_ptr;

or

lyx::support::FileName;

in header files (e.g. TocBackend.h). The shared_ptr was introduced as part
of the lyx::shared_ptr removal (which did either point to boost or std), but
there are other hits as well. While I understand that in this particular
case the "using" statement avoided other changes in the headers, I consider
it dangerous to have "using" statements in header files in general:

using foo::bar

effectively forbids to use the name 'bar' in any other namespace in the
whole program, since simply adding or removing an #include of the
corresponding header subtly changes the name lookup. Therefore I'd like to
remove these using statements. OK?

Georg
Attachment (x.diff): text/x-patch, 8 KiB
25 Jun 21:03 2016

### Remove \it from math completion?

Attached is a patch that removes \it from math completion, since \it has
been deprecated for a while, only giving a warning in TL 2015, but an
error in 2016.

I think the patch is consistent with 24d01111 in the concept of removing
math completion but if the user insists on using it, LyX still displays
it with built-in support.

I don't think this will have much impact since \it is so short that I
doubt anyone uses completion to access it, but perhaps it is better than
nothing.

Scott

From 4d7e5edf8753e237467bfdaac79cd3c376e7310f Mon Sep 17 00:00:00 2001
From: Scott Kostyshak <skostysh <at> lyx.org>
Date: Sat, 25 Jun 2016 04:49:02 -0400
Subject: [PATCH] Remove \it from math completion

\it is deprecated and \mathit should be used instead. \it can lead
to a warning in TeX Live 2015 and an error in TeX Live 2016.

Note that with this commit only affects completion, so LyX still
supports displaying \it in math if the user enters it without
completion.

This is consistent with 24d01111.
---
src/mathed/InsetMathNest.cpp | 4 +++-


25 Jun 11:13 2016

### new LyX 2.2.0 installer for Windows Vista is available

Dear LyXers,

there is a new Windows installer available that provides support for
Windows Vista:
http://ftp.lyx.de/LyX%202.2.0/LyX-220-Installer-Vista-3.exe

Dima kindly prepared the binary from the 2.2.0 tarball, I checked it
against viruses and malware using commercial antivirus software, I
created the installer with it and Dima tested that everything works fine
on Vista.

Richard, could you please put it on ftp.lyx.org? Could you please also
write a news message that we now have a Vista installer but that this
installer should not be used for other Windows versions than Vista.

-------------------------------------------

understand. Scott and Richard are concerned that Dima'S build contains
malware. This is not fair. Dima invested some spare time to fiddle
around with Qt to prepare a Vista build and to test it. To presume that
a new contributor is not trustworthy is not the way we should welcome
new people!
I checked Dima's build wit the anti-virus software at work (the
installer only contains the lyx.exe and tex2lyx.exe from Dima, all other
LyX files are identic with the other installers I released for 2.2.0.
However, in general, if we don't trust new people investing their spare
time, we will be lost. To dramatize: Some of you have never seen me,
nobody knows my build system and could cross-check if I don't add
spyware to the Win installers. So you have to trust me too.


25 Jun 00:23 2016

### Combo Box for Custom Insets


Attached please find a patch that implements a combo box for custom
insets, much like the layout box. This is a very simple version. More
complicated ones might also have an InsetLayout tag that governed
whether an inset would appear here. It would also be very easy to adapt
this also to give us a combo for charstyles.

Richard


24 Jun 08:43 2016

### Joining LyX development team

Hi. My name is Dima Ruinskiy, and I would like to join the LyX development team.

I hereby permit to use my contributions to LyX under the license of the GPL
version 2 or later.


23 Jun 17:02 2016

### Save transient properties

Dear list,

I am thinking of adding the "Save transient properties" checkbox
(disabling the save of \origin, \tracking_changes, \output_changes) to
the "document class" panel, for lack of a better place. This panel
already contains other settings unrelated to the document class.

Can you think of a better place? Of a better label? Thank you for any

Sincerely,
Guillaume


23 Jun 06:12 2016

### improved Customized Page Headers and Footers section of User Guide 2.2.x (please CC me, colinnkeenan <at> gmail.com, not subscribed)

This time, I used the correct branch (2.2.x) instead of 2.0.x. This patch makes more sense, showing just 215 insertions(+), 31 deletions(-).

Again, please CC me (colinnkeenan <at> gmail.com) because I have not subscribed to this list.
22 Jun 07:10 2016

### After having upgraded to LyX 2.2.0, could it be useful to have also LyX 2.1.5?

If have already upgraded to LyX 2.2.0 on Windows 10 but I still have also LyX 2.1.4 on my pc.

Could it be useful to upgrade my 2.1.4 to 2.1.5? For example, in case of errors in 2.2.0, just to compare the behaviour in 2.1.5?