SourceForge.net | 1 Aug 2012 07:57
Picon

[ jedit-Patches-3482818 ] Initialization of look and feel

Patches item #3482818, was opened at 2012-02-01 12:43
Message generated for change (Comment added) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3482818&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: general
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Dale Anson (daleanson)
Assigned to: Jarek Czekalski (jarekczek)
Summary: Initialization of look and feel

Initial Comment:
I'd like to get a second opinion on this patch before committing it directly. The issue is the look and feel as
set by the look and feel plugin is not restored properly in jEdit 4.5 and 5.0. The main problem is that the
look and feel for jEdit is set before the look and feel plugin is loaded, so when jEdit is restarted, the
previous look and feel is not available until later, which can cause a long spew of errors in the Activity
log. My testing shows the patch does not conflict with the look and feel if set in the Global Options -
Appearance, but does allow the look and feel plugin to properly restore the previous look and feel when it
is finally loaded. To see this patch work properly with the look and feel plugin, you'll need the look and
feel plugin from revision 21042 or later.

----------------------------------------------------------------------

(Continue reading)

SourceForge.net | 1 Aug 2012 08:00
Picon

[ jedit-Plugin Patches-3507276 ] SVNPlugin : make use of brand new pv api

Plugin Patches item #3507276, was opened at 2012-03-17 15:11
Message generated for change (Settings changed) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3507276&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jarek Czekalski (jarekczek)
Assigned to: Dale Anson (daleanson)
Summary: SVNPlugin : make use of brand new pv api

Initial Comment:
To create a project and import files into it.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-03-27 08:18

Message:
Project Viewer 3.4.0 is released months time ago. PV 3.4.2 is submitted for
a release but not yet released. I guess it won't be released until a
volunteer steps up to do it. I should rather not release my own plugin by
(Continue reading)

SourceForge.net | 1 Aug 2012 08:08
Picon

[ jedit-Plugin Bugs-3553020 ] XML debugging output "quote is not closed"

Plugin Bugs item #3553020, was opened at 2012-07-31 23:08
Message generated for change (Tracker Item Submitted) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3553020&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: XML
Group: None
Status: Open
Resolution: None
Priority: 3
Private: No
Submitted By: Jarek Czekalski (jarekczek)
Assigned to: Eric Le Lay (kerik-sf)
Summary: XML debugging output "quote is not closed"

Initial Comment:
This output on stderr should be turned off as it is nothing abnormal in having quotes opened transitionally.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3553020&group_id=588

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
(Continue reading)

Matthieu Casanova | 1 Aug 2012 09:55
Picon

Re: getting a property from mode or from buffer

It seems you are right, it should at least use mode properties as default.
But another thing I was thinking about is that Buffer could use the IProperty interface instead of calling jEdit.getProperty(), and of couse JEditBuffer could also use it, this way the getDefaultProperty() method could be the same for both and pulled in JEditBuffer.

Matthieu

2012/7/31 Jarek Czekalski <jarekczek <at> poczta.onet.pl>
The correct order is ask then change. But after the change a reflection
came to me. What should be actually used and does it depend on context:

A.
buffer.getStringProperty("x")

or

B.
(String) buffer.getMode().getProperty("x)

See related revision:
jedit.svn.sourceforge.net/viewvc/jedit?view=revision&revision=21964

where I changed B to A.

I wonder about contexts where JEditBuffer is used and not Buffer
(standalone text area?). In these cases buffer properties are not
defaulted to mode properties, if I read the code properly. Or maybe they
should anyway?

Maybe this is a jedit api pitfall and I should make a note about it in
wiki :)

Jarek

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel
Jarek Czekalski | 1 Aug 2012 13:54
Picon
Favicon
Gravatar

Re: getting a property from mode or from buffer

So my decision was probably ok. And now after doing a hypersearch for getmode.*get.*property it looks like the B syntax is not used at all, for no property. It was used only with noWordSep in search related files.

Jarek

W dniu 2012-08-01 09:55, Matthieu Casanova pisze:
It seems you are right, it should at least use mode properties as default.
But another thing I was thinking about is that Buffer could use the IProperty interface instead of calling jEdit.getProperty(), and of couse JEditBuffer could also use it, this way the getDefaultProperty() method could be the same for both and pulled in JEditBuffer.

Matthieu

2012/7/31 Jarek Czekalski <jarekczek <at> poczta.onet.pl>
The correct order is ask then change. But after the change a reflection
came to me. What should be actually used and does it depend on context:

A.
buffer.getStringProperty("x")

or

B.
(String) buffer.getMode().getProperty("x)

See related revision:
jedit.svn.sourceforge.net/viewvc/jedit?view=revision&revision=21964

where I changed B to A.

I wonder about contexts where JEditBuffer is used and not Buffer
(standalone text area?). In these cases buffer properties are not
defaulted to mode properties, if I read the code properly. Or maybe they
should anyway?

Maybe this is a jedit api pitfall and I should make a note about it in
wiki :)

Jarek

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel
SourceForge.net | 1 Aug 2012 15:29
Picon

[ jedit-Feature Requests-3551931 ] beep on error

Feature Requests item #3551931, was opened at 2012-07-30 02:55
Message generated for change (Comment added) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=350588&aid=3551931&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jarek Czekalski (jarekczek)
Assigned to: Nobody/Anonymous (nobody)
Summary: beep on error

Initial Comment:
I have problems catching an assertion error that spontaneously happens on completion popups. If I only
know that it happens just now...

So I introduced beeping on any output. Probably this is a useful feature. What do you think about
introducing a new option pane called "Debugging" in which I would place an entry "beep on errors"?

I'm attaching a patch that does beep, without configuration options yet.

----------------------------------------------------------------------

>Comment By: Jarek Czekalski (jarekczek)
Date: 2012-08-01 06:29

Message:
I did it this way, but it's not the best option. I had to add
propertiesChanged after ok in these settings. It interferes with viewing
the activity log, as it causes a bunch of new log entries. A new patch
attached. Any other suggestions?

----------------------------------------------------------------------

Comment By: Dale Anson (daleanson)
Date: 2012-07-30 09:45

Message:
Definitely this needs a way to be turned off. I can see this being
extremely annoying. Rather than a new option pane, how about adding a
checkbox to the Activity Log settings?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=350588&aid=3551931&group_id=588

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel

SourceForge.net | 1 Aug 2012 17:05
Picon

[ jedit-Plugin Patches-3507276 ] SVNPlugin : make use of brand new pv api

Plugin Patches item #3507276, was opened at 2012-03-17 15:11
Message generated for change (Comment added) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3507276&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jarek Czekalski (jarekczek)
Assigned to: Dale Anson (daleanson)
Summary: SVNPlugin : make use of brand new pv api

Initial Comment:
To create a project and import files into it.

----------------------------------------------------------------------

>Comment By: Alan Ezust (ezust)
Date: 2012-08-01 08:05

Message:
huh? 3.4.2 and 3.4.4 were both released on plugin central. And if another
release needs to be done, you can create the plugin submission yourself,
but it seems not necessary at this time.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-03-27 08:18

Message:
Project Viewer 3.4.0 is released months time ago. PV 3.4.2 is submitted for
a release but not yet released. I guess it won't be released until a
volunteer steps up to do it. I should rather not release my own plugin by
myself. Instructions are in wiki.
https://sourceforge.net/apps/mediawiki/jedit/index.php?title=Conventions,_procedures#Releasing_a_plugin_part_II

----------------------------------------------------------------------

Comment By: Dale Anson (daleanson)
Date: 2012-03-27 07:14

Message:
Jarek, I saw that ProjectViewer 3.4.0 is released in Plugin Manager, so I
applied this patch. While the patch applies cleanly, it does not compile. I
see a note in the patch about ProjectViewer 3.4.2 is needed, when will that
be ready? In the mean time, I can't apply this patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3507276&group_id=588

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel

SourceForge.net | 1 Aug 2012 18:18
Picon

[ jedit-Plugin Bugs-3553208 ] jDiff: state confused

Plugin Bugs item #3553208, was opened at 2012-08-01 09:18
Message generated for change (Tracker Item Submitted) made by snarum-micron
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3553208&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Steve (snarum-micron)
Assigned to: Nobody/Anonymous (nobody)
Summary: jDiff: state confused

Initial Comment:
Generally, the first DualDiff of the day works great.  When I close it, all looks good.  When I do a second diff,
most of the time (but not 100%) the diff pane, which I dock at bottom, appears to be out of sync.  All buttons
are grey except the delta button.  The differences are marked in the buffers, and using the menu to move to
the next difference, etc, works as expected.  At this point, nothing I do will get things back in sync. 
Clicking the delta button removes the split and minimizes the diff pane.  Using the menu to refresh the diff
works (refreshes the difference marks in the buffers) but does not fix the button state.

  I have tried three different methods of closing the first diff, hoping that one of them might work where the
others don't.  I have used the button in the diff pane, the menu, and simply removed splits.  All three close
the diff as I would expect, but no matter which I do, I still get the button state wrong on the next diff, most
of the time.

  Finally, after some time, I'll do a diff and everything will magically get back in sync.  I can't seem to pin
down how long it takes, or if I have done any particular operation in the interim.

  I'm using 5.0pre2 in Linux, jDiff plugin 3.3.0 and SVNPlugin 1.7.5 daily of 27-Jul-12 (though I observed
this behavior with released SVNPlugin and jDiff plugin 3.2.0 as well.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3553208&group_id=588

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel

SourceForge.net | 1 Aug 2012 19:47
Picon

[ jedit-Patches-3543916 ] Fixed Issue replacing start of line match with empty string

Patches item #3543916, was opened at 2012-07-13 23:48
Message generated for change (Comment added) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3543916&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: texteditor
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Swetha (swetha1910)
>Assigned to: Jarek Czekalski (jarekczek)
Summary: Fixed Issue replacing start of line match with empty string

Initial Comment:
Problem:  With regular expressions enabled, and if the search pattern having '^' then the 'replace all' 
option  performs repeated replacing for every character in the line and not 'start of the line' matches. 

Details:
Example I:
Input:
Twinkle Twinkle
Little Star
How I wonder what you
are

Search for: ^.
meaning I want a search for the first character of every line

Replace with:
replace every matched character with nothing (literally deleting the first character from every line)

Expected Output when I click REPLACE ALL:
winkle Twinkle
ittle Star
ow I wonder what you
re

What actually happens here is that the buffer is emptied because every character is replaced with an empty string.

Output when I click REPLACE:
winkle Twinkle
Little Star
How I wonder what you
are

Output when I click REPLACE AND FIND:
winkle Twinkle
Little Star
How I wonder what you
are

NOTE: In the last case, the find function will now match 'w' in the second line input text.

Example II:
Input:
Twinkle Twinkle
Little Star
How I wonder what you
are

Search for:  ^.
meaning I want a search for the first character of every line

Replace with: p
replace every matched character with the letter 'p'

Expected Output when I click REPLACE ALL:
pwinkle Twinkle
pittle Star
pow I wonder what you
pre

Output when I click REPLACE:
pwinkle Twinkle
Little Star
How I wonder what you
are

Output when I click REPLACE AND FIND:
pinkle Twinkle
Little Star
How I wonder what you
are

NOTE: In the last case, the find function will now match 'L' in the input text because in regular expressions
'^' symbol should check only for the beginning of the line.
But the result in the current version empties the buffer whenever replace all is given for Example 1 which is
wrong. It violates the meaning of the regular expression '^' itself.

Example III:
Input text:
AABBBA
Search: ^A
Expected Output: ABBBA
But Actual Result of the current version: BBBA

How the bug was fixed:
1. Check if the regex option is selected
2. If yes, then check if the search pattern has '^'
3. If yes, then set the offset value accordingly. 

Patch Details:
Version of jEdit : 4.5.2
Platform: Windows
Edited file: SearchAndReplace.java
Package: org/gjt/sp/jedit/Search

----------------------------------------------------------------------

>Comment By: Jarek Czekalski (jarekczek)
Date: 2012-08-01 10:47

Message:
1. It's not the output of svn diff
2. Still can't compile "string"

----------------------------------------------------------------------

Comment By: Swetha (swetha1910)
Date: 2012-07-31 00:08

Message:
It's fine with me. Leave it in original state.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-07-30 13:01

Message:
For you the condition is more logical. For the original author it was more
logical to make infinite loop. If it is not necessary to change this line,
I suggest to leave it in the original state. Would you agree?

----------------------------------------------------------------------

Comment By: Swetha (swetha1910)
Date: 2012-07-30 11:09

Message:
There is no particular meaning for an infinite loop in the _replace
function (SearchAndReplace.java file). The replace should not take place
beyond the end value and so is more logical when the condition "offset <
end" is added. 

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-07-27 10:49

Message:
This patch does not compile, because of this line:

string current_line = buffer.getLineOfOffset(offset);

Cannot find symbol string.

If you resubmit the patch please pay attention to following:
1. prepare it using "svn diff" command run from the root directory
(directory containing org directory), preferrably having checked out the
most recent version (from trunk)
2. check type of whitespace you insert (match the ones used in the file)
3. explain, to help me understand the patch: why is the condition "offset <
end" in "for" loop needed now, while previously it wasn't there

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3543916&group_id=588

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel

SourceForge.net | 1 Aug 2012 19:55
Picon

[ jedit-Merge Requests-3539490 ] Fix for VFS session not closed in copy

Merge Requests item #3539490, was opened at 2012-07-02 09:04
Message generated for change (Comment added) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1235750&aid=3539490&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: for 5.0.x
>Status: Pending
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Matthieu Casanova (kpouer)
>Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for VFS session not closed in copy

Initial Comment:
Please merge rev 21910 to fix bug #3522406

http://jedit.svn.sourceforge.net/jedit/?rev=21910&view=rev
https://sourceforge.net/tracker/index.php?func=detail&aid=3522406&group_id=588&atid=100588#

----------------------------------------------------------------------

>Comment By: Jarek Czekalski (jarekczek)
Date: 2012-08-01 10:55

Message:
It is not necessary to merge this fix, imo. So unassigning myself.

----------------------------------------------------------------------

Comment By: Matthieu Casanova (kpouer)
Date: 2012-07-30 05:37

Message:
It was not a bug that was really visible. Only some VFS sessions were not
closed when you copy/paste a file in the VFS browser

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2012-07-28 16:33

Message:
What are the proper steps to test the patch/reproduce the original bug?
Assigning to Jarek since he opened the original ticket.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1235750&aid=3539490&group_id=588

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--

-- 
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel


Gmane