[ jedit-Merge Requests-3534174 ] MiscUtilities.openInDesktop() in jEdit 5.0
<SourceForge.net>
2012-07-01 15:53:41 GMT
Merge Requests item #3534174, was opened at 2012-06-10 11:41
Message generated for change (Comment added) made by jarekczek
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1235750&aid=3534174&group_id=588
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: for 5.0.x
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Alan Ezust (ezust)
>Assigned to: Jarek Czekalski (jarekczek)
Summary: MiscUtilities.openInDesktop() in jEdit 5.0
Initial Comment:
Originally, I was just going to move the code out of the browser.actions.xml file and into MiscUtilities
but during testing, I found and fixed a couple of bugs in related to files with spaces in the names.
So revision # 21791 moves the code into MiscUtilities (which is a new API) and also fixes some of the code
that was there before. I would like to put this into jEdit 5.0 so that plugins can use it sooner (esp.
projectviewer which has duplicate bad code right now).
----------------------------------------------------------------------
>Comment By: Jarek Czekalski (jarekczek)
Date: 2012-07-01 08:53
Message:
Applied to 5.0 as r21894. It would be easier if there were no other changes
to the method applied inbetween and no whitespace changes in different
places.
----------------------------------------------------------------------
Comment By: Alan Ezust (ezust)
Date: 2012-06-26 14:41
Message:
Rev# 21880 should address all your issues.
----------------------------------------------------------------------
Comment By: Jarek Czekalski (jarekczek)
Date: 2012-06-26 07:22
Message:
Alan, with such hasty comment and this level of your verbosity I see no way
to work on this ticket. And my opinion about this new api in 5.1 remains
negative.
----------------------------------------------------------------------
Comment By: Alan Ezust (ezust)
Date: 2012-06-25 10:17
Message:
That is incorrect.
An IOException can also be thrown from Runtime.exec(). if for example,
command is not found or filename is bad.
----------------------------------------------------------------------
Comment By: Jarek Czekalski (jarekczek)
Date: 2012-06-25 10:12
Message:
There is a problem with method's signature, maybe with javadoc.
<at> throws IOException if the path is not valid or something else is not
working
Usually the exception will not be thrown because the string is simply
passed to a native command. Only in
// I don't know what platform it is...
there may really be IOException raised. But that's the border case, as all
known operating systems don't reach this line.
I think it would be better to remove this misleading exception from
signature. Capture it and report immediately, maybe returning true on
success, false on failure.
Copying the code from action to api seems to be not enough in this case.
Api needs additional care.
----------------------------------------------------------------------
Comment By: Jarek Czekalski (jarekczek)
Date: 2012-06-17 08:07
Message:
Kazutoshi was not sure whether to agree on this merge. I am going to commit
it, but will wait a few days for possible objections.
----------------------------------------------------------------------
Comment By: Alan Ezust (ezust)
Date: 2012-06-14 10:47
Message:
Rev#21801 improves the API docs for the function.
----------------------------------------------------------------------
Comment By: Alan Ezust (ezust)
Date: 2012-06-11 11:11
Message:
I hope an exception can be made in this case.
I was just a day late 
----------------------------------------------------------------------
Comment By: Jarek Czekalski (jarekczek)
Date: 2012-06-11 10:27
Message:
Alan, so you suggest that 5.0pre1 (already released) have different api
than 5.0 or 5.0pre2? I remember someone said recently that it shouldn't be
done, but I don't see any written rule about that.
----------------------------------------------------------------------
Comment By: Alan Ezust (ezust)
Date: 2012-06-11 10:12
Message:
I removed some unnecessary code in rev# 21792 so you can apply that as part
of this merge request too.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1235750&aid=3534174&group_id=588
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
--
--
-----------------------------------------------
jEdit Developers' List
jEdit-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jedit-devel
RSS Feed