patch to correct broken link [Help --> About GNOME Office]

Hi,

Just wanted to forward a patch for broken URL in [Help --> About GNOME Office]
(attached).

Thanks for all your work.

Regards,
Dmitry.

Author: Dmitry Smirnov <onlyjob <at> member.fsf.org>
Bug-Debian: http://bugs.debian.org/657909
Last-Update: 2012-01-31
Forwarded: 2012-02-05
Description: Update GNOME Office URL

--- a/src/wp/ap/xp/ap_EditMethods.cpp
+++ b/src/wp/ap/xp/ap_EditMethods.cpp
@@ -3557,7 +3557,7 @@

 Defun0(helpAboutGnomeOffice)
 {
-	return _openURL("http://www.gnome.org/gnome-office/");
+	return _openURL("http://live.gnome.org/GnomeOffice");
 }

 Defun1(cycleWindows)

XP code for saveRectangle & restoreRectangle

Hello!

I attached a patch in order to make saveRectangle and restoreRectangle XP code.

UNIX: I made a "cairo only" implementation and moved them to from
GR_UnixCairoGraphics to GR_CairoGraphics.
WIN: This way, there will also be no need to implement these methods
in a future GR_Win32CairoGraphics class.
COCOA: Unfortunately, due to a bug in the quartz backend,
GR_CocoaCairoGraphics cannot take advantage of this code yet, so I
left the GR_CocoaCairoGraphics class untouched.

I already tested the patch and it seems to work fine (64bit Linux
Mint, 32bit Ubuntu).

Please, can someone review so I can commit it?

Andrei SFRENT

Index: src/af/gr/gtk/gr_UnixCairoGraphics.h
===================================================================
--- src/af/gr/gtk/gr_UnixCairoGraphics.h	(revision 30602)
+++ src/af/gr/gtk/gr_UnixCairoGraphics.h	(working copy)
@@ -85,8 +85,6 @@
 	virtual void		scroll(UT_sint32 x_dest, UT_sint32 y_dest,
 						   UT_sint32 x_src, UT_sint32 y_src,
 						   UT_sint32 width, UT_sint32 height);
-	virtual void	    saveRectangle(UT_Rect & r, UT_uint32 iIndx);
-	virtual void	    restoreRectangle(UT_uint32 iIndx);

Win32 #warning build error

The win32 build is broken because of the use of #warning:

1>..\..\src\text\ptbl\xp\pp_Revision.cpp(1150) : fatal error C1021:
invalid preprocessor command 'warning'

I'm not sure who added it, but could he shed some light on this?

Thanks!

  Marc

Re: Win32 #warning build error

On 05/02/12 05:15 AM, J.M. Maurer wrote:
> 
> The win32 build is broken because of the use of #warning:
> 
> 1>..\..\src\text\ptbl\xp\pp_Revision.cpp(1150) : fatal error C1021:
> invalid preprocessor command 'warning'
> 
> 
> I'm not sure who added it, but could he shed some light on this?

I did. I didn't think it would break MSVC, I was wrong.

Now the best course of action is actually fixing what the #warning says 

Sorry for the mess.

Hub

Re: Win32 #warning build error

On Sun, 2012-02-05 at 20:54 -0800, Hub Figuière wrote:
> On 05/02/12 05:15 AM, J.M. Maurer wrote:
> > 
> > The win32 build is broken because of the use of #warning:
> > 
> > 1>..\..\src\text\ptbl\xp\pp_Revision.cpp(1150) : fatal error C1021:
> > invalid preprocessor command 'warning'
> > 
> > 
> > I'm not sure who added it, but could he shed some light on this?
> 
> I did. I didn't think it would break MSVC, I was wrong.
> 
> Now the best course of action is actually fixing what the #warning says 
> 
> Sorry for the mess.
> 
> Hub

I've removed that debug block. 

Since I was really unfamiliar with the CT stuff and there seems to be
some funky memory stuff in there I had some detailed debug code as I
went along.

Re: XP code for saveRectangle & restoreRectangle

Looks good to me++

  Marc

On Sat, 2012-02-04 at 17:15 +0200, Andrei Sfrent wrote:
> Hello!
> 
> I attached a patch in order to make saveRectangle and restoreRectangle XP code.
> 
> UNIX: I made a "cairo only" implementation and moved them to from
> GR_UnixCairoGraphics to GR_CairoGraphics.
> WIN: This way, there will also be no need to implement these methods
> in a future GR_Win32CairoGraphics class.
> COCOA: Unfortunately, due to a bug in the quartz backend,
> GR_CocoaCairoGraphics cannot take advantage of this code yet, so I
> left the GR_CocoaCairoGraphics class untouched.
> 
> I already tested the patch and it seems to work fine (64bit Linux
> Mint, 32bit Ubuntu).
> 
> Please, can someone review so I can commit it?
> 
> Andrei SFRENT

Re: XP code for saveRectangle & restoreRectangle

On 06/02/12 12:21 PM, J.M. Maurer wrote:
> 
> Looks good to me++
> 

As said on IRC, Drop the UT_GenericVector<> stuff and use std::vector<>
instead.

This is a general rule.

Same when you encounter UT_String and UT_UTF8String. The first one need
to go. The second one should in *most cases*.

Hub

Re: XP code for saveRectangle & restoreRectangle

Hi!

I rewrote the code using std::vector (as Hub suggested) and attached
the new patch.

Andrei

2012/2/6 Hub Figuière <hfiguiere <at> teaser.fr>:
>
> On 06/02/12 12:21 PM, J.M. Maurer wrote:
>>
>> Looks good to me++
>>
>
> As said on IRC, Drop the UT_GenericVector<> stuff and use std::vector<>
> instead.
>
> This is a general rule.
>
> Same when you encounter UT_String and UT_UTF8String. The first one need
> to go. The second one should in *most cases*.
>
>
> Hub

Index: src/af/gr/gtk/gr_UnixCairoGraphics.h
===================================================================
--- src/af/gr/gtk/gr_UnixCairoGraphics.h	(revision 30621)
+++ src/af/gr/gtk/gr_UnixCairoGraphics.h	(working copy)

AbiWord on the raspberry pi!

From the "another reason that abiword is cool" department.

The default distro for the $35 Raspberry Pi is fedora which includes abiword.

See the video linked below:

http://www.youtube.com/watch?v=6I7jCSWdRLQ&feature=player_embedded

Maybe this could be linked from the new webpage?

Cheers

martin

UT_std_vector_freeall function

Hello!

The attached patch adds the UT_std_vector_freeall function to
ut_std_vector.h file. This is the equivalent of
UT_VECTOR_SPARSECLEANUP macro defined in ut_vector.h. It is useful
when we need to call something else than "delete" on every element of
a std::vector.

Andrei

Index: src/af/util/xp/ut_std_vector.h
===================================================================
--- src/af/util/xp/ut_std_vector.h	(revision 30623)
+++ src/af/util/xp/ut_std_vector.h	(working copy)
@@ -35,6 +35,13 @@
 	}
 }

+template <class V, typename F>
+void UT_std_vector_freeall(V & v, F free_func = g_free)
+{
+	for(typename V::iterator iter = v.begin();iter != v.end(); ++iter) {
+		if(*iter)
+			free_func(*iter);
+	}
+}

-
 #endif