headers
Nick Hughart | 1 Sep 2009 04:50
Favicon

Re: [E-devel] .desktop files in .local dir are very bad managed IMHO

On Mon, 31 Aug 2009 17:16:52 -0400
Atton Jonathan <jonathan.atton <at> gmail.com> wrote:

> new test made with liferea. I have drag and drop the icon from the
> window's border into the ibar. A new .desktop file has been created in
> ~/.local/sare/applications.
> Now I have 2 files!
> /usr/share/applications/liferea.desktop
> ~/.local/share/applications/liferea-bin.desktop
> 
> Maybe the window was not "link" to a valid .desktop, that's why the
> ibar has created a new one. See, the both files name are different.
> The systeam file use the binarie "liferea" and the local use
> "liferea-bin".

Yes, this is most likely why it did this.  There was no way for E to
match the original .desktop to the window as the exec doesn't match and
there is probably not StartupWMClass in the original .desktop.  E does
some tracking on apps if they've been started via the .desktop, but
this info is lost if you restart IIRC.

> 
> 2009/8/31 Atton Jonathan <jonathan.atton <at> gmail.com>
> 
> > Some times ago I had this problem :  the .desktop file was copied in
> > ~/.local/application. The result was an entry in the category
> > "others" of the menu. I have made the test today and no .desktop
> > files was created. Maybe the problem has been fixed some days/weeks
> > ago ?
> >
(Continue reading)

Permalink | Reply | 6 comments |
headers
Cedric BAIL | 1 Sep 2009 11:15
Picon
Favicon

Re: [E-devel] NOTICE: svn feature freeze this weekend (Sep 4-6)

On Tue, Sep 1, 2009 at 12:22 AM, Gustavo Sverzut
Barbieri<barbieri <at> profusion.mobi> wrote:
>   - fixing bugs reported by Luis Felipe's LLVM/Clang:
> http://local.profusion.mobi:8081/~lfelipe/output-efl/
>   - moving code from fprintf/printf to eina_log (prefer to do this
> BEFORE this weekend!)

eina_log should also be used more inside eina, I don't know if André
Dieb plan to do it, but you can do a file by file hunt of eina_error
and replace it with eina_log. Perhaps André you can do one small
commit so others can understand what needs to be done.

> Enlightenment DR17 is quite stable these days, the release items are
> almost all done. Items under "Reorganize, Layout and Visual Changes"
> are the biggest pending, but Raster already talked about postponing
> those. But in turn, Edje received new Lua scripting support, that
> really needs to be improved so Edje and thus E17 can be released.

Well, Edje received a lot of internal improvement during the past
week, not only lua, but the way all edje_recalc is done also.
Apparently all breakage are fixed now, but if you see anything
strange, don't hesitate to report.

> Cedric wished to release Eina last time but we were missing eina_log,
> just introduced by André Dieb some weeks ago. Probably with some love
> we can make it 1.0 and be happy to release another important building
> block.

Yep, just need a little bit of work around eina_log and we will be
ready for a release of Eina. If people can take time for a last API
(Continue reading)

Permalink | Reply | 33 comments |
headers
Viktor Kojouharov | 1 Sep 2009 11:37
Picon

Re: [E-devel] Fix issues with edge bindings

On Mon, 2009-08-31 at 22:23 -0500, Nick Hughart wrote:
> On Mon, 31 Aug 2009 09:14:13 +0300
> Viktor Kojouharov <vkojouharov <at> gmail.com> wrote:
> 
> > On Sun, 2009-08-30 at 18:56 -0500, Nick Hughart wrote:
> > > On Mon, 31 Aug 2009 01:08:36 +0300
> > > Viktor Kojouharov <vkojouharov <at> gmail.com> wrote:
> > > 
> > > > On Sun, 2009-08-30 at 11:17 -0500, Nick Hughart wrote:
> > > > > On Sun, 30 Aug 2009 18:28:04 +0300
> > > > > Viktor Kojouharov <vkojouharov <at> gmail.com> wrote:
> > > > > 
> > > > > > On Sun, 2009-08-30 at 10:01 -0500, Nick Hughart wrote:
> > > > > > > On Sun, 30 Aug 2009 15:28:11 +0300
> > > > > > > Viktor Kojouharov <vkojouharov <at> gmail.com> wrote:
> > > > > > > 
> > > > > > > > On Sat, 2009-08-29 at 18:56 -0500, Nick Hughart wrote:
> > > > > > > > > So the edge bindings have once again ticked me off.  So
> > > > > > > > > much so that I've made the attached patch to correct
> > > > > > > > > it's flaws.  I tried to keep as much of the mechanisms
> > > > > > > > > the same even though I don't exactly like how it's done
> > > > > > > > > right now.
> > > > > > > > > 
> > > > > > > > > Anyway, the patch fixes a couple of things.
> > > > > > > > > 
> > > > > > > > > First it will hide any of the edge windows if that edge
> > > > > > > > > is not being used.  It is pointless to have the entire
> > > > > > > > > 1px border of the screen unusable when I have no edge
> > > > > > > > > bindings.
> > > > > > > >
(Continue reading)

Permalink | Reply | 1 comment |
headers
Rocco Carbone | 1 Sep 2009 11:28
Picon
Favicon

[E-devel] Was: Re: NOTICE: svn feature freeze this weekend (Sep 4-6)

On 1 September 11:15 2009 Cedric BAIL spoke:
 | On Tue, Sep 1, 2009 at 12:22 AM, Gustavo Sverzut
 | Barbieri<barbieri <at> profusion.mobi> wrote:
 | >   - fixing bugs reported by Luis Felipe's LLVM/Clang:
 | > http://local.profusion.mobi:8081/~lfelipe/output-efl/
 | >   - moving code from fprintf/printf to eina_log (prefer to do this
 | > BEFORE this weekend!)
 | 
 | eina_log should also be used more inside eina, I don't know if André
 | Dieb plan to do it, but you can do a file by file hunt of eina_error
 | and replace it with eina_log. Perhaps André you can do one small
 | commit so others can understand what needs to be done.
 | 
 | > Enlightenment DR17 is quite stable these days, the release items are
 | > almost all done. Items under "Reorganize, Layout and Visual Changes"
 | > are the biggest pending, but Raster already talked about postponing
 | > those. But in turn, Edje received new Lua scripting support, that
 | > really needs to be improved so Edje and thus E17 can be released.
 | 
 | Well, Edje received a lot of internal improvement during the past
 | week, not only lua, but the way all edje_recalc is done also.
 | Apparently all breakage are fixed now, but if you see anything
 | strange, don't hesitate to report.
 | 
 | > Cedric wished to release Eina last time but we were missing eina_log,
 | > just introduced by André Dieb some weeks ago. Probably with some love
 | > we can make it 1.0 and be happy to release another important building
 | > block.
 | 
 | Yep, just need a little bit of work around eina_log and we will be
(Continue reading)

Permalink | Reply | 23 comments |
headers
Gustavo Sverzut Barbieri | 1 Sep 2009 12:26

Re: [E-devel] NOTICE: svn feature freeze this weekend (Sep 4-6)

On Tue, Sep 1, 2009 at 6:15 AM, Cedric BAIL<cedric.bail <at> free.fr> wrote:
> On Tue, Sep 1, 2009 at 12:22 AM, Gustavo Sverzut
> Barbieri<barbieri <at> profusion.mobi> wrote:
>>   - fixing bugs reported by Luis Felipe's LLVM/Clang:
>> http://local.profusion.mobi:8081/~lfelipe/output-efl/
>>   - moving code from fprintf/printf to eina_log (prefer to do this
>> BEFORE this weekend!)
>
> eina_log should also be used more inside eina, I don't know if André
> Dieb plan to do it, but you can do a file by file hunt of eina_error
> and replace it with eina_log. Perhaps André you can do one small
> commit so others can understand what needs to be done.

Sure, and this all should use log domains. At least each library and
E17 split into core and per module should have it.

For those used to ecore_event_type_new(), it's pretty similar! We made
it on purpose. The recommended usage is to register the new domain on
first MODULE_init() and unregister on last MODULE_shutdown(), then
define macros in your MODULE_private.h:

extern int _MODULE_log_dom = -1; /* usually not static since multiple
.o will use the same domain */
#define DBG(...) EINA_LOG_DOM_DBG(_MODULE_log_dom, __VA_ARGS__)
#define ERR(...) EINA_LOG_DOM_ERR(_MODULE_log_dom, __VA_ARGS__)

for E17 i guess we can have E_DBG, E_ERR... so users can use the
simple versions themselves. OR simply modules could #undef and define
it again in their own header/source.
(Continue reading)

Permalink | Reply | 6 comments |
headers
Andre Dieb | 1 Sep 2009 11:58
Picon

Re: [E-devel] Was: Re: NOTICE: svn feature freeze this weekend (Sep 4-6)

I plan to change what I can, but I'll certainly need help.
Basically we need to eina_log_init() and eina_log_shutdown() (some places
are only using macros directly and not init'ing - won't work with new API).
Also, you can't just replace eina_error_init() because these apps also use
eina_error API for error messages and codes (that will be kept).

On Tue, Sep 1, 2009 at 6:28 AM, Rocco Carbone <rocco <at> tecsiel.it> wrote:

> On 1 September 11:15 2009 Cedric BAIL spoke:
>  | On Tue, Sep 1, 2009 at 12:22 AM, Gustavo Sverzut
>  | Barbieri<barbieri <at> profusion.mobi> wrote:
>  | > Â  - fixing bugs reported by Luis Felipe's LLVM/Clang:
>  | > http://local.profusion.mobi:8081/~lfelipe/output-efl/
>  | > Â  - moving code from fprintf/printf to eina_log (prefer to do this
>  | > BEFORE this weekend!)
>  |
>  | eina_log should also be used more inside eina, I don't know if André
>  | Dieb plan to do it, but you can do a file by file hunt of eina_error
>  | and replace it with eina_log. Perhaps André you can do one small
>  | commit so others can understand what needs to be done.
>  |
>  | > Enlightenment DR17 is quite stable these days, the release items are
>  | > almost all done. Items under "Reorganize, Layout and Visual Changes"
>  | > are the biggest pending, but Raster already talked about postponing
>  | > those. But in turn, Edje received new Lua scripting support, that
>  | > really needs to be improved so Edje and thus E17 can be released.
>  |
>  | Well, Edje received a lot of internal improvement during the past
>  | week, not only lua, but the way all edje_recalc is done also.
>  | Apparently all breakage are fixed now, but if you see anything
(Continue reading)

Permalink | Reply | 21 comments |
headers
Gustavo Sverzut Barbieri | 1 Sep 2009 12:35

Re: [E-devel] E SVN: urandom IN trunk/E-MODULES-EXTRA/drawer: . src src/plugins src/plugins/sources src/plugins/views

On Mon, Aug 31, 2009 at 9:39 PM, Enlightenment
SVN<no-reply <at> enlightenment.org> wrote:
> Log:
>  silence clang warnings
...
> Modified: trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c
> ===================================================================
> --- trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c       2009-08-31 21:04:13 UTC (rev 42140)
> +++ trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c       2009-09-01 00:39:26 UTC (rev 42141)
>  <at>  <at>  -290,6 +290,9  <at>  <at> 
>                }
>              e = _list_horizontal_entry_create(inst, si);
>              break;
> +           default:
> +              e = NULL;
> +              break;
>          }
>        inst->entries = eina_list_append(inst->entries, e);
>        e_box_pack_end(inst->o_box, e->o_holder);

silence is not good, this last hunk will likely introduce a bug since
you're appending e == NULL to inst->entries and likely a new run of
the CLang static checker will point out you just introduced a NULL
pointer dereference in the line following it: e->o_holder == CRASH!

Please take care to not silence problems and introduce a new, tricker
bug! (it would be the case with inst->entries containing data == NULL,
we'd have to check for data != NULL in every place and possible fail
once and screw, it's much more safe avoiding NULL pointers to get into
the list.
(Continue reading)

Permalink | Reply | 2 comments |
headers
Gustavo Sverzut Barbieri | 1 Sep 2009 12:50

Re: [E-devel] E SVN: urandom IN trunk/E-MODULES-EXTRA/drawer: . src src/plugins src/plugins/sources src/plugins/views

On Tue, Sep 1, 2009 at 7:43 AM, Viktor Kojouharov<vkojouharov <at> gmail.com> wrote:
> On Tue, 2009-09-01 at 07:35 -0300, Gustavo Sverzut Barbieri wrote:
>> On Mon, Aug 31, 2009 at 9:39 PM, Enlightenment
>> SVN<no-reply <at> enlightenment.org> wrote:
>> > Log:
>> >  silence clang warnings
>> ...
>> > Modified: trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c
>> > ===================================================================
>> > --- trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c       2009-08-31 21:04:13 UTC (rev 42140)
>> > +++ trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c       2009-09-01 00:39:26 UTC (rev 42141)
>> >  <at>  <at>  -290,6 +290,9  <at>  <at> 
>> >                }
>> >              e = _list_horizontal_entry_create(inst, si);
>> >              break;
>> > +           default:
>> > +              e = NULL;
>> > +              break;
>> >          }
>> >        inst->entries = eina_list_append(inst->entries, e);
>> >        e_box_pack_end(inst->o_box, e->o_holder);
>>
>> silence is not good, this last hunk will likely introduce a bug since
>> you're appending e == NULL to inst->entries and likely a new run of
>> the CLang static checker will point out you just introduced a NULL
>> pointer dereference in the line following it: e->o_holder == CRASH!
>>
>> Please take care to not silence problems and introduce a new, tricker
>> bug! (it would be the case with inst->entries containing data == NULL,
>> we'd have to check for data != NULL in every place and possible fail
(Continue reading)

Permalink | Reply | 0 comments |
headers
Viktor Kojouharov | 1 Sep 2009 12:43
Picon

Re: [E-devel] E SVN: urandom IN trunk/E-MODULES-EXTRA/drawer: . src src/plugins src/plugins/sources src/plugins/views

On Tue, 2009-09-01 at 07:35 -0300, Gustavo Sverzut Barbieri wrote:
> On Mon, Aug 31, 2009 at 9:39 PM, Enlightenment
> SVN<no-reply <at> enlightenment.org> wrote:
> > Log:
> >  silence clang warnings
> ...
> > Modified: trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c
> > ===================================================================
> > --- trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c       2009-08-31 21:04:13 UTC (rev 42140)
> > +++ trunk/E-MODULES-EXTRA/drawer/src/plugins/views/list.c       2009-09-01 00:39:26 UTC (rev 42141)
> >  <at>  <at>  -290,6 +290,9  <at>  <at> 
> >                }
> >              e = _list_horizontal_entry_create(inst, si);
> >              break;
> > +           default:
> > +              e = NULL;
> > +              break;
> >          }
> >        inst->entries = eina_list_append(inst->entries, e);
> >        e_box_pack_end(inst->o_box, e->o_holder);
> 
> silence is not good, this last hunk will likely introduce a bug since
> you're appending e == NULL to inst->entries and likely a new run of
> the CLang static checker will point out you just introduced a NULL
> pointer dereference in the line following it: e->o_holder == CRASH!
> 
> Please take care to not silence problems and introduce a new, tricker
> bug! (it would be the case with inst->entries containing data == NULL,
> we'd have to check for data != NULL in every place and possible fail
> once and screw, it's much more safe avoiding NULL pointers to get into
(Continue reading)

Permalink | Reply | 1 comment |
headers
Christopher Michael | 1 Sep 2009 15:21
Picon

Re: [E-devel] API inconsistency

Carsten Haitzler (The Rasterman) wrote:
> On Thu, 20 Aug 2009 11:51:50 -0400 Christopher Michael <cpmichael1 <at> comcast.net>
> said:
> 
>> While working on the new shelf dialog, I noticed an API inconsistency:
>>
>> we have e_win_size_min_set but we also have e_widget_min_size_set ...
>>
>> which is prefered ? :
>>
>> e_win_size_min_set
>> e_widget_size_min_set
>>
>> OR
>>
>> e_win_min_size_set
>> e_widget_min_size_set
> 
> first one. :)
> 
I have all the changes done for this (e, modules, etc, etc). Went 
through all of e/trunk and did the replacements. I am just building 
everything right now to make sure it's ok, then I will commit these 
changes (in mass)

dh

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on
(Continue reading)

Permalink | Reply | 0 comments |

Gmane