headers
mychael.janes | 1 Nov 2007 16:44
Picon

Re: [PATCH 3/3] ncol and nmaster also per-screen

I hope I submitted this correctly, everyone.

I want to tell you I really love awesome, and am enjoying it immensely.
It's what I'm using on my archlinux machines at home and work.  However,
the other day I got to thinking that I like for each screen to have its
own tile layout and not change when I switch from one screen to the
other.  So that's what this patch series does.

It's working for me here, but I would love some constructive feedback
since this is my first time ever submitting a patch for an open-source
project.

Thanks!
Mychael

On Thu, Nov 01, 2007 at 08:41:12AM -0700, Mychael Janes wrote:
> ---
>  awesome.c      |    3 +++
>  config.c       |   17 ++++++++++++++---
>  config.h       |    4 ++--
>  layouts/tile.c |   36 ++++++++++++++++++++----------------
>  4 files changed, 39 insertions(+), 21 deletions(-)
> 
> diff --git a/awesome.c b/awesome.c
> index bed6079..e3e9d5c 100644
> --- a/awesome.c
> +++ b/awesome.c
>  <at>  <at>  -79,6 +79,9  <at>  <at>  cleanup_screen(awesome_config *awesomeconf)
>      p_delete(&awesomeconf->layouts);
>      p_delete(&awesomeconf->rules);
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mychael Janes | 1 Nov 2007 16:41
Picon

[PATCH 2/3] mwfact now works per screen

---
 config.c       |    7 ++++++-
 config.h       |    2 +-
 layouts/tile.c |   18 +++++++++++++-----
 3 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/config.c b/config.c
index 9c117cc..c62f58c 100644
--- a/config.c
+++ b/config.c
 <at>  <at>  -329,7 +329,6  <at>  <at>  parse_config(const char *confpatharg, awesome_config *awesomeconf)
         awesomeconf->layouts[i].symbol = a_strdup(cfg_getstr(cfgsectmp, "symbol"));
     }

-    awesomeconf->mwfact = cfg_getfloat(cfg_layouts, "mwfact");
     awesomeconf->nmaster = cfg_getint(cfg_layouts, "nmaster");
     awesomeconf->ncol = cfg_getint(cfg_layouts, "ncol");

 <at>  <at>  -375,6 +374,12  <at>  <at>  parse_config(const char *confpatharg, awesome_config *awesomeconf)
     if(!awesomeconf->ntags)
         eprint("awesome: fatal: no tags found in configuration file\n");

+    awesomeconf->mwfact = p_new(double, awesomeconf->ntags);
+    for (i=0; i < awesomeconf->ntags; i++)
+    {
+        awesomeconf->mwfact[i] = cfg_getfloat(cfg_layouts, "mwfact");
+    }
+
     /* select first tag by default */
     awesomeconf->tags[0].selected = True;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mychael Janes | 1 Nov 2007 16:41
Picon

[PATCH 3/3] ncol and nmaster also per-screen

---
 awesome.c      |    3 +++
 config.c       |   17 ++++++++++++++---
 config.h       |    4 ++--
 layouts/tile.c |   36 ++++++++++++++++++++----------------
 4 files changed, 39 insertions(+), 21 deletions(-)

diff --git a/awesome.c b/awesome.c
index bed6079..e3e9d5c 100644
--- a/awesome.c
+++ b/awesome.c
 <at>  <at>  -79,6 +79,9  <at>  <at>  cleanup_screen(awesome_config *awesomeconf)
     p_delete(&awesomeconf->layouts);
     p_delete(&awesomeconf->rules);
     p_delete(&awesomeconf->keys);
+    p_delete(&awesomeconf->mwfact);
+    p_delete(&awesomeconf->ncol);
+    p_delete(&awesomeconf->nmaster);
 }

 /** Cleanup everything on quit
diff --git a/config.c b/config.c
index c62f58c..3eb28a2 100644
--- a/config.c
+++ b/config.c
 <at>  <at>  -329,9 +329,6  <at>  <at>  parse_config(const char *confpatharg, awesome_config *awesomeconf)
         awesomeconf->layouts[i].symbol = a_strdup(cfg_getstr(cfgsectmp, "symbol"));
     }

-    awesomeconf->nmaster = cfg_getint(cfg_layouts, "nmaster");
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mychael Janes | 1 Nov 2007 16:40
Picon

[PATCH 1/3] added awesome-client to ignore list

---
 .gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/.gitignore b/.gitignore
index 601cf9a..9c6d791 100644
--- a/.gitignore
+++ b/.gitignore
 <at>  <at>  -1,2 +1,3  <at>  <at> 
 *.o
 awesome
+awesome-client
--

-- 
1.5.3.5
Permalink | Reply | 0 comments |
headers
Mike Erdely | 3 Nov 2007 16:38
Favicon

Re: Call for testing future awesome 1.3: Xinerama new handling

Julien Danjou wrote:
> The last few days I've been working on a complete rewrite of the
> Xinerama handling of awesome.
> Xinerama screens are now handled like Zaphod screens (multi-head with
> multiple physical screen and displays). That allows changing tags views
> on each screen without changing the whole display.
> In one word: each screen is independant, Xinerama is now more a "big
> display". I always wanted that in a window manager, and I think Xmonad
> also is going this way.
> 
> This can introduce a number of regression in Xinerama mode, but also in
> Zaphod mode and maybe in one screen mode.
> 
> Consequently I ask that if you're using 1.2 to test the current git
> master branch. There won't be any big feature adittion for 1.3 right
> now, only bug fixes.

I've just started using awesome (previously 1.1 from OpenBSD ports) and
now 1.3 (also from OpenBSD ports) and I think is behaviour change makes
awesome unusable with Xinerama.  With awesome 1.3, I cannot use dwm to
launch an application in my second monitor.  I have to drag the window
to the second screen.  And, according to:
http://awesome.naquadah.org/doc/uicb/#index15h2
there's no way from the keyboard to switch focus from one screen to
another.  The way Xinerama was supported in awesome 1.1 made sense and
worked.  I could make awesome behave the way it currently does in 1.3 by
disabling Xinerama and having X just recognize two separate displays.
So, now there's virtually no benefit to Xinerama support.

Am I missing some benefit to this new Xinerama handling?
(Continue reading)

Permalink | Reply | 501 comments |
headers
Mike Erdely | 3 Nov 2007 16:28
Favicon

tightvnc & awesome

Hi,

With both awesome-1.1 and awesome-1.3 from the OpenBSD -current ports
tree, when I've connected to a vncserver (Vine Server on OS X) with
TightVNC's vncviewer (again from OpenBSD ports) and I leave the tag with
the vncviewer in it, the vncviewer disconnects.  Sometimes it doesn't
connect immediately.  Sometimes I can switch away and switch back (using
Mod1+[1-9]) and vncviewer will still be there, but eventually *every*
time, it will disconnect.

As a test, instead of using dmenu to launch vncviewer, I launched it
from an xterm and after switching away from vncviewer, I see this in the
xterm when vncviewer disconnects:
CleanupXErrorHandler called
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  42 (X_SetInputFocus)
  Serial number of failed request:  9232
  Current serial number in output stream:  9232

Note: This does not happen in dwm, fvwm or ratpoison.

Any ideas?  Anything you want me to test?

Thanks.
-ME
Permalink | Reply | 2 comments |
headers
Julien Danjou | 4 Nov 2007 11:22
Gravatar

Re: Call for testing future awesome 1.3: Xinerama new handling

At 1194104322 time_t, Mike Erdely wrote:
> I've just started using awesome (previously 1.1 from OpenBSD ports) and
> now 1.3 (also from OpenBSD ports) and I think is behaviour change makes
> awesome unusable with Xinerama.  With awesome 1.3, I cannot use dwm to
> launch an application in my second monitor.  I have to drag the window
> to the second screen.  And, according to:
> http://awesome.naquadah.org/doc/uicb/#index15h2
> there's no way from the keyboard to switch focus from one screen to
> another.  The way Xinerama was supported in awesome 1.1 made sense and
> worked.  I could make awesome behave the way it currently does in 1.3 by
> disabling Xinerama and having X just recognize two separate displays.
> So, now there's virtually no benefit to Xinerama support.
> 
> Am I missing some benefit to this new Xinerama handling?

No, but everything is so more better in devel version, try a git clone.

Cheers,
--

-- 
Julien Danjou
// ᐰ <julien@...>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
Permalink | Reply | 501 comments |
headers
Julien Danjou | 4 Nov 2007 17:40
Gravatar

Re: [PATCH 2/3] mwfact now works per screen

At 1193931662 time_t, Mychael Janes wrote:

I don't know. Some people asked about a per tag.
Maybe it'll be better.

--

-- 
Julien Danjou
// ᐰ <julien@...>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
Permalink | Reply | 2 comments |
headers
Julien Danjou | 4 Nov 2007 17:41
Gravatar

Re: tightvnc & awesome

Hi Mike,

At 1194103720 time_t, Mike Erdely wrote:
> With both awesome-1.1 and awesome-1.3 from the OpenBSD -current ports
> tree, when I've connected to a vncserver (Vine Server on OS X) with
> TightVNC's vncviewer (again from OpenBSD ports) and I leave the tag with
> the vncviewer in it, the vncviewer disconnects.  Sometimes it doesn't
> connect immediately.  Sometimes I can switch away and switch back (using
> Mod1+[1-9]) and vncviewer will still be there, but eventually *every*
> time, it will disconnect.
> Any ideas?  Anything you want me to test?

Test devel version please.

--

-- 
Julien Danjou
// ᐰ <julien@...>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
Permalink | Reply | 1 comment |
headers
Martin Stubenschrott | 4 Nov 2007 19:03
Picon

Re: [PATCH 2/3] mwfact now works per screen

On Sun, Nov 04, 2007 at 05:40:22PM +0100, Julien Danjou wrote:
> At 1193931662 time_t, Mychael Janes wrote:
> 
> I don't know. Some people asked about a per tag.
> Maybe it'll be better.

Yeah, i think per tag makes more sense, maybe per tag AND screen if
somebody really wants, but per-tag would be really helpful.
Permalink | Reply | 1 comment |

Gmane