headers
Perry Hargrave | 1 Jun 2010 06:56
Picon

Re: [PATCH 5/5] tag.lua: move_screen() moves tag to another screen

On Sun, May 30, 2010 at 12:24:34PM +0200, Uli Schlachter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Am 29.05.2010 20:01, Perry Hargrave wrote:
> > +--- Find a suitable fallback tag.
> > +--  <at> param screen The screen number to look for a tag on. [mouse.screen]
> > +--  <at> param target A table of tags we consider unacceptable. [{selected()}]
> > +function find_fallback(screen, invalids)
> > +    local scr = screen or capi.mouse.screen
> > +    local t = invalids or {selected()}
> 
> I'd propose:
> 
>   local t = invalids or selectedlist(scr)
> 
what worried me about this was if all the tags on a screen were
selected we might be blocking a tag delete when its
unnecessary.

(because find_fallback would return nil, indicating that there would be
untagged clients)

I'm really not sure which would be the more common use-case...

--

-- 
perry
Permalink | Reply | 0 comments |
headers
Perry Hargrave | 1 Jun 2010 07:15
Picon

[PATCH] tag.lua: check name argument to add() is valid


Signed-off-by: Perry Hargrave <perry.hargrave <at> gmail.com>
---
 lib/awful/tag.lua.in |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/lib/awful/tag.lua.in b/lib/awful/tag.lua.in
index 16bd54b..3563c26 100644
--- a/lib/awful/tag.lua.in
+++ b/lib/awful/tag.lua.in
 <at>  <at>  -33,8 +33,14  <at>  <at>  history.limit = 20
 --- Add a tag.
 --  <at> param name The tag name, a string
 --  <at> param props The tags properties, a table
---  <at> return The created tag
+--  <at> return The created tag or nil if not created.
+-- If the name is a valid string then the tag will be created and each key,value
+-- pair in 'props' table is iterated and applied to the tag. If the 'name'
+-- argument is nil or its string length is zero then the function returns nil.
 function add(name, props)
+    -- abort if the name is not provided
+    if not name or #(tostring(name)) == 0 then return end
+
     local properties = props or {}
     local newtag = capi.tag{name = name}
     newtag.screen = properties.screen or capi.mouse.screen
--

-- 
1.7.1
(Continue reading)

Permalink | Reply | 1 comment |
headers
awesome | 1 Jun 2010 07:26
Gravatar

[awesome bugs] #769 - applications are killed when all windows don't fit on the screen in tiled mode

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#769 - applications are killed when all windows don't fit on the screen in tiled mode
User who did this - lotus (lotus)

----------
 <at> yves this is the same issue  here, it seems to be application independence. its caused by awesome
----------

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=769#comment2005

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you
did not expect this message or don't want to receive mails in future, you can change your notification
settings at the URL shown above.

--

-- 
To unsubscribe, send mail to awesome-devel-unsubscribe <at> naquadah.org.
Permalink | Reply | 0 comments |
headers
Julien Danjou | 1 Jun 2010 10:31
Gravatar

Re: [PATCH] tag.lua: check name argument to add() is valid

On Tue, Jun 01 2010, Perry Hargrave wrote:

Pushed.

--

-- 
Julien Danjou
// ᐰ <julien <at> danjou.info>   http://julien.danjou.info
Permalink | Reply | 0 comments |
headers
awesome | 1 Jun 2010 15:13
Gravatar

[awesome bugs] #570 - The Psychon Secret Project

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task is now closed:

FS#570 - The Psychon Secret Project
User who did this - Gregor Best (farhaven)

Reason for closing: Won't implement
Additional comments about closing: Meh :) I know myself, I'm too busy procrastinating to implement this
(especially since it's an easteregg)

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=570

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you
did not expect this message or don't want to receive mails in future, you can change your notification
settings at the URL shown above.

--

-- 
To unsubscribe, send mail to awesome-devel-unsubscribe <at> naquadah.org.
Permalink | Reply | 0 comments |
headers
awesome | 1 Jun 2010 15:15
Gravatar

[awesome bugs] #531 - Apptags should not affect dialog boxes or child windows

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task is now closed:

FS#531 - Apptags should not affect dialog boxes or child windows
User who did this - Gregor Best (farhaven)

Reason for closing: Not a bug
Additional comments about closing: If you say you want all windows with class "Pidgin" on some tag, awesome
will do as you please, if you don't want that, tell it to do something else.

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=531

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you
did not expect this message or don't want to receive mails in future, you can change your notification
settings at the URL shown above.

--

-- 
To unsubscribe, send mail to awesome-devel-unsubscribe <at> naquadah.org.
Permalink | Reply | 0 comments |
headers
awesome | 1 Jun 2010 15:19
Gravatar

[awesome bugs] #749 - Override client focus hint

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#749 - Override client focus hint
User who did this - Gregor Best (farhaven)

----------
Hmm, but is it really our duty to work around broken programs (especially since Java is notorious in that
regard)? OTOH, we allow ignoring size hints, so this might be in order.
----------

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=749#comment2006

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you
did not expect this message or don't want to receive mails in future, you can change your notification
settings at the URL shown above.

--

-- 
To unsubscribe, send mail to awesome-devel-unsubscribe <at> naquadah.org.
Permalink | Reply | 0 comments |
headers
awesome | 1 Jun 2010 18:05
Gravatar

[awesome bugs] #749 - Override client focus hint

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#749 - Override client focus hint
User who did this - Uli Schlachter (psychon)

----------
I'd rather find out why this works everywhere else. I doubt a lot that this an awesome-specific issue.

That would mean we'd need someone to debug this. However, this most likely means that I would need to debug
this and I dont have time and "don't like" java a lot. :/

Just to be sure: This does not happen with any other WM, right?
----------

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=749#comment2007

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you
did not expect this message or don't want to receive mails in future, you can change your notification
settings at the URL shown above.

--

-- 
To unsubscribe, send mail to awesome-devel-unsubscribe <at> naquadah.org.
Permalink | Reply | 0 comments |
headers
awesome | 1 Jun 2010 18:05
Gravatar

[awesome bugs] #570 - The Psychon Secret Project

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#570 - The Psychon Secret Project
User who did this - Uli Schlachter (psychon)

----------
So I don't ever get to find out what this was all about? :(
----------

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=570#comment2008

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you
did not expect this message or don't want to receive mails in future, you can change your notification
settings at the URL shown above.

--

-- 
To unsubscribe, send mail to awesome-devel-unsubscribe <at> naquadah.org.
Permalink | Reply | 0 comments |
headers
Perry Hargrave | 1 Jun 2010 22:44
Picon

Re: [PATCH 2/5] tag.lua: delete() intelligently delete tags

On Sat, May 29, 2010 at 08:46:31AM +0200, Uli Schlachter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Am 29.05.2010 08:31, Uli Schlachter wrote:
> > It's nice to clean up properly, but AFAIK target_tag.screen = nil already
> > removes all clients from the affected tag. I'm not sure if it's clearer to do it
> > explicitly or not...
> 
> Seems like I'm wrong on that one....?
> 
I think you were correct. I tested with something like this:

clients = awful.tag.selected():clients()
tag.delete()
for _,c in pairs(clients) do
    for _, t in pairs(c:tags()) do
        print(c.name, t.name)
    end
end

and the deleted tag was not shown. It would feel better to verify
this other than empirically, but I didn't find it.

So here attached is something using the 'find_fallback' function. I also
added a 'feature' to try and prevent staring at selected() == nil.

Someone was opposed to doing history.restore() in my previous set but
this time I only call it if no tag is currently visible. Which I think
is just 'doing the right thing'
(Continue reading)

Permalink | Reply | 0 comments |

Gmane