Matthew Wilkes | 1 Nov 2010 11:49

Re: New features for plone.openid


On 2010-10-27, at 1726, Kai Lautaportti wrote:

> I've placed the code on github and it's available at
> 
>  http://github.com/dokai/plone.openid
> 
> so it's easier to access.

You have now forked that package and will be breaching your contributor agreement if you merge from that
repository into the main one.  Is that really what you intended?

Matthew
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
Kai Lautaportti | 1 Nov 2010 12:31
Picon
Favicon
Gravatar

Re: New features for plone.openid

Hi Matthew

On Mon, Nov 1, 2010 at 12:49 PM, Matthew Wilkes
<matt@...> wrote:
>
> On 2010-10-27, at 1726, Kai Lautaportti wrote:
>
>> I've placed the code on github and it's available at
>>
>>  http://github.com/dokai/plone.openid
>>
>> so it's easier to access.
>
> You have now forked that package and will be breaching your contributor agreement if you merge from that
repository into the main one.  Is that really what you intended?

Like I mentioned before I have not yet signed a contributor agreement
which is the reason why I was unable to create a branch for my work.
My intensions for placing my current work on github were simply to
make it easier to share the work.

In particular, there is an ongoing PLIP
(https://dev.plone.org/plone/ticket/10687) which deals with OpenID and
the work for that has taken place on github

  http://github.com/christophwarner/plone.openid
  http://github.com/christophwarner/plone.app.openid

which is why I felt it was an appropriate place to have the code while
I work on it. The overall goal would be to commit the changes to the
(Continue reading)

Wichert Akkerman | 1 Nov 2010 13:34
Gravatar

Re: New features for plone.openid

On 11/1/10 12:31 , Kai Lautaportti wrote:
> As a person who is interested in signing the contributor agreement and
> making future contributions to Plone  I have to admit I'm curious as
> how storing commits in a different repository and then merging them
> back breaches the agreement (as opposed to doing the work in
> svn.plone.org directly). Could you elaborate on this?

I don't see how that can possibly break the agreement as long as you do 
not merge any changes from others.

Wichert.

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
Plone Tests Summarizer | 1 Nov 2010 13:58
Picon

Plone Tests: 4 OK, 1 Failed

Summary of messages to the testbot list.
Period Sun Oct 31 13:00:00 2010 UTC to Mon Nov  1 13:00:00 2010 UTC.
There were 5 messages: 1 from ATContentTypes Tests, 1 from Archetypes Tests, 1 from Plone Libraries Tests,
1 from Plone Products Tests, 1 from Plone Tests.

Test failures
-------------

Subject: FAILED (97 packages, 2 failures) : Plone-4.0 Zope-2.12 Python-2.6.5
From: Plone Tests
Date: Mon Nov  1 04:38:38 CET 2010
URL: http://lists.plone.org/pipermail/testbot/2010-November/016946.html

Tests passed OK
---------------

Subject: OK : Plone-3.3 Zope-2.10 Python-2.4.6
From: Plone Products Tests
Date: Mon Nov  1 04:15:54 CET 2010
URL: http://lists.plone.org/pipermail/testbot/2010-November/016942.html

Subject: OK : Plone-3.3 Zope-2.10 Python-2.4.6
From: Plone Libraries Tests
Date: Mon Nov  1 04:20:54 CET 2010
URL: http://lists.plone.org/pipermail/testbot/2010-November/016943.html

Subject: OK : AT-1.5 Plone-3.3 Zope-2.10 Python-2.4.6
From: Archetypes Tests
Date: Mon Nov  1 04:27:10 CET 2010
URL: http://lists.plone.org/pipermail/testbot/2010-November/016944.html
(Continue reading)

Christopher Warner | 1 Nov 2010 16:22

Re: New features for plone.openid

On Mon, Nov 1, 2010 at 8:34 AM, Wichert Akkerman <wichert-5HFq4VzZ2RFeoWH0uzbU5w@public.gmane.org> wrote:

On 11/1/10 12:31 , Kai Lautaportti wrote:
> As a person who is interested in signing the contributor agreement and
> making future contributions to Plone  I have to admit I'm curious as
> how storing commits in a different repository and then merging them
> back breaches the agreement (as opposed to doing the work in
> svn.plone.org directly). Could you elaborate on this?

I don't see how that can possibly break the agreement as long as you do
not merge any changes from others.

Wichert.


What I plan on doing here is getting with Kai and merging code when and where I have something more usable but obviously I don't think anyone will be committing anything back before it's been vetted by many different parties. 

--
Christopher Warner
http://cwarner.kernelcode.com
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Plone-developers mailing list
Plone-developers@...
https://lists.sourceforge.net/lists/listinfo/plone-developers
David Glick | 1 Nov 2010 19:41
Favicon

Re: Archetypes -> Dexterity relations status

On 10/31/10 8:01 PM, toutpt wrote:
> I have worked during the ploneconf2010 sprint on this issue.
>
Thanks again for your work on making Dexterity content AT-referenceable.

You had asked me at the sprint about the fact that the ObjectRemoved
event is getting raised even if you cancel deletion of an item (and
raised twice if you actually delete it).  I looked into this and it does
appear to be because of linkintegrity, as I suspected.  There is a
function Products.CMFPlone.utils.isLinked which is called from the
delete_confirmation.cpy script when you click the delete action from the
menu. This actually tries to delete the object via manage_delObjects in
order to check if there are any references being broken.  However, it
then calls transaction.begin() which should discard all modifications so
far, so I don't think it is a problem (i.e., this object deletion takes
place but is not committed).  It might be good, however, to write a
functional test showing that if you start deleting an item in this way
and then cancel it, it is not removed from the uid_catalog.

peace,
David
----------		
David Glick
 Web Developer
 davidglick@...
 206.286.1235x32

Groundwire: You Are Connected		
 http://groundwire.org		

Online tools and stratgies for the environmental movement.  Sign up for Groundwire News!
 http://groundwire.org/email-capture
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
Wichert Akkerman | 2 Nov 2010 09:16
Gravatar

Image scaling implementation

I'm looking at some odd behaviour in the new image scaling logic in 
Plone 4: it looks like scales are not cleared when the original image is 
changed. While tracking this down I am noticing two things:

1. IImageScaleStorage was intended to be an adapter so it can support
    images stored outside the ZODB or non-ZODB content, but that feature
    appears to have gotten lost somewhere and plone.app.imaging now uses
    AnnotationStorage directly. Is that on purpose?

2. when an image (at least on a dexterity object) is updated the image
    scales are not cleared. Is that a known problem?

Wichert.

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
toutpt | 2 Nov 2010 11:13
Picon
Gravatar

Re: Archetypes -> Dexterity relations status


> I think we need to split these, since plone.app.referenceablebehavior
depends on Archetypes. So we'll either need to add UID support directly in
plone.dexterity, or have two behaviours: 
> plone.app.referenceablebehavior and plone.uidbehavior (which should be 
Plone-non-specific). 

plone.uidbehavior will be so small, I think it will be simpler to include
this code in plone.dexterity. The only dependency is plone.uuid. Let me
know, I will do it during the week.

> I thought either plone.uuid or Products.CMFPlone.CatalogTool already  had
> an indexer for UID. Is this not the case? 

No it is not the case at the moment. I think it should be in CMFPlone. I can
move that part of the code from the behavior to the CMFPlone branch during
the week.
https://svn.plone.org/svn/plone/Plone/branches/plip9938-output-filters/Products/CMFPlone/CatalogTool.py

> Thank you - this is very important work! 

Your welcome, It has been really nice for me to work on Plone with you and
David. Now I will spend more time on Plone it self.

-----
Jean-Michel François aka toutpt
http://toutpt.wordpress.com
http://twitter.com/toutpt

--

-- 
View this message in context: http://plone.293351.n2.nabble.com/Archetypes-Dexterity-relations-status-tp5691973p5696513.html
Sent from the Core Developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Plone-developers mailing list
Plone-developers <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plone-developers
toutpt | 2 Nov 2010 11:19
Picon
Gravatar

Re: Archetypes -> Dexterity relations status


> You had asked me at the sprint about the fact that the ObjectRemoved 
> ...
>  However, it then calls transaction.begin() which should discard all
> modifications so far, so I don't think it is a problem

During my tests I had message from the uid_catalog said it can't delete the
entry because it does't exists. I had already suffer from this on my
customer projects. The only workaround I have found was to  mark the object
with sth like 'first call', and check this in the handler... but I don't
want this kind of code on plone itself ...

> It might be good, however, to write a  functional test showing that if you
> start deleting an item in this way and then cancel it, it is not removed
> from the uid_catalog. 

Sure I will try to spend time on this point because, at the moment dexterity
object will not be deleted from the uid_catalog and this is not acceptable.
So first we need to add the tests.

-----
Jean-Michel François aka toutpt
http://toutpt.wordpress.com
http://twitter.com/toutpt

--

-- 
View this message in context: http://plone.293351.n2.nabble.com/Archetypes-Dexterity-relations-status-tp5691973p5696527.html
Sent from the Core Developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Plone-developers mailing list
Plone-developers <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plone-developers
Martin Aspeli | 2 Nov 2010 11:46
Picon

Re: Archetypes -> Dexterity relations status

On 2 November 2010 10:13, toutpt <toutpt@...> wrote:
>
>> I think we need to split these, since plone.app.referenceablebehavior
> depends on Archetypes. So we'll either need to add UID support directly in
> plone.dexterity, or have two behaviours:
>> plone.app.referenceablebehavior and plone.uidbehavior (which should be
> Plone-non-specific).
>
> plone.uidbehavior will be so small, I think it will be simpler to include
> this code in plone.dexterity. The only dependency is plone.uuid. Let me
> know, I will do it during the week.

Yes, I think so too. And to be honest, I'm not sure it needs to be a
behaviour: I'm happy if DexterityContent implements IAttributeUUID
always and plone.dexterity depends on plone.uuid.

>> I thought either plone.uuid or Products.CMFPlone.CatalogTool already  had
>> an indexer for UID. Is this not the case?
>
> No it is not the case at the moment. I think it should be in CMFPlone.

Yes, it probably should be, on the branch for the UUID PLIP. It should
be an indexer for IUUIDAware with the name UID returning
IUUID(context).

> I can
> move that part of the code from the behavior to the CMFPlone branch during
> the week.
> https://svn.plone.org/svn/plone/Plone/branches/plip9938-output-filters/Products/CMFPlone/CatalogTool.py

Great!

>> Thank you - this is very important work!
>
> Your welcome, It has been really nice for me to work on Plone with you and
> David. Now I will spend more time on Plone it self.

That is a very good outcome. :)

Martin

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev

Gmane