RE: Highlight current category...

>From: Amanzimtoti <amanzimtoti@...>
>
>
>I edited the list_cats() function slightly - I found this line (line 340 on
>the current nighltly build):
>
>$link = '<a href="'.get_category_link($category->cat_ID).'" ';
>
>and I changed it to this:
>
>if ( $category->cat_name == single_cat_title('', FALSE)) {
>$link = '<a href="'.get_category_link($category->cat_ID).'"
>class="current-cat" ';
>} else {
>$link = '<a href="'.get_category_link($category->cat_ID).'" ';
>}
>

Good idea!  I turned it into a little plugin that I think does the same 
thing:

function wp_current_category_class_attribute ($thelist) {
	if (!('' == single_cat_title('', FALSE))) {
		$category = single_cat_title('', FALSE);
		$string = '/(<a href.*)(>.*' . $category . ')/';
		return preg_replace("$string"," $1 class=\"current-cat\" $2",$thelist);
	}
	else return $thelist;
}
add_filter('list_cats','wp_current_category_class_attribute');

Re: UTW in 1.6

_______________________________________________
wp-testers mailing list
wp-testers@...
http://lists.automattic.com/mailman/listinfo/wp-testers

Re: Highlight current category...

On 28/10/05, Austin Matzko <ajmatzko@...> wrote:
> Good idea!  I turned it into a little plugin that I think does the same
> thing:
>
> function wp_current_category_class_attribute ($thelist) {
>         if (!('' == single_cat_title('', FALSE))) {
>                 $category = single_cat_title('', FALSE);
>                 $string = '/(<a href.*)(>.*' . $category . ')/';
>                 return preg_replace("$string"," $1 class=\"current-cat\" $2",$thelist);
>         }
>         else return $thelist;
> }
> add_filter('list_cats','wp_current_category_class_attribute');

I think it probably existed better as a core patch: as we already do
this for pages, it makes sense to do it for cats as well. Amanzimtoti,
if you submitted the core patch with Ryan's suggestions to Trac, it'd
almost certainly get included.

Great work!

--
-David House, dmhouse@..., http://xmouse.ithium.net

Re: Highlight current category...

I think the plugin is a good idea for current users of Wordpress, but
it would be good to commit this into the code for future versions. I
tried Ryan's code but got errors so maybe I did something wrong. If
others can come up with a working solution then I will put it into the
Trac system.

Cheers - Stuart.

p.s. changed my Gmail preferences so my name should show up properly
in the from address.

On 10/28/05, David House <dmhouse@...> wrote:
> On 28/10/05, Austin Matzko <ajmatzko@...> wrote:
> > Good idea!  I turned it into a little plugin that I think does the same
> > thing:
> >
> > function wp_current_category_class_attribute ($thelist) {
> >         if (!('' == single_cat_title('', FALSE))) {
> >                 $category = single_cat_title('', FALSE);
> >                 $string = '/(<a href.*)(>.*' . $category . ')/';
> >                 return preg_replace("$string"," $1 class=\"current-cat\" $2",$thelist);
> >         }
> >         else return $thelist;
> > }
> > add_filter('list_cats','wp_current_category_class_attribute');
>
> I think it probably existed better as a core patch: as we already do
> this for pages, it makes sense to do it for cats as well. Amanzimtoti,
> if you submitted the core patch with Ryan's suggestions to Trac, it'd
> almost certainly get included.
>
> Great work!
>
> --
> -David House, dmhouse@..., http://xmouse.ithium.net
> _______________________________________________
> wp-testers mailing list
> wp-testers@...
> http://lists.automattic.com/mailman/listinfo/wp-testers
>

Re: Highlight current category...

Stuart wrote:
> I think the plugin is a good idea for current
>  users of Wordpress, but it would be good to
> commit this into the code for future versions.

May I suggest that when adding this, a
"decorate_category" hook is added so that other
plugins can intercept or  add to the default
decoration.

Rich
--
http://boakes.org

Re: Highlight current category...

On 28/10/05, Stuart <amanzimtoti@...> wrote:
> I think the plugin is a good idea for current users of Wordpress, but
> it would be good to commit this into the code for future versions. I
> tried Ryan's code but got errors so maybe I did something wrong. If
> others can come up with a working solution then I will put it into the
> Trac system.

Patch attached.

--
-David House, dmhouse@..., http://xmouse.ithium.net

_______________________________________________
wp-testers mailing list
wp-testers@...
http://lists.automattic.com/mailman/listinfo/wp-testers

Re: Highlight current category...

Thanks David!

I've raised a ticket in the Trac system - number 1800 -
http://trac.wordpress.org/ticket/1800

This is the first time I've used Trac so please have a look at it and
see if it is ok.

Cheers - Stuart.

On 10/28/05, David House <dmhouse@...> wrote:
> On 28/10/05, Stuart <amanzimtoti@...> wrote:
> > I think the plugin is a good idea for current users of Wordpress, but
> > it would be good to commit this into the code for future versions. I
> > tried Ryan's code but got errors so maybe I did something wrong. If
> > others can come up with a working solution then I will put it into the
> > Trac system.
>
> Patch attached.
>
> --
> -David House, dmhouse@..., http://xmouse.ithium.net
>
>
> _______________________________________________
> wp-testers mailing list
> wp-testers@...
> http://lists.automattic.com/mailman/listinfo/wp-testers
>
>
>
>

Re: Highlight current category...

On 28/10/05, Stuart <amanzimtoti@...> wrote:
> This is the first time I've used Trac so please have a look at it and
> see if it is ok.

Looks good. Anyone want to test this? Then we can poke a bug gardener
and get it in line for a commit.

--
-David House, dmhouse@..., http://xmouse.ithium.net

Re: Highlight current category...

Needless to say, I've tested it. I removed my original hack and made
the changes in the diff file and it works a treat.

On 10/29/05, David House <dmhouse@...> wrote:
> On 28/10/05, Stuart <amanzimtoti@...> wrote:
> > This is the first time I've used Trac so please have a look at it and
> > see if it is ok.
>
> Looks good. Anyone want to test this? Then we can poke a bug gardener
> and get it in line for a commit.
>
> --
> -David House, dmhouse@..., http://xmouse.ithium.net
> _______________________________________________
> wp-testers mailing list
> wp-testers@...
> http://lists.automattic.com/mailman/listinfo/wp-testers
>

Import

_______________________________________________
wp-testers mailing list
wp-testers@...
http://lists.automattic.com/mailman/listinfo/wp-testers