Devel Tools | 1 Feb 2010 03:00
Favicon

git changes 2010-02-01


Good Morning!

This are the git changes for DokuWiki committed
yesterday. Please test them and report bugs.

---------------------------------------------------------------------

http://github.com/splitbrain/dokuwiki/commit/fcd3bb7cfe60027407e0af2ec83fafbf89758e9c
Author: Andreas Gohr <andi[at]splitbrain.org>
Date:   Sun Jan 31 18:00:38 2010 +0100

    fixed file header

http://github.com/splitbrain/dokuwiki/commit/46d41845ed1f3e722a11e31b866023973545fd7c
Author: Andreas Gohr <andi[at]splitbrain.org>
Date:   Sun Jan 31 17:57:35 2010 +0100

    fixed call-time pass-by-reference warning

---------------------------------------------------------------------

You can download individual diffs or patches by appending .diff or
.patch to the given commit URLs above.

Bye,
your git changelog mailer

--

-- 
DokuWiki mailing list - more info at
(Continue reading)

Carsten Fuchs | 1 Feb 2010 15:19
Picon
Favicon

Re: Text editor buttons ceased to work after recent upgrade

Hi all,

On 29.01.2010 17:59, Carsten Fuchs wrote:
> after the recent upgrade of DokuWiki to version 2009-12-25c "Lemming",
> the text editor buttons ceased to work.

Argh, sorry, this was a Javascript conflict with the template that I embedded the DokuWiki instance 
in. Removed the Javascript of the non-Dokuwiki parts (RokMooMenu plus MooTools in this case), and 
now it works again.

Sorry for the noise.

Best regards (and a thousand thanks for DokuWiki!),
Carsten

--

-- 
    Cafu - the open-source Game and Graphics Engine
for multiplayer, cross-platform, real-time 3D Action
               Learn more at www.cafu.de

Attachment (smime.p7s): application/pkcs7-signature, 5146 bytes
aliasonline | 1 Feb 2010 15:46
Picon

Re: javascript showing in edit mode


On Jan 29, 2010, at 5:16 PM, Guy Brand wrote:

On jan 29, aliasonline <at> mac.com wrote:

I have the latest version of DW installed on Windows IIS server.   
Since the upgrade I see the following piece of code in the edit mode  
(right below the toolbar):

script type='javascript'>window.cancelToExit=true

How do I fix the problem?

Try to "touch" your local.php config file so that the pages are no
longer read from cache, but reparsed. I faced something similar which
was related to a plugin that I removed after a few days of tests and
which was pouring javascript in the cached pages thus disturbing the
editor.

Please note that I have no idea how to touch the local.php file on
Windows, but editing and saving the file should work.

bug

I did touch up for local.php but still no luck.  I forgot to mention that I'm using Monobook template.

Corey
M. Sabath | 1 Feb 2010 16:08
Picon
Picon

Re: MySQL and Dokuwiki

Am Donnerstag, den 28.01.2010, 10:51 +0100 schrieb M. Sabath:
> Am Donnerstag, den 17.12.2009, 11:23 +0100 schrieb Matthias Grimm:
> > On Wed, 16 Dec 2009 04:28:35 +0100
> > "M. Sabath" <msabath <at> gmx.de> wrote:
> > 
> > Hi Markus,
> > 
> > > table name is "egw_adrress" 
> > > an the 
> > > column name is "subject" 
> > > 
> > > How do I ask mysql for the information?#
> > 
> > To get a link from the "subject" to your user you need a reference from one table to the other.
> > This is a commin field like username or something similar.
> > 
> > Here is the SQL statement:
> > $conf['auth']['mysql']['getGroups']   = "SELECT subject as `group`
> > 		                                                    FROM egw_address g, egw_accounts u
> >                                                                 WHERE u.account_id = g.account_id
> >                                                                       AND u.account_id='%{user}'";
> > 
> > The statement does the following: 
> > The result of the statement is a table which contains the field "subject" named as "group".
> > The data came from the two tables "egw_address" and "egw_accounts". For both tables
> > aliases were set ("g" and "u") to make life easier. Now comes the tricky part. We have to tell
> > MySQL how the two tables are connected; which row in egw_address belongs to which
> > row in egw_accounts. I assumed that  the column "account_id" exists in both tables. Keep
> > in mind that this relation must not be unique. A row in "egw_accounts" may have multiple
> > counterparts in "egw_address", but this depends on the dabase design.
> > Last but not least we have to make shure that obly groups that belong to our user will be
> > returned, so we add a condition to check that to the WHERE statement.
> > 
> > I hope my explanation will help you to play a bit with the statement and find one that works
> > for you. I could only provide a full statement, if I knew the complete database model.
> > 
> >  Best Regards
> >    Matthias
> 
> 
> Hello Matthias,
> 
> thank your for your time and advice.
> I had to adjust it a little bit.
> 
> 
> > I assumed that the column "account_id" exists in both tables.
> The columns have different names.
> 
> Markus
> 
> 

this is my again,

it doesn't work as I thought.
The two tables aren't related. 

-------------------------

My goal is, that every user in the table "egw_accounts" is allowed to
see and edit the dokuwiki pages. All others aren't allowed to see and
edit pages.

The table "egw_accounts" has no column where I could put in the entry
"user". All it has is a column "primary_group" with the entry "u" for
all users.

Here is my question:

* Is there a mysql statement which makes "user" out of the "u" while
questioning the database.

or

* Cant't every user in the table be a member of the group "user" by
default without checking?

Thank you

Markus

--

-- 
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Devel Tools | 2 Feb 2010 03:00
Favicon

git changes 2010-02-02


Good Morning!

This are the git changes for DokuWiki committed
yesterday. Please test them and report bugs.

---------------------------------------------------------------------

http://github.com/splitbrain/dokuwiki/commit/f8f3bfb0816ee4940fd5efe295903a0f6b5e03f8
Author: Adrian Lang <lang[at]cosmocode.de>
Date:   Mon Feb 1 11:56:51 2010 +0100

    Add tests for em from old bug reports (failing)

http://github.com/splitbrain/dokuwiki/commit/eba9da2d4784b9ff1fb8cdc545118a081c546e93
Author: Adrian Lang <lang[at]cosmocode.de>
Date:   Mon Feb 1 11:39:00 2010 +0100

    Fix auth_ismanager calls in test cases

---------------------------------------------------------------------

You can download individual diffs or patches by appending .diff or
.patch to the given commit URLs above.

Bye,
your git changelog mailer

--

-- 
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Kazutaka Miyasaka | 2 Feb 2010 16:51
Picon

Re: New subscription handling

Hi Adrian,

2010/1/29 Adrian Lang <lang <at> cosmocode.de>:

> did you read my feature request [1] and my mailing list post [2] on
> this topic? I think this implementation might support your use case as
> well.

Yes I read it. But I guess I don't get it.

Adding an ID to a button or marking target elements are of
course a welcome step. However the point of my concern is the
button position.

Currently your code appears to result in:

  <table>...</table>
  <div class="secedit"></div>

But I'd like to choose either:

  <table>...</table>
  <div class="secedit">...</div>

    or

  <div class="secedit">...</div>
  <table>...</table>

Is that possible in your planned implementation? I read your
posts, but I'm not sure that is possible or not.

Regards,
kazmiya
--

-- 
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Julian Knauer | 2 Feb 2010 18:26
Picon
Gravatar

Re: New subscription handling

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I don't know if it has been fixed somewhere else already, but I tried use the
current git head (bd6dc08ec192a3ef891b0488f43bf86f95dd621f) of the discussion
plugin with dokuwiki commit f8f3bfb0816ee4940fd5efe295903a0f6b5e03f8.

For me it seems discussion is still using the old function to geht the
subscribtions. Patch attached.


diff --git a/action.php b/action.php
index 9b192bb..1b92ba9 100644
- --- a/action.php
+++ b/action.php
 <at>  <at>  -1103,7 +1103,7  <at>  <at>  class action_plugin_discussion extends
DokuWiki_Action_Plugin{
 
         // notify page subscribers
         if ($conf['subscribers'] || $conf['notify']) {
- -            $list = explode(',', subscriber_addresslist($ID));
+            $list = explode(',', subscription_addresslist($ID));
             $to   = (!empty($conf['notify'])) ? $conf['notify'] : array_pop($list);
             $bcc  = implode(',', $list);
 




- -- 

Julian Knauer

Email : jpk <at> goatpr0n.de
WWW   : http://wiki.goatpr0n.de

Jabber: jaypikay <at> via.im
key-id: 0x89E3BCB6

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAktoYD8ACgkQYsx2O4njvLaFxQCePBfbSFMa7WqFlmEYTkiA49F4
IbYAnRv5PEUZA/gd6MrCAW4ufq7bI+5Z
=JwNz
-----END PGP SIGNATURE-----
.Z)"x%fmh"*+XX
Andreas Gohr | 2 Feb 2010 20:00
Favicon
Gravatar

new include handling

Hi *,

as you may have noticed, I opened a new git branch called
'requireall'. There I started to implement a feature Chris and I
talked about several times for the last two years.

The patches remove all the various occurrences of require_once() from
the different core files. Instead *all* files are loaded from a file
called inc/load.php which itself is loaded from within inc/init.php

Classes are loaded through PHP5's autoload mechanism, all other files
are just included by default. Plugins and other script files do no
longer need to require any other file than inc/init.php

The ideas behind that move are the following:

* require_once is very slow in PHP, skipping all the unnecessary
requires should give a tiny performance boost
* most of the includes are loaded anyway during a normal DokuWiki
call, so why not just load them all at once?
* plugin authors do not need to care about loading any core libraries
- all core functionality is automagically available

The last point is the most important for me. Personally I had plugins
not working for others when they worked perfectly for me. The cause
often was a second plugin installed on my setup, that had already
loaded a library the plugin in question was missing. An error that is
easily avoided by the new system.

The new branch is available at github for testing
http://github.com/splitbrain/dokuwiki/tree/requireall

There are things I'd like to get:

* feedback/bugreports if I accidentally broke something
* improvement patches (I probably missed a few things that should be
updated for the new mechanism)
* benchmarks (are there any measurable speed improvements?)
* nice before/after graphs created with http://pecl.php.net/package/inclued
* any rationale why this should not be merged into the master branch

Andi

-- 
splitbrain.org
--

-- 
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Devel Tools | 3 Feb 2010 03:00
Favicon

git changes 2010-02-03


Good Morning!

This are the git changes for DokuWiki committed
yesterday. Please test them and report bugs.

---------------------------------------------------------------------

http://github.com/splitbrain/dokuwiki/commit/c1b2e736c1da490219a060dd52104c4f88e70f7e
Author: Sergio Motta <sergio[at]cisne.com.br>
Date:   Tue Feb 2 21:02:48 2010 +0100

    Portuguese language update

---------------------------------------------------------------------

You can download individual diffs or patches by appending .diff or
.patch to the given commit URLs above.

Bye,
your git changelog mailer

--

-- 
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Michael Klier | 3 Feb 2010 11:42
Picon
Favicon
Gravatar

Re: New subscription handling

On Tue, Feb 02, 2010 at 06:26:23PM +0100, Julian Knauer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> I don't know if it has been fixed somewhere else already, but I tried use the
> current git head (bd6dc08ec192a3ef891b0488f43bf86f95dd621f) of the discussion
> plugin with dokuwiki commit f8f3bfb0816ee4940fd5efe295903a0f6b5e03f8.
> 
> For me it seems discussion is still using the old function to geht the
> subscribtions. Patch attached.

Thx,

this hasn't been fixed in the discussion plugin yet. I'll apply your patch
ASAP.

--

-- 
Michael Klier

www:    http://www.chimeric.de
jabber: chi <at> jabber.shipdown.de
key:    http://downloads.chimeric.de/chi.asc
key-id: 0x8308F551

Gmane