20 Jan 2009 23:54
Twill is not working as expected
Hi,
I am trying to test Google OpenID Auth with twill, but getting an unexpected URLError because of quotes in refresh url that google inserts in response's header (Refresh: 0; url='http://www.google.com/...' , notice single quotes). I don't know is it a google's bug or twill's feature :). I propose this simple patch:
--- /usr/lib/python2.5/site-packages/twill-0.9-py2.5.egg/twill/other_packages/_mechanize_dist/_request.py 2009-01-21 00:34:17.000000000 +0200
+++ /home/sergey/dev/sandbox/_request.py 2009-01-21 00:25:35.000000000 +0200
<at> <at> -31,7 +31,10 <at> <at> class Request(urllib2.Request):
if not _rfc3986.is_clean_uri(url):
warn("url argument is not a URI "
"(contains illegal characters) %r" % url)
- urllib2.Request.__init__(self, url, data, headers)
+ if url[0]=="'" and url[-1]=="'":
+ url = url[1:-1]
+
+ urllib2.Request.__init__(self, url, data, headers)
self.selector = None
self.unredirected_hdrs = {}
self.visit = visit
Can anyone help me with not-so-dirty solution?
Regards,
Sergey Kishchenko
I am trying to test Google OpenID Auth with twill, but getting an unexpected URLError because of quotes in refresh url that google inserts in response's header (Refresh: 0; url='http://www.google.com/...' , notice single quotes). I don't know is it a google's bug or twill's feature :). I propose this simple patch:
--- /usr/lib/python2.5/site-packages/twill-0.9-py2.5.egg/twill/other_packages/_mechanize_dist/_request.py 2009-01-21 00:34:17.000000000 +0200
+++ /home/sergey/dev/sandbox/_request.py 2009-01-21 00:25:35.000000000 +0200
<at> <at> -31,7 +31,10 <at> <at> class Request(urllib2.Request):
if not _rfc3986.is_clean_uri(url):
warn("url argument is not a URI "
"(contains illegal characters) %r" % url)
- urllib2.Request.__init__(self, url, data, headers)
+ if url[0]=="'" and url[-1]=="'":
+ url = url[1:-1]
+
+ urllib2.Request.__init__(self, url, data, headers)
self.selector = None
self.unredirected_hdrs = {}
self.visit = visit
Can anyone help me with not-so-dirty solution?
Regards,
Sergey Kishchenko
_______________________________________________ twill mailing list twill@... http://lists.idyll.org/listinfo/twill
RSS Feed