GitHub | 22 May 2013 23:43

[bagder/curl] 520833: ossl_recv: SSL_read() returning 0 is an error too

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 520833cbe1601feed1c6473bd28c4c894e7ee63e
      https://github.com/bagder/curl/commit/520833cbe1601feed1c6473bd28c4c894e7ee63e
  Author: Mike Giancola <mikegiancola <at> gmail.com>
  Date:   2013-05-22 (Wed, 22 May 2013)

  Changed paths:
    M lib/ssluse.c

  Log Message:
  -----------
  ossl_recv: SSL_read() returning 0 is an error too

SSL_read can return 0 for "not successful", according to the open SSL
documentation: http://www.openssl.org/docs/ssl/SSL_read.html

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 22 May 2013 23:15

[bagder/curl] e58d9c: ossl_send: SSL_write() returning 0 is an error too

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: e58d9c87f783334b01310260e0cf5220c338c58c
      https://github.com/bagder/curl/commit/e58d9c87f783334b01310260e0cf5220c338c58c
  Author: Mike Giancola <mikegiancola <at> gmail.com>
  Date:   2013-05-22 (Wed, 22 May 2013)

  Changed paths:
    M lib/ssluse.c

  Log Message:
  -----------
  ossl_send: SSL_write() returning 0 is an error too

We found that in specific cases if the connection is abruptly closed,
the underlying socket is listed in a close_wait state. We continue to
call the curl_multi_perform, curl_mutli_fdset etc. None of these APIs
report the socket closed / connection finished.  Since we have cases
where the multi connection is only used once, this can pose a problem
for us. I've read that if another connection was to come in, curl would
see the socket as bad and attempt to close it at that time -
unfortunately, this does not work for us.

I found that in specific situations, if SSL_write returns 0, curl did
not recognize the socket as closed (or errored out) and did not report
it to the application. I believe we need to change the code slightly, to
check if ssl_write returns 0. If so, treat it as an error - the same as
a negative return code.

For OpenSSL - the ssl_write documentation is here:
(Continue reading)

GitHub | 21 May 2013 23:59

[bagder/curl] 84f799: KNOWN_BUGS: curl -OJC- fails to resume

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 84f799147431a15d1efc86654950408120adad22
      https://github.com/bagder/curl/commit/84f799147431a15d1efc86654950408120adad22
  Author: Daniel Stenberg <daniel <at> haxx.se>
  Date:   2013-05-21 (Tue, 21 May 2013)

  Changed paths:
    M docs/KNOWN_BUGS

  Log Message:
  -----------
  KNOWN_BUGS: curl -OJC- fails to resume

Bug: http://curl.haxx.se/bug/view.cgi?id=1169

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 21 May 2013 23:35

[bagder/curl] 85b9dc: Curl_cookie_add: handle IPv6 hosts

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 85b9dc80232d1d7d48ee4dea6db5a2263ee68efd
      https://github.com/bagder/curl/commit/85b9dc80232d1d7d48ee4dea6db5a2263ee68efd
  Author: Daniel Stenberg <daniel <at> haxx.se>
  Date:   2013-05-21 (Tue, 21 May 2013)

  Changed paths:
    M lib/cookie.c

  Log Message:
  -----------
  Curl_cookie_add: handle IPv6 hosts

1 - don't skip host names with a colon in them in an attempt to bail out
on HTTP headers in the cookie file parser. It was only a shortcut anyway
and trying to parse a file with HTTP headers will still be handled, only
slightly slower.

2 - don't skip domain names based on number of dots. The original
netscape cookie spec had this oddity mentioned and while our code
decreased the check to only check for two, the existing cookie spec has
no such dot counting required.

Bug: http://curl.haxx.se/bug/view.cgi?id=1221
Reported-by: Stefan Neis

_______________________________________________
(Continue reading)

GitHub | 20 May 2013 10:51

[bagder/curl] 7d4d48: curl_easy_setopt.3: expand the PROGRESSFUNCTION se...

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 7d4d4892d8cddd14ab48db9991db893035a7a938
      https://github.com/bagder/curl/commit/7d4d4892d8cddd14ab48db9991db893035a7a938
  Author: Daniel Stenberg <daniel <at> haxx.se>
  Date:   2013-05-20 (Mon, 20 May 2013)

  Changed paths:
    M docs/libcurl/curl_easy_setopt.3

  Log Message:
  -----------
  curl_easy_setopt.3: expand the PROGRESSFUNCTION section

Explain the callback and its arguments better and with more descriptive
text.

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 19 May 2013 12:45

[bagder/curl] fc4759: tests: add test1394 file to the tarball

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: fc4759af9d9cbc7635af0da68c28672a4bbf35ff
      https://github.com/bagder/curl/commit/fc4759af9d9cbc7635af0da68c28672a4bbf35ff
  Author: Daniel Stenberg <daniel <at> haxx.se>
  Date:   2013-05-19 (Sun, 19 May 2013)

  Changed paths:
    M tests/data/Makefile.am

  Log Message:
  -----------
  tests: add test1394 file to the tarball

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 19 May 2013 11:22

[bagder/curl] ee84c4: tarball: include the xmlstream example

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: ee84c47655e8bed035b5e9a85eb11f1f0b5df5e2
      https://github.com/bagder/curl/commit/ee84c47655e8bed035b5e9a85eb11f1f0b5df5e2
  Author: Daniel Stenberg <daniel <at> haxx.se>
  Date:   2013-05-19 (Sun, 19 May 2013)

  Changed paths:
    M docs/examples/Makefile.inc

  Log Message:
  -----------
  tarball: include the xmlstream example

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 19 May 2013 11:20

[bagder/curl] ce3217: xmlstream: XML stream parsing example source code

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: ce32176db749b40691c7fb08a1cb2ff184b4794e
      https://github.com/bagder/curl/commit/ce32176db749b40691c7fb08a1cb2ff184b4794e
  Author: David Strauss <david <at> davidstrauss.net>
  Date:   2013-05-19 (Sun, 19 May 2013)

  Changed paths:
    M docs/examples/.gitignore
    M docs/examples/README
    A docs/examples/xmlstream.c

  Log Message:
  -----------
  xmlstream: XML stream parsing example source code

Add an XML stream parsing example using Expat. Add missing ignore for
the binary from an unrelated example.

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 18 May 2013 22:55

[bagder/curl] 04f52e: cookies: only consider full path matches

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 04f52e9b4db01bcbf672c9c69303a4e4ad0d0fb9
      https://github.com/bagder/curl/commit/04f52e9b4db01bcbf672c9c69303a4e4ad0d0fb9
  Author: YAMADA Yasuharu <yasuharu.yamada <at> access-company.com>
  Date:   2013-05-18 (Sat, 18 May 2013)

  Changed paths:
    M lib/cookie.c
    M tests/data/Makefile.am
    A tests/data/test1228
    M tests/data/test46
    M tests/data/test8

  Log Message:
  -----------
  cookies: only consider full path matches

I found a bug which cURL sends cookies to the path not to aim at.
For example:
- cURL sends a request to http://example.fake/hoge/
- server returns cookie which with path=/hoge;
  the point is there is NOT the '/' end of path string.
- cURL sends a request to http://example.fake/hogege/ with the cookie.

The reason for this old "feature" is because that behavior is what is
described in the original netscape cookie spec:
http://curl.haxx.se/rfc/cookie_spec.html

The current cookie spec (RFC6265) clarifies the situation:
(Continue reading)

GitHub | 16 May 2013 20:28

[bagder/curl] 100a33: axtls: prevent memleaks on SSL handshake failures

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 100a33f7ff8bd7dec1fe4b50bed57626a86c6b87
      https://github.com/bagder/curl/commit/100a33f7ff8bd7dec1fe4b50bed57626a86c6b87
  Author: Eric Hu <EHu <at> directv.com>
  Date:   2013-05-16 (Thu, 16 May 2013)

  Changed paths:
    M lib/axtls.c

  Log Message:
  -----------
  axtls: prevent memleaks on SSL handshake failures

_______________________________________________
curl-commits mailing list
curl-commits <at> cool.haxx.se
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-commits
GitHub | 12 May 2013 15:12

[bagder/curl] 7ed25c: Revert "WIN32 MemoryTracking: track wcsdup() _wcsd...

  Branch: refs/heads/master
  Home:   https://github.com/bagder/curl
  Commit: 7ed25ccf0d1e5b8c7fd3bd90f0375a06011cd394
      https://github.com/bagder/curl/commit/7ed25ccf0d1e5b8c7fd3bd90f0375a06011cd394
  Author: Daniel Stenberg <daniel <at> haxx.se>
  Date:   2013-05-12 (Sun, 12 May 2013)

  Changed paths:
    M lib/curl_memory.h
    M lib/curl_setup.h
    M lib/easy.c
    M lib/memdebug.c
    M lib/memdebug.h
    M tests/memanalyze.pl
    M tests/server/getpart.c

  Log Message:
  -----------
  Revert "WIN32 MemoryTracking: track wcsdup() _wcsdup() and _tcsdup() usage"

This reverts commit 8ec2cb5544b86306b702484ea785b6b9596562ab.

We don't have any code anywhere in libcurl (or the curl tool) that use
wcsdup so there's no such memory use to track. It seems to cause mild
problems with the Borland compiler though that we may avoid by reverting
this change again.

Bug: http://curl.haxx.se/mail/lib-2013-05/0070.html

(Continue reading)


Gmane