The file browser strings appear to be set with a macro also, which is
probably why the tool can't find them:

#define SET_STRING(ns, id) \
 dict->SetString(#id, l10n_util::GetStringUTF16(ns##_##id))

SET_STRING(IDS_FILE_BROWSER, ROOT_DIRECTORY_LABEL);

Tue, Nov 29, 2011 at 9:56 PM, Yusuke Sato <yusukes <at> google.com> wrote:
> Yes. I think (most of the) IDS_OPTIONS_SETTINGS_LANGUAGES_MOZC_* are still
> in use. It seems that they are detected as unused since the IDs are
> generated by the following macro to make the IDs less than 80 chars:
>
>   #define IDS_MOZC(suffic) \
>     IDS_OPTIONS_SETTINGS_LANGUAGES_MOZC_##suffix

Hi all,

I've been trying to diagnose this issue all day with no luck, why is Chromium failing to link on Windows? Am I doing something wrong or was the build broken all day?

Here's some of the error spew:

29>chrome_main_delegate.obj : error LNK2019: unresolved external symbol "public: static void __cdecl content::RenderProcessHost::set_run_renderer_in_process(bool)" (?set_run_renderer_in_process <at> RenderProcessHost <at> content <at> <at> SAX_N <at> Z) referenced in function "public: virtual void __thiscall ChromeMainDelegate::PreSandboxStartup(void)" (?PreSandboxStartup <at> ChromeMainDelegate <at> <at> UAEXXZ)

29>browser.lib(chrome_content_browser_client.obj) : error LNK2019: unresolved external symbol "public: class content::RenderProcessHost * __thiscall SiteInstance::GetProcess(void)" (?GetProcess <at> SiteInstance <at> <at> QAEPAVRenderProcessHost <at> content <at> <at> XZ) referenced in function "public: virtual void __thiscall chrome::ChromeContentBrowserClient::SiteInstanceGotProcess(class SiteInstance *)" (?SiteInstanceGotProcess <at> ChromeContentBrowserClient <at> chrome <at> <at> UAEXPAVSiteInstance <at> <at> <at> Z)

29>browser.lib(render_view_host_delegate_helper.obj) : error LNK2001: unresolved external symbol "public: class content::RenderProcessHost * __thiscall SiteInstance::GetProcess(void)" (?GetProcess <at> SiteInstance <at> <at> QAEPAVRenderProcessHost <at> content <at> <at> XZ)

29>browser.lib(extension_message_service.obj) : error LNK2001: unresolved external symbol "public: class content::RenderProcessHost * __thiscall SiteInstance::GetProcess(void)" (?GetProcess <at> SiteInstance <at> <at> QAEPAVRenderProcessHost <at> content <at> <at> XZ)

29>browser.lib(tracking_synchronizer.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(visitedlink_event_listener.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(chrome_plugin_message_filter.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(prerender_manager.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(extension_message_service.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(web_cache_manager.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(chrome_content_browser_client.obj) : error LNK2019: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z) referenced in function "public: virtual void __thiscall chrome::ChromeContentBrowserClient::AppendExtraCommandLineSwitches(class CommandLine *,int)" (?AppendExtraCommandLineSwitches <at> ChromeContentBrowserClient <at> chrome <at> <at> UAEXPAVCommandLine <at> <at> H <at> Z)

29>browser.lib(spellcheck_message_filter.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

Thanks,

Fady

--
Chromium Developers mailing list: chromium-dev <at> chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

have you tried a clean build?

On Wed, Nov 30, 2011 at 4:41 PM, Fady Samuel <fsamuel <at> chromium.org> wrote:

Hi all,

I've been trying to diagnose this issue all day with no luck, why is Chromium failing to link on Windows? Am I doing something wrong or was the build broken all day?

Here's some of the error spew:

29>chrome_main_delegate.obj : error LNK2019: unresolved external symbol "public: static void __cdecl content::RenderProcessHost::set_run_renderer_in_process(bool)" (?set_run_renderer_in_process <at> RenderProcessHost <at> content <at> <at> SAX_N <at> Z) referenced in function "public: virtual void __thiscall ChromeMainDelegate::PreSandboxStartup(void)" (?PreSandboxStartup <at> ChromeMainDelegate <at> <at> UAEXXZ)

29>browser.lib(chrome_content_browser_client.obj) : error LNK2019: unresolved external symbol "public: class content::RenderProcessHost * __thiscall SiteInstance::GetProcess(void)" (?GetProcess <at> SiteInstance <at> <at> QAEPAVRenderProcessHost <at> content <at> <at> XZ) referenced in function "public: virtual void __thiscall chrome::ChromeContentBrowserClient::SiteInstanceGotProcess(class SiteInstance *)" (?SiteInstanceGotProcess <at> ChromeContentBrowserClient <at> chrome <at> <at> UAEXPAVSiteInstance <at> <at> <at> Z)

29>browser.lib(render_view_host_delegate_helper.obj) : error LNK2001: unresolved external symbol "public: class content::RenderProcessHost * __thiscall SiteInstance::GetProcess(void)" (?GetProcess <at> SiteInstance <at> <at> QAEPAVRenderProcessHost <at> content <at> <at> XZ)

29>browser.lib(extension_message_service.obj) : error LNK2001: unresolved external symbol "public: class content::RenderProcessHost * __thiscall SiteInstance::GetProcess(void)" (?GetProcess <at> SiteInstance <at> <at> QAEPAVRenderProcessHost <at> content <at> <at> XZ)

29>browser.lib(tracking_synchronizer.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(visitedlink_event_listener.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(chrome_plugin_message_filter.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(prerender_manager.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(extension_message_service.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(web_cache_manager.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

29>browser.lib(chrome_content_browser_client.obj) : error LNK2019: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z) referenced in function "public: virtual void __thiscall chrome::ChromeContentBrowserClient::AppendExtraCommandLineSwitches(class CommandLine *,int)" (?AppendExtraCommandLineSwitches <at> ChromeContentBrowserClient <at> chrome <at> <at> UAEXPAVCommandLine <at> <at> H <at> Z)

29>browser.lib(spellcheck_message_filter.obj) : error LNK2001: unresolved external symbol "public: static class content::RenderProcessHost * __cdecl content::RenderProcessHost::FromID(int)" (?FromID <at> RenderProcessHost <at> content <at> <at> SAPAV12 <at> H <at> Z)

Thanks,

Fady

--
Chromium Developers mailing list: chromium-dev <at> chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

During a code review, I was considering proposing to use a shared cache of immutable data and guarding the cache with a SWMR lock. Surprisingly, I haven't seen an implementation inside src/base/synchronization. Did I miss it?

SWMR locks are useful for shared data where the ratio between writes/reads is below 10% like for caches. In my particular case, the data is immutable so the ratio is even better than that since it's append-only. Using a standard lock increases the contention significantly without any benefit.

Using a pure append-only structure is tricky in C++, the STL doesn't provide anything near that with a fast lookup.

Any pointers? There is an implementation in third_party/tcmalloc/chromium/src/base/simple_mutex.h but it's only partial, e.g. it's falling back to a standard CriticalSection on windows (!). It's especially surprising from a memory heap implementation.

M-A

--
Chromium Developers mailing list: chromium-dev <at> chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

On Thu, Dec 1, 2011 at 6:21 PM, Marc-Antoine Ruel <maruel <at> chromium.org> wrote:

During a code review, I was considering proposing to use a shared cache of immutable data and guarding the cache with a SWMR lock. Surprisingly, I haven't seen an implementation inside src/base/synchronization. Did I miss it?

SWMR locks are useful for shared data where the ratio between writes/reads is below 10% like for caches. In my particular case, the data is immutable so the ratio is even better than that since it's append-only. Using a standard lock increases the contention significantly without any benefit.

Have you benchmarked it? Reader-writer locks are frequently slower than simple spin locks.

Using a pure append-only structure is tricky in C++, the STL doesn't provide anything near that with a fast lookup.

Any pointers? There is an implementation in third_party/tcmalloc/chromium/src/base/simple_mutex.h but it's only partial, e.g. it's falling back to a standard CriticalSection on windows (!). It's especially surprising from a memory heap implementation.

M-A

--
Chromium Developers mailing list: chromium-dev <at> chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev