headers
Hans de Goede | 3 Aug 2009 10:09
Picon

Re: Syntek Driver ...

On 07/27/2009 09:30 PM, Clinton Lee Taylor wrote:
> Greetings ...
>
>   I was wondering if anybody has looked at the Syntek Driver stk11xx at
> http://sourceforge.net/projects/syntekdriver/files/ ... This driver is
> meant to have updates for the EasyCap USB video capture device ...
> Would be great to have included in the main line Video4Linux and then
> up stream Kernel ... Pretty please!!
>
> Mailed
> LeeT
>

Hi,

1) The video4linux-list <at> redhat.com list is no longer in use, please
    resend your mail to Linux Media Mailing List <linux-media <at> vger.kernel.org>

2) Getting this driver upstream requires someone who owns the actual hardware
    to drive this, are you willing to do that ?

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request <at> redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
(Continue reading)

Permalink | Reply | 1 comment |
headers
Clinton Lee Taylor | 3 Aug 2009 10:40
Picon

Re: Syntek Driver ...

Greetings ...

2009/8/3 Hans de Goede <j.w.r.degoede <at> hhs.nl>:
> On 07/27/2009 09:30 PM, Clinton Lee Taylor wrote:
>>
>> Greetings ...
>>
>>  I was wondering if anybody has looked at the Syntek Driver stk11xx at
>> http://sourceforge.net/projects/syntekdriver/files/ ... This driver is
>> meant to have updates for the EasyCap USB video capture device ...
>> Would be great to have included in the main line Video4Linux and then
>> up stream Kernel ... Pretty please!!
>
> Hi,
 Thanks for the reply ...

> 1) The video4linux-list <at> redhat.com list is no longer in use, please
>   resend your mail to Linux Media Mailing List <linux-media <at> vger.kernel.org>
 Okay, going to subscribe to this list tonight ...

> 2) Getting this driver upstream requires someone who owns the actual
> hardware
>   to drive this, are you willing to do that ?
 I have this hardware and willing to try and test and report back, but
I'm not a kernel programmer ... More an intergrator ... Have two
options, either I could arrange a purchase of a unit for yourself,
then you could test too, or I could test what ever you could debug, I
see that you have many v4l devices already ... Would that be of any
good?
(Continue reading)

Permalink | Reply | 0 comments |
headers
Eric Miao | 3 Aug 2009 13:35
Picon
Gravatar

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

Marek Vasut wrote:
> Hi!
> 
> Eric, would you mind applying ?
> 
> From 4dcbff010e996f4c6e5761b3c19f5d863ab51b39 Mon Sep 17 00:00:00 2001
> From: Marek Vasut <marek.vasut <at> gmail.com>
> Date: Mon, 3 Aug 2009 10:27:57 +0200
> Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera
> 
> Those formats are requiered on widely used OmniVision OV96xx cameras.
> Those formats are nothing more then endian-swapped RGB555 and RGB565.
> 
> Signed-off-by: Marek Vasut <marek.vasut <at> gmail.com>

Acked-by: Eric Miao <eric.y.miao <at> gmail.com>

Guennadi,

Would be better if this gets merged by you, thanks.

> ---
>  drivers/media/video/pxa_camera.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/pxa_camera.c 
> b/drivers/media/video/pxa_camera.c
> index 46e0d8a..de0fc8a 100644
> --- a/drivers/media/video/pxa_camera.c
> +++ b/drivers/media/video/pxa_camera.c
(Continue reading)

Permalink | Reply | 44 comments |
headers
Trilok Soni | 3 Aug 2009 13:43
Picon

Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera

Hi Eric,

On Mon, Aug 3, 2009 at 5:05 PM, Eric Miao<eric.y.miao <at> gmail.com> wrote:
> Marek Vasut wrote:
>> Hi!
>>
>> Eric, would you mind applying ?
>>
>> From 4dcbff010e996f4c6e5761b3c19f5d863ab51b39 Mon Sep 17 00:00:00 2001
>> From: Marek Vasut <marek.vasut <at> gmail.com>
>> Date: Mon, 3 Aug 2009 10:27:57 +0200
>> Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera
>>
>> Those formats are requiered on widely used OmniVision OV96xx cameras.
>> Those formats are nothing more then endian-swapped RGB555 and RGB565.
>>
>> Signed-off-by: Marek Vasut <marek.vasut <at> gmail.com>
>
> Acked-by: Eric Miao <eric.y.miao <at> gmail.com>
>
> Guennadi,
>
> Would be better if this gets merged by you, thanks.

linux-media is new list for v4l2.

--

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
(Continue reading)

Permalink | Reply | 0 comments |
headers
Esben Stien | 4 Aug 2009 03:08
Favicon

Re: video4linux loopback device

Folkert van Heusden <folkert <at> vanheusden.com> writes:

> Any chance that the video4linux loopback device will be integrated in
> the main video4linux distribution and included in the kernel?

Why don't we focus on something like JACK[0], but for video, like
videojack[1]. This brings all this to userspace and we can pipe video
into and out of applications as easily as we're doing with audio with
JACK. 

This seems more like a final solution to me. 

[0]http://jackaudio.org/
[1]http://www.piksel.no/pwiki/VideoJack
[2]http://www.linuxmao.org/tikiwiki/img/wiki_up/patchage.png

--

-- 
Esben Stien is b0ef <at> e     s      a             
         http://www. s     t    n m
          irc://irc.  b  -  i  .   e/%23contact
           sip:b0ef <at>    e     e 
           jid:b0ef <at>     n     n

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request <at> redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Permalink | Reply | 0 comments |
headers
Kuninori Morimoto | 4 Aug 2009 11:47

[PATCH] sh_mobile_ceu_camera: add VBP error cure operation

If CEU driver can not receive data from camera,
CETCR has VBP error state.
Then, CEU is stopped and cure operation is needed.
This patch add VBP error cure operation.
Special thanks to Magnus

Signed-off-by: Kuninori Morimoto <morimoto.kuninori <at> renesas.com>
---
 drivers/media/video/sh_mobile_ceu_camera.c |   33 +++++++++++++++++++++------
 1 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c
index 0db88a5..7ce78a3 100644
--- a/drivers/media/video/sh_mobile_ceu_camera.c
+++ b/drivers/media/video/sh_mobile_ceu_camera.c
 <at>  <at>  -182,26 +182,42  <at>  <at>  static void free_buffer(struct videobuf_queue *vq,
 #define CEU_CETCR_MAGIC 0x0317f313 /* acknowledge magical interrupt sources */
 #define CEU_CETCR_IGRW (1 << 4) /* prohibited register access interrupt bit */
 #define CEU_CEIER_CPEIE (1 << 0) /* one-frame capture end interrupt */
+#define CEU_CEIER_VBP   (1 << 20) /* vbp error */
 #define CEU_CAPCR_CTNCP (1 << 16) /* continuous capture mode (if set) */
+#define CEU_CEIER_MASK (CEU_CEIER_CPEIE | CEU_CEIER_VBP)

 
-static void sh_mobile_ceu_capture(struct sh_mobile_ceu_dev *pcdev)
+static int sh_mobile_ceu_capture(struct sh_mobile_ceu_dev *pcdev)
 {
 	struct soc_camera_device *icd = pcdev->icd;
 	dma_addr_t phys_addr_top, phys_addr_bottom;
+	u32 status;
(Continue reading)

Permalink | Reply | 2 comments |
headers
Guennadi Liakhovetski | 4 Aug 2009 18:56
Picon
Picon

Re: [PATCH] sh_mobile_ceu_camera: add VBP error cure operation

Hello Morimoto-san

A couple of notes to your patch:

On Tue, 4 Aug 2009, Kuninori Morimoto wrote:

> If CEU driver can not receive data from camera,
> CETCR has VBP error state.
> Then, CEU is stopped and cure operation is needed.
> This patch add VBP error cure operation.
> Special thanks to Magnus
> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori <at> renesas.com>
> ---
>  drivers/media/video/sh_mobile_ceu_camera.c |   33 +++++++++++++++++++++------
>  1 files changed, 25 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c
> index 0db88a5..7ce78a3 100644
> --- a/drivers/media/video/sh_mobile_ceu_camera.c
> +++ b/drivers/media/video/sh_mobile_ceu_camera.c
>  <at>  <at>  -182,26 +182,42  <at>  <at>  static void free_buffer(struct videobuf_queue *vq,
>  #define CEU_CETCR_MAGIC 0x0317f313 /* acknowledge magical interrupt sources */
>  #define CEU_CETCR_IGRW (1 << 4) /* prohibited register access interrupt bit */
>  #define CEU_CEIER_CPEIE (1 << 0) /* one-frame capture end interrupt */
> +#define CEU_CEIER_VBP   (1 << 20) /* vbp error */
>  #define CEU_CAPCR_CTNCP (1 << 16) /* continuous capture mode (if set) */
> +#define CEU_CEIER_MASK (CEU_CEIER_CPEIE | CEU_CEIER_VBP)
>  
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Kuninori Morimoto | 5 Aug 2009 06:11

Re: [PATCH] sh_mobile_ceu_camera: add VBP error cure operation


Dear Guennadi

Thank you for advice.

> I think, it would be good to add a coment here, explaining, that the 
> return code doesn't reflex the success or failure to queue the new buffer, 
> but rather the status of the previous buffer, if any.

OK. I add explaining

> > +	/* VBP error */
> > +	if (status & CEU_CEIER_VBP) {
> > +		/* soft reset */
> > +		ceu_write(pcdev, CAPSR, 1 << 16);
> > +		while ((1 << 16) & ceu_read(pcdev, CAPSR))
> > +			cpu_relax();
> > +		while (ceu_read(pcdev, CSTSR) & 1)
> > +			cpu_relax();
> 
> Let's put some security in these loops - please, add some counter to them. 
> Even more importantly, since these loops are also run in IRQ.

OK.
But there are part where run soft reset.
So, I will send another patch which add/use soft_reset function.

> > +		ret = -1;
> 
> I see, that this ret value is only used internally, still, I think it
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kuninori Morimoto | 5 Aug 2009 12:21

[PATCH 1/2] sh_mobile_ceu: add soft reset function


Signed-off-by: Kuninori Morimoto <morimoto.kuninori <at> renesas.com>
---
 drivers/media/video/sh_mobile_ceu_camera.c |   26 ++++++++++++++++++++++----
 1 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c
index 0db88a5..896bbf1 100644
--- a/drivers/media/video/sh_mobile_ceu_camera.c
+++ b/drivers/media/video/sh_mobile_ceu_camera.c
 <at>  <at>  -135,6 +135,26  <at>  <at>  static u32 ceu_read(struct sh_mobile_ceu_dev *priv, unsigned long reg_offs)
 	return ioread32(priv->base + reg_offs);
 }

+static void sh_mobile_ceu_soft_reset(struct sh_mobile_ceu_dev *pcdev)
+{
+	int t;
+
+	ceu_write(pcdev, CAPSR, 1 << 16); /* reset */
+	t = 10000;
+	while (t--) {
+		if (!(ceu_read(pcdev, CAPSR) & (1 << 16)))
+			break;
+		cpu_relax();
+	}
+
+	t = 10000;
+	while (t--) {
+		if (!(ceu_read(pcdev, CSTSR) & 1))
+			break;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Kuninori Morimoto | 5 Aug 2009 12:21

[PATCH 2/2 v2] sh_mobile_ceu_camera: add VBP error support

If CEU driver can not receive data from camera,
CETCR has VBP error state.
Then, CEU is stopped and cure operation is needed.
This patch add VBP error cure operation.

Signed-off-by: Kuninori Morimoto <morimoto.kuninori <at> renesas.com>
---
v1 -> v2

o add explain for sh_mobile_ceu_capture
o use sh_mobile_ceu_soft_reset
o use -EIO in sh_mobile_ceu_capture
o add small explain to sh_mobile_ceu_videobuf_queue

 drivers/media/video/sh_mobile_ceu_camera.c |   37 ++++++++++++++++++++++------
 1 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c
index 896bbf1..4281325 100644
--- a/drivers/media/video/sh_mobile_ceu_camera.c
+++ b/drivers/media/video/sh_mobile_ceu_camera.c
 <at>  <at>  -202,26 +202,42  <at>  <at>  static void free_buffer(struct videobuf_queue *vq,
 #define CEU_CETCR_MAGIC 0x0317f313 /* acknowledge magical interrupt sources */
 #define CEU_CETCR_IGRW (1 << 4) /* prohibited register access interrupt bit */
 #define CEU_CEIER_CPEIE (1 << 0) /* one-frame capture end interrupt */
+#define CEU_CEIER_VBP   (1 << 20) /* vbp error */
 #define CEU_CAPCR_CTNCP (1 << 16) /* continuous capture mode (if set) */
+#define CEU_CEIER_MASK (CEU_CEIER_CPEIE | CEU_CEIER_VBP)
(Continue reading)

Permalink | Reply | 0 comments |

Gmane