Reimar Döffinger | 1 Aug 19:30 2009
Picon
Picon

Re: [PATCH] hack x264_encoder_encode returns 0 incorrectly when flushing

On Wed, Jul 08, 2009 at 10:40:06AM +0200, Reimar Döffinger wrote:
> On Wed, Jul 08, 2009 at 03:31:14AM +0000, Loren Merritt wrote:
> > The correct implementation of end of stream flush is: Pass nulls until you 
> > have gotten some frames back, then pass nulls until x264 stops returning 
> > frames. (Unless you haven't encoded any frames at all, in which case that 
> > will hang.)
> 
> And have an endless loop if there isn't any delay? Apart from limiting
> the first wait for getting frames back to 255 that is what my patch
> does.
> 
> > If the above is too cumbersome, I suppose I can add a return value saying 
> > whether there are any remaining delayed frames.
> 
> I'd say that might be a good idea. Because at least mencoder and FFmpeg
> do it wrong, and I have some suspicion that nobody does it right
> actually, because given this code in x264.c:
>     /* Flush delayed B-frames */
>     do {
>         i_file +=
>         i_frame_size = Encode_frame( h, opt->hout, NULL );
>     } while( i_frame_size );
> I'd claim that not even x264 CLI gets it right.
> Maybe a little bit of documentation wouldn't hurt after all?

What about this? Does someone know if x264 gets this right or not?
Should my patch be applied?
Or will libx264 be extended?
Francesco Lavra | 2 Aug 10:18 2009
Picon

Re: [PATCH] Add DVB teletext support

On Wed, 2009-07-22 at 09:53 +0000, Carl Eugen Hoyos wrote:
> Francesco Lavra <francescolavra <at> interfree.it> writes:
> 
> > - moved stream/tvi_vbi.c to /libmpcodecs/dec_teletext.c
> 
> Unfortunately not (svn move stream/tvi_vbi.c libmpcodecs/dec_teletext.c).
> 
> I would really love to see dvb teletext support in mplayer and I can help you
> test and get the patches into an acceptable shape.
> But to get this into svn, it is absolutely needed that you either:
> - Implement dvb teletext without changing any filenames or renaming any options
>   Change filenames and rename options afterwards.
> - Send patches only to rename files (but not with cp && svn rm!), more patches to
>   rename/add options
>   Then send a patch to implement dvb teletext.
> 
> I slightly prefer the first option, but that is totally up to you.
> If you go for the second one, I will be able to test teletext.
> 
> Carl Eugen
> 
> 

Sorry for my late reply. I see that libmpcodecs/dec_teletext.c has
already been scheduled for addition to the repository. In attachment is
a patch that removes the old file stream/tvi_vbi.c, removes
teletext-related definitions from stream/tv.h and stream/tvi_def.h and
places them in the new file libmpcodecs/dec_teletext.h, replaces
stream/tvi_vbi.c with libmpcodecs/dec_teletext.c in the Makefile and
changes some includes in related files to make the new code compilable.
(Continue reading)

Diego Biurrun | 2 Aug 10:56 2009
Picon

Re: [PATCH] Add DVB teletext support

On Sun, Aug 02, 2009 at 10:18:02AM +0200, Francesco Lavra wrote:
> 
> --- libmpcodecs/dec_teletext.h	(revision 0)
> +++ libmpcodecs/dec_teletext.h	(revision 0)
>  <at>  <at>  -0,0 +1,114  <at>  <at> 
> +#ifndef MPLAYER_DEC_TELETEXT_H
> +#define MPLAYER_DEC_TELETEXT_H

This is missing the standard license header.

> --- command.c	(revision 29464)
> +++ command.c	(working copy)
>  <at>  <at>  -57,6 +57,9  <at>  <at> 
>  #ifdef CONFIG_GUI
>  #include "gui/interface.h"
>  #endif
> +#ifdef CONFIG_TV_TELETEXT
> +#include "libmpcodecs/dec_teletext.h"
> +#endif

Is the #ifdef necessary?

I think this patch would be smaller if you moved stuff around with 'svn
cp' before creating the diff.

Diego
Francesco Lavra | 2 Aug 13:14 2009
Picon

Re: [PATCH] Add DVB teletext support

On Sun, 2009-08-02 at 10:56 +0200, Diego Biurrun wrote:
> On Sun, Aug 02, 2009 at 10:18:02AM +0200, Francesco Lavra wrote:
> > 
> > --- libmpcodecs/dec_teletext.h	(revision 0)
> > +++ libmpcodecs/dec_teletext.h	(revision 0)
> >  <at>  <at>  -0,0 +1,114  <at>  <at> 
> > +#ifndef MPLAYER_DEC_TELETEXT_H
> > +#define MPLAYER_DEC_TELETEXT_H
> 
> This is missing the standard license header.
Added in the attached patch
> 
> > --- command.c	(revision 29464)
> > +++ command.c	(working copy)
> >  <at>  <at>  -57,6 +57,9  <at>  <at> 
> >  #ifdef CONFIG_GUI
> >  #include "gui/interface.h"
> >  #endif
> > +#ifdef CONFIG_TV_TELETEXT
> > +#include "libmpcodecs/dec_teletext.h"
> > +#endif
> 
> Is the #ifdef necessary?
It is not really necessary, I just followed the coding style present in
that file (see the 30 or so lines above my addition)
> 
> I think this patch would be smaller if you moved stuff around with 'svn
> cp' before creating the diff.
I don't think so, dec_teletext.h takes about 110 out of 350 lines of
code from tv.h
(Continue reading)

Diego Biurrun | 2 Aug 13:30 2009
Picon

Re: [PATCH] Add DVB teletext support

On Sun, Aug 02, 2009 at 01:14:12PM +0200, Francesco Lavra wrote:
> On Sun, 2009-08-02 at 10:56 +0200, Diego Biurrun wrote:
> > On Sun, Aug 02, 2009 at 10:18:02AM +0200, Francesco Lavra wrote:
> > > 
> > > --- command.c	(revision 29464)
> > > +++ command.c	(working copy)
> > >  <at>  <at>  -57,6 +57,9  <at>  <at> 
> > >  #ifdef CONFIG_GUI
> > >  #include "gui/interface.h"
> > >  #endif
> > > +#ifdef CONFIG_TV_TELETEXT
> > > +#include "libmpcodecs/dec_teletext.h"
> > > +#endif
> > 
> > Is the #ifdef necessary?
> It is not really necessary, I just followed the coding style present in
> that file (see the 30 or so lines above my addition)

Those #ifdefs should be necessary or else they should be removed.

> > I think this patch would be smaller if you moved stuff around with 'svn
> > cp' before creating the diff.
> I don't think so, dec_teletext.h takes about 110 out of 350 lines of
> code from tv.h

You are copying code.  Use svn cp.

Diego

P.S.: It would greatly help the readability of your emails if you left a
(Continue reading)

Francesco Lavra | 2 Aug 16:08 2009
Picon

Re: [PATCH] Add DVB teletext support

On Sun, 2009-08-02 at 13:30 +0200, Diego Biurrun wrote:
> > > Is the #ifdef necessary?
> > It is not really necessary, I just followed the coding style present in
> > that file (see the 30 or so lines above my addition)
>
> Those #ifdefs should be necessary or else they should be removed.

Removed

> > > I think this patch would be smaller if you moved stuff around with 'svn
> > > cp' before creating the diff.
> > I don't think so, dec_teletext.h takes about 110 out of 350 lines of
> > code from tv.h
> 
> You are copying code.  Use svn cp.

Done
Attachment (dec_teletext.patch): text/x-patch, 82 KiB
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng <at> mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
Diego Biurrun | 2 Aug 17:17 2009
Picon

Re: [PATCH]fix building with dpkg-buildpackage

On Sun, Jul 26, 2009 at 10:33:23AM +0200, Anton Khirnov wrote:
> dpkg-buildpackage automatically sets CFLAGS and pals to -g -O2, which causes build
> to fail. Attached patch (taken from official Debian package) fixes it.

Applied.

Diego
Francesco Lavra | 2 Aug 17:21 2009
Picon

Re: [PATCH] Add DVB teletext support

On Sun, 2009-08-02 at 16:08 +0200, Francesco Lavra wrote:
> On Sun, 2009-08-02 at 13:30 +0200, Diego Biurrun wrote:
> > > > Is the #ifdef necessary?
> > > It is not really necessary, I just followed the coding style present in
> > > that file (see the 30 or so lines above my addition)
> >
> > Those #ifdefs should be necessary or else they should be removed.
> 
> Removed
> 
> > > > I think this patch would be smaller if you moved stuff around with 'svn
> > > > cp' before creating the diff.
> > > I don't think so, dec_teletext.h takes about 110 out of 350 lines of
> > > code from tv.h
> > 
> > You are copying code.  Use svn cp.
> 
> Done

Second patch of the series:
- Replaced TVI_CONTROL_TRUE, TVI_CONTROL_FALSE and TVI_CONTROL_UNKNOWN
constants in /libmpcodecs/dec_teletext.c with VBI_CONTROL_TRUE,
VBI_CONTROL_FALSE and VBI_CONTROL_UNKNOWN
- Added TVI_CONTROL_GET_VBI_PTR definition in stream/tv.h and
implementation of relevant control in stream/tvi_v4l.c,
stream/tvi_v4l2.c and stream/tvi_dshow.c
- Modified stream/tv.c, command.c and mpcommon.c such that
teletext_control() is called directly, instead of passing through TVI
handle control function
- Moved teletext-related struct members of tv_param_t in stream/tv.h to
(Continue reading)

Adam M. Costello | 3 Aug 00:56 2009
Picon

[PATCH] convol (general convolution filter)

The attached patch adds a new filter, convol, which does general
convolution.  The scale filter already uses convolution for scaling
and image-format conversion, but provides very limited control over
the filter coefficients.  The convol filter does no scaling and no
image-format conversion but provides full control over the convolution
coefficients, with (optionally) separate filters for luma-x, luma-y,
chroma-x, and chroma-y.

The geq filter can do most of what convol can do (and more), but is
about 20x slower for similar operations and has a more cumbersome option
syntax.

I use convol for attenuating very noisy high-frequency "information" in
the luma channel of over-compressed MJPEG source material from a pocket
camera before recoding as H.264.

AMC
Index: libmpcodecs/vf_convol.c
===================================================================
--- libmpcodecs/vf_convol.c	(revision 0)
+++ libmpcodecs/vf_convol.c	(revision 0)
 <at>  <at>  -0,0 +1,889  <at>  <at> 
+/*
+
+Unlike vf_scale, which does scaling and image-format conversion using
+convolution filters but provides very limited control over the filter
+coefficients, vf_convol does no scaling and no image-format conversion
+but provides full control over the convolution coefficients.
(Continue reading)

Luca Barbato | 3 Aug 11:22 2009
Picon

Re: [PATCH] Use local labels to avoid clashes caused by -ftracer

Luca Barbato wrote:
> Reimar Döffinger wrote:
> [...]
> 
> Even if it seems to work, since 0 and 1 are used just once in that
> scope, probably using 'b' is safer and less ambiguous.

Ping, it's ok to commit this?

lu

--

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng <at> mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Gmane