Robert Henney | 1 Oct 03:34 2005

Re: Re: [MPlayer-users] ssa reader for mplayer using vf_overlay

On Thu, Sep 29, 2005 at 09:57:24AM -0400, Jason Tackaberry wrote:
> On Thu, 2005-09-29 at 00:21 -0400, Robert Henney wrote:

> > The other is that invalidate ranges don't seem to be working perfectly
> > right for me.  Currently to get around the problem I'm issuing an
> > "invalidate=.." with dimentions that cover the entire overlay memory.
> 
> I haven't noticed any problems myself with this.  I've never been
> concerned about calculating the invalidate rectangles since I've been
> using Evas, and it does that for me.  If there's a bug in this area, I'm
> guessing that it has to do with the coordinate translation code.  Is
> there any hardware scaling of your video happening?  If so, vf_overlay
> will scale the OSD from display size to frame size, and it will
> translate all coordinates from one to the other.  You can try using
> software scaling in the filter chain to prevent any resizing and see if
> it fixes your problem.

[..]

> Or maybe the bug is in your application, I don't know. :)  If you can
> tell me how to reproduce it, I can certainly fix it.

I've written a minimal example program.  the needed files for it are
here: 
	http://rut.org/mpssa/osdtest/

it almost looks like a parser bug.  when the lock first gets set to
0x20, the overlay acknowledges all of the issued invalidates, but each
time the lock gets set to 0x20 after that only one of the issued
invalidates is acknowledged.
(Continue reading)

Robert Henney | 1 Oct 04:57 2005

Re: Re: [MPlayer-users] ssa reader for mplayer using vf_overlay

On Fri, Sep 30, 2005 at 09:34:58PM -0400, Robert Henney wrote:
> On Thu, Sep 29, 2005 at 09:57:24AM -0400, Jason Tackaberry wrote:
> > On Thu, 2005-09-29 at 00:21 -0400, Robert Henney wrote:
> 
> > Or maybe the bug is in your application, I don't know. :)  If you can
> > tell me how to reproduce it, I can certainly fix it.
> 
> I've written a minimal example program.  the needed files for it are
> here: 
> 	http://rut.org/mpssa/osdtest/
> 
> it almost looks like a parser bug.  when the lock first gets set to
> 0x20, the overlay acknowledges all of the issued invalidates, but each
> time the lock gets set to 0x20 after that only one of the issued
> invalidates is acknowledged.

replying to myself. <g>

it wasn't a parser bug, but a linked list bug.  these bite me all the 
time in my own stuff too. :)

I found the bug in vf_overlay.c.  at the end of invalidate_rect(), 
the line

	priv->invalid_rects = r->next;

should become

	priv->invalid_rects = r;

(Continue reading)

Jason Tackaberry | 1 Oct 05:01 2005

Re: Re: [MPlayer-users] ssa reader for mplayer using vf_overlay

On Fri, 2005-09-30 at 22:57 -0400, Robert Henney wrote:
> I found the bug in vf_overlay.c.  at the end of invalidate_rect(), 
> the line
[...]
> 	priv->invalid_rects = r;

Sorry I haven't replied to your other emails yet.  I've had a busy
night, and will reply tomorrow.

I did find this bug a couple weeks ago, but I haven't posted a new patch
since then.  I should have remembered it when you posted your email.
Sorry for causing you a lot of wasted time, but good eye catching that
one. :)

Until I get a chance to cut a new patch, you might try the patch at:

http://sault.org/mebox/downloads/patches/vf_overlay_outbuf-2005-09-20-TESTING.diff

This patch also includes vf_outbuf (which is another patch I'm working
on, but it's not polished yet).  But it includes the fix you mentioned,
plus I believe a couple others.  You could at least pull vf_overlay.c
from this patch and be a bit further ahead.

Talk to you tomorrow. :)

Cheers,
Jason.
_______________________________________________
(Continue reading)

Gianluigi Tiesi | 1 Oct 08:22 2005
Picon

Re: avisynth.dll

On Fri, Sep 30, 2005 at 06:57:40AM +0200, Diego Biurrun wrote:
> On Thu, Sep 29, 2005 at 09:04:22PM +0200, Roberto Togni wrote:
> > 
> > Does avisynth.dll works on other Os than windows? Iirc the author
> > (Gianluigi Tiesi) told me that it needs c++ exceptions, that are not
> > handled by our win32 loader/emulator.
> 
> IIRC it is Windows only.
> 
> > If that is true, what about enabling avisynth only on windows?
> 
It doesn't changes much except of some messages in verbose mode, since
if loadlibrary fails it exits the init, anyway until some big brain
ports c++ exception handler to win32 loader it's safe to disable it on
non WIN32.
My old tests were a bit unsucessfull, even disabling try/catch blocks
in avs sources, order of passed params was a mess (on windows just
works).

Bye

--

-- 
Gianluigi Tiesi <sherpya <at> netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/
Robert Henney | 1 Oct 09:35 2005

Re: Re: [MPlayer-users] ssa reader for mplayer using vf_overlay

On Fri, Sep 30, 2005 at 11:01:35PM -0400, Jason Tackaberry wrote:
> On Fri, 2005-09-30 at 22:57 -0400, Robert Henney wrote:
> > I found the bug in vf_overlay.c.  at the end of invalidate_rect(), 
> > the line
> [...]
> > 	priv->invalid_rects = r;
> 
> Sorry I haven't replied to your other emails yet.  I've had a busy
> night, and will reply tomorrow.

don't worry about it.  :)

> I did find this bug a couple weeks ago, but I haven't posted a new patch
> since then.  I should have remembered it when you posted your email.
> Sorry for causing you a lot of wasted time, but good eye catching that
> one. :)

:)

I'm still having one last issue which appears to be of a color space
nature, even with the vf_overlay_outbuf-2005-09-20-TESTING.diff applied.
Doesn't appear any different even if I insert the scale filter.  It also
doesn't happen every time I go to update the overlay, but is
consistently repeatable if I follow the same sequence each time.

A snapshot of the problem:

	http://rut.org/mpssa/osdtest/outfile.png

The image is of a bitblt'ed rectangle of data into the overlay buffer at
(Continue reading)

Paweł Sakowski | 1 Oct 14:18 2005
Picon

Re: [PATCH] Pivoting

On Wed, 2005-09-21 at 10:17 +0300, Ivan Kalvachev wrote:
> 2005/9/20, Paweł Sakowski <pawel <at> sakowski.pl>:
> > Another attempt to gain some focus.
> > 
> > What do you think about the patches (for XRandR support and
> > monitor_aspect autodetection)? Do you find them appliable, bad but
> > fixable or fubar?
> 
> I'll tell you tommorow

Ping?

--

-- 
+----------------------------------------------------------------------+
| Paweł Sakowski <pawel <at> sakowski.pl>                Never trust a man  |
|                            who can count up to 1023 on his fingers.  |
+----------------------------------------------------------------------+
Reimar Döffinger | 1 Oct 14:52 2005
Picon
Picon

Re: [PATCH] libaf/af code documentation

Him
On Thu, Sep 29, 2005 at 06:53:29PM +0200, Reimar Döffinger wrote:
> the attached patch modifies the documentation in af.c and af.h to use
> doxgen-style commments more importantly creates two doxygen "modules",
> one containing the everything for manipulating the filter chain
> ("Audio filter chain functions") and one containing the (helper) functions
> used by filters ("Audio filter helper functions").
[...]

Applied.

Greetings,
Reimar Döffinger
Reimar Döffinger | 1 Oct 14:54 2005
Picon
Picon

Re: [PATCH] ATI GPU YUV conversion

Hi,
On Thu, Sep 29, 2005 at 06:30:15PM +0200, Reimar Döffinger wrote:
> the attached patch adds a new method for the hardware YUV->RGB conversion in
> vo_gl and vo_gl2 (yuv=5 suboption) that should work for older ATI cards
> as well. Please test if you have such hardware, since I don't.

Applied.

Greetings,
Reimar Döffinger
Reimar Döffinger | 1 Oct 14:57 2005
Picon
Picon

Re: [PATCH] libdvdcss upgrade

Hi,
On Fri, Sep 30, 2005 at 09:56:02PM +0200, Diego Biurrun wrote:
> On Sun, Sep 18, 2005 at 07:31:06PM +0200, Diego Biurrun wrote:
> > Here is a patch that syncs our included libdvdcss with the latest
> > release.  Please give this a spin as I could only test it on PPC.
> 
> NOTE: I cannot test this on x86 because my PC does not have a DVD drive.
> If I commit this and it breaks your Intel boxes don't come whining to
> me.  Test it now please.

If you didn't give me another day to test it in MingW, I am suspicious
that some changes might break compilation.

Greetings,
Reimar Döffinger
Jason Tackaberry | 1 Oct 16:08 2005

Re: Re: [MPlayer-users] ssa reader for mplayer using vf_overlay

On Sat, 2005-10-01 at 03:35 -0400, Robert Henney wrote:
> 	UPDATE: did some further testing before sending this mail and
> 	came up with a pattern.  if the y value passed with the
> 	invalidate command is ODD, then this strange color shift
> 	always happens, but never when it's EVEN.

Ah, yes, this does make sense. :)  I'll add some code to vf_overlay
which internally aligns the coordinates given to multiples of 2.  I can
reproduce the problem here.

>     // 'mem' is pointer to overlay memory
[...]
> 	pW = (unsigned long*)mem + 4 + imagex + (y+imagey) * screenwidth;

The BGRA buffer is offset 16 bytes from the shmem address, so it looks
like you should be adding 16, rather than 4.

Cheers,
Jason.
_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng <at> mplayerhq.hu
http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

Gmane