What about CreateThread patch?

Hello, mplayer-cygwin.

  What about this patch for win32 GUI? Without this patch mplayer GUI
does not start at least under Win98 SE (tested on two win98 machines,
can also check on several WinME).
  With this patch applied GUI works.

  From MSDN: http://msdn2.microsoft.com/en-us/library/ms682453.aspx
    lpThreadId
    [out] A pointer to a variable that receives the thread identifier.
    If this parameter is NULL, the thread identifier is not returned.
    Windows Me/98/95:  This parameter may not be NULL.

--- mplayer/Gui/win32/interface.c   Sat Oct 14 03:31:58 2006
+++ mplayer.my/Gui/win32/interface.c    Mon Nov  6 02:34:08 2006
 <at>  <at>  -453,11 +453,12  <at>  <at> 

 void guiInit(void)
 {
+    DWORD threadId; // required for CreateThread under win9x/ME
     memset(&guiIntfStruct, 0, sizeof(guiIntfStruct));
     /* Create The gui thread */
     if (!mygui)
         mp_msg(MSGT_GPLAYER, MSGL_V, "[GUI] Creating GUI Thread 0x%04x\n",
-              (int) CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) GuiThread, NULL, 0, NULL));
+              (int) CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) GuiThread, NULL, 0, &threadId));

     /* Wait until the gui is created */
     while(!mygui) Sleep(100);
****** end of patch

Re: What about CreateThread patch?

On Tue, Apr 03, 2007 at 02:16:36AM +0300, Sergey wrote:
> Hello, mplayer-cygwin.
> 
>   What about this patch for win32 GUI? Without this patch mplayer GUI
> does not start at least under Win98 SE (tested on two win98 machines,
> can also check on several WinME).
>   With this patch applied GUI works.
> 
>   From MSDN: http://msdn2.microsoft.com/en-us/library/ms682453.aspx
>     lpThreadId
>     [out] A pointer to a variable that receives the thread identifier.
>     If this parameter is NULL, the thread identifier is not returned.
>     Windows Me/98/95:  This parameter may not be NULL.
> 
> --- mplayer/Gui/win32/interface.c   Sat Oct 14 03:31:58 2006
> +++ mplayer.my/Gui/win32/interface.c    Mon Nov  6 02:34:08 2006
>  <at>  <at>  -453,11 +453,12  <at>  <at> 
> 
>  void guiInit(void)
>  {
> +    DWORD threadId; // required for CreateThread under win9x/ME
>      memset(&guiIntfStruct, 0, sizeof(guiIntfStruct));
>      /* Create The gui thread */
>      if (!mygui)
>          mp_msg(MSGT_GPLAYER, MSGL_V, "[GUI] Creating GUI Thread 0x%04x\n",
> -              (int) CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) GuiThread, NULL, 0, NULL));
> +              (int) CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) GuiThread, NULL, 0, &threadId));
> 
>      /* Wait until the gui is created */
>      while(!mygui) Sleep(100);

Re: What about CreateThread patch?

--- Sergey <sergemp <at> mail.ru> wrote:

> Hello, mplayer-cygwin.
> 
>   What about this patch for win32 GUI? Without this patch mplayer GUI
> does not start at least under Win98 SE (tested on two win98 machines,
> can also check on several WinME).
>   With this patch applied GUI works.
> 
>   From MSDN: http://msdn2.microsoft.com/en-us/library/ms682453.aspx
>     lpThreadId
>     [out] A pointer to a variable that receives the thread
> identifier.
>     If this parameter is NULL, the thread identifier is not returned.
>     Windows Me/98/95:  This parameter may not be NULL.
> 
> --- mplayer/Gui/win32/interface.c   Sat Oct 14 03:31:58 2006
> +++ mplayer.my/Gui/win32/interface.c    Mon Nov  6 02:34:08 2006
>  <at>  <at>  -453,11 +453,12  <at>  <at> 
> 
>  void guiInit(void)
>  {
> +    DWORD threadId; // required for CreateThread under win9x/ME
>      memset(&guiIntfStruct, 0, sizeof(guiIntfStruct));
>      /* Create The gui thread */
>      if (!mygui)
>          mp_msg(MSGT_GPLAYER, MSGL_V, "[GUI] Creating GUI Thread
> 0x%04x\n",
> -              (int) CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)

Testers needed for -vo gl under Vista

Hello,
to anyone who wants the issues to be fixed, I need someone who can
compile MPlayer and test patches.
Attached is a patch that might make -vo gl actually display something.
I was reading the VirtualDub blog, and it seems Vista just doesn't
update windows as long as there is still a DC allocated - and MPlayer
for simplicity always keeps one.
Note: I did not even test for compilation.

Greetings,
Reimar Döffinger

Index: libvo/w32_common.c
===================================================================
--- libvo/w32_common.c	(revision 22946)
+++ libvo/w32_common.c	(working copy)
 <at>  <at>  -10,6 +10,9  <at>  <at> 
 #include "video_out.h"
 #include "aspect.h"
 #include "w32_common.h"
+#ifndef PFD_SUPPORT_COMPOSITION
+#define PFD_SUPPORT_COMPOSITION 0x00008000
+#endif
 #include "mp_fifo.h"

 extern int enable_mouse_movements;
 <at>  <at>  -20,7 +23,6  <at>  <at> 

 static const char* classname = "MPlayer - Media player for Win32";

Re: Testers needed for -vo gl under Vista

Reimar Döffinger wrote:
> Hello,
> to anyone who wants the issues to be fixed, I need someone who can
> compile MPlayer and test patches.
> Attached is a patch that might make -vo gl actually display something.
> I was reading the VirtualDub blog, and it seems Vista just doesn't
> update windows as long as there is still a DC allocated - and MPlayer
> for simplicity always keeps one.
> Note: I did not even test for compilation.
> 
> Greetings,
> Reimar Döffinger
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> MPlayer-cygwin mailing list
> MPlayer-cygwin <at> mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/mplayer-cygwin

ReleaseDC(..) takes 2 parameters instead of one (hWnd and HDC). After adding the 
hWnd, it compiles fine.

I am running Vista Business on a Athlon XP 2600+ with a ATi Radeon X800 Pro.
-vo gl did work for me before this patch, and as far as I can see nothing 
changes after applying. So maybe this "black window" problem is only relevant 
for Nvidia models.

The OpenGL support from ATi on Vista is quite bad currently, which causes video 

Re: Re: Testers needed for -vo gl under Vista

--- Frank Aurich <fa859178 <at> inf.tu-dresden.de> wrote:

> Reimar Döffinger wrote:
> > Hello,
> > to anyone who wants the issues to be fixed, I need someone who can
> > compile MPlayer and test patches.
> > Attached is a patch that might make -vo gl actually display
> something.
> > I was reading the VirtualDub blog, and it seems Vista just doesn't
> > update windows as long as there is still a DC allocated - and
> MPlayer
> > for simplicity always keeps one.
> > Note: I did not even test for compilation.
> > 
> > Greetings,
> > Reimar Döffinger
> > 
> > 
> >
>
------------------------------------------------------------------------
> > 
> > _______________________________________________
> > MPlayer-cygwin mailing list
> > MPlayer-cygwin <at> mplayerhq.hu
> > http://lists.mplayerhq.hu/mailman/listinfo/mplayer-cygwin
> 
> ReleaseDC(..) takes 2 parameters instead of one (hWnd and HDC). After
> adding the 

Re: MPlayer-cygwin Digest, Vol 51, Issue 4

Enzo <v.deflorio <at> katamail.com> writes:

> 
> Dear all,
> 
> after a few weeks, today I svn'ed the latest release and tried to compile it
on my Win-XP laptop under cygwin.
> There seems to be an undefined reference to _open_osfhandle (see below for the
last few lines of the output
> of make). How may I solve this?
> 
> Thanks in advance, greetings
> 
> Enzo
> 
> make[1]: Leaving directory `/home/Vincenz/trunk/osdep'
> cc -o mplayer.exe mplayer.o m_property.o mp_msg.o mixer.o parser-mpcmd.o
> subopt-helper.o command.o osdep/mplayer-rc.o asxparser.o codec-cfg.o
> cpudetect.o edl.o find_sub.o m_config.o m_option.o m_struct.o mpcommon.o
> parser-cfg.o playtree.o playtreeparser.o spudec.o sub_cc.o subreader.o
> vobsub.o unrarlib.o libvo/libvo.a libao2/libao2.a input/libinput.a
> libmenu/libmenu.a libmpcodecs/libmpcodecs.a libaf/libaf.a
> libmpdemux/libmpdemux.a stream/stream.a libswscale/libswscale.a
> libvo/libosd.a libavformat/libavformat.a libavcodec/libavcodec.a
> libavutil/libavutil.a libpostproc/libpostproc.a mp3lib/libMP3.a
> liba52/liba52.a libmpeg2/libmpeg2.a libfaad2/libfaad2.a
> tremor/libvorbisidec.a osdep/libosdep.a -lopengl32 -lgdi32 -lwinmm
> -lwinmm  -liconv -lncurses -lpng -lz -L/usr/local/lib  -static -lm
> -lstdc++ -lm /home/Vincenz/x264/libx264.a
> /home/Vincenz/live2/live/BasicUsageEnvironment/libBasicUsageEnvironment.a

Re: Re: MPlayer-cygwin Digest, Vol 51, Issue 4

--- KyubIX <AdministrateurA <at> gmail.com> wrote:

>.a>                  -L/home/Kyubi/mplayer/extra
> -L/home/Kyubi/mplayer/extra/bin
> -L/home/Kyubi/mplayer/extra/include
> -L/home/Kyubi/mplayer/extra/lame-3.97
> -L/home/Kyubi/mplayer/extra/lib
> -L/home/Kyubi/mplayer/extra/live
> -L/home/Kyubi/mplayer/extra/man
> -L/home/Kyubi/mplayer/extra/share
> -L/home/Kyubi/mplayer/extra/x264
> -L/home/Kyubi/mplayer/extra/xvidcore-1.1.2
> -lwinmm  -liconv -ltermcap -lpng -lz -ljpeg
> -lfreetype -lz -lz -ladvapi32
> -lole32  -lstdc++ -lxvidcore -lm    -static -lm
>
stream/stream.a(stream_vcd.o):stream_vcd.c:(.text+0x598):
> undefined reference to
> `__open_osfhandle'
>
libavcodec/libavcodec.a(mpegaudiodec.o):mpegaudiodec.c:(.text+0x5a0):
> undefined
> reference to `_llrint'
> collect2: ld returned 1 exit status
> make: *** [mplayer.exe] Error 1
> 
> I'm runing this on Windows x64 (amd X2) with Cygwin
> (32 although) so if you have
> an idea I'll be gratefuly to know.

Re: MPlayer-cygwin Digest, Vol 52, Issue 5

I have a very dirty trick for you: just change the occurrences of llrint
to lrint (e.g., add a #define llrint lrint)
Very dirty, but it works!
Cheers
Enzo

mplayer-cygwin-request <at> mplayerhq.hu ha scritto:
> Send MPlayer-cygwin mailing list submissions to
> 	mplayer-cygwin <at> mplayerhq.hu
>
> To subscribe or unsubscribe via the World Wide Web, visit
> 	http://lists.mplayerhq.hu/mailman/listinfo/mplayer-cygwin
> or, via email, send a message with subject or body 'help' to
> 	mplayer-cygwin-request <at> mplayerhq.hu
>
> You can reach the person managing the list at
> 	mplayer-cygwin-owner <at> mplayerhq.hu
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of MPlayer-cygwin digest..."
>
>
> Today's Topics:
>
>    1. Re: MPlayer-cygwin Digest, Vol 51, Issue 4 (KyubIX)
>    2. Re: Re: MPlayer-cygwin Digest, Vol 51, Issue 4 (Asonganyi D.)
>
>
> ----------------------------------------------------------------------
>

build issue

Current CVS won't compile with mingw without u_char and u_long being defined
for usage in vidix/pm2_vid.c
Can someone please fix this?
~zid