Kenneth Graunke | 1 Jun 01:19 2012

[PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".

Tungsten Graphics has not existed for several years, and the majority of
ongoing development and support is done by Intel.  I chose to include
"Open Source Technology Center" to distinguish it from, say, the closed
source Windows OpenGL driver.

The one downside to this patch is that applications that pattern match
against "Intel" may start applying workarounds meant for the Windows
driver.  However, it does seem like the right thing to do.

This does change oglconform behavior.

Acked-by: Eric Anholt <eric <at> anholt.net>
Acked-by: Ian Romanick <ian.d.romanick <at> intel.com>
Cc: Eugeni Dodonov <eugeni <at> dodonov.net>
Signed-off-by: Kenneth Graunke <kenneth <at> whitecape.org>
---
 src/mesa/drivers/dri/intel/intel_context.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
index 9deb4ca..712acb8 100644
--- a/src/mesa/drivers/dri/intel/intel_context.c
+++ b/src/mesa/drivers/dri/intel/intel_context.c
 <at>  <at>  -72,7 +72,7  <at>  <at>  intelGetString(struct gl_context * ctx, GLenum name)

    switch (name) {
    case GL_VENDOR:
-      return (GLubyte *) "Tungsten Graphics, Inc";
+      return (GLubyte *) "Intel® Open Source Technology Center";
       break;
(Continue reading)

Roland Mainz | 1 Jun 01:28 2012

Re: [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke <kenneth <at> whitecape.org> wrote:
> Tungsten Graphics has not existed for several years, and the majority of
> ongoing development and support is done by Intel.  I chose to include
> "Open Source Technology Center" to distinguish it from, say, the closed
> source Windows OpenGL driver.
>
> The one downside to this patch is that applications that pattern match
> against "Intel" may start applying workarounds meant for the Windows
> driver.  However, it does seem like the right thing to do.
>
> This does change oglconform behavior.
>
> Acked-by: Eric Anholt <eric <at> anholt.net>
> Acked-by: Ian Romanick <ian.d.romanick <at> intel.com>
> Cc: Eugeni Dodonov <eugeni <at> dodonov.net>
> Signed-off-by: Kenneth Graunke <kenneth <at> whitecape.org>
> ---
>  src/mesa/drivers/dri/intel/intel_context.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
> index 9deb4ca..712acb8 100644
> --- a/src/mesa/drivers/dri/intel/intel_context.c
> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>  <at>  <at>  -72,7 +72,7  <at>  <at>  intelGetString(struct gl_context * ctx, GLenum name)
>
>    switch (name) {
>    case GL_VENDOR:
> -      return (GLubyte *) "Tungsten Graphics, Inc";
> +      return (GLubyte *) "Intel® Open Source Technology Center";
(Continue reading)

Alan Coopersmith | 1 Jun 01:34 2012
Picon

Re: [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

On 05/31/12 04:28 PM, Roland Mainz wrote:
> On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke <kenneth <at> whitecape.org> wrote:
>>    switch (name) {
>>    case GL_VENDOR:
>> -      return (GLubyte *) "Tungsten Graphics, Inc";
>> +      return (GLubyte *) "Intel® Open Source Technology Center";
>>       break;
> 
> Uhm... isn't "®" a character outside the ASCII range ? Some compiles
> might choke on this, i.e. the Sun Workshop/Forte/Studio compilers
> require -xcsi ("... This option allows the C compiler to accept source
> code written in locales that do not conform to the ISO C source
> character code requirements. These locales include ja_JP.PCK ...") to
> avoid occasional hiccups.

I don't remember having any problems with the Studio compilers using UTF-8
characters, but they do break down if you use other encodings that appear
to cause invalid UTF-8 sequences.

--

-- 
	-Alan Coopersmith-              alan.coopersmith <at> oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
mesa-dev mailing list
mesa-dev <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Roland Mainz | 1 Jun 01:44 2012

Re: [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

On Fri, Jun 1, 2012 at 1:34 AM, Alan Coopersmith
<alan.coopersmith <at> oracle.com> wrote:
> On 05/31/12 04:28 PM, Roland Mainz wrote:
>> On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke <kenneth <at> whitecape.org> wrote:
>>>    switch (name) {
>>>    case GL_VENDOR:
>>> -      return (GLubyte *) "Tungsten Graphics, Inc";
>>> +      return (GLubyte *) "Intel® Open Source Technology Center";
>>>       break;
>>
>> Uhm... isn't "®" a character outside the ASCII range ? Some compiles
>> might choke on this, i.e. the Sun Workshop/Forte/Studio compilers
>> require -xcsi ("... This option allows the C compiler to accept source
>> code written in locales that do not conform to the ISO C source
>> character code requirements. These locales include ja_JP.PCK ...") to
>> avoid occasional hiccups.
>
> I don't remember having any problems with the Studio compilers using UTF-8
> characters,

Technically they shouldn't... but I still remember being chased around
(oh... yes... I lively remember *THAT* ... *shudder* ... the teeth...
these horrible t...[1]) by Sun's ON gatekeeper for causing the
occasional one in 100 random build failures until we figured out that
we need to add -xcsi (see
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/Makefile.ast#73).

[1]=Yes, yes... I'm joking a bit... :-)

> but they do break down if you use other encodings that appear
(Continue reading)

Kenneth Graunke | 1 Jun 01:45 2012

Re: [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

On 05/31/2012 04:28 PM, Roland Mainz wrote:
> On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke<kenneth <at> whitecape.org>  wrote:
>> Tungsten Graphics has not existed for several years, and the majority of
>> ongoing development and support is done by Intel.  I chose to include
>> "Open Source Technology Center" to distinguish it from, say, the closed
>> source Windows OpenGL driver.
>>
>> The one downside to this patch is that applications that pattern match
>> against "Intel" may start applying workarounds meant for the Windows
>> driver.  However, it does seem like the right thing to do.
>>
>> This does change oglconform behavior.
>>
>> Acked-by: Eric Anholt<eric <at> anholt.net>
>> Acked-by: Ian Romanick<ian.d.romanick <at> intel.com>
>> Cc: Eugeni Dodonov<eugeni <at> dodonov.net>
>> Signed-off-by: Kenneth Graunke<kenneth <at> whitecape.org>
>> ---
>>   src/mesa/drivers/dri/intel/intel_context.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
>> index 9deb4ca..712acb8 100644
>> --- a/src/mesa/drivers/dri/intel/intel_context.c
>> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>>  <at>  <at>  -72,7 +72,7  <at>  <at>  intelGetString(struct gl_context * ctx, GLenum name)
>>
>>     switch (name) {
>>     case GL_VENDOR:
>> -      return (GLubyte *) "Tungsten Graphics, Inc";
(Continue reading)

Ian Romanick | 1 Jun 04:59 2012

Re: [PATCH 20/26] mesa/tests: Add tests for the generated dispatch table

On 05/30/2012 03:19 PM, Eric Anholt wrote:
> On Tue, 29 May 2012 15:51:47 -0700, "Ian Romanick"<idr <at> freedesktop.org>  wrote:
>> +TEST(GetProcAddress, ABINameByOffset)
>> +{
>> +   /* 408 functions have had their locations in the dispatch table set since
>> +    * the danw of time.  Verify that all of these functions are at the correct
>               ^dawn

D'oh!

> (also copy and pasted)
>
> I don't like the "as big as at some git sha1" test given that you
> immediately go on to show that the test is invalid and just hack around
> it.  That sounds to me like "this test should be removed".  Maybe just
> check that it's bigger than the fixed ABI?

The intention is for the test to catch changes that accidentally cause 
the dispatch table to shrink.  The dispatch table pretty much only ever 
grows.  The most recent change to gl_API.xml that caused the dispatch 
table to shrink was a5f220607 in 2006.  I'd be surprised if there were 
more changes after this series that shrink the dispatch table before 
another 6 years. :)

Anything else that causes a shrink is a bug.  I want to have some kind 
of test for that, but it doesn't necessarily have to be this test.
Pekka Paalanen | 1 Jun 08:18 2012
Picon

Re: [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".

On Thu, 31 May 2012 16:19:17 -0700
Kenneth Graunke <kenneth <at> whitecape.org> wrote:

> Tungsten Graphics has not existed for several years, and the majority of
> ongoing development and support is done by Intel.  I chose to include
> "Open Source Technology Center" to distinguish it from, say, the closed
> source Windows OpenGL driver.
> 
> The one downside to this patch is that applications that pattern match
> against "Intel" may start applying workarounds meant for the Windows
> driver.  However, it does seem like the right thing to do.
> 
> This does change oglconform behavior.
> 
> Acked-by: Eric Anholt <eric <at> anholt.net>
> Acked-by: Ian Romanick <ian.d.romanick <at> intel.com>
> Cc: Eugeni Dodonov <eugeni <at> dodonov.net>
> Signed-off-by: Kenneth Graunke <kenneth <at> whitecape.org>
> ---
>  src/mesa/drivers/dri/intel/intel_context.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
> index 9deb4ca..712acb8 100644
> --- a/src/mesa/drivers/dri/intel/intel_context.c
> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>  <at>  <at>  -72,7 +72,7  <at>  <at>  intelGetString(struct gl_context * ctx, GLenum name)
>  
>     switch (name) {
>     case GL_VENDOR:
(Continue reading)

Pekka Paalanen | 1 Jun 08:34 2012
Picon

Re: [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".

On Fri, 1 Jun 2012 09:18:44 +0300
Pekka Paalanen <ppaalanen <at> gmail.com> wrote:

> On Thu, 31 May 2012 16:19:17 -0700
> Kenneth Graunke <kenneth <at> whitecape.org> wrote:
> 
> > Tungsten Graphics has not existed for several years, and the majority of
> > ongoing development and support is done by Intel.  I chose to include
> > "Open Source Technology Center" to distinguish it from, say, the closed
> > source Windows OpenGL driver.
> > 
> > The one downside to this patch is that applications that pattern match
> > against "Intel" may start applying workarounds meant for the Windows
> > driver.  However, it does seem like the right thing to do.
> > 
> > This does change oglconform behavior.
> > 
> > Acked-by: Eric Anholt <eric <at> anholt.net>
> > Acked-by: Ian Romanick <ian.d.romanick <at> intel.com>
> > Cc: Eugeni Dodonov <eugeni <at> dodonov.net>
> > Signed-off-by: Kenneth Graunke <kenneth <at> whitecape.org>
> > ---
> >  src/mesa/drivers/dri/intel/intel_context.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
> > index 9deb4ca..712acb8 100644
> > --- a/src/mesa/drivers/dri/intel/intel_context.c
> > +++ b/src/mesa/drivers/dri/intel/intel_context.c
> >  <at>  <at>  -72,7 +72,7  <at>  <at>  intelGetString(struct gl_context * ctx, GLenum name)
(Continue reading)

Eirik Byrkjeflot Anonsen | 1 Jun 08:31 2012
Picon

Re: [PATCH] intel: Change vendor string to "Intel(R) Open Source Technology Center".

Kenneth Graunke <kenneth <at> whitecape.org> writes:

> On 05/31/2012 04:28 PM, Roland Mainz wrote:
>> On Fri, Jun 1, 2012 at 1:19 AM, Kenneth Graunke<kenneth <at> whitecape.org>  wrote:
>>>     switch (name) {
>>>     case GL_VENDOR:
>>> -      return (GLubyte *) "Tungsten Graphics, Inc";
>>> +      return (GLubyte *) "Intel® Open Source Technology Center";
>>>        break;
>>
>> Uhm... isn't "®" a character outside the ASCII range ? Some compiles
>> might choke on this, i.e. the Sun Workshop/Forte/Studio compilers
>> require -xcsi ("... This option allows the C compiler to accept source
>> code written in locales that do not conform to the ISO C source
>> character code requirements. These locales include ja_JP.PCK ...") to
>> avoid occasional hiccups.
>
> I'm happy to change it if it's an issue, but I believe that the ®
> character already appears in the source code:
>
>       case PCI_CHIP_GM45_GM:
>          chipset = "Mobile Intel® GM45 Express Chipset";
>          break;

I believe the C89 specification disallows the use of characters outside
the basic character set in the source file.  The "basic character set"
is a subset of the characters representable by ASCII.  Or alternatively,
that it leaves the effect "implementation-defined" or maybe even
"undefined".  But I don't have the C89 specification lying around to
check.
(Continue reading)

Oliver McFadden | 1 Jun 09:33 2012
Picon

Re: [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".

On Fri, Jun 01, 2012 at 09:18:44AM +0300, Pekka Paalanen wrote:
> On Thu, 31 May 2012 16:19:17 -0700
> Kenneth Graunke <kenneth <at> whitecape.org> wrote:
> 
> > Tungsten Graphics has not existed for several years, and the majority of
> > ongoing development and support is done by Intel.  I chose to include
> > "Open Source Technology Center" to distinguish it from, say, the closed
> > source Windows OpenGL driver.
> > 
> > The one downside to this patch is that applications that pattern match
> > against "Intel" may start applying workarounds meant for the Windows
> > driver.  However, it does seem like the right thing to do.
> > 
> > This does change oglconform behavior.
> > 
> > Acked-by: Eric Anholt <eric <at> anholt.net>
> > Acked-by: Ian Romanick <ian.d.romanick <at> intel.com>
> > Cc: Eugeni Dodonov <eugeni <at> dodonov.net>
> > Signed-off-by: Kenneth Graunke <kenneth <at> whitecape.org>
> > ---
> >  src/mesa/drivers/dri/intel/intel_context.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
> > index 9deb4ca..712acb8 100644
> > --- a/src/mesa/drivers/dri/intel/intel_context.c
> > +++ b/src/mesa/drivers/dri/intel/intel_context.c
> >  <at>  <at>  -72,7 +72,7  <at>  <at>  intelGetString(struct gl_context * ctx, GLenum name)
> >  
> >     switch (name) {
(Continue reading)


Gmane