headers
Ian Romanick | 1 Sep 2011 02:58

Re: [PATCH] mesa: Replace the EmitNoIfs compiler flag with a MaxIfLevel flag.


On 08/31/2011 03:30 PM, Bryan Cain wrote:
> This is a better, more fine-grained way of lowering if statements.  Fixes the
> game And Yet It Moves on nv50.

Other than the one comment below,

Reviewed-by: Ian Romanick <ian.d.romanick <at> intel.com>

> ---
>  src/mesa/drivers/dri/i915/i915_context.c   |    2 +-
>  src/mesa/main/mtypes.h                     |    6 +-----
>  src/mesa/program/ir_to_mesa.cpp            |    8 ++++----
>  src/mesa/state_tracker/st_extensions.c     |    2 +-
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    6 +++---
>  5 files changed, 10 insertions(+), 14 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i915/i915_context.c b/src/mesa/drivers/dri/i915/i915_context.c
> index 11bee14..7a40ba1 100644
> --- a/src/mesa/drivers/dri/i915/i915_context.c
> +++ b/src/mesa/drivers/dri/i915/i915_context.c
>  <at>  <at>  -189,7 +189,7  <at>  <at>  i915CreateContext(int api,
>  
>     struct gl_shader_compiler_options *const fs_options =
>        & ctx->ShaderCompilerOptions[MESA_SHADER_FRAGMENT];
> -   fs_options->EmitNoIfs = GL_TRUE;
> +   fs_options->MaxIfLevel = 0;
>     fs_options->EmitNoNoise = GL_TRUE;
>     fs_options->EmitNoPow = GL_TRUE;
>     fs_options->EmitNoMainReturn = GL_TRUE;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ian Romanick | 1 Sep 2011 03:00

Re: [PATCH 2/3] i915: factor our source lists into Makefile.sources


On 08/30/2011 10:27 PM, Chia-I Wu wrote:
> From: Chia-I Wu <olv <at> lunarg.com>
> 
> In preparation for porting i915 to Android, factor its source lists into
> a shared makefile. This prevents duplication of source lists, and hence
> prevents the Android from breaking as often.

I think you meant "the Android build" in the commit message.

> ---
>  src/mesa/drivers/dri/i915/Makefile         |   51 ++-------------------------
>  src/mesa/drivers/dri/i915/Makefile.sources |   49 ++++++++++++++++++++++++++
>  2 files changed, 53 insertions(+), 47 deletions(-)
>  create mode 100644 src/mesa/drivers/dri/i915/Makefile.sources
> 
> diff --git a/src/mesa/drivers/dri/i915/Makefile b/src/mesa/drivers/dri/i915/Makefile
> index 79e03f2..e2e5382 100644
> --- a/src/mesa/drivers/dri/i915/Makefile
> +++ b/src/mesa/drivers/dri/i915/Makefile
>  <at>  <at>  -6,59 +6,16  <at>  <at>  LIBNAME = i915_dri.so
>  
>  include ../Makefile.defines
>  
> -DRIVER_SOURCES = \
> -	i830_context.c \
> -	i830_state.c \
> -	i830_texblend.c \
> -	i830_texstate.c \
> -	i830_vtbl.c \
(Continue reading)

Permalink | Reply | 1 comment |
headers
Chia-I Wu | 1 Sep 2011 04:33
Picon

Re: [PATCH 2/3] i915: factor our source lists into Makefile.sources

On Thu, Sep 1, 2011 at 9:00 AM, Ian Romanick <idr <at> freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/30/2011 10:27 PM, Chia-I Wu wrote:
>> From: Chia-I Wu <olv <at> lunarg.com>
>>
>> In preparation for porting i915 to Android, factor its source lists into
>> a shared makefile. This prevents duplication of source lists, and hence
>> prevents the Android from breaking as often.
>
> I think you meant "the Android build" in the commit message.
Yes, thanks.

--

-- 
olv <at> LunarG.com
Permalink | Reply | 0 comments |
headers
Chia-I Wu | 1 Sep 2011 04:35
Picon

Re: [PATCH 1/3] i965: fix Android build

On Thu, Sep 1, 2011 at 6:48 AM, Chad Versace <chad <at> chad-versace.us> wrote:
> On 08/30/2011 10:27 PM, Chia-I Wu wrote:
>> From: Chia-I Wu <olv <at> lunarg.com>
>>
>> Use $(TARGET_CC) instead of $(CC).  Correctly name and set LOCAL_CFLAGS.
>> ---
>>  src/mesa/drivers/dri/Android.mk      |    5 +++++
>>  src/mesa/drivers/dri/i965/Android.mk |    7 +++----
>>  2 files changed, 8 insertions(+), 4 deletions(-)
>
> Thanks for fixing the mistakes in i965/Android.mk. I was unaware of TARGET_CC.
>
> I tested the i915 build, both with Android and Autoconf. So, for the series:
> Reviewed-by: Chad Versace <chad <at> chad-versace.us>
Thanks for the review.  I will push shortly.
>
> --
> Chad Versace
> chad <at> chad-versace.us
>

--

-- 
olv <at> LunarG.com
_______________________________________________
mesa-dev mailing list
mesa-dev <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Permalink | Reply | 0 comments |
headers
Chia-I Wu | 1 Sep 2011 04:35
Picon

Re: [PATCH 8/8] intel: enable GL_OES_draw_texture

On Thu, Sep 1, 2011 at 4:06 AM, Ian Romanick <idr <at> freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/30/2011 10:46 PM, Chia-I Wu wrote:
>> From: Chia-I Wu <olv <at> lunarg.com>
>>
>> ---
>>  src/mesa/drivers/dri/intel/intel_extensions_es.c |    1 +
>>  src/mesa/drivers/dri/intel/intel_tex.c           |    1 +
>>  2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/intel/intel_extensions_es.c b/src/mesa/drivers/dri/intel/intel_extensions_es.c
>> index 2af616e..fdb6318 100644
>> --- a/src/mesa/drivers/dri/intel/intel_extensions_es.c
>> +++ b/src/mesa/drivers/dri/intel/intel_extensions_es.c
>>  <at>  <at>  -73,6 +73,7  <at>  <at>  static const char *es1_extensions[] = {
>>     "GL_EXT_blend_equation_separate",
>>     "GL_EXT_blend_func_separate",
>>     "GL_EXT_blend_subtract",
>> +   "GL_OES_draw_texture",
>>     "GL_ARB_framebuffer_object",
>>     "GL_EXT_framebuffer_object",
>>     "GL_ARB_point_sprite",
>> diff --git a/src/mesa/drivers/dri/intel/intel_tex.c b/src/mesa/drivers/dri/intel/intel_tex.c
>> index 4faa01a..5fdc29b 100644
>> --- a/src/mesa/drivers/dri/intel/intel_tex.c
>> +++ b/src/mesa/drivers/dri/intel/intel_tex.c
>>  <at>  <at>  -209,4 +209,5  <at>  <at>  intelInitTextureFuncs(struct dd_function_table *functions)
>>     functions->FreeTextureImageBuffer = intel_free_texture_image_buffer;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chia-I Wu | 1 Sep 2011 04:41
Picon

Re: [PATCH 7/8] meta: add _mesa_meta_DrawTex()

On Thu, Sep 1, 2011 at 4:04 AM, Ian Romanick <idr <at> freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/30/2011 10:46 PM, Chia-I Wu wrote:
>> From: Chia-I Wu <olv <at> lunarg.com>
>>
>> It can be used for dd->DrawTex.
>
> My main concern about this is that we have exactly zero tests for this
> extension.  Before this is enabled in Intel drivers, I want there to be
> at least some test coverage.  I always have Keith Packard's adage, "Any
> code that isn't tested is broken." in the back of my mind... and I hate
> it when he's right. :)
I think you are right.  I will work on a piglit test before committing
this change (but likely not today).  There is a demo in demos repo
meanwhile if you want to play with it.

> There's one other comment below.  I was going to say more, but I decided
> I was wrong.
>
>> ---
>>  src/mesa/drivers/common/meta.c |  141 ++++++++++++++++++++++++++++++++++++++++
>>  src/mesa/drivers/common/meta.h |    3 +
>>  2 files changed, 144 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
>> index 291d912..c772543 100644
>> --- a/src/mesa/drivers/common/meta.c
>> +++ b/src/mesa/drivers/common/meta.c
(Continue reading)

Permalink | Reply | 0 comments |
headers
Chia-I Wu | 1 Sep 2011 04:50
Picon

Re: [PATCH 0/8] intel: fixes and features for Android

On Thu, Sep 1, 2011 at 3:42 AM, Ian Romanick <idr <at> freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/30/2011 10:46 PM, Chia-I Wu wrote:
>> Hi,
>>
>> There are 3 changes in this series.  They are combined into a single
>> series so that it is clear where they lead to.  I will split them up
>> if there is a v2.  Tested with i915.
>>
>> Patch 1-2: enable GLESv1 extensions
>>
>>   They add intelInitExtensionsES1 that is called to enable extensions
>>   that are required by or optional to GLESv1.
>
> As much as I hate to keep these multiple extension lists going, these
> two are
>
> Reviewed-by: Ian Romanick <ian.d.romanick <at> intel.com>
While agreeing with you, I will push this part first :)

Other than the multiple extension lists issue, incidentally, how
arguments are checked under different profiles (compat, core, gles2,
...) may also need to be changed..

>> Patch 3-6: add __DRI_IMAGE_FORMAT_RGBA8888_REV
>>
>>   They add a new __DRI_IMAGE format, which is used by translucent
>>   surfaces on Android.  Patch 4 makes i915/i965 support the new
(Continue reading)

Permalink | Reply | 0 comments |
headers
Brian Paul | 1 Sep 2011 05:32
Favicon

Re: map-texture-image-v5 branch

Eric,

I've pushed some more patches to the map-texture-image-v5 branch. 
This should fix some (all, maybe?) of your regressions.

There's still a few failures with some compressed formats, but I'm 
suspecting they're bugs in the block compression/decompression logic 
in a couple cases.  They're present in Mesa/master too.

-Brian
Permalink | Reply | 0 comments |
headers
Brian Paul | 1 Sep 2011 05:36
Favicon

Re: [PATCH 01/11] mesa: Remove API facing bits of EXT_paletted_texture and EXT_shared_texture_palette

On 08/31/2011 02:21 PM, Ian Romanick wrote:
> From: Ian Romanick<ian.d.romanick <at> intel.com>
>
> This was also discussed at XDS 2010.  However, actually making the
> change was delayed because several drivers still exposed these
> extensions to significant benefit (e.g., tdfx).  Now that those
> drivers have been removed, this code can be removed as well.
>
> v2: A lot of bits that were missed in the previous patch have been removed.

For the series:
Reviewed-by: Brian Paul <brianp <at> vmware.com>

I presume you've run conform on this.  It tests color index in a few 
ways (like CI->RGBA in glDrawPixels).

-Brian
Permalink | Reply | 1 comment |
headers
Benjamin Franzke | 1 Sep 2011 11:53

[PATCH] st/egl: Prepare for EGL_ALPHA_FORMAT

In preparation for wayland ALPHA_FORMAT usage,
see commit 7b1d94e5d1f53ac5f59000176aea1d02fc9a1181.

Changes:
 - New native_config surface_type bit: alpha_format_pre_bit
 - Introduction of native_surface_attribs
   (as new parameter in create_{window,pixmap}_surface)
 - New attrib alpha_format in native_surface_attribs

CC: Chia-I Wu <olv <at> lunarg.com>
---
 .../state_trackers/egl/android/native_android.cpp  |    3 ++-
 src/gallium/state_trackers/egl/common/egl_g3d.c    |    3 +++
 .../state_trackers/egl/common/egl_g3d_api.c        |   13 +++++++++++--
 .../state_trackers/egl/common/egl_g3d_image.c      |    2 +-
 src/gallium/state_trackers/egl/common/native.h     |   11 +++++++++--
 .../state_trackers/egl/common/native_helper.c      |    2 +-
 src/gallium/state_trackers/egl/drm/native_drm.c    |    3 ++-
 src/gallium/state_trackers/egl/gdi/native_gdi.c    |    3 ++-
 .../state_trackers/egl/wayland/native_wayland.c    |    6 ++++--
 src/gallium/state_trackers/egl/x11/native_dri2.c   |    6 ++++--
 src/gallium/state_trackers/egl/x11/native_ximage.c |    6 ++++--
 11 files changed, 43 insertions(+), 15 deletions(-)

diff --git a/src/gallium/state_trackers/egl/android/native_android.cpp b/src/gallium/state_trackers/egl/android/native_android.cpp
index 338427d..e4a74b3 100644
--- a/src/gallium/state_trackers/egl/android/native_android.cpp
+++ b/src/gallium/state_trackers/egl/android/native_android.cpp
 <at>  <at>  -494,7 +494,8  <at>  <at>  android_surface_destroy(struct native_surface *nsurf)
 static struct native_surface *
(Continue reading)

Permalink | Reply | 3 comments |

Gmane