Robert Noland | 1 Dec 01:24 2009
Picon

Re: [PATCH] gallium: ERESTART is not returned to userland, at least not on FreeBSD

On Tue, 2009-12-01 at 10:37 +1100, Daniel Stone wrote:
> On Mon, Nov 30, 2009 at 11:21:47AM -0600, Robert Noland wrote:
> > I've tried to ask linux folk if this is also true for linux, but the
> > answer is unclear at this time.
> 
> EINTR will be returned to userspace if the syscall needs to be restarted.

Ok, EINTR is already handled in drmIoctl() as is EAGAIN, so that sounds
like my patch would be correct.

robert.

> Cheers,
> Daniel
--

-- 
Robert Noland <rnoland <at> 2hip.net>
2Hip Networks

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
Jakob Bornecrantz | 1 Dec 01:37 2009

Re: [PATCH] gallium: ERESTART is not returned to userland, at least not on FreeBSD

On 1 dec 2009, at 00.24, Robert Noland wrote:
> On Tue, 2009-12-01 at 10:37 +1100, Daniel Stone wrote:
>> On Mon, Nov 30, 2009 at 11:21:47AM -0600, Robert Noland wrote:
>>> I've tried to ask linux folk if this is also true for linux, but the
>>> answer is unclear at this time.
>>
>> EINTR will be returned to userspace if the syscall needs to be  
>> restarted.
>
> Ok, EINTR is already handled in drmIoctl() as is EAGAIN, so that  
> sounds
> like my patch would be correct.

Hmm looks like we need to change bunch of stuff in ttm and the vmwgfx  
for that to be true. I still like to get Thomas comments on this  
before we do anything drastic.

Cheers Jakob.

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
Ian Romanick | 1 Dec 02:37 2009

Re: Mesa (mesa_7_7_branch): mesa: Fix array out-of-bounds access by _mesa_TexGeni.


Vinson Lee wrote:
> Module: Mesa
> Branch: mesa_7_7_branch

Our agreed process is that bug fixes, especially ones with low
probability of breaking other things, are supposed to go into the oldest
open tree *first*.  In this case, and the case of the several other of
your recent commits, this should have been mesa_7_6_branch.

If having more than two open trees is a problem for people because of
this policy, we probably need to revisit the policy.  Having a stable
release branch, a stabilization branch, and a development branch is not
outrageous.  We should be able to handle this.

> Commit: d55fb7c835b56951f05a058083e7eda264ba192e
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d55fb7c835b56951f05a058083e7eda264ba192e
> 
> Author: Vinson Lee <vlee <at> vmware.com>
> Date:   Sat Nov 28 23:47:23 2009 -0500
> 
> mesa: Fix array out-of-bounds access by _mesa_TexGeni.
> 
> _mesa_TexGeni calls _mesa_TexGeniv, which uses the params argument
> as an array.
> 
> ---
> 
>  src/mesa/main/texgen.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
(Continue reading)

Ian Romanick | 1 Dec 03:13 2009

Mesa 7.6.2 release candidate 2 and Mesa 7.7 release candidate 1


Mesa 7.6.1-rc2 available for testing at
ftp://freedesktop.org/pub/mesa/7.6.1/

md5sums:

afc6bb9054126d4718e2da321e6ec1c3  MesaDemos-7.6.1-rc2.tar.bz2
0b476cf2c7cffabea44462836df2c319  MesaDemos-7.6.1-rc2.tar.gz
571997ca6ae98ce888fb9567221fedb4  MesaDemos-7.6.1-rc2.zip
99403e32ab7d5c3c01fc36538d324eba  MesaGLUT-7.6.1-rc2.tar.bz2
e79f1b53885be1c4ef24812ebaee770f  MesaGLUT-7.6.1-rc2.tar.gz
cae0debfc5b6eb5834ec96c8bf72fc9e  MesaGLUT-7.6.1-rc2.zip
965e157b47e241efaadaf84e3c5bd9e0  MesaLib-7.6.1-rc2.tar.bz2
d911a1997b40cfcaa80feaf2a3d549db  MesaLib-7.6.1-rc2.tar.gz
a91f1e7ab5c45a853ea0fc66b4225ecb  MesaLib-7.6.1-rc2.zip

Mesa 7.7-rc1 available for testing at ftp://freedesktop.org/pub/mesa/7.7/

md5sums:

26ab30acefc8a997f57eb4f77c181704  MesaDemos-7.7-rc1-devel.tar.bz2
298bf2ed316cc2319a68eb665c773350  MesaDemos-7.7-rc1-devel.tar.gz
6af3ad7597af936f11d3e54837ec64e8  MesaDemos-7.7-rc1-devel.zip
5091102478d5ebe41dc26b1093ec9503  MesaGLUT-7.7-rc1-devel.tar.bz2
20fccac320ba885f1d469d260788372c  MesaGLUT-7.7-rc1-devel.tar.gz
9102a094817d55b48af21383c750c7b7  MesaGLUT-7.7-rc1-devel.zip
4a1033071a1ef0b92080737deec2e893  MesaLib-7.7-rc1-devel.tar.bz2
72a39587772133a2e42cbcb6a942861d  MesaLib-7.7-rc1-devel.tar.gz
c4a909c945f1d154b6352e6c8faac5aa  MesaLib-7.7-rc1-devel.zip
(Continue reading)

Keith Whitwell | 1 Dec 08:32 2009

Re: Mesa (mesa_7_7_branch): mesa: Fix array out-of-bounds access by _mesa_TexGeni.

It should be straightforward to handle this - it just means merging 7.6->7.7 and then 7.7->master.

Vinson - is there any problem doing your bugfixing against the 7.6 branch, and then having the changes flow
into master as above?

Keith
________________________________________
From: Ian Romanick [idr <at> freedesktop.org]
Sent: Monday, November 30, 2009 5:37 PM
To: Vinson Lee
Cc: mesa3d-dev <at> lists.sourceforge.net
Subject: Re: [Mesa3d-dev] Mesa (mesa_7_7_branch): mesa: Fix array out-of-bounds access by _mesa_TexGeni.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vinson Lee wrote:
> Module: Mesa
> Branch: mesa_7_7_branch

Our agreed process is that bug fixes, especially ones with low
probability of breaking other things, are supposed to go into the oldest
open tree *first*.  In this case, and the case of the several other of
your recent commits, this should have been mesa_7_6_branch.

If having more than two open trees is a problem for people because of
this policy, we probably need to revisit the policy.  Having a stable
release branch, a stabilization branch, and a development branch is not
outrageous.  We should be able to handle this.

(Continue reading)

Thomas Hellstrom | 1 Dec 10:17 2009

Re: [PATCH] gallium: ERESTART is not returned to userland, at least not on FreeBSD

Jakob Bornecrantz wrote:
> On 1 dec 2009, at 00.24, Robert Noland wrote:
>   
>> On Tue, 2009-12-01 at 10:37 +1100, Daniel Stone wrote:
>>     
>>> On Mon, Nov 30, 2009 at 11:21:47AM -0600, Robert Noland wrote:
>>>       
>>>> I've tried to ask linux folk if this is also true for linux, but the
>>>> answer is unclear at this time.
>>>>         
>>> EINTR will be returned to userspace if the syscall needs to be  
>>> restarted.
>>>       
>> Ok, EINTR is already handled in drmIoctl() as is EAGAIN, so that  
>> sounds
>> like my patch would be correct.
>>     
>
> Hmm looks like we need to change bunch of stuff in ttm and the vmwgfx  
> for that to be true. I still like to get Thomas comments on this  
> before we do anything drastic.
>
>   
Yes, there is some stuff we need to change here, really.

As previously pointed out by people on the dri-devel list (Kristian 
among others), if the linux kernel returns
-ERESTARTSYS, and the kernel cannot restart the system call AND there is 
a signal pending, the kernel (not libc) will convert it to -EINTR and 
return to user-space. -ERESTARTSYS may only be returned when there is a 
(Continue reading)

Ian Romanick | 1 Dec 11:16 2009

Re: Mesa (mesa_7_7_branch): mesa: Fix array out-of-bounds access by _mesa_TexGeni.


Keith Whitwell wrote:
> It should be straightforward to handle this - it just means merging 7.6->7.7 and then 7.7->master.

Speaking of which... there are a bunch of conflicts merging 7.7 to
master in Galliumland.  Could one of you guys take a look at it?  I have
no clue what's going on over there.

> Vinson - is there any problem doing your bugfixing against the 7.6 branch, and then having the changes flow
into master as above?

Tomáš Chvátal | 1 Dec 11:28 2009
Picon

Re: Mesa 7.6.2 release candidate 2 and Mesa 7.7 release candidate 1

Dne úterý 01 Prosinec 2009 03:13:49 Ian Romanick napsal(a):
> Mesa 7.6.1-rc2 available for testing at
> ftp://freedesktop.org/pub/mesa/7.6.1/
> 
> md5sums:
> 
> afc6bb9054126d4718e2da321e6ec1c3  MesaDemos-7.6.1-rc2.tar.bz2
> 0b476cf2c7cffabea44462836df2c319  MesaDemos-7.6.1-rc2.tar.gz
> 571997ca6ae98ce888fb9567221fedb4  MesaDemos-7.6.1-rc2.zip
> 99403e32ab7d5c3c01fc36538d324eba  MesaGLUT-7.6.1-rc2.tar.bz2
> e79f1b53885be1c4ef24812ebaee770f  MesaGLUT-7.6.1-rc2.tar.gz
> cae0debfc5b6eb5834ec96c8bf72fc9e  MesaGLUT-7.6.1-rc2.zip
> 965e157b47e241efaadaf84e3c5bd9e0  MesaLib-7.6.1-rc2.tar.bz2
> d911a1997b40cfcaa80feaf2a3d549db  MesaLib-7.6.1-rc2.tar.gz
> a91f1e7ab5c45a853ea0fc66b4225ecb  MesaLib-7.6.1-rc2.zip
> 
> Mesa 7.7-rc1 available for testing at ftp://freedesktop.org/pub/mesa/7.7/
> 
> md5sums:
> 
> 26ab30acefc8a997f57eb4f77c181704  MesaDemos-7.7-rc1-devel.tar.bz2
> 298bf2ed316cc2319a68eb665c773350  MesaDemos-7.7-rc1-devel.tar.gz
> 6af3ad7597af936f11d3e54837ec64e8  MesaDemos-7.7-rc1-devel.zip
> 5091102478d5ebe41dc26b1093ec9503  MesaGLUT-7.7-rc1-devel.tar.bz2
> 20fccac320ba885f1d469d260788372c  MesaGLUT-7.7-rc1-devel.tar.gz
> 9102a094817d55b48af21383c750c7b7  MesaGLUT-7.7-rc1-devel.zip
> 4a1033071a1ef0b92080737deec2e893  MesaLib-7.7-rc1-devel.tar.bz2
> 72a39587772133a2e42cbcb6a942861d  MesaLib-7.7-rc1-devel.tar.gz
> c4a909c945f1d154b6352e6c8faac5aa  MesaLib-7.7-rc1-devel.zip
> 
(Continue reading)

Ian Romanick | 1 Dec 11:34 2009

Re: Mesa 7.6.2 release candidate 2 and Mesa 7.7 release candidate 1


Tomáš Chvátal wrote:
> Dne úterý 01 Prosinec 2009 03:13:49 Ian Romanick napsal(a):
>> Mesa 7.6.1-rc2 available for testing at
>> ftp://freedesktop.org/pub/mesa/7.6.1/
>>
>> md5sums:
>>
>> afc6bb9054126d4718e2da321e6ec1c3  MesaDemos-7.6.1-rc2.tar.bz2
>> 0b476cf2c7cffabea44462836df2c319  MesaDemos-7.6.1-rc2.tar.gz
>> 571997ca6ae98ce888fb9567221fedb4  MesaDemos-7.6.1-rc2.zip
>> 99403e32ab7d5c3c01fc36538d324eba  MesaGLUT-7.6.1-rc2.tar.bz2
>> e79f1b53885be1c4ef24812ebaee770f  MesaGLUT-7.6.1-rc2.tar.gz
>> cae0debfc5b6eb5834ec96c8bf72fc9e  MesaGLUT-7.6.1-rc2.zip
>> 965e157b47e241efaadaf84e3c5bd9e0  MesaLib-7.6.1-rc2.tar.bz2
>> d911a1997b40cfcaa80feaf2a3d549db  MesaLib-7.6.1-rc2.tar.gz
>> a91f1e7ab5c45a853ea0fc66b4225ecb  MesaLib-7.6.1-rc2.zip
>>
>> Mesa 7.7-rc1 available for testing at ftp://freedesktop.org/pub/mesa/7.7/
>>
>> md5sums:
>>
>> 26ab30acefc8a997f57eb4f77c181704  MesaDemos-7.7-rc1-devel.tar.bz2
>> 298bf2ed316cc2319a68eb665c773350  MesaDemos-7.7-rc1-devel.tar.gz
>> 6af3ad7597af936f11d3e54837ec64e8  MesaDemos-7.7-rc1-devel.zip
>> 5091102478d5ebe41dc26b1093ec9503  MesaGLUT-7.7-rc1-devel.tar.bz2
>> 20fccac320ba885f1d469d260788372c  MesaGLUT-7.7-rc1-devel.tar.gz
>> 9102a094817d55b48af21383c750c7b7  MesaGLUT-7.7-rc1-devel.zip
>> 4a1033071a1ef0b92080737deec2e893  MesaLib-7.7-rc1-devel.tar.bz2
>> 72a39587772133a2e42cbcb6a942861d  MesaLib-7.7-rc1-devel.tar.gz
(Continue reading)

Keith Whitwell | 1 Dec 11:44 2009

Re: Mesa (mesa_7_7_branch): mesa: Fix array out-of-bounds access by _mesa_TexGeni.

On Tue, 2009-12-01 at 02:16 -0800, Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Keith Whitwell wrote:
> > It should be straightforward to handle this - it just means merging 7.6->7.7 and then 7.7->master.
> 
> Speaking of which... there are a bunch of conflicts merging 7.7 to
> master in Galliumland.  Could one of you guys take a look at it?  I have
> no clue what's going on over there.

I can take a look.

Keith

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev

Gmane