1 Mar 2006 21:17
[Bug 6070] arb_vertex_program seems dependant on nv_vertex_program at least for glGet
<bugzilla-daemon <at> annarchy.freedesktop.org>
2006-03-01 20:17:46 GMT
2006-03-01 20:17:46 GMT
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=6070 ------- Additional Comments From rscheidegger <at> gmx.ch 2006-03-02 07:17 ------- Created an attachment (id=4790) --> (https://bugs.freedesktop.org/attachment.cgi?id=4790&action=view) proposed fix Ok, here's a patch. It's not 100% correct, as some enums are valid with not only 2, but in principle 4 extensions (like GL_PROGRAM_ERROR_POSITION_ARB), i.e. all of ARB/NV_fragment/vertex_program. That patch thus isn't correct when the fragment_program extensions are supported but the vertex extensions aren't. I changed the CHECK_EXT macros to return GL_INVALID_ENUM, same as when the enum isn't known at all (I'm not sure, is it actually necessary to return an error at all if the driver DOES know the enum, but doesn't announce the corresponding extension? In particular quake4 still hits the max_texture_image/max_texture_coord_units queries, which mesa relies on internally anyway, though I'd guess that's just an app bug), it seems illogical to return GL_INVALID_VALUE. Changed some compile-time #ifs depending on NV_vertex_program too (not that I tried compiling it that way...) which looked wrong. Could the constant names be changed to the ARB ones instead of the NV ones? In some cases the names are quite different (like MAX_TRACK_MATRICES_NV vs. MAX_PROGRAM_MATRICES_ARB) which is confusing, and I'd think the standard names should be used vs. the names from the pretty much deprecated nv extension. Some code is a bit confusing too since the enums are shared, there is code like(Continue reading)
RSS Feed