Re: [PATCH] sgienc: add a limit for maximum supported resolution

On Thu, May 31, 2012 at 08:10:04PM +0200, Piotr Bandurski wrote:
> diff --git a/libavcodec/sgienc.c b/libavcodec/sgienc.c
> index d35c7ac..4e58a7f 100644

applied

thanks

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH 2/3] bufferqueue: allow to add fields to the structure.

On Thu, May 31, 2012 at 09:59:17PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>
> ---
>  libavfilter/bufferqueue.h |    3 +++
>  1 file changed, 3 insertions(+)

LGTM

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH 1/3] af_astreamsync: set samples rate in query_formats.

On Thu, May 31, 2012 at 09:59:16PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>

should be ok

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH 3/3] af_amerge: use the buferqueue API.

On Thu, May 31, 2012 at 10:54:36PM +0200, Nicolas George wrote:
> Le tridi 13 prairial, an CCXX, Nicolas George a écrit :
> >  libavfilter/af_amerge.c |   65 +++++++++++++++++------------------------------
> 
> Please forget this patch and the previous one, I want to do it a slightly
> different way.

just read your mail after looking at patch 2
anyway, no problem, the patch was trivial ...

[...]

--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: soundtouch filter?

On 05/31/2012 08:37 AM, Nicolas George wrote:
> Le primidi 11 prairial, an CCXX, Pavel Koshevoy a écrit :
>> I have some concerns regarding timestamps.  In my opinion this
>> filter should not change the timestamps.
> Timestamps should be, as far as possible, consistent with playback duration.
> If the filter is set up to change the pitch and not the speed, the
> timestamps should be unchanged. If the filter is set up to change the speed,
> the timestamps should be scaled accordingly, IMHO.
>

This filter will consume N samples and output N/tempo samples, without affecting 
pitch.  So, at 0.5 tempo twice as many samples are output.  I am not planning on 
implementing pitch shifting in this filter.

If only audio timestamps are adjusted audio will no longer be in sync with video 
and subtitles.  This may be intentional (perhaps the user is trying to correct a 
lip-sync error caused by a telecine conversion).

However, if the users intention is to slow down or speed up everything (not just 
the audio) and keep audio/video sync then the timestamps of all streams need to 
be transformed according to the current tempo.  Frankly, I am not at all well 
versed in avfilter APIs to know how to do that yet -- I am still trying to 
figure out what an AVFilterPad is.

Regarding my preference to not change the timestamps -- I am simply concerned 
about the effect that this would have on video player time-line if the user 
varies tempo continuously during playback.

As far as I can see there are only a couple of options available for updating 
the timestamps:

Re: [PATCH 1/3] log: add category to AVClass

On Mon, May 28, 2012 at 12:53:27PM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni <at> gmx.at>
> ---
>  libavutil/avutil.h |    2 +-
>  libavutil/log.h    |   18 ++++++++++++++++++
>  2 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/avutil.h b/libavutil/avutil.h
> index acef213..2e83d1f 100644
> --- a/libavutil/avutil.h
> +++ b/libavutil/avutil.h
>  <at>  <at>  -153,7 +153,7  <at>  <at> 
>   */
>  
>  #define LIBAVUTIL_VERSION_MAJOR 51
> -#define LIBAVUTIL_VERSION_MINOR 55
> +#define LIBAVUTIL_VERSION_MINOR 56
>  #define LIBAVUTIL_VERSION_MICRO 100
>  
>  #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
> diff --git a/libavutil/log.h b/libavutil/log.h
> index 26c806f..51a5766 100644
> --- a/libavutil/log.h
> +++ b/libavutil/log.h
>  <at>  <at>  -25,6 +25,18  <at>  <at> 
>  #include "avutil.h"
>  #include "attributes.h"
>  
> +typedef enum {
> +    AV_LOG_CATEGORY_NA = 0,

Re: [PATCH 3/3] log: color prefixes according to their source.

On Mon, May 28, 2012 at 12:53:29PM +0200, Michael Niedermayer wrote:
> The use of cyan is droped from the levels to avoid confusion
> magenta/cyan/blue is used for muxer/codec/filter layer
> 
> Signed-off-by: Michael Niedermayer <michaelni <at> gmx.at>
> ---
>  libavutil/log.c |   58 +++++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 46 insertions(+), 12 deletions(-)
> 
> diff --git a/libavutil/log.c b/libavutil/log.c
> index e62f11c..22f2364 100644
> --- a/libavutil/log.c
> +++ b/libavutil/log.c
>  <at>  <at>  -34,13 +34,17  <at>  <at>  static int flags;
>  
>  #if defined(_WIN32) && !defined(__MINGW32CE__)
>  #include <windows.h>
> -static const uint8_t color[] = { 12, 12, 12, 14, 7, 10, 11 };
> +static const uint8_t color[] = { 12, 12, 12, 14, 7, 10, 10,
> +                                  3, 11,  5, 13, 1,  9
> +};
>  static int16_t background, attr_orig;
>  static HANDLE con;
>  #define set_color(x)  SetConsoleTextAttribute(con, background | color[x])
>  #define reset_color() SetConsoleTextAttribute(con, attr_orig)
>  #else
> -static const uint8_t color[] = { 0x41, 0x41, 0x11, 0x03, 9, 0x02, 0x06 };
> +static const uint8_t color[] = { 0x41, 0x41, 0x11, 0x03, 9, 0x02, 0x02,
> +                                 0x06, 0x16, 0x05, 0x15, 0x04, 0x14
> +};

Re: [PATCH 2/3] set some categories of some AVClass structs

On Mon, May 28, 2012 at 12:53:28PM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni <at> gmx.at>
> ---
>  libavcodec/options.c     |    1 +
>  libavfilter/af_aformat.c |    1 +
>  libavfilter/avfilter.c   |    1 +
>  libavformat/options.c    |    1 +

It would be nice to complete this a little before pushing; at least
commonly used filters, like the buffer sinks.

[...]

--

-- 
Clément B.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH 1/2] timecode: move timecode muxer options to metadata.

On Wed, May 30, 2012 at 03:30:23PM +0200, Michael Niedermayer wrote:
> On Wed, May 30, 2012 at 02:58:41PM +0200, Clément Bœsch wrote:
> > From: Clément Bœsch <clement.boesch <at> smartjog.com>
> > 
> > Some demuxers set a timecode in the format or streams metadata. The
> > muxers now make use of this metadata instead of a duplicated private
> > option.
> > 
> > This makes possible transparent copy of the timecode when transmuxing
> > and transcoding.
> > 
> > -timecode option for MPEG1/2 codec is also renamed to -gop_timecode. The
> > global ffmpeg -timecode option will set it anyway so no option change
> > visible for the user.
> 
> dunno if baptiste or other timecode people have time to comment
> if not LGTM
> 

I'll push this in a few days if I see no other comment.

--

-- 
Clément B.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH]Let ffmpeg select the setpts filter

Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:

> I am not sure I understand why the setpts filter is 
> absolutely necessary, but if it is, ffmpeg should select it.

Patch applied, I did not test if the filter is really needed.

Carl Eugen