Re: [PATCH] OpenAL 1.1 Capture Support

> I've been told that the ISC license is simpler, feel free to send a
> patch for changing licence if you feel like that.

Here ya go. It is quite a bit simpler. I actually only chose the
variant of the MIT license that I originally used because it was
already in use by other parts of FFmpeg (specifically the libavformat
output example.)

> And thanks again for the nice job, this finally allows audio capture
> on Windows .

You're welcome . I'm very glad I could help. I plan to write an
OpenAL output device someday, but I have something I'm writing first
before that.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH]Fix buffer size for 4bpp and 2bpp raw video

On Friday 01 July 2011 12:00:11 am Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes decoding of some 4bpp and 2bpp samples.

And a fixed version.

Please comment, Carl Eugen

diff --git a/libavcodec/rawdec.c b/libavcodec/rawdec.c
index 6644d6c..d48cbed 100644
--- a/libavcodec/rawdec.c
+++ b/libavcodec/rawdec.c
 <at>  <at>  -103,13 +103,15  <at>  <at>  static av_cold int raw_init_decoder(AVCodecContext *avctx)
     }

     ff_set_systematic_pal2(context->palette, avctx->pix_fmt);
-    context->length = avpicture_get_size(avctx->pix_fmt, avctx->width, avctx->height);
     if((avctx->bits_per_coded_sample == 4 || avctx->bits_per_coded_sample == 2) &&
        avctx->pix_fmt==PIX_FMT_PAL8 &&
        (!avctx->codec_tag || avctx->codec_tag == MKTAG('r','a','w',' '))){
+        context->length = avpicture_get_size(avctx->pix_fmt, (avctx->width+3)&~3, avctx->height);
         context->buffer = av_malloc(context->length);
         if (!context->buffer)
             return -1;
+    } else {
+        context->length = avpicture_get_size(avctx->pix_fmt, avctx->width, avctx->height);
     }
     context->pic.pict_type = AV_PICTURE_TYPE_I;

Re: [PATCH]Fix buffer size for 4bpp and 2bpp raw video

On Fri, Jul 01, 2011 at 01:36:32AM +0200, Carl Eugen Hoyos wrote:
> On Friday 01 July 2011 12:00:11 am Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > Attached patch fixes decoding of some 4bpp and 2bpp samples.
> 
> And a fixed version.
> 
> Please comment, Carl Eugen

>  rawdec.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> bb706dcb652438341da80960780a8b9825a7a947  patchraw42.diff

should be ok
[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: Add support for AVI YV24 (RAW) FourCC

On Saturday 25 June 2011 11:32:14 pm ami_stuff wrote:

> The attached patch adds support for YV24 FourCC. The background in the
>  video must the blue, so it seems there is a need to swap UV.
> 
> Fixes ticket #306.

Updated patch attached.

Please comment, Carl Eugen

diff --git a/libavcodec/raw.c b/libavcodec/raw.c
index d686718..e87a9af 100644
--- a/libavcodec/raw.c
+++ b/libavcodec/raw.c
 <at>  <at>  -137,6 +137,7  <at>  <at>  const PixelFormatTag ff_raw_pix_fmt_tags[] = {

     /* special */
     { PIX_FMT_RGB565LE,MKTAG( 3 ,  0 ,  0 ,  0 ) }, /* flipped RGB565LE */
+    { PIX_FMT_YUV444P, MKTAG('Y', 'V', '2', '4') }, /* YUV444P, swapped UV */

     { PIX_FMT_NONE, 0 },
 };
diff --git a/libavcodec/rawdec.c b/libavcodec/rawdec.c
index 6644d6c..474026c 100644
--- a/libavcodec/rawdec.c
+++ b/libavcodec/rawdec.c
 <at>  <at>  -206,6 +206,7  <at>  <at>  static int raw_decode(AVCodecContext *avctx,

Re: [PATCH] Reinit variables for padding bugs workaround in MPEG4 streams

On Tue, Jun 28, 2011 at 10:04:11PM +0400, Anatoly Nenashev wrote:
> Hi!
> There is a patch in attachment which fixes the issue described in Ticket  
> 302:
> https://ffmpeg.org/trac/ffmpeg/ticket/302.
>
> The problem arises in a case when the frame contains resync markers and  
> some garbage bytes after last slice's end.
> The idea of solution is to reinitialize variables used in padding bugs  
> workaround at the beginning of each frame.

The patch below simply breaks the pading bug detection.
About why we cant just always skip garbage at the end, that breaks
error detection for error concealment at least but possibly more.

[...]

--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH]Fix buffer size for 4bpp and 2bpp raw video

Michael Niedermayer <michaelni <at> gmx.at> writes:

> >  rawdec.c |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > bb706dcb652438341da80960780a8b9825a7a947  patchraw42.diff
> 
> should be ok

Pushed.

Carl Eugen

Re: [PATCH] av_get_delay

On Thu, Jun 30, 2011 at 08:03:39PM +0200, Nicolas George wrote:
[...]
>  <at>  <at>  -1518,6 +1521,22  <at>  <at>  int av_interleave_packet_per_dts(AVFormatContext *s, AVPacket *out,
>   */
>  int av_write_trailer(AVFormatContext *s);
>  
> +/**
> + * Get timing information for the data currently output.
> + * The exact meaning of "currently output" depends on the format.
> + * It is mostly relevant for devices that have an internal buffer and/or
> + * work in real time.
> + *  <at> param s       media file handle
> + *  <at> param stream  stream in the media file

> + *  <at> param dts     DTS of the last packet output for the stream
> + *  <at> param wall    absolute time when that packet whas output

these should be marked as outputs
also the units/timebases used should be mentioned
otherwise the patchset LGTM

[...]

--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.

Re: [PATCH] av_get_delay

Le tridi 13 messidor, an CCXIX, Michael Niedermayer a écrit :
> these should be marked as outputs
> also the units/timebases used should be mentioned
> otherwise the patchset LGTM

Thanks: precisions added, patch updated and pushed.

Here is the corresponding minor bump and APIChanged entry.

Regards,

--

-- 
  Nicolas George

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH] OpenAL 1.1 Capture Support

On date Thursday 2011-06-30 19:05:30 -0400, Jonathan Baldwin encoded:
> > I've been told that the ISC license is simpler, feel free to send a
> > patch for changing licence if you feel like that.
> 
> Here ya go. It is quite a bit simpler. I actually only chose the
> variant of the MIT license that I originally used because it was
> already in use by other parts of FFmpeg (specifically the libavformat
> output example.)

Patch pushed.

> > And thanks again for the nice job, this finally allows audio capture
> > on Windows .
> 
> You're welcome . I'm very glad I could help. I plan to write an
> OpenAL output device someday, but I have something I'm writing first
> before that.

Nice, looking forward for that :).
--

-- 
FFmpeg = Fanciful Fanciful Most Puritan Embarassing Gem

Re: [PATCH] Port tinterlace filter from MPlayer.

On date Thursday 2011-06-30 10:15:15 +0200, Stefano Sabatini encoded:
> On date Wednesday 2011-06-29 05:43:18 +0200, Michael Niedermayer encoded:
> > On Tue, Jun 28, 2011 at 01:08:23PM +0300, Ivan Kalvachev wrote:
> > > On 6/28/11, Stefano Sabatini <stefano.sabatini-lala <at> poste.it> wrote:
> > > > On date Monday 2011-06-27 23:49:09 +0200, Stefano Sabatini encoded:
> > > >> On date Sunday 2010-09-26 20:32:48 +0200, Michael Niedermayer wrote:
> > > > [...]
> > > >> Updated based on the tinterlace port from FFmbc, with some
> > > >> simplifications.
> > > >
> > > > Updated again, with a request_frame() implementation.
> > > >
> > > > Some questions:
> > > >
> > > > 1) what do we want to do with the limpcodecs wrapper as they are
> > > > ported to native filters? (I suppose the right answer is "drop them"
> > > > => less code to maintain, in this case mpcodecs/tinterlace is broken
> > > > and in general fixing those filters - with no previous knowledge of
> > > > libmpcodecs - requires more time than porting them).
> > > 
> > > IMHO, once the native is working fine, remove the other.
> > 
> > agree
> > also once you and stefano agree on the patch, consider it approved by
> > me too. iam too busy to double review and you are a pretty good
> > developer who i would hope to be more active :)
> 
> Updated with more fixes.
> 
> I withdraw the "mode 5" ideas, since it requires some more changes to