Re: [PATCH] Lowercase the FRWU codec name

On date Saturday 2011-04-30 17:24:02 +0200, Michael Niedermayer encoded:
> On Sat, Apr 30, 2011 at 05:06:48PM +0200, Stefano Sabatini wrote:
> > On date Saturday 2011-04-30 15:40:30 +0200, ami_stuff encoded:
> > > the patch changes this
> > > 
> > > [...]
> > >  D A    8svx_exp        8SVX exponential
> > >  D A    8svx_fib        8SVX fibonacci
> > >  D V D  FRWU            Forward Uncompressed
> > >   EV    a64multi        Multicolor charset for Commodore 64
> > >   EV    a64multi5       Multicolor charset for Commodore 64, extended with 5th color (colram)
> > > [...]
> > > 
> > > to
> > > 
> > > [...]
> > >  DEVSD  flv             Flash Video (FLV) / Sorenson Spark / Sorenson H.263
> > >  D V D  fraps           Fraps
> > >  D V D  frwu            Forward Uncompressed
> > >  DEA    g722            G.722 ADPCM
> > >  DEA    g726            G.726 ADPCM
> > > [...]
> > > 
> > > 
> > > and
> > > 
> > > 
> > > [...]
> > >     Stream #0.0: Video: FRWU, uyvy422, 192x144, 23.97 tbr, 23.97 tbn, 23.97 tbc
> > > [...]

Re: [PATCH] dca: set correct value for data_size when using AV_SAMPLE_FMT_FLT

On Sat, Apr 30, 2011 at 11:24 PM, Reimar Döffinger
<Reimar.Doeffinger <at> gmx.de> wrote:
>
> Thanks. However I'd prefer to have the code match the one in the
> AAC decoder.

I suppose i only roughly based it on the code in the AAC decoder,
operand order was kept from the previous dca code. ;)

> Also the AC3 decoder is broken as well, though in a different way.

Guess i would've only noticed that if i actually used a too small buffer, huh.

> Could you check the patch I just sent?

Looks and sounds good to me.

- Hendrik

Re: [PATCH]: Fix decoding of mpegts streams with h264 video that does *NOT* have b frames

On Thu, Apr 28, 2011 at 10:14:26AM -0400, Mike Scheutzow wrote:
> Tony Strauss wrote:
>> ...
>>
>> Basically, the earlier patch made h264_parse() invoke
>> ff_h264_decode_extradata() the first time through.  The problem,
>> however, is that the H264Context that was passed in belongs to the
>> AVCodecParserContext and is uninitialized.  In particular, low_delay =
>> 0 and that eventually leads to has_b_frames = 1.  My fix is to split
>> off a new ff_h264_context_init() function from ff_h264_decode_init();
>> this will initialize the AVCodecParserContext's H264Context and also
>> invoke ff_h264_decode_extradata().
>>
>> ...
>
> This problem was more difficult to solve than I expected. I've attached  
> a patch which takes a different approach than Tony's patch.
>
> One of the causes of this bug is that the h264 parser defaults low_delay  
> to 1, but the h264 codec defaults low_delay to 0. Really Ugly.
>
> After many hours of looking at this, I'm still not sure how has_b_frames  
> is *intended* to behave, but to me the implementation appears way more  
> complicated than it ought to be.
>
> My patch relies on the encoder to set an optional field in the SPS. This  
> works for libx264 streams, but I'm not sure that all h264 encoders will  
> set it.
>
>

Re: YUV video to RGB image export color conversion issue

On Sat, Apr 30, 2011 at 11:46:02PM +0200, Peter B. wrote:
> Michael Niedermayer wrote:
> > its fine to use the slow one for 422 and the fast one for 420 no cmd
> > line option should be needed.
> >   
> Thank you very much!

You dont have to thank me.
we still need a actual implementation of that idea

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH]Fix compilation without flac decoder

On Sat, Apr 30, 2011 at 01:32:46PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached fixes compilation when the flac decoder is disabled.
> An alternative is to move the layout setting into flac_dec.c, but it would not 
> significantly reduce the size of the patch.
> 
> Carl Eugen

>  Makefile |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 22eac301a1197784bc8eabf69ddb720a1845195b  patchflacdeps.diff

if thats needed then it is needed and thus ok

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [PATCH] Fix data_size handling for AC3 and dca decoders.

On Sat, Apr 30, 2011 at 11:23:17PM +0200, Reimar Döffinger wrote:
> They use now code identical to the AAC decoder.
> The AC3 decoder previously did not check the data_size and
> the dca decoder checked against and set wrong values for float.
> ---
>  libavcodec/ac3dec.c |    9 +++++++--
>  libavcodec/dca.c    |    8 +++++---
>  2 files changed, 12 insertions(+), 5 deletions(-)

iam a bit tired but it does look correct

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[PATCH]8 and 24 bit True Audio

Hi!

The patches fix decoding for some u8- and s24-encoded tta files, samples 
attached to ticket 118.
(Longer samples fail because the output buffer size is too small.)

Please comment, Carl Eugen

diff --git a/libavcodec/tta.c b/libavcodec/tta.c
index ece5c1c..af883aa 100644
--- a/libavcodec/tta.c
+++ b/libavcodec/tta.c
 <at>  <at>  -251,7 +251,7  <at>  <at>  static av_cold int tta_decode_init(AVCodecContext * avctx)
             return -1;
         }
         else switch(s->bps) {
-//            case 1: avctx->sample_fmt = AV_SAMPLE_FMT_U8; break;
+            case 1: avctx->sample_fmt = AV_SAMPLE_FMT_U8; break;
             case 2: avctx->sample_fmt = AV_SAMPLE_FMT_S16; break;
 //            case 3: avctx->sample_fmt = AV_SAMPLE_FMT_S24; break;
             case 4: avctx->sample_fmt = AV_SAMPLE_FMT_S32; break;
 <at>  <at>  -311,7 +311,7  <at>  <at>  static int tta_decode_frame(AVCodecContext *avctx,
         int cur_chan = 0, framelen = s->frame_length;
         int32_t *p;

-        if (*data_size < (framelen * s->channels * 2)) {
+        if (*data_size < (framelen * s->channels * av_get_bits_per_sample_fmt(avctx->sample_fmt) / 8)) {
             av_log(avctx, AV_LOG_ERROR, "Output buffer size is too small.\n");
             return -1;

Re: [PATCH]Fix compilation without flac decoder

Michael Niedermayer <michaelni <at> gmx.at> writes:

> >  Makefile |   20 +++++++++++---------
> >  1 file changed, 11 insertions(+), 9 deletions(-)
> > 22eac301a1197784bc8eabf69ddb720a1845195b  patchflacdeps.diff
> 
> if thats needed then it is needed and thus ok

Pushed.

Carl Eugen

Re: [PATCH] lavc: add a pkt_pos field to AVFrame

On date Friday 2011-04-29 15:08:51 +0200, Michael Niedermayer encoded:
> On Fri, Apr 29, 2011 at 01:15:44PM +0200, Stefano Sabatini wrote:
> > On date Friday 2011-04-29 12:33:26 +0200, Stefano Sabatini encoded:
> > > On date Friday 2011-04-29 12:31:35 +0200, Stefano Sabatini encoded:
> > > > This is similar to what was done with pkt_pts. This simplifies the
> > > > operation of extracting the pos information from the AVPacket, and
> > > > allows further simplifications.
> > > > ---
> > > >  cmdutils.c               |    1 +
> > > >  ffplay.c                 |    2 +-
> > > >  libavcodec/avcodec.h     |    7 +++++++
> > > >  libavcodec/rawdec.c      |    1 +
> > > >  libavcodec/utils.c       |   10 ++++++++--
> > > >  libavfilter/vsrc_movie.c |    3 +--
> > > >  6 files changed, 19 insertions(+), 5 deletions(-)
> > 
> > Updated with a minor fix.
> > -- 
> > FFmpeg = Fanciful and Fancy Monstrous Purposeless Evanescent God
> 
> >  cmdutils.c               |    1 +
> >  ffplay.c                 |    2 +-
> >  libavcodec/avcodec.h     |    7 +++++++
> >  libavcodec/rawdec.c      |    1 +
> >  libavcodec/utils.c       |   11 +++++++++--
> >  libavfilter/vsrc_movie.c |    3 +--
> >  6 files changed, 20 insertions(+), 5 deletions(-)
> > fdcd24ad9b2c92b1f95b358c48df2377c3d9f7da  0001-lavc-add-a-pkt_pos-field-to-AVFrame.patch
> > From 926630f9afa9f65b396c3c6d487b793f599eccc9 Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala <at> poste.it>

Re: [PATCH] lavc: add a sample_aspect_ratio field to AVFrame

On date Friday 2011-04-29 15:57:00 +0200, Michael Niedermayer encoded:
> On Fri, Apr 29, 2011 at 01:14:06PM +0200, Stefano Sabatini wrote:
> > Simplify application-level sample aspect ratio information extraction,
> > and allow further simplifications.
> > ---
> >  cmdutils.c                |    1 +
> >  ffmpeg.c                  |    7 +++----
> >  ffplay.c                  |    2 +-
> >  libavcodec/avcodec.h      |    8 ++++++++
> >  libavcodec/utils.c        |    3 +++
> >  libavfilter/vsrc_buffer.c |   10 +++++-----
> >  libavfilter/vsrc_buffer.h |    4 ++--
> >  libavfilter/vsrc_movie.c  |    4 ++--
> >  8 files changed, 25 insertions(+), 14 deletions(-)
> 
> LGTM

Applied.
--

-- 
FFmpeg = Fancy Fantastic Mournful Purposeless Elected Geek