headers
Carl Eugen Hoyos | 1 Jul 2010 01:03
Picon

Re: [PATCH 10/28] silence 'invalid dts/pts combination' spew coming from ffmpeg. This is an info message not a error condition as ffmpeg will flag the invalid pts as AV_NOPTS_VALUE.

Michael Niedermayer <michaelni <at> gmx.at> writes:

> > -        av_log(s, AV_LOG_WARNING, "invalid dts/pts combination\n");
> > +        av_log(s, AV_LOG_DEBUG, "invalid dts/pts combination\n");
> >          pkt->dts= pkt->pts= AV_NOPTS_VALUE;
> 
> if people consider it to noisy then the patch is ok

Applied after finding a similar report on roundup.

Carl Eugen
Permalink | Reply | 0 comments |
headers
Måns Rullgård | 1 Jul 2010 01:05

Re: [PATCH] move put_v from nutenc.c and make it public in avio.h and aviobuf.c

Michael Chinen <mchinen <at> gmail.com> writes:

> On Wed, Jun 30, 2010 at 1:09 PM, Michael Chinen <mchinen <at> gmail.com> wrote:
>> Hi,
>> I want to use put_v in utils.c, but it is a private function in
>> nutenc.c.  Seems like it should be moved to avio.h and made public
>> with the other ByteIOContext put* funcs.
>> I recently committed this to soc but learned it should be put in the devel ML.
>
> modifying patch because updating svn has caused a conflict due to
> documentation fixes.  Now against rev 23915.
>
> Index: libavformat/avio.h
> ===================================================================
> --- libavformat/avio.h	(revision 23915)
> +++ libavformat/avio.h	(working copy)
>  <at>  <at>  -348,8 +348,12  <at>  <at> 
>  void put_tag(ByteIOContext *s, const char *tag);
>
>  void put_strz(ByteIOContext *s, const char *buf);
> -
> +void put_v(ByteIOContext *bc, uint64_t val);
>  /**
> + * Get the length in bytes which is needed to store val as v.
> + */
> +int get_length(uint64_t val);
> +/**
>   * fseek() equivalent for ByteIOContext.
>   *  <at> return new position or AVERROR.
>   */
(Continue reading)

Permalink | Reply | 21 comments |
headers
Reimar Döffinger | 1 Jul 2010 01:06
Picon
Picon

Re: [PATCH] mxfdec: make it work with other calling conventions

On Wed, Jun 30, 2010 at 02:49:55PM -0700, Baptiste Coudurier wrote:
> >>But that's more an explanation of
> >>why there isn't any prototype for the read() function.
> >
> >I expected that is because pointers to functions with a different
> >number of arguments were stored there, but that is more of an argument
> >_for_ making it an error, since this allowed the fact that the
> >code would crash with stdcall and all other calle-restores-stack calling
> >conventions to go by unnoticed, without even a warning.
> 
> All the functions are called with the same number of arguments.

That's completely irrelevant, they are called with a different number
of arguments than the number of arguments they are declared with!
Permalink | Reply | 4 comments |
headers
Michael Niedermayer | 1 Jul 2010 01:12
Picon
Picon

Re: [PATCH] Make av_get_random_seed not block when waiting for more entropy

On Wed, Jun 30, 2010 at 11:54:05PM +0100, Måns Rullgård wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > On Wed, Jun 30, 2010 at 10:20:29PM +0100, Måns Rullgård wrote:
> >> Michael Niedermayer <michaelni <at> gmx.at> writes:
> >> 
> >> > On Wed, Jun 30, 2010 at 09:53:55PM +0100, Måns Rullgård wrote:
> >> >> Michael Niedermayer <michaelni <at> gmx.at> writes:
> >> >> 
> >> >> > On Wed, Jun 30, 2010 at 09:07:40PM +0100, Måns Rullgård wrote:
> >> >> >> Michael Niedermayer <michaelni <at> gmx.at> writes:
> >> >> >> 
> >> >> >> > On Wed, Jun 30, 2010 at 07:28:16PM +0300, Martin Storsjö wrote:
> >> >> >> >> On Wed, 30 Jun 2010, Måns Rullgård wrote:
> >> >> >> >> 
> >> >> >> >> > Martin Storsjö <martin <at> martin.st> writes:
> >> >> >> >> > 
> >> >> >> >> > > On Wed, 30 Jun 2010, Michael Niedermayer wrote:
> >> >> >> >> > >
> >> >> >> >> > >> before you spend more time on this.
> >> >> >> >> > >> There is a possible security issue with using non block mode
> >> >> >> >> > >> namely if we have /dev/*random and not use it we can end up
> >> >> >> >> > >> using a uninitialized variable. Thats an information leak
> >> >> >> >> > >> it could leak from pointers (kills ASLR) to OS/platform or
> >> >> >> >> > >> compiler version or or or ...
> >> >> >> >> > >> thats all usefull information for a attacker
> >> >> >> >> > >> he only has to saturate /dev/random so it would block
> >> >> >> >> > >
> >> >> >> >> > > Could you elaborate on your concern here? The fix he committed tries
> >> >> >> >> > > both /dev/random and /dev/urandom, and the latter should never block
(Continue reading)

Permalink | Reply | 5 comments |
headers
Baptiste Coudurier | 1 Jul 2010 01:20
Picon

Re: [PATCH] mxfdec: make it work with other calling conventions

On 06/30/2010 04:06 PM, Reimar Döffinger wrote:
> On Wed, Jun 30, 2010 at 02:49:55PM -0700, Baptiste Coudurier wrote:
>>>> But that's more an explanation of
>>>> why there isn't any prototype for the read() function.
>>>
>>> I expected that is because pointers to functions with a different
>>> number of arguments were stored there, but that is more of an argument
>>> _for_ making it an error, since this allowed the fact that the
>>> code would crash with stdcall and all other calle-restores-stack calling
>>> conventions to go by unnoticed, without even a warning.
>>
>> All the functions are called with the same number of arguments.
>
> That's completely irrelevant, they are called with a different number
> of arguments than the number of arguments they are declared with!

In any case, the compiler has to fail in this case, because 
vararg/undefined prototype cannot work and stdcall requires a function 
prototype.

--

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org
Permalink | Reply | 3 comments |
headers
Michael Niedermayer | 1 Jul 2010 01:22
Picon
Picon

Re: [PATCH 06/28] fixed: #5585 Media file gets played twice. we assume avi EOF when we can't find the next streams index entry for non interleaved files.

On Wed, Jun 30, 2010 at 10:09:34AM +0100, Mans Rullgard wrote:
> From: Cory Fields <theuni-nospam- <at> xbmc.org>
> 
> ---
>  libavformat/avidec.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/libavformat/avidec.c b/libavformat/avidec.c
> index 730b3b7..befaa79 100644
> --- a/libavformat/avidec.c
> +++ b/libavformat/avidec.c
>  <at>  <at>  -738,7 +738,8  <at>  <at>  static int avi_read_packet(AVFormatContext *s, AVPacket *pkt)
>          if(i>=0){
>              int64_t pos= best_st->index_entries[i].pos;
>              pos += best_ast->packet_size - best_ast->remaining;
> -            url_fseek(s->pb, pos + 8, SEEK_SET);
> +            if(url_fseek(s->pb, pos + 8, SEEK_SET) < 0)
> +              return AVERROR_EOF;

changing every error code to EOf feels a bit odd

>  //        av_log(s, AV_LOG_DEBUG, "pos=%"PRId64"\n", pos);
>  
>              assert(best_ast->remaining <= best_ast->packet_size);
>  <at>  <at>  -748,6 +749,8  <at>  <at>  static int avi_read_packet(AVFormatContext *s, AVPacket *pkt)
>                  best_ast->packet_size=
>                  best_ast->remaining= best_st->index_entries[i].size;
>          }
> +        else
> +          return AVERROR_EOF;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Michael Chinen | 1 Jul 2010 01:37
Picon
Gravatar

Re: [PATCH] move put_v from nutenc.c and make it public in avio.h and aviobuf.c

2010/7/1 Måns Rullgård <mans <at> mansr.com>:
>> +/**
>> + * Get the length in bytes which is needed to store val as v.
>> + */
>
> You don't need to repeat the comment here.  Once in the header is
> enough.
ok.  done.

Index: libavformat/avio.h
===================================================================
--- libavformat/avio.h	(revision 23915)
+++ libavformat/avio.h	(working copy)
 <at>  <at>  -348,8 +348,14  <at>  <at> 
 void put_tag(ByteIOContext *s, const char *tag);

 void put_strz(ByteIOContext *s, const char *buf);
+void put_v(ByteIOContext *bc, uint64_t val);

 /**
+ * Get the length in bytes which is needed to store val as v.
+ */
+int get_length(uint64_t val);
+
+/**
  * fseek() equivalent for ByteIOContext.
  *  <at> return new position or AVERROR.
  */
Index: libavformat/aviobuf.c
===================================================================
(Continue reading)

Permalink | Reply | 20 comments |
headers
Stefano Sabatini | 1 Jul 2010 01:40
Picon
Favicon

Re: [Patch] Scale filter should use multiples of 2

On date Wednesday 2010-06-30 13:21:03 -0400, Daniel G. Taylor encoded:
> On 06/29/2010 08:16 PM, Michael Niedermayer wrote:
> >On Wed, Jun 30, 2010 at 01:04:36AM +0200, Stefano Sabatini wrote:
> >>On date Tuesday 2010-06-29 12:56:17 -0700, Baptiste Coudurier encoded:
> >>>On 6/29/10 12:02 PM, Daniel G. Taylor wrote:
> >>>>Hey,
> >>>>
> >>>>Attached is a small patch to make the vf_scale filter always produce
> >>>>multiples of 2 when the -1 option is used for either width or height to
> >>>>keep the aspect ratio. This lets you use it properly with some encoders,
> >>>>like libx264, that would otherwise fail, e.g:
> >>>
> >>>This depends on the output pixel format. For 420, indeed it would be useful.
> >>
> >>Odd-size rescaling was a feature explicitely requested by Michael. I'm
> >>not against adding an option to make it only issues even-sized image though.
> >
> >I insisted possibly on it being supported (that is important)
> >but doing it by default with 420 seems odd
> 
> What about attached patch? It changes the behavior so that a width
> or height of -1 remains the same as it is now while adding the
> ability to use other negative values to mean "scale proportionately
> but clip to the closest multiple of X," so e.g.
> 
>     scale=320:-1  =>  320x197
>     scale=320:-2  =>  320x198
>     scale=320:-8  =>  320x200
>     scale=320:-16 =>  320x192
>
(Continue reading)

Permalink | Reply | 12 comments |
headers
Rodney Baker | 1 Jul 2010 01:47
Picon
Picon
Gravatar

Re: [PATCH] Change all instances of "inofficial" to "unofficial" (except c/l option in lavc/options.c)

On Tue, 29 Jun 2010 23:59:36 Rodney Baker wrote:
> On Tue, 29 Jun 2010 02:53:12 Stefano Sabatini wrote:
> > On date Sunday 2010-06-27 00:32:22 +0930, Rodney Baker encoded:
> > > On Sun, 27 Jun 2010 00:27:09 Rodney Baker wrote:
> > [...]
> > 
> > > Index: Changelog
> > > ===================================================================
> > > --- Changelog	(revision 23792)
> > > +++ Changelog	(working copy)
> > >  <at>  <at>  -15,9 +15,11  <at>  <at> 
> > > 
> > >  - libfaad2 wrapper removed
> > >  - DTS-ES extension (XCh) decoding support
> > >  - native VP8 decoder
> > > 
> > > +- added FF_COMPLIANCE_UNOFFICIAL
> > > +- changed all instances of FF_COMPLIANCE_INOFFICIAL to use
> > > FF_COMPLIANCE_UNOFFICIAL
> > 
> > These are API changes, should be placed in doc/APIchanges.
> 
> Moved.
> 
> > > +- added "unofficial" command line option and marked "inofficial" to be
> > > removed at next major version bump.
> > 
> > I suggest:
> > -strict inofficial replaced by -strict unofficial
>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Reimar Döffinger | 1 Jul 2010 01:50
Picon
Picon

Re: [PATCH] mxfdec: make it work with other calling conventions

On Wed, Jun 30, 2010 at 04:20:50PM -0700, Baptiste Coudurier wrote:
> On 06/30/2010 04:06 PM, Reimar Döffinger wrote:
> >On Wed, Jun 30, 2010 at 02:49:55PM -0700, Baptiste Coudurier wrote:
> >>>>But that's more an explanation of
> >>>>why there isn't any prototype for the read() function.
> >>>
> >>>I expected that is because pointers to functions with a different
> >>>number of arguments were stored there, but that is more of an argument
> >>>_for_ making it an error, since this allowed the fact that the
> >>>code would crash with stdcall and all other calle-restores-stack calling
> >>>conventions to go by unnoticed, without even a warning.
> >>
> >>All the functions are called with the same number of arguments.
> >
> >That's completely irrelevant, they are called with a different number
> >of arguments than the number of arguments they are declared with!
> 
> In any case, the compiler has to fail in this case, because
> vararg/undefined prototype cannot work and stdcall requires a
> function prototype.

What? Whatever gave you that idea?
Microsoft all those years has never noticed that none of their sofware
can even compile?
http://www.cygwin.com/ml/cygwin/2003-06/msg00470/windef.h
[...]
#define WINAPI __stdcall
[...]
typedef int (WINAPI *FARPROC)();
(Continue reading)

Permalink | Reply | 2 comments |

Gmane