1 Oct 2009 01:00
Re: [PATCH] libavfilter-soc: implement pad filter
Stefano Sabatini <stefano.sabatini-lala <at> poste.it>
2009-09-30 23:00:16 GMT
2009-09-30 23:00:16 GMT
Sorry for the slow reply. On date Thursday 2009-09-17 02:21:59 +0200, Michael Niedermayer encoded: [...] > > Now I'm posting other patches, what I'd like to discuss are these two > > points: > > > > * I tried both to put the information required for padding (x, y, h, > > w, exp_h, exp_w) in the link and pass it in the get_video_buffer() > > params, they're pretty equivalent but the second method (as in the > > patch) seems more flexible, as the information is not stored > > statically in the links, so it doesn't need a reconfiguration when > > changing it. > > yes > > > > (BTW maybe we can as well remove w/h from the link, > > that should make simpler to implement variable size filters, I still > > have to experiment with this). > > maybe > > > > > * I tinkered about the vflip problem much time, and I could'nt find some > > way to keep the previous behavior with the new system. > > The new system assumes that the position of the area to pad > > (referred by the x/y params in the picref) needs to be invariant > > when passing a picref to the next filter. > > That's because the pad filter expects this:(Continue reading)
RSS Feed