Re: [PATCH] Rename input/outdev symbols in libavdevice

On date Monday 2009-06-29 22:01:02 +0200, Stefano Sabatini encoded:
> On date Monday 2009-06-29 21:13:36 +0200, Luca Abeni encoded:
> > Hi,
> >
> > Stefano Sabatini wrote:
> >> Hi, as in subject.
> >
> > Not that I care, but I think this was proposed when
> > libavdevice has been created, but it was rejected.
> 
> Do you remember the reasons for which it was rejected?
> 
> Appears to me a quite natural change...

Ping.
--

-- 
FFmpeg = Funny and Foolish Monstrous Perennial Ecumenical Geek

Re: libavfilter-soc update and variable frame size/pixel format

On date Monday 2009-06-29 21:57:04 +0200, Stefano Sabatini encoded:
> On date Monday 2009-06-29 21:01:15 +0200, Michael Niedermayer encoded:
> > On Mon, Jun 29, 2009 at 08:54:38PM +0200, Stefano Sabatini wrote:
> > > On date Monday 2009-06-29 01:26:11 +0200, Michael Niedermayer encoded:
> > > > On Mon, Jun 29, 2009 at 01:05:19AM +0200, Stefano Sabatini wrote:
> > > > > Hi, since r19226/19279 ffmpeg supports variable frame size/pixel
> > > > > formats.
> > > > > 
> > > > > I managed to update libavfilter-soc, and my current solution is to
> > > > > simply don't support it if libavfilter is enabled.
> > > > > 
> > > > > That's because those are ones of the problem lavfi should natively
> > > > > manage, rather than leave the problem to the application, also I don't
> > > > > want to spend time on this since that will be removed anyway once it
> > > > > will be supported by the lavfi framework.
> > > > > 
> > > > > See updating patch attached, OK to apply?
> > > > 
> > > > i dont review diffs of diffs :)
> > > 
> > > In attachment the diff. Note that I'm just keeping the old behaviour
> > > when CONFIG_AVFILTER is enabled.
> > 
> > i also dont review that
> > we have A ---diff1--->B
> > and
> > 
> > we have A ---diff1--diff2->B
> > 
> > i review diff2, i wont review a combined diff1+diff2 nor a diff between

Re: [PATCH] Update metadata docs in the ffmpeg man page

On date Sunday 2009-06-28 23:27:06 +0200, Stefano Sabatini encoded:
> On date Saturday 2009-06-27 22:40:56 +0200, Reinhard Tartler encoded:
> > Stefano Sabatini <stefano.sabatini-lala <at> poste.it> writes:
> > 
> > > On date Saturday 2009-06-27 15:17:45 +0200, Diego Biurrun encoded:
> > >> On Sat, Jun 27, 2009 at 03:12:40PM +0200, Stefano Sabatini wrote:
> > >> > Hi, as in subject.
> > >> 
> > >> Apply and next time skip sending patches, I can review it on -cvslog as
> > >> well...
> > >
> > > Applied.
> > 
> > Do these changes apply to ffmpeg 0.5 as well?
> 
> I see why we shouldn't backport them to 0.5. Diego, OK to apply?

I'll do that in few days, if there are no objections.

Regards.
--

-- 
FFmpeg = Furious and Free Mega Pure Entertaining Gadget

Re: [PATCH] Make configure use --enable-{in, out}dev=foo for enabling a single inoutdev

On date Monday 2009-06-29 20:48:11 +0200, Stefano Sabatini encoded:
> On date Monday 2009-06-29 10:48:01 +0200, Diego Biurrun encoded:
> > I don't like the Changelog entry.  Commit the rest.
> 
> Committed.
> 
> But please make clear your position for what regards the use of the
> Changelog.

Posting the Changelog entry patch, since it's not clear if it is the
patch or the idea which you don't like.

Regards.
--

-- 
FFmpeg = Fostering & Foolish Mere Patchable Everlasting God

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

[PATCH] Fix argument type mismatches for av_picture_crop and av_picture_fill

---
 libavcodec/avcodec.h    |    2 +-
 libavcodec/imgconvert.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 70b6c62..8eb7c3c 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
 <at>  <at>  -2902,7 +2902,7  <at>  <at>  void avpicture_free(AVPicture *picture);
  *  <at> return size of the image data in bytes
  */
 int avpicture_fill(AVPicture *picture, uint8_t *ptr,
-                   int pix_fmt, int width, int height);
+                   enum PixelFormat pix_fmt, int width, int height);
 int avpicture_layout(const AVPicture* src, enum PixelFormat pix_fmt, int width, int height,
                      unsigned char *dest, int dest_size);

diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c
index 3f457fe..a2db471 100644
--- a/libavcodec/imgconvert.c
+++ b/libavcodec/imgconvert.c
 <at>  <at>  -1288,7 +1288,7  <at>  <at>  static inline int is_yuv_planar(const PixFmtInfo *ps)
 }

 int av_picture_crop(AVPicture *dst, const AVPicture *src,
-              int pix_fmt, int top_band, int left_band)
+                    enum PixelFormat pix_fmt, int top_band, int left_band)
 {
     int y_shift;

Updating initial dts when streamswitching and dts/pts wrap occurs

Hello;

I need some hints on how I would go on updating the ffmpeg code for the dvd
decoding I am working on. I got playing for ffplay working fine, but before
I submit anything I also want to get ffmpeg going, to see if the data I pass
back is enough for all Libav users.

I figured out the changes needed for the introduction in new streams and
stream switching, but am stuck on the best way to get dts/pts
synchronization working both when a new chapter/vob transition happens, and
pts wrapping occurs because of 2^31 stamps.

Problem is getting the syncing between input and output streams going. When
a stream switch occurs (or a new stream is introduced), pts of the new
stream will start from 0 (or be at least less then "old" pts). The sync
difference between output generated dts will be off (or even wrap around)
and audio/video desync occurs (depending on the sync mechanism either frames
dropped or inserted).

I tested several scenario's, but found none that works well.  I looked at
av_update_cur_dts(): can't use since new substreams might be introduced late
(like subtitles), and tested some stuff that would be rejected anyway by
messing with AVStream::cur_dts .

Anyone have any idea's or can give me a direction?

Thanks

*(Might be a better topic for av-user, not sure).

Re: FATE mtv test

Benjamin Larsson wrote:
> Hi, the mtv test spec seems to produce one more output frame. I looks 
> valid to me so just add it to the reference.

Done.

--

-- 
     -Mike Melanson

Re: [PATCH] Fast half-float to float conversion

On 2009-06-30 19:04, Frank Barchard wrote:
> On Tue, Jun 30, 2009 at 8:07 AM, Reimar Döffinger
> <Reimar.Doeffinger <at> gmx.de>wrote:
>
>> On Tue, Jun 30, 2009 at 07:55:04AM -0700, Frank Barchard wrote:
>>> On Tue, Jun 30, 2009 at 7:08 AM, Reimar Döffinger
>>> <Reimar.Doeffinger <at> gmx.de>wrote:
>>>> Personally I don't think there is any need for such optimization for
>> the
>>>> first implementation of such a rare format as OpenEXR, it can still be
>>>> added after the rest has passed review (though Michael sometimes has a
>>>> different opinion on these kinds of things), and hopefully in a way
>> that
>>>> can
>>>> be properly optimized with assembly (whether ARM NEON or SSE2 or
>>>> whatever).
>>>
>>> I agree.    A small/simple version that can be done in hardware would be
>>> good for now.
>>> Graphic chips are starting to support half float.  So at some point we'll
>>> just want to pass the images along to be rendered as is.
>>
>> It seems more like the opposite way to me: they supported half float since
>> a
>> long time, but use it less and less nowadays and may eventually remove
>> support
>> for it.
>>
>>> Conversion could be done in swscaler.
>>

Re: libavfilter-soc update and variable frame size/pixel format

On 2009-07-01 01:11, Stefano Sabatini wrote:
> On date Monday 2009-06-29 21:57:04 +0200, Stefano Sabatini encoded:
>> On date Monday 2009-06-29 21:01:15 +0200, Michael Niedermayer encoded:
>>> On Mon, Jun 29, 2009 at 08:54:38PM +0200, Stefano Sabatini wrote:
>>>> On date Monday 2009-06-29 01:26:11 +0200, Michael Niedermayer encoded:
>>>>> On Mon, Jun 29, 2009 at 01:05:19AM +0200, Stefano Sabatini wrote:
>>>>>> Hi, since r19226/19279 ffmpeg supports variable frame size/pixel
>>>>>> formats.
>>>>>>
>>>>>> I managed to update libavfilter-soc, and my current solution is to
>>>>>> simply don't support it if libavfilter is enabled.
>>>>>>
>>>>>> That's because those are ones of the problem lavfi should natively
>>>>>> manage, rather than leave the problem to the application, also I don't
>>>>>> want to spend time on this since that will be removed anyway once it
>>>>>> will be supported by the lavfi framework.
>>>>>>
>>>>>> See updating patch attached, OK to apply?
>>>>>
>>>>> i dont review diffs of diffs :)
>>>>
>>>> In attachment the diff. Note that I'm just keeping the old behaviour
>>>> when CONFIG_AVFILTER is enabled.
>>>
>>> i also dont review that
>>> we have A ---diff1--->B
>>> and
>>>
>>> we have A ---diff1--diff2->B
>>>

Re: [PATCH] Fast half-float to float conversion

On 2009-06-30 15:50, Reimar Döffinger wrote:
> On Tue, Jun 30, 2009 at 03:09:33PM +0200, Jimmy Christensen wrote:
>>> Lastly it seems to me that this code would belong into
>>> libavutil/intfloat_readwrite.*
>>
>> You are probably right.
>
> Personally I'd suggest doing a stupid implementation for
> libavutil/intfloat_readwrite.*, something like this (certainly
> not a beauty, possibly buggy, does not support denormals, though since
> they are rare it probably wouldn't be a big issue to add handling for
> them in if (nosign<  0x0400)).
> float av_int2halflt(int16_t v){
>      uint16_t nosign = v+v;
>      if (nosign>= 0xfc00) {
>          if (nosign == 0xfc00) return v>>15 ? -1.0/0.0 : 1.0/0.0;
>          else return 0.0/0.0;
>      }
>      if (nosign<  0x0400) return 0; // denormal or 0
>      return ldexp((v&0x3ff) + (1<<11)) * (v>>15|1), (v>>10&0x1f)-26);
> }
>
>
> And consider an optimized version only after it is actually used and
> thus it is clear what kind of optimizations are necessary/most useful.
> E.g. the table based approach probably is hard to SIMD and thus might be
> a bad idea if you want to convert a lot of data.

I tried testing with the code that you posted but it doesn't seem to 
work? The image looks quite clamped.