headers
Måns Rullgård | 1 Apr 2006 01:34

Re: CVS: ffmpeg/libavformat rtp.c,1.24,1.25

Luca Barbato <lu_zero <at> gentoo.org> writes:

> Richard Felker CVS wrote:
>> Update of /cvsroot/ffmpeg/ffmpeg/libavformat
>> In directory mail:/var2/tmp/cvs-serv5251
>> Modified Files:
>> 	rtp.c Log Message:
>> fix constraint violation: libavformat is not allowed to modify state of caller, including rng state
>> Index: rtp.c
>> ===================================================================
>> RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/rtp.c,v
>> retrieving revision 1.24
>> retrieving revision 1.25
>> diff -u -d -r1.24 -r1.25
>> --- rtp.c	1 Mar 2006 22:45:27 -0000	1.24
>> +++ rtp.c	30 Mar 2006 16:44:32 -0000	1.25
>>  <at>  <at>  -532,9 +532,9  <at>  <at> 
>>          payload_type = RTP_PT_PRIVATE; /* private payload type */
>>      s->payload_type = payload_type;
>>  -    s->base_timestamp = random();
>> +    s->base_timestamp = 0; /* FIXME: was random(), what should this be? */
>
> random (check the rfc)
>
>>      s->timestamp = s->base_timestamp;
>> -    s->ssrc = random();
>> +    s->ssrc = 0; /* FIXME: was random(), what should this be? */
>
> any value would fit, random warmly suggested
(Continue reading)

Permalink | Reply | 4 comments |
headers
Rich Felker | 1 Apr 2006 01:53

Re: CVS: ffmpeg/libavformat rtp.c,1.24,1.25

On Sat, Apr 01, 2006 at 12:34:51AM +0100, Måns Rullgård wrote:
> Luca Barbato <lu_zero <at> gentoo.org> writes:
> 
> > Richard Felker CVS wrote:
> >> Update of /cvsroot/ffmpeg/ffmpeg/libavformat
> >> In directory mail:/var2/tmp/cvs-serv5251
> >> Modified Files:
> >> 	rtp.c Log Message:
> >> fix constraint violation: libavformat is not allowed to modify state of caller, including rng state
> >> Index: rtp.c
> >> ===================================================================
> >> RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/rtp.c,v
> >> retrieving revision 1.24
> >> retrieving revision 1.25
> >> diff -u -d -r1.24 -r1.25
> >> --- rtp.c	1 Mar 2006 22:45:27 -0000	1.24
> >> +++ rtp.c	30 Mar 2006 16:44:32 -0000	1.25
> >>  <at>  <at>  -532,9 +532,9  <at>  <at> 
> >>          payload_type = RTP_PT_PRIVATE; /* private payload type */
> >>      s->payload_type = payload_type;
> >>  -    s->base_timestamp = random();
> >> +    s->base_timestamp = 0; /* FIXME: was random(), what should this be? */
> >
> > random (check the rfc)
> >
> >>      s->timestamp = s->base_timestamp;
> >> -    s->ssrc = random();
> >> +    s->ssrc = 0; /* FIXME: was random(), what should this be? */
> >
> > any value would fit, random warmly suggested
(Continue reading)

Permalink | Reply | 2 comments |
headers
Mike Melanson | 1 Apr 2006 01:50

Re: CVS: ffmpeg/libavformat rtp.c,1.24,1.25

Måns Rullgård wrote:
> What sort of sick spec mandates random values?  It's not like we're
> generating encryption keys here.

	MPEG AAC. Check out generate_random_vector() on this page:

   http://wiki.multimedia.cx/index.php?title=Reconstructing_AAC_CPE

Since this will eventually be part of our internal AAC decoder, maybe it 
can be leveraged for general purpose.

--

-- 
	-Mike Melanson
Permalink | Reply | 0 comments |
headers
Ivan Kalvachev | 1 Apr 2006 10:49
Picon

Re: CVS: ffmpeg/libavformat rtp.c,1.24,1.25

2006/4/1, Rich Felker <dalias <at> aerifal.cx>:
> On Sat, Apr 01, 2006 at 12:34:51AM +0100, Måns Rullgård wrote:
> > Luca Barbato <lu_zero <at> gentoo.org> writes:
> >
> > > Richard Felker CVS wrote:
> > >> Update of /cvsroot/ffmpeg/ffmpeg/libavformat
> > >> In directory mail:/var2/tmp/cvs-serv5251
> > >> Modified Files:
> > >>    rtp.c Log Message:
> > >> fix constraint violation: libavformat is not allowed to modify state of caller, including rng state
> > >> Index: rtp.c
> > >> ===================================================================
> > >> RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/rtp.c,v
> > >> retrieving revision 1.24
> > >> retrieving revision 1.25
> > >> diff -u -d -r1.24 -r1.25
> > >> --- rtp.c  1 Mar 2006 22:45:27 -0000       1.24
> > >> +++ rtp.c  30 Mar 2006 16:44:32 -0000      1.25
> > >>  <at>  <at>  -532,9 +532,9  <at>  <at> 
> > >>          payload_type = RTP_PT_PRIVATE; /* private payload type */
> > >>      s->payload_type = payload_type;
> > >>  -    s->base_timestamp = random();
> > >> +    s->base_timestamp = 0; /* FIXME: was random(), what should this be? */
> > >
> > > random (check the rfc)
> > >
> > >>      s->timestamp = s->base_timestamp;
> > >> -    s->ssrc = random();
> > >> +    s->ssrc = 0; /* FIXME: was random(), what should this be? */
> > >
(Continue reading)

Permalink | Reply | 1 comment |
headers
Måns Rullgård CVS | 1 Apr 2006 20:19
Picon

CVS: ffmpeg/libavformat mpegts.c,1.38,1.39

Update of /cvsroot/ffmpeg/ffmpeg/libavformat
In directory mail:/var2/tmp/cvs-serv3112/libavformat

Modified Files:
	mpegts.c 
Log Message:
fix memory leak on mpegts close
found by Andy Brown <abrown at daqtron com>

Index: mpegts.c
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/mpegts.c,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -d -r1.38 -r1.39
--- mpegts.c	6 Mar 2006 14:13:01 -0000	1.38
+++ mpegts.c	1 Apr 2006 18:19:00 -0000	1.39
 <at>  <at>  -1374,6 +1374,14  <at>  <at> 
     int i;
     for(i=0;i<NB_PID_MAX;i++)
         if (ts->pids[i]) mpegts_close_filter(ts, ts->pids[i]);
+
+    for(i = 0; i < ts->nb_services; i++){
+        av_free(ts->services[i]->provider_name);
+        av_free(ts->services[i]->name);
+        av_free(ts->services[i]);
+    }
+    av_freep(&ts->services);
+
     return 0;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Måns Rullgård CVS | 1 Apr 2006 21:02
Picon

CVS: ffmpeg/libavformat mpegts.c,1.39,1.40

Update of /cvsroot/ffmpeg/ffmpeg/libavformat
In directory mail:/var2/tmp/cvs-serv19665

Modified Files:
	mpegts.c 
Log Message:
This patch simply adds demuxing support for AC-3 streams in DVB TS
files.  In these streams AC-3 is given type 0x06 (private stream) and
includes a descriptor with either tag 0x6A or 0x7A.  The code already
handles ATSC AC-3 which uses stream type 0x81.  All the new patch does
is look for any stream type 0x06 that has a descriptor with the proper
tag (i.e. 0x6A or 0x7A) and if found forces it to be recognized as an
AC-3 stream.
>From Andy Brown <abrown at daqtron com>

Index: mpegts.c
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/mpegts.c,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -d -r1.39 -r1.40
--- mpegts.c	1 Apr 2006 18:19:00 -0000	1.39
+++ mpegts.c	1 Apr 2006 19:02:40 -0000	1.40
 <at>  <at>  -427,6 +427,11  <at>  <at> 
             desc_tag = get8(&p, desc_list_end);
             if (desc_tag < 0)
                 break;
+            if (stream_type == STREAM_TYPE_PRIVATE_DATA &&
+                ((desc_tag == 0x6A) || (desc_tag == 0x7A))) {
+                    /*assume DVB AC-3 Audio*/
(Continue reading)

Permalink | Reply | 0 comments |
headers
Rich Felker | 1 Apr 2006 22:15

Re: CVS: ffmpeg/libavformat rtp.c,1.24,1.25

On Sat, Apr 01, 2006 at 11:49:34AM +0300, Ivan Kalvachev wrote:
> 2006/4/1, Rich Felker <dalias <at> aerifal.cx>:
> > On Sat, Apr 01, 2006 at 12:34:51AM +0100, Måns Rullgård wrote:
> > > Luca Barbato <lu_zero <at> gentoo.org> writes:
> > >
> > > > Richard Felker CVS wrote:
> > > >> Update of /cvsroot/ffmpeg/ffmpeg/libavformat
> > > >> In directory mail:/var2/tmp/cvs-serv5251
> > > >> Modified Files:
> > > >>    rtp.c Log Message:
> > > >> fix constraint violation: libavformat is not allowed to modify state of caller, including rng state
> > > >> Index: rtp.c
> > > >> ===================================================================
> > > >> RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/rtp.c,v
> > > >> retrieving revision 1.24
> > > >> retrieving revision 1.25
> > > >> diff -u -d -r1.24 -r1.25
> > > >> --- rtp.c  1 Mar 2006 22:45:27 -0000       1.24
> > > >> +++ rtp.c  30 Mar 2006 16:44:32 -0000      1.25
> > > >>  <at>  <at>  -532,9 +532,9  <at>  <at> 
> > > >>          payload_type = RTP_PT_PRIVATE; /* private payload type */
> > > >>      s->payload_type = payload_type;
> > > >>  -    s->base_timestamp = random();
> > > >> +    s->base_timestamp = 0; /* FIXME: was random(), what should this be? */
> > > >
> > > > random (check the rfc)
> > > >
> > > >>      s->timestamp = s->base_timestamp;
> > > >> -    s->ssrc = random();
> > > >> +    s->ssrc = 0; /* FIXME: was random(), what should this be? */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Måns Rullgård CVS | 2 Apr 2006 00:29
Picon

CVS: ffmpeg/libavutil common.h,1.162,1.163

Update of /cvsroot/ffmpeg/ffmpeg/libavutil
In directory mail:/var2/tmp/cvs-serv31704/libavutil

Modified Files:
	common.h 
Log Message:
#define [U]INT32_{MIN,MAX} if missing

Index: common.h
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavutil/common.h,v
retrieving revision 1.162
retrieving revision 1.163
diff -u -d -r1.162 -r1.163
--- common.h	6 Mar 2006 22:06:33 -0000	1.162
+++ common.h	1 Apr 2006 22:29:20 -0000	1.163
 <at>  <at>  -140,6 +140,18  <at>  <at> 
 #define INT16_MAX       0x7fff
 #endif

+#ifndef INT32_MIN
+#define INT32_MIN       (-0x7fffffff-1)
+#endif
+
+#ifndef INT32_MAX
+#define INT32_MAX       0x7fffffff
+#endif
+
+#ifndef UINT32_MAX
+#define UINT32_MAX      0xffffffff
(Continue reading)

Permalink | Reply | 0 comments |
headers
Roman Shaposhnick | 2 Apr 2006 01:13
Picon

CVS: ffmpeg/libavformat dv.c,1.52,1.53

Update of /cvsroot/ffmpeg/ffmpeg/libavformat
In directory mail:/var2/tmp/cvs-serv31590/ffmpeg/libavformat

Modified Files:
	dv.c 
Log Message:
  * fixing DV-in-AVI type1 packet production bug

Index: dv.c
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavformat/dv.c,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -d -r1.52 -r1.53
--- dv.c	6 Mar 2006 08:54:33 -0000	1.52
+++ dv.c	1 Apr 2006 23:13:53 -0000	1.53
 <at>  <at>  -834,8 +834,11  <at>  <at> 
 {
     int size, i;

-    if (buf_size < 4 || buf_size < c->sys->frame_size)
-        return -1;   /* Broken frame, or not enough data */
+    if (buf_size < DV_PROFILE_BYTES ||
+        !(c->sys = dv_frame_profile(buf)) ||
+        buf_size < c->sys->frame_size) {
+          return -1;   /* Broken frame, or not enough data */
+    }

     /* Queueing audio packet */
     /* FIXME: in case of no audio/bad audio we have to do something */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Corey Hickey CVS | 3 Apr 2006 02:51
Picon

CVS: ffmpeg/libavcodec ac3enc.c,1.29,1.30

Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
In directory mail:/var2/tmp/cvs-serv17203/libavcodec

Modified Files:
	ac3enc.c 
Log Message:
AC3: support encoding fractional frame sizes

Patch by Justin Ruggles, jruggle <<at>> earthlink <<dot>> net

Index: ac3enc.c
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/ac3enc.c,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -d -r1.29 -r1.30
--- ac3enc.c	26 Mar 2006 17:07:02 -0000	1.29
+++ ac3enc.c	3 Apr 2006 00:51:09 -0000	1.30
 <at>  <at>  -38,6 +38,8  <at>  <at> 
     unsigned int bsid;
     unsigned int frame_size_min; /* minimum frame size in case rounding is necessary */
     unsigned int frame_size; /* current frame size in words */
+    unsigned int bits_written;
+    unsigned int samples_written;
     int halfratecod;
     unsigned int frmsizecod;
     unsigned int fscod; /* frequency */
 <at>  <at>  -859,7 +861,8  <at>  <at> 
     s->bit_rate = bitrate;
     s->frmsizecod = i << 1;
(Continue reading)

Permalink | Reply | 7 comments |

Gmane