libdvdread compatibility patches..

I used libdvdread-0.9.7 in my own project (llink) but since it appears 
that libdvdread has come to a stand-still, I have moved to use 
libdvdnav-4.2.1 instead, or rather, the dvdread inside libdvdnav. In 
future I will explore the additional features of libdvdnav to see what 
more I can do with it, but for now it was a simple transition.

In aid of being backward compatible (so that I could move to using 
libdvdnav) I applied the 0.9.7 patches for the various *stat() API 
methods. This is so I can simulate "directory listing" of an ISO file.

Patch 1: Add in DVDFileStat and "struct dvd_stat_t" for backward 
compatibility and maintaining portability.

Patch 2: I added a new dvd_input method for calling "unrar". This to 
allow my program to use libdvdread on .ISO files inside RAR archives. It 
uses a slightly patched "unrar" executable with a new -sk<offset> flag 
to specify starting seek position. It takes about two unrar spawns to 
"list" an ISO file, and on average, 2 unrar spawns to send a .VOB file. 
(Assuming VOB files are contiguous).

Patch 3: Add UDF2.50 support to read new BD5/9 disks.

I have only done Patch 1 and Patch 2 so far, and I do not know if it is 
even worth me forwarding them to this list, since they are rather 
specialised for me.

I will consider Patch 3 next, but if anyone has any hints, that would be 
appreciated.

Re: Fwd: [PATCH] remove preprocessor directives from nav_types.h

Il giorno ven, 25/07/2008 alle 08.25 +0200, Nico Sabbi ha scritto:

> 
> 
> ---------- Messaggio inoltrato ----------
> From: Erik Hovland <erik@...>
> To: dvdnav-discuss@...
> Date: Mon, 21 Jul 2008 13:32:03 -0700
> Subject: [DVDnav-discuss] [PATCH] remove preprocessor directives from
> nav_types.h
> For some reason nav_types.h has exactly the same preprocessor
> directives
> that ifo_types.h has and it includes ifo_types.h.
> 
> This patch removes the duplicates.
> 
> E
> 

thanks, applied
> 

r1120 - trunk/libdvdread/src/nav_types.h

Author: nicodvb
Date: Fri Jul 25 08:25:27 2008
New Revision: 1120

Log:
removed duplicated #pragma directives and definitions; patch by Erik Hovland

Modified:
   trunk/libdvdread/src/nav_types.h

Modified: trunk/libdvdread/src/nav_types.h
==============================================================================
--- trunk/libdvdread/src/nav_types.h	(original)
+++ trunk/libdvdread/src/nav_types.h	Fri Jul 25 08:25:27 2008
@@ -32,24 +32,6 @@
 #include <inttypes.h>
 #include "ifo_types.h" /* only dvd_time_t, vm_cmd_t and user_ops_t */

-
-#undef ATTRIBUTE_PACKED
-#undef PRAGMA_PACK_BEGIN 
-#undef PRAGMA_PACK_END
-
-#if defined(__GNUC__)
-#if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ >= 95)
-#define ATTRIBUTE_PACKED __attribute__ ((packed))
-#define PRAGMA_PACK 0
-#endif
-#endif
-

r1119 - in trunk/libdvdread/src: ifo_print.c ifo_print.h nav_print.c

Author: nicodvb
Date: Fri Jul 25 00:03:06 2008
New Revision: 1119

Log:
added dvdread_print_time() and removed the file-static print_time() in nav_print.c; based on a patch by
Erik Hovland org

Modified:
   trunk/libdvdread/src/ifo_print.c
   trunk/libdvdread/src/ifo_print.h
   trunk/libdvdread/src/nav_print.c

Modified: trunk/libdvdread/src/ifo_print.c
==============================================================================
--- trunk/libdvdread/src/ifo_print.c	(original)
+++ trunk/libdvdread/src/ifo_print.c	Fri Jul 25 00:03:06 2008
@@ -60,6 +60,10 @@ static void ifo_print_time(int level, dv
   printf(" @ %s fps", rate);
 }

+void dvdread_print_time(dvd_time_t *dtime) {
+  ifo_print_time(5, dtime);
+}
+
 /* Put this in some other file / package?  It's used in nav_print too.
    Possibly also by the vm / navigator. */
 static void ifo_print_cmd(int row, vm_cmd_t *command) {
@@ -655,7 +659,7 @@ static void ifo_print_CELL_PLAYBACK(cell
   for(i=0;i<nr;i++) {

Re: Fwd: [PATCH] remove dup code in dvd_input.{h, c}

Il giorno gio, 24/07/2008 alle 23.47 +0200, Nico Sabbi ha scritto:
> 
> 
> ---------- Forwarded message ----------
> From: Nico Sabbi <Nicola.Sabbi@...>
> Date: 2008/7/22
> Subject: Fwd: [DVDnav-discuss] [PATCH] remove dup code in
> dvd_input.{h,c}
> To: Nico Sabbi <nico.sabbi@...>
> 
> 
> 
> 
> 
> ---------- Messaggio inoltrato ----------
> From: Erik Hovland <erik@...>
> To: dvdnav-discuss@...
> Date: Mon, 21 Jul 2008 11:45:49 -0700
> Subject: [DVDnav-discuss] [PATCH] remove dup code in dvd_input.{h,c}
> The function pointer declarations in dvd_input.{h,c} are redundant.
> This
> patch puts them only in the header and makes it so extern is not used
> internally in the C file.
> 
> E
> 
> --
> Erik Hovland
> mail: erik@...
> web: http://hovland.org/

[PATCH] move print_time to its own file and remove it from {ifo, nav}_print.c

ifo_print.c and nav_print.c both have a function print_time. That aside
from the asserts vs. CHECK_VALUE are exactly the same. There is even a
comment about it.

So I moved print_time to a new file, dvdread_internal.c and renamed it.
Then changed the usage in {ifo,nav}_print.c to that function.

E

--

-- 
Erik Hovland
mail: erik@...
web: http://hovland.org/
PGP/GPG public key available on request

_______________________________________________
DVDnav-discuss mailing list
DVDnav-discuss@...
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss

[PATCH] remove preprocessor directives from nav_types.h

For some reason nav_types.h has exactly the same preprocessor directives
that ifo_types.h has and it includes ifo_types.h.

This patch removes the duplicates.

E

--

-- 
Erik Hovland
mail: erik@...
web: http://hovland.org/
PGP/GPG public key available on request

_______________________________________________
DVDnav-discuss mailing list
DVDnav-discuss@...
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss

[PATCH] fix types in dvd_input.{h,c}

While looking through dvd_input.{h,c}, I noticed a few typos.

E

--

-- 
Erik Hovland
mail: erik@...
web: http://hovland.org/
PGP/GPG public key available on request

_______________________________________________
DVDnav-discuss mailing list
DVDnav-discuss@...
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss

[PATCH] remove dup code in dvd_input.{h,c}

The function pointer declarations in dvd_input.{h,c} are redundant. This
patch puts them only in the header and makes it so extern is not used
internally in the C file.

E

--

-- 
Erik Hovland
mail: erik@...
web: http://hovland.org/
PGP/GPG public key available on request

_______________________________________________
DVDnav-discuss mailing list
DVDnav-discuss@...
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss

r1118 - trunk/libdvdread/src/ifo_read.c

Author: nicodvb
Date: Wed Jul 16 09:46:33 2008
New Revision: 1118

Log:
moved various pieces of duplicated code to free_ptl_mait(); patch by Erik Hovland org

Modified:
   trunk/libdvdread/src/ifo_read.c

Modified: trunk/libdvdread/src/ifo_read.c
==============================================================================
--- trunk/libdvdread/src/ifo_read.c	(original)
+++ trunk/libdvdread/src/ifo_read.c	Wed Jul 16 09:46:33 2008
@@ -276,6 +276,15 @@ static void read_playback_type(playback_
   pt->title_or_time_play              = dvdread_getbits(&state, 1);
 }

+static void free_ptl_mait(ptl_mait_t* ptl_mait, int num_entries) {
+  int i;
+  for (i = 0; i < num_entries; i++)
+    free(ptl_mait->countries[i].pf_ptl_mai);
+
+  free(ptl_mait->countries);
+  free(ptl_mait);
+}
+
 ifo_handle_t *ifoOpen(dvd_reader_t *dvd, int title) {
   ifo_handle_t *ifofile;

[PATCH] remove some duplicate code in ifo_read.c

This patch removes some duplicate code in ifo_read.c. The code to delete
the pmt_maint_t struct is duplicated in a few places.

This is in the libdvdread tree.

E

--

-- 
Erik Hovland
mail: erik@...
web: http://hovland.org/
PGP/GPG public key available on request

_______________________________________________
DVDnav-discuss mailing list
DVDnav-discuss@...
https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss