Re: [RFC PATCH] Re: KMS:RV635:Radeon 3650HD graphics driver broken on a laptop when connected to a docking station and external display
Alex Deucher <alexdeucher <at> gmail.com>
2010-07-01 14:35:34 GMT
On Thu, Jul 1, 2010 at 10:07 AM, Pasi Kärkkäinen <pasik <at> iki.fi> wrote:
> On Mon, Jun 21, 2010 at 09:18:01PM +0300, Pasi Kärkkäinen wrote:
>> > >>
>> > >> I am not sure your patch is right, my guess is that devices field of
>> > >> radeon connector structure btw the HDMI & DVI connector are different
>> > >> and thus that drm_detect_hdmi_monitor is not call. I expect it's normal
>> > >> for the device field to be different (my understanding being that HDMI
>> > >> will have one more bit set than the DVI connector). Bottom line is
>> > >> i think we want to discard non hdmi connector just in case we face
>> > >> shared connector.
>> > >>
>> > >> Alex would have to comment on the device field test, maybe your atombios
>> > >> is broken. Does it works if instead of removing
>> > >> if (connector == list_connector)
>> > >> continue;
>> > >> You remove :
>> > >> if (radeon_connector->devices == list_radeon_connector->devices)
>> > >>
>> > >> Also can you print the radeon_connector->devices of all your connector
>> > >> so we can compare them.
>> > >
>> > > The code was for systems with shared ddc lines and shared encoders,
>> > > but it looks like your system may have a shared ddc line and (sort of)
>> > > non-shared encoders. I suspect the DVI port is using UNIPHY A or A+B
>> > > (for dual link) and HDMI is using UNIPHY link B. It's probably
>> > > actually using router objects (gpio toggle to switch gpio routing
>> > > between physical ports), however support for that is not implemented
>> > > yet which is why we have the current code. Can you send me a copy of
>> > > your vbios so I can verify?
>> > >
(Continue reading)