Daniel Vetter | 21 Oct 15:38 2014
Picon

[PULL] drm-intel-next

Hi Dave,

drm-intel-next-2014-10-03:
- first batch of skl stage 1 enabling
- fixes from Rodrigo to the PSR, fbc and sink crc code
- kerneldoc for the frontbuffer tracking code, runtime pm code and the basic
  interrupt enable/disable functions
- smaller stuff all over
drm-intel-next-2014-09-19:
- bunch more i830M fixes from Ville
- full ppgtt now again enabled by default
- more ppgtt fixes from Michel Thierry and Chris Wilson
- plane config work from Gustavo Padovan
- spinlock clarifications
- piles of smaller improvements all over, as usual

As promised the updated pull with the backmerge to take care of the silent
conflict I've missed first time around.

Cheers, Daniel

The following changes since commit ebb69c95175609990af708ec90c46530f5a2c819:

  drm/i915: Enable pixel replicated modes on BDW and HSW. (2014-10-01 10:01:41 +0200)

are available in the git repository at:

  git://anongit.freedesktop.org/drm-intel tags/drm-intel-next-2014-10-03-merge

for you to fetch changes up to a8cbd4597799ade2b8a656dac7768c352b58e43a:
(Continue reading)

bugzilla-daemon | 21 Oct 04:53 2014

[Bug 85267] New: vlc crashes with vdpau (Radeon 3850HD) [r600]

Bug ID Summary Product Version Hardware OS Status Severity Priority Component Assignee Reporter
85267
vlc crashes with vdpau (Radeon 3850HD) [r600]
Mesa
unspecified
x86-64 (AMD64)
Linux (All)
NEW
normal
medium
Drivers/Gallium/r600
dri-devel <at> lists.freedesktop.org
arthur.marsh <at> internode.on.net

I'm using version 10.3.1-1 on Debian of most mesa-related packages and Linux kernel 3.18.0-rc1 from Linus' git head. replaying a particular dvd in VLC triggers some errors: (see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766058 ) vdpau-related packages are also installed; when I ran the dvd in VLC under valgrind I encountered: (comments are from michel <at> daenzer.net ) > ==13424== Invalid read of size 1 > ==13424== at 0x1A8789C0: r600_bind_blend_state_internal (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1A6723C0: blitter_restore_fragment_states (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1A675C47: util_blitter_clear_render_target (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1A852985: r600_clear_render_target (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1A69D9A9: vl_compositor_render (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1A629E96: vlVdpPresentationQueueDisplay (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1F2F80A3: Queue (in /usr/lib/vlc/plugins/vdpau/libvdpau_display_plugin.so) > ==13424== by 0x30D0E6DB48: ThreadDisplayPicture (in /usr/lib/libvlccore.so.8.0.0) > ==13424== by 0x30D0E6DEB2: Thread (in /usr/lib/libvlccore.so.8.0.0) > ==13424== by 0x30022080A3: start_thread (pthread_create.c:309) > ==13424== Address 0xedfe51d is 61 bytes inside a block of size 64 free'd > ==13424== at 0x4A08E90: free (vg_replace_malloc.c:473) > ==13424== by 0x1A62C7DD: vlVdpOutputSurfaceRenderBitmapSurface (in /usr/lib/x86_64-linux-gnu/vdpau/libvdpau_r600.so.1.0.0) > ==13424== by 0x1F2F8200: Queue (in /usr/lib/vlc/plugins/vdpau/libvdpau_display_plugin.so) > ==13424== by 0x30D0E6DB48: ThreadDisplayPicture (in /usr/lib/libvlccore.so.8.0.0) > ==13424== by 0x30D0E6DEB2: Thread (in /usr/lib/libvlccore.so.8.0.0) > ==13424== by 0x30022080A3: start_thread (pthread_create.c:309) This looks like a use-after-free bug in the Mesa r600g driver. Can you report this upstream at https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa , component Drivers/Gallium/r600?
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Michel Dänzer | 20 Oct 11:40 2014
Picon

[PATCH] drm/radeon: Use drm_malloc_ab instead of kmalloc_array

From: Michel Dänzer <michel.daenzer <at> amd.com>

Should avoid kmalloc failures due to large number of array entries.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81991
Signed-off-by: Michel Dänzer <michel.daenzer <at> amd.com>
---
 drivers/gpu/drm/radeon/radeon_cs.c   | 2 +-
 drivers/gpu/drm/radeon/radeon_ring.c | 4 ++--
 drivers/gpu/drm/radeon/radeon_vm.c   | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 1c89344..a3e7aed 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
 <at>  <at>  -450,7 +450,7  <at>  <at>  static void radeon_cs_parser_fini(struct radeon_cs_parser *parser, int error, bo
 	kfree(parser->track);
 	kfree(parser->relocs);
 	kfree(parser->relocs_ptr);
-	kfree(parser->vm_bos);
+	drm_free_large(parser->vm_bos);
 	for (i = 0; i < parser->nchunks; i++)
 		drm_free_large(parser->chunks[i].kdata);
 	kfree(parser->chunks);
diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c
index 596e591..51dcf40 100644
--- a/drivers/gpu/drm/radeon/radeon_ring.c
+++ b/drivers/gpu/drm/radeon/radeon_ring.c
 <at>  <at>  -314,7 +314,7  <at>  <at>  unsigned radeon_ring_backup(struct radeon_device *rdev, struct radeon_ring *ring
 	}

 	/* and then save the content of the ring */
-	*data = kmalloc_array(size, sizeof(uint32_t), GFP_KERNEL);
+	*data = drm_malloc_ab(size, sizeof(uint32_t));
 	if (!*data) {
 		mutex_unlock(&rdev->ring_lock);
 		return 0;
 <at>  <at>  -356,7 +356,7  <at>  <at>  int radeon_ring_restore(struct radeon_device *rdev, struct radeon_ring *ring,
 	}

 	radeon_ring_unlock_commit(rdev, ring, false);
-	kfree(data);
+	drm_free_large(data);
 	return 0;
 }

diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
index 4532cc7..dfde266 100644
--- a/drivers/gpu/drm/radeon/radeon_vm.c
+++ b/drivers/gpu/drm/radeon/radeon_vm.c
 <at>  <at>  -132,8 +132,8  <at>  <at>  struct radeon_cs_reloc *radeon_vm_get_bos(struct radeon_device *rdev,
 	struct radeon_cs_reloc *list;
 	unsigned i, idx;

-	list = kmalloc_array(vm->max_pde_used + 2,
-			     sizeof(struct radeon_cs_reloc), GFP_KERNEL);
+	list = drm_malloc_ab(vm->max_pde_used + 2,
+			     sizeof(struct radeon_cs_reloc));
 	if (!list)
 		return NULL;

--

-- 
2.1.1

_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
bugzilla-daemon | 20 Oct 00:41 2014

[Bug 85107] A10-7800: Boot problems (CPU stuck) and dpm not working correctly

Comment # 9 on bug 85107 from Today I tried to use radeon.dpm=0 to get the full performance, but I noticed that with radeon.dpm=0 I get the CPU stuck errors again, even with radeon.bapm=0. So the only way to boot without these errors is "radeon.bapm=0" or "radeon.bapm=0 radeon.dpm=1".
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
bugzilla-daemon | 19 Oct 23:07 2014

[Bug 85207] New: agd5f drm-next-3.19-wip + Unreal Elemental sometimes = list_add corruption/hung task

Bug ID Summary Product Version Hardware OS Status Severity Priority Component Assignee Reporter
85207
agd5f drm-next-3.19-wip + Unreal Elemental sometimes = list_add corruption/hung task
DRI
XOrg CVS
Other
All
NEW
normal
medium
DRM/Radeon
dri-devel <at> lists.freedesktop.org
adf.lists <at> gmail.com

Created attachment 108075 [details] dmesg when Unreal Elemental hangs on start R9270X Sometime running unreal elemental demo it hangs at startup with errors in dmesg attached. This doesn't always happen. Mesa is currently on winsys/radeon: Use a single buffer cache manager again, previously produced with slightly older. Haven't seen on drm-next-3.18-wip (but really need to test more with current mesa) Possibly unrelated, but new for drm-next-3.19-wip I get below when running Unigine Valley - it runs OK. Oct 17 11:15:35 ph4 kernel: radeon 0000:01:00.0: GPU fault detected: 146 0x0af03504 Oct 17 11:15:35 ph4 kernel: radeon 0000:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x00010E57 Oct 17 11:15:35 ph4 kernel: radeon 0000:01:00.0: VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x10035004 Oct 17 11:15:35 ph4 kernel: VM fault (0x04, vmid 8) at page 69207, read from VGT (53)
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
bugzilla-daemon | 19 Oct 21:21 2014

[Bug 85204] New: [Radeon HD 5650] return from sleep state failed

Bug ID Summary Product Version Hardware OS Status Severity Priority Component Assignee Reporter
85204
[Radeon HD 5650] return from sleep state failed
DRI
XOrg 6.7.0
x86-64 (AMD64)
Linux (All)
NEW
normal
medium
DRM/Radeon
dri-devel <at> lists.freedesktop.org
rnp <at> 25ghz.net

Created attachment 108069 [details] Kernel log The system is put from sleep from GUI (X.org + KDE). After "waking up" the from sleep state the GUI is not accessible anymore and the screen keeps switching from conlose with kernel log output and a black screen. Tested on Arch Linux, Kernel version 3.17.0, 3.17.1 Graphic card infos and kenrel log: see files attached. Okt 19 19:18:56 fourier kernel: [drm:radeon_cs_ib_fill] *ERROR* Failed to get ib ! Okt 19 19:18:56 fourier kernel: [drm] PCIE GART of 1024M enabled (table at 0x000000000025D000). Okt 19 19:18:56 fourier kernel: [drm] UVD initialized successfully. Okt 19 19:18:56 fourier kernel: [drm] ring test on 0 succeeded in 1 usecs Okt 19 19:18:56 fourier kernel: [drm] ring test on 3 succeeded in 1 usecs Okt 19 19:18:56 fourier kernel: [drm] ring test on 5 succeeded in 1 usecs Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_STATUS = 0x00003828 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_STATUS = 0xA0003828 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0x00000007 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_STATUS_SE0 = 0x00000007 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0x00000007 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_STATUS_SE1 = 0x00000007 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_008674_CP_STALLED_STAT1 = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_008678_CP_STALLED_STAT2 = 0x00010002 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_00867C_CP_BUSY_STAT = 0x00020182 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_008680_CP_STAT = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_008680_CP_STAT = 0x80038647 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_00D034_DMA_STATUS_REG = 0x44C83D57 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: R_00D034_DMA_STATUS_REG = 0x44C83D57 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: SRBM_STATUS = 0x200000C0 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: SRBM_STATUS = 0x200000C0 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: SRBM_STATUS2 = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: SRBM_STATUS2 = 0x00000000 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GPU lockup (waiting for 0x000000000000140e last fence id 0x00000000000013f7 on ring 0) Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GPU reset succeeded, trying to resume Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GPU softreset: 0x00000008 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: GRBM_SOFT_RESET=0x00004001 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: SRBM_SOFT_RESET=0x00000100 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: Saved 1202 dwords of commands on ring 0. Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: WB enabled Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: failed to get a new IB (-35) Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: fence driver on ring 0 use gpu addr 0x0000000040000c00 and cpu addr 0xffff88020cfc2c00 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: fence driver on ring 3 use gpu addr 0x0000000040000c0c and cpu addr 0xffff88020cfc2c0c Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: fence driver on ring 5 use gpu addr 0x000000000005c418 and cpu addr 0xffffc9000731c418 Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: ffff8801fa15d000 pin failed Okt 19 19:18:56 fourier kernel: radeon 0000:01:00.0: ring 0 stalled for more than 10203msec Okt 19 19:19:06 fourier kernel: [drm:r600_ib_test] *ERROR* radeon: fence wait failed (-35). Okt 19 19:19:06 fourier kernel: [drm:radeon_ib_ring_tests] *ERROR* radeon: failed testing IB on GFX ring (-35). Okt 19 19:19:06 fourier kernel: [drm] PCIE GART of 1024M enabled (table at 0x000000000025D000). Okt 19 19:19:06 fourier kernel: [drm] ring test on 0 succeeded in 1 usecs Okt 19 19:19:06 fourier kernel: [drm] ring test on 3 succeeded in 1 usecs
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
bugzilla-daemon | 18 Oct 21:14 2014

[Bug 85180] New: [drm:r100_ring_test] *ERROR* radeon: ring test failed (scratch(0x15E4)=0xCAFEDEAD)

Bug ID Summary Product Version Hardware OS Status Severity Priority Component Assignee Reporter
85180
[drm:r100_ring_test] *ERROR* radeon: ring test failed (scratch(0x15E4)=0xCAFEDEAD)
DRI
unspecified
x86 (IA32)
Linux (All)
NEW
normal
medium
DRM/Radeon
dri-devel <at> lists.freedesktop.org
wrgcpp <at> gmail.com

Created attachment 108036 [details] dmesg I'm using Debian Jessie, kernel 3.16.3, my graphic card is 01:05.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] RV350 [Radeon 9550] System is booting normally, but GPU acceleration can't start.
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Clark | 18 Oct 00:53 2014
Picon

[PATCH] drm/i915/vlv: don't try to enable a crtc without fb

On valleyview, all enabled pipes get added to the prepare mask.  However
if you did state readout to find that the crtc is enabled, but failed to
map stolen mem and wrap it in a bo (and fb), you could end up in a
scenario where crtc->primary->fb is still null on first modeset.  So
lets check for this rather than exploding.

Signed-off-by: Rob Clark <robdclark <at> gmail.com>
---
As with http://lists.freedesktop.org/archives/dri-devel/2014-September/069341.html
the root cause is issues with stolen region.  But it would be nice if
i915 was a bit less fragile when things don't go as planned.

This could have the side effect that, at first modeset, the crtc's which
were enabled by BIOS but not yet set (by fbcon or userspace) get disabled.
This is a somewhat lesser inconvenience compared to opps'ing under
console_lock.

 drivers/gpu/drm/i915/intel_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d8324c6..9f85033 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
 <at>  <at>  -10895,6 +10895,9  <at>  <at>  static int __intel_set_mode(struct drm_crtc *crtc,

 	/* Now enable the clocks, plane, pipe, and connectors that we set up. */
 	for_each_intel_crtc_masked(dev, prepare_pipes, intel_crtc) {
+		if (!intel_crtc->base.primary->fb)
+			continue;
+
 		update_scanline_offset(intel_crtc);

 		dev_priv->display.crtc_enable(&intel_crtc->base);
--

-- 
1.9.3
Jani Nikula | 17 Oct 23:13 2014
Picon

[PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

Documentation/kbuild/kconfig-language.txt warns to use select with care,
and in general use select only for non-visible symbols and for symbols
with no dependencies, because select will force a symbol to a value
without visiting the dependencies.

Select has become particularly problematic, interdependently, with the
BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO configs. For example:

scripts/kconfig/conf --randconfig Kconfig
KCONFIG_SEED=0x48312B00
warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 &&
DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY
&& FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI &&
EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE
which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT)
warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 &&
DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY
&& FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI &&
EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE
which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT)

With tristates it's possible to end up selecting FOO=y depending on
BAR=m in the config, which gets discovered at build time, not config
time, like reported in the thread referenced below.

Do the following to fix the dependencies:

* Depend on instead of select BACKLIGHT_CLASS_DEVICE everywhere. Drop
  select BACKLIGHT_LCD_SUPPORT in such cases, as it's a dependency of
  BACKLIGHT_CLASS_DEVICE.

* Remove config FB_BACKLIGHT altogether, and replace it with a
  dependency on BACKLIGHT_CLASS_DEVICE. All configs selecting
  FB_BACKLIGHT select or depend on FB anyway, so we can simplify.

* Depend on (ACPI && ACPI_VIDEO) || ACPI=n in several places instead of
  selecting ACPI_VIDEO and a number of its dependencies if ACPI is
  enabled. This is tied to backlight, as ACPI_VIDEO depends on
  BACKLIGHT_CLASS_DEVICE.

* Replace a couple of select INPUT/VT with depends as it seemed to be
  necessary.

Reference: http://lkml.kernel.org/r/CA+r1ZhhmT4DrWtf6MbRQo5EqXwx+LxCqh15Vsu_d9WpftLhnxw <at> mail.gmail.com
Reported-by: Jim Davis <jim.epost <at> gmail.com>
Cc: Randy Dunlap <rdunlap <at> infradead.org>
Cc: David Airlie <airlied <at> linux.ie>
Cc: Daniel Vetter <daniel.vetter <at> intel.com>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
Cc: Darren Hart <dvhart <at> infradead.org>
Cc: Laurent Pinchart <laurent.pinchart <at> ideasonboard.com>
Cc: Benjamin Herrenschmidt <benh <at> kernel.crashing.org>
Cc: Jens Frederich <jfrederich <at> gmail.com>
Cc: Daniel Drake <dsd <at> laptop.org>
Cc: Jon Nettleton <jon.nettleton <at> gmail.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj <at> jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen <at> ti.com>
Signed-off-by: Jani Nikula <jani.nikula <at> intel.com>

---

Sorry for the huge distribution; this is really quite hard to split up
sensibly without breaking the build!
---
 drivers/gpu/drm/Kconfig            |  2 +-
 drivers/gpu/drm/gma500/Kconfig     |  4 +---
 drivers/gpu/drm/i915/Kconfig       |  9 ++-------
 drivers/gpu/drm/nouveau/Kconfig    | 10 ++--------
 drivers/gpu/drm/shmobile/Kconfig   |  2 +-
 drivers/gpu/drm/tilcdc/Kconfig     |  3 +--
 drivers/macintosh/Kconfig          |  2 +-
 drivers/platform/x86/Kconfig       | 19 ++++++++-----------
 drivers/staging/olpc_dcon/Kconfig  |  2 +-
 drivers/usb/misc/Kconfig           |  3 +--
 drivers/video/fbdev/Kconfig        | 29 +++++++++++------------------
 drivers/video/fbdev/core/fbsysfs.c |  8 ++++----
 include/linux/fb.h                 |  2 +-
 include/uapi/linux/fb.h            |  2 +-
 14 files changed, 36 insertions(+), 61 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index e3b4b0f02b3d..dc789d0e293c 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
 <at>  <at>  -99,6 +99,7  <at>  <at>  config DRM_R128
 config DRM_RADEON
 	tristate "ATI Radeon"
 	depends on DRM && PCI
+	depends on BACKLIGHT_CLASS_DEVICE || BACKLIGHT_CLASS_DEVICE=n
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
 <at>  <at>  -108,7 +109,6  <at>  <at>  config DRM_RADEON
         select DRM_TTM
 	select POWER_SUPPLY
 	select HWMON
-	select BACKLIGHT_CLASS_DEVICE
 	select INTERVAL_TREE
 	select MMU_NOTIFIER
 	help
diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
index 17f928ec84ea..a84d0a4fcc58 100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
 <at>  <at>  -8,9 +8,7  <at>  <at>  config DRM_GMA500
 	select DRM_KMS_FB_HELPER
 	select DRM_TTM
 	# GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
-	select ACPI_VIDEO if ACPI
-	select BACKLIGHT_CLASS_DEVICE if ACPI
-	select INPUT if ACPI
+	depends on (ACPI && ACPI_VIDEO) || ACPI=n
 	help
 	  Say yes for an experimental 2D KMS framebuffer driver for the
 	  Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 4e39ab34eb1c..75d4c52c0971 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
 <at>  <at>  -3,6 +3,8  <at>  <at>  config DRM_I915
 	depends on DRM
 	depends on X86 && PCI
 	depends on (AGP || AGP=n)
+	depends on (ACPI && ACPI_VIDEO) || ACPI=n
+	depends on BACKLIGHT_CLASS_DEVICE || BACKLIGHT_CLASS_DEVICE=n
 	select INTEL_GTT
 	select AGP_INTEL if AGP
 	select INTERVAL_TREE
 <at>  <at>  -11,13 +13,6  <at>  <at>  config DRM_I915
 	select SHMEM
 	select TMPFS
 	select DRM_KMS_HELPER
-	# i915 depends on ACPI_VIDEO when ACPI is enabled
-	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
-	select BACKLIGHT_LCD_SUPPORT if ACPI
-	select BACKLIGHT_CLASS_DEVICE if ACPI
-	select INPUT if ACPI
-	select ACPI_VIDEO if ACPI
-	select ACPI_BUTTON if ACPI
 	help
 	  Choose this option if you have a system that has "Intel Graphics
 	  Media Accelerator" or "HD Graphics" integrated graphics,
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 40afc69a3778..40227fc4f284 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
 <at>  <at>  -1,6 +1,7  <at>  <at> 
 config DRM_NOUVEAU
 	tristate "Nouveau (NVIDIA) cards"
 	depends on DRM && PCI
+	depends on (ACPI && ACPI_VIDEO) || ACPI=n
         select FW_LOADER
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
 <at>  <at>  -10,18 +11,10  <at>  <at>  config DRM_NOUVEAU
 	select FB_CFB_IMAGEBLIT
 	select FB
 	select FRAMEBUFFER_CONSOLE if !EXPERT
-	select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT
-	select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT
 	select X86_PLATFORM_DEVICES if ACPI && X86
 	select ACPI_WMI if ACPI && X86
 	select MXM_WMI if ACPI && X86
 	select POWER_SUPPLY
-	# Similar to i915, we need to select ACPI_VIDEO and it's dependencies
-	select BACKLIGHT_LCD_SUPPORT if ACPI && X86
-	select BACKLIGHT_CLASS_DEVICE if ACPI && X86
-	select INPUT if ACPI && X86
-	select THERMAL if ACPI && X86
-	select ACPI_VIDEO if ACPI && X86
 	help
 	  Choose this option for open-source NVIDIA support.

 <at>  <at>  -64,6 +57,7  <at>  <at>  config NOUVEAU_DEBUG_DEFAULT
 config DRM_NOUVEAU_BACKLIGHT
 	bool "Support for backlight control"
 	depends on DRM_NOUVEAU
+	depends on BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  Say Y here if you want to control the backlight of your display
diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
index a50fe0eeaa0d..71c00f3c0fbc 100644
--- a/drivers/gpu/drm/shmobile/Kconfig
+++ b/drivers/gpu/drm/shmobile/Kconfig
 <at>  <at>  -2,7 +2,7  <at>  <at>  config DRM_SHMOBILE
 	tristate "DRM Support for SH Mobile"
 	depends on DRM && ARM
 	depends on ARCH_SHMOBILE || COMPILE_TEST
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
 	select DRM_KMS_CMA_HELPER
diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index 7c3ef79fcb37..52e60feaae53 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
 <at>  <at>  -1,13 +1,12  <at>  <at> 
 config DRM_TILCDC
 	tristate "DRM Support for TI LCDC Display Controller"
 	depends on DRM && OF && ARM
+	depends on BACKLIGHT_CLASS_DEVICE
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
 	select VIDEOMODE_HELPERS
-	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	help
 	  Choose this option if you have an TI SoC with LCDC display
 	  controller, for example AM33xx in beagle-bone, DA8xx, or
diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 3067d56b11a6..50cb2c3b567e 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
 <at>  <at>  -135,7 +135,7  <at>  <at>  config PMAC_MEDIABAY
 config PMAC_BACKLIGHT
 	bool "Backlight control for LCD screens"
 	depends on ADB_PMU && FB = y && (BROKEN || !PPC64)
-	select FB_BACKLIGHT
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Say Y here to enable Macintosh specific extensions of the generic
 	  backlight code. With this enabled, the brightness keys on older
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4dcfb7116a04..63e99ce0e3f8 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
 <at>  <at>  -17,7 +17,7  <at>  <at>  if X86_PLATFORM_DEVICES

 config ACER_WMI
 	tristate "Acer WMI Laptop Extras"
-	depends on ACPI
+	depends on ACPI && ACPI_VIDEO
 	select LEDS_CLASS
 	select NEW_LEDS
 	depends on BACKLIGHT_CLASS_DEVICE
 <at>  <at>  -26,8 +26,6  <at>  <at>  config ACER_WMI
 	depends on RFKILL || RFKILL = n
 	depends on ACPI_WMI
 	select INPUT_SPARSEKMAP
-	# Acer WMI depends on ACPI_VIDEO when ACPI is enabled
-        select ACPI_VIDEO if ACPI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,
 <at>  <at>  -70,7 +68,7  <at>  <at>  config ASUS_LAPTOP
 	depends on ACPI
 	select LEDS_CLASS
 	select NEW_LEDS
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
 	depends on RFKILL || RFKILL = n
 	select INPUT_SPARSEKMAP
 <at>  <at>  -294,7 +292,7  <at>  <at>  config COMPAL_LAPTOP
 config SONY_LAPTOP
 	tristate "Sony Laptop Extras"
 	depends on ACPI
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
 	depends on RFKILL
 	  ---help---
 <at>  <at>  -329,8 +327,7  <at>  <at>  config THINKPAD_ACPI
 	depends on ACPI
 	depends on INPUT
 	depends on RFKILL || RFKILL = n
-	select BACKLIGHT_LCD_SUPPORT
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	select HWMON
 	select NVRAM
 	select NEW_LEDS
 <at>  <at>  -499,7 +496,7  <at>  <at>  config EEEPC_LAPTOP
 	depends on INPUT
 	depends on RFKILL || RFKILL = n
 	depends on HOTPLUG_PCI
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	select HWMON
 	select LEDS_CLASS
 	select NEW_LEDS
 <at>  <at>  -675,8 +672,8  <at>  <at>  config ACPI_CMPC
 	tristate "CMPC Laptop Extras"
 	depends on X86 && ACPI
 	depends on RFKILL || RFKILL=n
-	select INPUT
-	select BACKLIGHT_CLASS_DEVICE
+	depends on INPUT
+	depends on BACKLIGHT_CLASS_DEVICE
 	default n
 	help
 	  Support for Intel Classmate PC ACPI devices, including some
 <at>  <at>  -805,7 +802,7  <at>  <at>  config INTEL_OAKTRAIL
 config SAMSUNG_Q10
 	tristate "Samsung Q10 Extras"
 	depends on ACPI
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	---help---
 	  This driver provides support for backlight control on Samsung Q10
 	  and related laptops, including Dell Latitude X200.
diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
index d277f048789e..94acb4279704 100644
--- a/drivers/staging/olpc_dcon/Kconfig
+++ b/drivers/staging/olpc_dcon/Kconfig
 <at>  <at>  -3,7 +3,7  <at>  <at>  config FB_OLPC_DCON
 	depends on OLPC && FB
 	depends on I2C
 	depends on (GPIO_CS5535 || GPIO_CS5535=n)
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	---help---
 	  In order to support very low power operation, the XO laptop uses a
 	  secondary Display CONtroller, or DCON.  This secondary controller
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 76d77206e011..824630b09662 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
 <at>  <at>  -150,8 +150,7  <at>  <at>  config USB_FTDI_ELAN

 config USB_APPLEDISPLAY
 	tristate "Apple Cinema Display support"
-	select BACKLIGHT_LCD_SUPPORT
-	select BACKLIGHT_CLASS_DEVICE
+	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Say Y here if you want to control the backlight of Apple Cinema
 	  Displays over USB. This driver provides a sysfs interface.
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index ccbe2ae22ac5..8cae7da2c723 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
 <at>  <at>  -185,13 +185,6  <at>  <at>  config FB_MACMODES
        depends on FB
        default n

-config FB_BACKLIGHT
-	bool
-	depends on FB
-	select BACKLIGHT_LCD_SUPPORT
-	select BACKLIGHT_CLASS_DEVICE
-	default n
-
 config FB_MODE_HELPERS
         bool "Enable Video Mode Handling Helpers"
         depends on FB
 <at>  <at>  -323,7 +316,7  <at>  <at>  config FB_CLPS711X
 	tristate "CLPS711X LCD support"
 	depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
 	select FB_CLPS711X_OLD if ARCH_CLPS711X && !ARCH_MULTIPLATFORM
-	select BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT
 	select FB_MODE_HELPERS
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 <at>  <at>  -351,7 +344,7  <at>  <at>  config FB_SA1100
 config FB_IMX
 	tristate "Freescale i.MX1/21/25/27 LCD support"
 	depends on FB && ARCH_MXC
-	select BACKLIGHT_LCD_SUPPORT
+	depends on BACKLIGHT_LCD_SUPPORT
 	select LCD_CLASS_DEVICE
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 <at>  <at>  -674,7 +667,7  <at>  <at>  config FB_STI
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
 	select STI_CONSOLE
-	select VT
+	depends on VT
 	default y
 	---help---
 	  STI refers to the HP "Standard Text Interface" which is a set of
 <at>  <at>  -990,7 +983,7  <at>  <at>  config FB_S1D13XXX
 config FB_ATMEL
 	tristate "AT91/AT32 LCD Controller support"
 	depends on FB && HAVE_FB_ATMEL
-	select FB_BACKLIGHT
+	depends on BACKLIGHT_CLASS_DEVICE
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
 <at>  <at>  -1019,7 +1012,6  <at>  <at>  config FB_ATMEL_STN
 config FB_NVIDIA
 	tristate "nVidia Framebuffer Support"
 	depends on FB && PCI
-	select FB_BACKLIGHT if FB_NVIDIA_BACKLIGHT
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 <at>  <at>  -1060,6 +1052,7  <at>  <at>  config FB_NVIDIA_DEBUG
 config FB_NVIDIA_BACKLIGHT
 	bool "Support for backlight control"
 	depends on FB_NVIDIA
+	depends on BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  Say Y here if you want to control the backlight of your display.
 <at>  <at>  -1067,7 +1060,6  <at>  <at>  config FB_NVIDIA_BACKLIGHT
 config FB_RIVA
 	tristate "nVidia Riva support"
 	depends on FB && PCI
-	select FB_BACKLIGHT if FB_RIVA_BACKLIGHT
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 <at>  <at>  -1107,6 +1099,7  <at>  <at>  config FB_RIVA_DEBUG
 config FB_RIVA_BACKLIGHT
 	bool "Support for backlight control"
 	depends on FB_RIVA
+	depends on BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  Say Y here if you want to control the backlight of your display.
 <at>  <at>  -1345,7 +1338,6  <at>  <at>  config FB_MATROX_MAVEN
 config FB_RADEON
 	tristate "ATI Radeon display support"
 	depends on FB && PCI
-	select FB_BACKLIGHT if FB_RADEON_BACKLIGHT
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 <at>  <at>  -1370,6 +1362,7  <at>  <at>  config FB_RADEON_I2C
 config FB_RADEON_BACKLIGHT
 	bool "Support for backlight control"
 	depends on FB_RADEON
+	depends on BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  Say Y here if you want to control the backlight of your display.
 <at>  <at>  -1389,7 +1382,6  <at>  <at>  config FB_ATY128
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-	select FB_BACKLIGHT if FB_ATY128_BACKLIGHT
 	select FB_MACMODES if PPC_PMAC
 	help
 	  This driver supports graphics boards with the ATI Rage128 chips.
 <at>  <at>  -1402,6 +1394,7  <at>  <at>  config FB_ATY128
 config FB_ATY128_BACKLIGHT
 	bool "Support for backlight control"
 	depends on FB_ATY128
+	depends on BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  Say Y here if you want to control the backlight of your display.
 <at>  <at>  -1412,7 +1405,6  <at>  <at>  config FB_ATY
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-	select FB_BACKLIGHT if FB_ATY_BACKLIGHT
 	select FB_MACMODES if PPC
 	help
 	  This driver supports graphics boards with the ATI Mach64 chips.
 <at>  <at>  -1452,6 +1444,7  <at>  <at>  config FB_ATY_GX
 config FB_ATY_BACKLIGHT
 	bool "Support for backlight control"
 	depends on FB_ATY
+	depends on BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  Say Y here if you want to control the backlight of your display.
 <at>  <at>  -1997,12 +1990,12  <at>  <at>  config FB_SH_MOBILE_LCDC
 	tristate "SuperH Mobile LCDC framebuffer support"
 	depends on FB && (SUPERH || ARCH_SHMOBILE) && HAVE_CLK
 	depends on FB_SH_MOBILE_MERAM || !FB_SH_MOBILE_MERAM
+	depends on BACKLIGHT_CLASS_DEVICE
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
 	select FB_SYS_IMAGEBLIT
 	select FB_SYS_FOPS
 	select FB_DEFERRED_IO
-	select FB_BACKLIGHT
 	select SH_MIPI_DSI if SH_LCD_MIPI_DSI
 	---help---
 	  Frame buffer driver for the on-chip SH-Mobile LCD controller.
 <at>  <at>  -2356,10 +2349,10  <at>  <at>  config FB_MSM
 config FB_MX3
 	tristate "MX3 Framebuffer support"
 	depends on FB && MX3_IPU
+	depends on BACKLIGHT_CLASS_DEVICE
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-	select BACKLIGHT_CLASS_DEVICE
 	default y
 	help
 	  This is a framebuffer device for the i.MX31 LCD Controller. So
diff --git a/drivers/video/fbdev/core/fbsysfs.c b/drivers/video/fbdev/core/fbsysfs.c
index 53444ac19fe0..8f766f14038e 100644
--- a/drivers/video/fbdev/core/fbsysfs.c
+++ b/drivers/video/fbdev/core/fbsysfs.c
 <at>  <at>  -59,7 +59,7  <at>  <at>  struct fb_info *framebuffer_alloc(size_t size, struct device *dev)

 	info->device = dev;

-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 	mutex_init(&info->bl_curve_mutex);
 #endif

 <at>  <at>  -428,7 +428,7  <at>  <at>  static ssize_t show_fbstate(struct device *device,
 	return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->state);
 }

-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 static ssize_t store_bl_curve(struct device *device,
 			      struct device_attribute *attr,
 			      const char *buf, size_t count)
 <at>  <at>  -517,7 +517,7  <at>  <at>  static struct device_attribute device_attrs[] = {
 	__ATTR(stride, S_IRUGO, show_stride, NULL),
 	__ATTR(rotate, S_IRUGO|S_IWUSR, show_rotate, store_rotate),
 	__ATTR(state, S_IRUGO|S_IWUSR, show_fbstate, store_fbstate),
-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 	__ATTR(bl_curve, S_IRUGO|S_IWUSR, show_bl_curve, store_bl_curve),
 #endif
 };
 <at>  <at>  -558,7 +558,7  <at>  <at>  void fb_cleanup_device(struct fb_info *fb_info)
 	}
 }

-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 /* This function generates a linear backlight curve
  *
  *     0: off
diff --git a/include/linux/fb.h b/include/linux/fb.h
index 09bb7a18d287..47e7742fdc9e 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
 <at>  <at>  -461,7 +461,7  <at>  <at>  struct fb_info {
 	struct list_head modelist;      /* mode list */
 	struct fb_videomode *mode;	/* current mode */

-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 	/* assigned backlight device */
 	/* set before framebuffer registration, 
 	   remove after unregister */
diff --git a/include/uapi/linux/fb.h b/include/uapi/linux/fb.h
index fb795c3b3c17..a7a4be063432 100644
--- a/include/uapi/linux/fb.h
+++ b/include/uapi/linux/fb.h
 <at>  <at>  -392,7 +392,7  <at>  <at>  struct fb_cursor {
 	struct fb_image	image;	/* Cursor image */
 };

-#ifdef CONFIG_FB_BACKLIGHT
+#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
 /* Settings for the generic backlight code */
 #define FB_BACKLIGHT_LEVELS	128
 #define FB_BACKLIGHT_MAX	0xFF
--

-- 
2.1.1
bugzilla-daemon | 17 Oct 22:22 2014

[Bug 85107] A10-7800: Boot problems (CPU stuck) and dpm not working correctly

Comment # 8 on bug 85107 from no it does only "fix" the CPU stuck errors
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
bugzilla-daemon | 17 Oct 17:02 2014

[Bug 85107] A10-7800: Boot problems (CPU stuck) and dpm not working correctly

Comment # 7 on bug 85107 from does setting radeon.bapm=0 change anything with respect to the GPU clocks?
You are receiving this mail because:
  • You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Gmane