Re: [Trac-dev] Using style sheet for egg pulgin
Steffen Hoffmann <hoff.st <at> web.de>
2012-02-16 21:12:09 GMT
Hello,
Am 16.02.2012 16:12, wrote Rumi, Natasha:
> Thanks for your reply these are my files.
You're welcome. Got your email, but message has been badly formatted,
maybe due to not standards-compliant email software? Try to stick to
ascii/plain-text whenever possible.
regarding setup.py:
change entry to a true dict like so
entry_points = {
'trac.plugins': [
'PJ6CKanban = PJ6CKanban',
]
},
but 'PJ6CKanban' really your directories name, where python scripts,
htdocs and template folder reside? - adjust as needed, please.
consider adding for completeness
description = 'short desc about this great plugin',
author='Natasha Rumi',
author_email='NRumi <at> tmvse.com',
url = 'http://www.tmvse.com',
license = 'some licenses reference',
include and adapt, if applicable
install_requires = ['Trac >= 0.11'],
zip_safe = True,
regarding PJ6CKanban.html
appears to be a Genshi template, but space mingled, with wicked encoding
and embedded in more wired HTML? Just decoded an re-formatted a few
lines to get a first glance. Re-send inside ZIP archive or prevent
changes by your email program through other means, if reqired. Anyway,
here are my comments:
<!DOCTYPEhtmlPUBLIC"-//W3C//DTDXHTML1.0Strict//EN"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:py="http://genshi.edgewall.org"
xmlns:xi="http://www.w3.org/2001/XInclude">
<xi:include href="layout.html" />
<head><link rel="stylesheet" href="'/css/mykanban.css" type"text/css"/>
----
Don't do that. Make sure you have an appropriately designed
ITemplateProvider (from trac.web.chrome) but use add_stylesheet method
(from trac.web.chrome too) before returning the template inside your
IRequestHandler like so:
from pkg_resources import resource_filename
from trac.web.api import IRequestFilter, IRequestHandler
from trac.web.chrome import ITemplateProvider, add_ctxtnav, \
add_stylesheet
# ITemplateProvider methods
def get_htdocs_dirs(self):
"""Return static resources for TracForms."""
return [('PJ6CKanban', resource_filename(__name__, 'htdocs'))]
def get_templates_dirs(self):
"""Return template directory for TracForms."""
return [resource_filename(__name__, 'templates')]
# IRequestHandler methods
def match_request(self, req):
...
def process_request(self, req):
...
add_stylesheet(req, 'PJ6CKanban/css/mykanban.css')
return 'PJ6CKanban.html', data, None
----
<title>PJ6CKanban</title>
<stylerel="stylesheet"type="text/css"></style>
</head>
<body>
<div id="ctxtnav"class="nav">
</div>
<ivid="content"><h1>PJ6CKanban</h1>
<table style="width:880px;">
<tbody>
<tr>
<td style="vertical-align:top;width:220px border-style:outset;
border-width:2px; height:100%; border-radius:3px;">
<table>
<thead>
<tr>
<th id="header" style="horizontal-align:left;
backgroud-color:#c4c4b9; width:200px; min-width:200px; max-width:200px;
border:solid thin grey; border-radius:3px; box-shadow:black 0.5em 0.5em
0.3e;">
<strong>New/Reopen</strong>
</th></tr><tr><th
style="height:10px;"> </th></tr></thead><tbody>
Uh, stop here. Well, I don't go for the table-inside-table design. Just
so much CSS inside XHTML is ugly. This file get's too messy to find
anything. Move all that out into separate CSS with appropriate
selectors. Watch spelling, i.e. "backgroud-color". Avoid very recent and
browser-specific things like "border-radius:3px", etc.
Hope this will get you started into a more successful direction.
Yours,
Steffen Hoffmann
>
>
> Trac 0.12.3 Released
> ====================
>
> We're happy to announce the Trac 0.12.3 release.
>
> You will find this release at the usual place:
>
> 
RSS Feed