headers
Noah Kantrowitz | 1 May 01:21
Picon
Favicon

[Trac-dev] Re: WorkFlow phase 1 ready for merge

> Hi,
>=20
> Eli has put the WorkFlow branch in a good shape, and it has been quite =

> usable for a while now. I've taken a look, tested it and all seems well=
=20
> for me for shifting the work on trunk where it could gain some wider=20
> exposure. So I'd like to call a vote for the merge.
>=20
> The ideal situation would be to get a few +1 besides mine and Eli's,=20
> till tomorrow afternoon, as it's the 1st of May and I'll have some time=
=20
> to work on the merge together with Eli. But otherwise, it's not a big=20
> deal, as I've got plenty of other areas to hack on ;-)

+1 from me. I would like to see some work on simplfying the API through
some base/mixin classes (like with WikiMacroBase), but that can
definitely be done on trunk.

--Noah
Permalink | Reply | 0 comments |
headers
Alec Thomas | 1 May 02:00

[Trac-dev] Re: WorkFlow phase 1 ready for merge


On 5/1/07, Christian Boos <cboos <at> neuf.fr> wrote:
> Eli has put the WorkFlow branch in a good shape, and it has been quite
> usable for a while now. I've taken a look, tested it and all seems well
> for me for shifting the work on trunk where it could gain some wider
> exposure. So I'd like to call a vote for the merge.
>
> The ideal situation would be to get a few +1 besides mine and Eli's,
> till tomorrow afternoon, as it's the 1st of May and I'll have some time
> to work on the merge together with Eli. But otherwise, it's not a big
> deal, as I've got plenty of other areas to hack on ;-)

This is not picking on Eli at all, but can we get more review before
doing major merges? I'd personally like to see at least one of cmlenz,
jborg or mgood comment on major merges *before* they go in. The more
people that look at the code the better it will be. Different minds
pick up different issues.

For my part, I'll look at this tonight (know I've said that before,
but this time for sure!).
--

-- 
Evolution: Taking care of those too stupid to take care of themselves.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
(Continue reading)

Permalink | Reply | 12 comments |
headers
Alec Thomas | 1 May 02:00

[Trac-dev] Re: WorkFlow phase 1 ready for merge


Err, in case this wasn't clear, I'm suggesting we delay the merge
until more people have reviewed it.

On 5/1/07, Alec Thomas <trac-dev-list <at> swapoff.org> wrote:
> On 5/1/07, Christian Boos <cboos <at> neuf.fr> wrote:
> > Eli has put the WorkFlow branch in a good shape, and it has been quite
> > usable for a while now. I've taken a look, tested it and all seems well
> > for me for shifting the work on trunk where it could gain some wider
> > exposure. So I'd like to call a vote for the merge.
> >
> > The ideal situation would be to get a few +1 besides mine and Eli's,
> > till tomorrow afternoon, as it's the 1st of May and I'll have some time
> > to work on the merge together with Eli. But otherwise, it's not a big
> > deal, as I've got plenty of other areas to hack on ;-)
>
> This is not picking on Eli at all, but can we get more review before
> doing major merges? I'd personally like to see at least one of cmlenz,
> jborg or mgood comment on major merges *before* they go in. The more
> people that look at the code the better it will be. Different minds
> pick up different issues.
>
> For my part, I'll look at this tonight (know I've said that before,
> but this time for sure!).
> --
> Evolution: Taking care of those too stupid to take care of themselves.
>

--

-- 
Evolution: Taking care of those too stupid to take care of themselves.
(Continue reading)

Permalink | Reply | 8 comments |
headers
Jeroen Ruigrok van der Werven | 1 May 07:53
Gravatar

[Trac-dev] Re: WorkFlow phase 1 ready for merge


-On [20070501 02:01], Alec Thomas (trac-dev-list <at> swapoff.org) wrote:
>Err, in case this wasn't clear, I'm suggesting we delay the merge
>until more people have reviewed it.

Well, I just set up a local workflow instance.

What are areas that should be scrutinized when using it (cannot do more than
offering a user's point of view review now)?

--

-- 
Jeroen Ruigrok van der Werven <asmodai(-at-)in-nomine.org> / asmodai
イェルーン ラウフロック ヴァン デル ウェルヴェン
http://www.in-nomine.org/ | http://www.rangaku.org/
Vae victis!

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
Permalink | Reply | 1 comment |
headers
Christian Boos | 1 May 14:55
Picon

[Trac-dev] Re: WorkFlow phase 1 ready for merge


Jeroen Ruigrok van der Werven wrote:
> ...
>
> What are areas that should be scrutinized when using it (cannot do more than
> offering a user's point of view review now)?
>   

That's excellent, just try to change the default workflow with one of 
the sample workflows, and make your way through the 
documentation,starting with the WorkFlow page: when things are unclear 
or some steps are not enough documented, just point it out and propose 
how to improve the doc.

Along those lines, I think we need a new TracWorkflow default wiki page, 
which extracts the relevant part of the documentation already in the 
WorkFlow page, plus all what's necessary to successfully customize the 
workflow. There could be a "basic customization" section dedicated to 
the DefaultTicketActionController, and an "Advanced Customization" 
section about using the additional ITicketActionController and creating 
new ones.

-- Christian

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
(Continue reading)

Permalink | Reply | 0 comments |
headers
Alec Thomas | 1 May 16:37

[Trac-dev] Re: WorkFlow phase 1 ready for merge


> For my part, I'll look at this tonight (know I've said that before,
> but this time for sure!).

I'm going to spam feedback as I use WorkFlow, so there could be a few mails...

- It'd be nice if the .ini based workflow could define the label for actions.
  eg. "needinfo_new"  could be rendered as "need more information". Perhaps
  with 'needinfo_new.label = need more information' in the .ini file.

- Unless there's some specific reason not to, I'd personally prefer
  parse_workflow_config() and get_workflow_config() to be methods in
  TicketSystem. eg. TicketSystem(env).parse_workflow_config(...). This is a
  common idiom in Trac.

- PEP8 changes (already discussed in IRC)

... still looking.

--

-- 
Evolution: Taking care of those too stupid to take care of themselves.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
(Continue reading)

Permalink | Reply | 2 comments |
headers
Eli Carter | 1 May 17:27

[Trac-dev] Re: WorkFlow phase 1 ready for merge


On Monday 30 April 2007, Alec Thomas wrote:
> 
> Err, in case this wasn't clear, I'm suggesting we delay the merge
> until more people have reviewed it.
> 
> On 5/1/07, Alec Thomas <trac-dev-list <at> swapoff.org> wrote:
> > On 5/1/07, Christian Boos <cboos <at> neuf.fr> wrote:
> > > Eli has put the WorkFlow branch in a good shape, and it has been quite
> > > usable for a while now. I've taken a look, tested it and all seems well
> > > for me for shifting the work on trunk where it could gain some wider
> > > exposure. So I'd like to call a vote for the merge.
> > >
> > > The ideal situation would be to get a few +1 besides mine and Eli's,
> > > till tomorrow afternoon, as it's the 1st of May and I'll have some time
> > > to work on the merge together with Eli. But otherwise, it's not a big
> > > deal, as I've got plenty of other areas to hack on ;-)
> >
> > This is not picking on Eli at all, but can we get more review before
> > doing major merges? I'd personally like to see at least one of cmlenz,
> > jborg or mgood comment on major merges *before* they go in. The more
> > people that look at the code the better it will be. Different minds
> > pick up different issues.

Agreed.  Review is definitely welcome.  The problem is it seems to require a 
threat of merging before it happens. :(

> > For my part, I'll look at this tonight (know I've said that before,
> > but this time for sure!).
(Continue reading)

Permalink | Reply | 5 comments |
headers
Jonas Borgström | 1 May 21:41
Favicon

[Trac-dev] Re: WorkFlow phase 1 ready for merge


Alec Thomas wrote:
>> For my part, I'll look at this tonight (know I've said that before,
>> but this time for sure!).
> 
> I'm going to spam feedback as I use WorkFlow, so there could be a few mails...
> 
> - It'd be nice if the .ini based workflow could define the label for actions.
>   eg. "needinfo_new"  could be rendered as "need more information". Perhaps
>   with 'needinfo_new.label = need more information' in the .ini file.
> 

Is "needinfo_new.name = something" what you're looking for?

I've also just started looking at this. So far I've not found anything 
not already reported by somebody else.

While looking at the ticket-workflow section format I realized that it 
would be fairly easy to convert this info to graphviz graphs and so I did:

http://www.edgewall.org/~jonas/workflow/workflow2dot.py
http://www.edgewall.org/~jonas/workflow/default-workflow.pdf
http://www.edgewall.org/~jonas/workflow/enterprise-review-workflow.pdf

In these images different edge colors are used to represent different 
operations, i.e blue lines means that the owner field is set, etc...

These images are probably not something we should show our end users but 
they might be useful for something.
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jonas Borgström | 1 May 22:01
Favicon

[Trac-dev] Re: WorkFlow phase 1 ready for merge


Jonas Borgström wrote:
*snip*
> 
> While looking at the ticket-workflow section format I realized that it 
> would be fairly easy to convert this info to graphviz graphs and so I did:
> 
> http://www.edgewall.org/~jonas/workflow/workflow2dot.py
> http://www.edgewall.org/~jonas/workflow/default-workflow.pdf
> http://www.edgewall.org/~jonas/workflow/enterprise-review-workflow.pdf
> 
> In these images different edge colors are used to represent different 
> operations, i.e blue lines means that the owner field is set, etc...
> 

Crap, nothing to see here, I was just informed that prior work exists :)
Eli Carter has already written a similar script:

http://trac.edgewall.org/wiki/WorkFlow/Examples

Cheers,
Jonas

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
(Continue reading)

Permalink | Reply | 0 comments |
headers
Christopher Taylor | 2 May 19:00
Picon

[Trac-dev] Time Tracking Patch


Hello all,

I'm trying to get the time tracking patch up and working on 0.10.3.1
and I'm having trouble getting the second progress bar displayed in
roadmap and the detailed milestone view.

at the end is the relevant parts of the patch for displaying the hours
completed progress bar.

any help would be greatly appreciated!

Respectfully,
Christopher Taylor

Index: templates/roadmap.cs
===================================================================
--- templates/roadmap.cs	(revision 4073)
+++ templates/roadmap.cs	(working copy)
@@ -63,6 +63,35 @@
          var:stats.active_tickets ?></a></dd>
       </dl><?cs
      /if ?><?cs
+     if:#stats.has_stats ?>
+      <div style="margin: 0; height: 1px;"></div>
+      <table class="progress">
+       <tr><?cs
+        if:#stats.work_percent_complete > #0.0 ?>
+         <td class="closed" style="width: <?cs
+           var:#stats.work_percent_complete ?>%"><a title="<?cs
(Continue reading)

Permalink | Reply | 1 comment |

Gmane